Re: [patch 02/25] drivers/scsi/advansys.c: cleanups

2007-05-24 Thread Christoph Hellwig
On Wed, May 23, 2007 at 08:22:07PM -0500, James Bottomley wrote: > On Wed, 2007-05-23 at 16:33 -0700, Andrew Morton wrote: > > On Wed, 23 May 2007 18:21:31 -0500 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: > > > > From: Adria

Re: [patch 02/25] drivers/scsi/advansys.c: cleanups

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 16:33 -0700, Andrew Morton wrote: > On Wed, 23 May 2007 18:21:31 -0500 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: > > > From: Adrian Bunk <[EMAIL PROTECTED]> > > > > > > - remove the unneeded advansys.h > >

Re: [patch 02/25] drivers/scsi/advansys.c: cleanups

2007-05-23 Thread Andrew Morton
On Wed, 23 May 2007 18:21:31 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: > > From: Adrian Bunk <[EMAIL PROTECTED]> > > > > - remove the unneeded advansys.h > > - remove the unused advansys_setup() > > This isn't quite right, thou

Re: [patch 02/25] drivers/scsi/advansys.c: cleanups

2007-05-23 Thread James Bottomley
On Wed, 2007-05-23 at 14:41 -0700, [EMAIL PROTECTED] wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > > - remove the unneeded advansys.h > - remove the unused advansys_setup() This isn't quite right, though, is it? advansys_setup() should be used. It looks like there was a bogus conversion away

[patch 02/25] drivers/scsi/advansys.c: cleanups

2007-05-23 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - remove the unneeded advansys.h - remove the unused advansys_setup() - make needlessly global functions static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/advansys.c | 101 +++---