Re: [patch 2/7] git scsi misc include fix

2007-10-16 Thread Paul Jackson
Randy wrote: > > #include > > > > #include > > +#include > > struct scsi_device; > > struct Scsi_Host; > > It's 3 lines above the patch line Ah - you mean scatterlist.h is now included twice - yup. First I noticed that scsi_eh.h needed this scatterlist.h include and sent this patch

Re: [patch 2/7] git scsi misc include fix

2007-10-16 Thread Randy Dunlap
On Tue, 16 Oct 2007 14:28:20 -0700 [EMAIL PROTECTED] wrote: > From: Paul Jackson <[EMAIL PROTECTED]> > > The added line in scsi_eh.h: > struct scatterlist sense_sgl; > fails to compile, with the error: > field 'sense_sgl' has incomplete type > unless scatterlist.h happens to be includ

[patch 2/7] git scsi misc include fix

2007-10-16 Thread akpm
From: Paul Jackson <[EMAIL PROTECTED]> The added line in scsi_eh.h: struct scatterlist sense_sgl; fails to compile, with the error: field 'sense_sgl' has incomplete type unless scatterlist.h happens to be included somehow already ... which it isn't always. So include scatterlist.h