Re: BLKZEROOUT not zeroing md dev on VMDK

2016-06-15 Thread Sitsofe Wheeler
On Wed, Jun 15, 2016 at 06:17:37PM +, Arvind Kumar wrote: > It is possibly some race. We saw a WRITE SAME related issue in past > for which Petr sent out a patch but looks like the patch didn't make > it. :( > > https://groups.google.com/forum/#!topic/linux.kernel/1WGDSlyY0y0 Indeed - the inv

Re: BLKZEROOUT not zeroing md dev on VMDK

2016-06-15 Thread Arvind Kumar
Sent: Tuesday, May 31, 2016 10:04 PM To: Tom Yan Cc: Darrick J. Wong; Shaohua Li; Jens Axboe; Arvind Kumar; VMware PV-Drivers; linux-r...@vger.kernel.org; linux-scsi@vger.kernel.org; linux-bl...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: BLKZEROOUT not zeroing md dev on VMDK On 2

Re: BLKZEROOUT not zeroing md dev on VMDK

2016-05-31 Thread Sitsofe Wheeler
On 27 May 2016 at 10:30, Tom Yan wrote: > There seems to be some sort of race condition between > blkdev_issue_zeroout() and the scsi disk driver (disabling write same > after an illegal request). On my UAS drive, sometimes `blkdiscard -z > /dev/sdX` will return right away, even though if I then c

Re: BLKZEROOUT not zeroing md dev on VMDK

2016-05-27 Thread Tom Yan
There seems to be some sort of race condition between blkdev_issue_zeroout() and the scsi disk driver (disabling write same after an illegal request). On my UAS drive, sometimes `blkdiscard -z /dev/sdX` will return right away, even though if I then check `write_same_max_bytes` it has turned 0. Some

Re: BLKZEROOUT not zeroing md dev on VMDK

2016-05-26 Thread Sitsofe Wheeler
On 27 May 2016 at 05:18, Darrick J. Wong wrote: > > It's possible that the pvscsi device advertised WRITE SAME, but if the device > sends back ILLEGAL REQUEST then the SCSI disk driver will set > write_same_max_bytes=0. Subsequent BLKZEROOUT attempts will then issue writes > of zeroes to the driv

Re: BLKZEROOUT not zeroing md dev on VMDK

2016-05-26 Thread Darrick J. Wong
On Wed, May 18, 2016 at 11:39:30PM +0100, Sitsofe Wheeler wrote: > Hi, > > With Ubuntu's 4.4.0-22-generic kernel and a Fedora 23 > 4.6.0-1.vanilla.knurd.1.fc23.x86_64 kernel I've found that the > BLKZEROOUT syscall can malfunction and not zero data. > > When BLKZEROOUT is issued to an MD device a

BLKZEROOUT not zeroing md dev on VMDK

2016-05-18 Thread Sitsofe Wheeler
Hi, With Ubuntu's 4.4.0-22-generic kernel and a Fedora 23 4.6.0-1.vanilla.knurd.1.fc23.x86_64 kernel I've found that the BLKZEROOUT syscall can malfunction and not zero data. When BLKZEROOUT is issued to an MD device atop a PVSCSI controller supplied VMDK from ESXi 6.0 the call returns immediatel