Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-19 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: +struct scsi_transport_template * +qla2x00_alloc_transport_tmpl(void) +{ + return (fc_attach_transport(qla2xxx_transport_functions)); +} I don't see much of a point in this function vs just making qla2xxx_transport_functions

Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-19 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: atomic_set(fcport-state, FCS_ONLINE); + if (ha-flags.init_done) + qla2x00_reg_remote_port(ha, fcport); } ... - goto probe_failed; + goto probe_alloc_failed; } + pci_set_drvdata(pdev,

Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-19 Thread Christoph Hellwig
On Tue, Apr 19, 2005 at 12:27:51AM -0700, Andrew Vasquez wrote: why do you still need the special case for delaying registration of the targets? Ok, this is actually a concern I have with the current fc_rport implementation (and yes, I realize I'm a day late) -- the auto-scan logic

PATCH [2/5] qla2xxx: add remote port codes...

2005-04-13 Thread Andrew Vasquez
Add initial support for FC remote port infrastructure. o Use fc_remote_port...() registration and block/unlock functions. o Consolidate 'attribute' (fc-remote/sysfs) helpers into new qla_attr.c file. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED]

Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-13 Thread Christoph Hellwig
+#include linux/version.h not needed (this is in qla_attr.c) +struct scsi_transport_template * +qla2x00_alloc_transport_tmpl(void) +{ + return (fc_attach_transport(qla2xxx_transport_functions)); +} I don't see much of a point in this function vs just making qla2xxx_transport_functions