Re: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread 'Christoph Hellwig'
On Wed, Mar 09, 2005 at 05:47:27PM -0500, Bagalkote, Sreenivas wrote: > > > >Even for kernels with a 64bit dma_addr_t you can get 32bit dma > >addresses > >only. As a start check whether the pci_set_dma_mask for the 64bit mask > >failed - in that case you can always use 32bit SGLs. > > > > Pleas

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Bagalkote, Sreenivas
>> > >> >Even for kernels with a 64bit dma_addr_t you can get 32bit dma >> >addresses >> >only. As a start check whether the pci_set_dma_mask for >the 64bit mask >> >failed - in that case you can always use 32bit SGLs. >> > >> >> Please help me understand: If dma_addr_t is 64 bit, I will get 64

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Bagalkote, Sreenivas
> >Even for kernels with a 64bit dma_addr_t you can get 32bit dma >addresses >only. As a start check whether the pci_set_dma_mask for the 64bit mask >failed - in that case you can always use 32bit SGLs. > Please help me understand: If dma_addr_t is 64 bit, I will get 64bit addresses in scatterl

Re: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread 'Christoph Hellwig'
On Wed, Mar 09, 2005 at 09:43:47AM -0500, Bagalkote, Sreenivas wrote: > During the module load time, I allocate 32 bit or 64 bit SGLs based on > whether I can receive 64 bit DMA addresses or not. If size of dma_addr_t > is 4, then I allocate only 32 bit SGLs. During the run time, I prepare > 32/64

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Arjan van de Ven
On Wed, 2005-03-09 at 12:44 -0500, Bagalkote, Sreenivas wrote: > >> > > >> >> . And since this is compile time > >> >> system-wide property, I kept it as driver global. > >> > > >> >that step I don't understand... why is it a global > >*VARIABLE* if it's > >> >compile time system-wide property...

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Bagalkote, Sreenivas
>> > >> >> . And since this is compile time >> >> system-wide property, I kept it as driver global. >> > >> >that step I don't understand... why is it a global >*VARIABLE* if it's >> >compile time system-wide property... >> > >> >> I see your point! Are you saying I should use >if(sizeof(dma_add

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Arjan van de Ven
On Wed, 2005-03-09 at 11:01 -0500, Bagalkote, Sreenivas wrote: > > > >> . And since this is compile time > >> system-wide property, I kept it as driver global. > > > >that step I don't understand... why is it a global *VARIABLE* if it's > >compile time system-wide property... > > > > I see your po

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Bagalkote, Sreenivas
> >> . And since this is compile time >> system-wide property, I kept it as driver global. > >that step I don't understand... why is it a global *VARIABLE* if it's >compile time system-wide property... > I see your point! Are you saying I should use if(sizeof(dma_addr_t)==8) instead of the shortcu

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Arjan van de Ven
> . And since this is compile time > system-wide property, I kept it as driver global. that step I don't understand... why is it a global *VARIABLE* if it's compile time system-wide property... - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [E

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Bagalkote, Sreenivas
>> >> I will make this an instance parameter if the idea to reduce as many >> global variables as possible. But if the objection is because each >> adapter >> may have different value for variable, then it is indeed a global >> value. >> "is_dma64" - which is computed using the size of dma_addr_t

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread Arjan van de Ven
On Tue, 2005-03-08 at 18:08 -0500, Bagalkote, Sreenivas wrote: > > I will make this an instance parameter if the idea to reduce as many > global variables as possible. But if the objection is because each > adapter > may have different value for variable, then it is indeed a global > value. > "is_

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-08 Thread Bagalkote, Sreenivas
> >> +static int is_dma64; > >the fact that this is a global variable worries me. > Matt also has the same concern. I am pasting my response from my reply to his comment: I will make this an instance parameter if the idea to reduce as many global variables as poss

RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-08 Thread Bagalkote, Sreenivas
>Subject: Re: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: >Announcing new module for LSI Logic's SAS based MegaRAID controllers > >On Fri, Mar 04, 2005 at 10:06:00PM -0500, Bagalkote, Sreenivas wrote: >> We are announcing a driver for LSI Logic's new SAS based MegaRAID >> controllers. > >I'd like t