Thanks for the patch.
Acked-by: Anil Gurumurthy <anil.gurumur...@qlogic.com>

-----Original Message-----
From: Rickard Strandqvist [mailto:rickard_strandqv...@spectrumdigital.se]
Sent: 18 May 2014 21:36
To: Anil Gurumurthy; Sudarsana Kalluru
Cc: Rickard Strandqvist; James E.J. Bottomley; linux-scsi; linux-kernel
Subject: [PATCH] scsi: bfa: bfa_fcs_lport.c: Fix for possible null pointer 
dereference

There is otherwise a risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
---
 drivers/scsi/bfa/bfa_fcs_lport.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c
index ff75ef8..542d5c6 100644
--- a/drivers/scsi/bfa/bfa_fcs_lport.c
+++ b/drivers/scsi/bfa/bfa_fcs_lport.c
@@ -5826,12 +5826,13 @@ bfa_fcs_lport_get_rport_max_speed(bfa_fcs_lport_t *port)
        bfa_port_speed_t max_speed = 0;
        struct bfa_port_attr_s port_attr;
        bfa_port_speed_t port_speed, rport_speed;
-       bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
+       bfa_boolean_t trl_enabled;


        if (port == NULL)
                return 0;

+       trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
        fcs = port->fcs;

        /* Get Physical port's current speed */
--
1.7.10.4


________________________________

This message and any attached documents contain information from QLogic 
Corporation or its wholly-owned subsidiaries that may be confidential. If you 
are not the intended recipient, you may not read, copy, distribute, or use this 
information. If you have received this transmission in error, please notify the 
sender immediately by reply e-mail and then delete this message.

<<attachment: winmail.dat>>

Reply via email to