Re: [PATCH] scsi: rescan VPD attributes

2015-11-25 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> The VPD page information might change, so we need to be able to Hannes> update it. This patch implements a VPD page rescan whenever the Hannes> 'rescan' sysfs attribute is triggered. I was looking into merging the ALUA series but this prerequisit

RE: [PATCH] scsi: rescan VPD attributes

2015-11-25 Thread Seymour, Shane M
Hi Hannes, I have one probably small nitpick about the patch. I'm not sure how likely what I've put below is likely to happen in real life though. Is there any chance at all that sdev->vpd_pg83_len could change when updated? If there's any chance of that I'd have expected that both the length o

Re: [PATCH] scsi: rescan VPD attributes

2015-11-25 Thread Hannes Reinecke
On 11/26/2015 06:07 AM, Seymour, Shane M wrote: > Hi Hannes, > > I have one probably small nitpick about the patch. I'm not sure how likely > what I've put below is likely > to happen in real life though. > > Is there any chance at all that sdev->vpd_pg83_len could change when updated? > If ther

Re: [PATCH] scsi: rescan VPD attributes

2015-11-25 Thread Johannes Thumshirn
On Mon, 2015-11-09 at 13:24 +0100, Hannes Reinecke wrote: > The VPD page information might change, so we need to be able to > update it. This patch implements a VPD page rescan whenever > the 'rescan' sysfs attribute is triggered. > > Signed-off-by: Hannes Reinecke > --- >  drivers/scsi/scsi.c   

RE: [PATCH] scsi: rescan VPD attributes

2015-11-26 Thread Seymour, Shane M
> The VPD page information might change, so we need to be able to > update it. This patch implements a VPD page rescan whenever > the 'rescan' sysfs attribute is triggered. > > Signed-off-by: Hannes Reinecke > --- Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsub

Re: [PATCH] scsi: rescan VPD attributes

2015-11-30 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> The VPD page information might change, so we need to be able to Hannes> update it. This patch implements a VPD page rescan whenever the Hannes> 'rescan' sysfs attribute is triggered. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle