Re: [PATCH] st: Take additional queue ref in st_probe

2013-03-05 Thread Jan Vesely
Hi, I don't understand how error paths are supposed to work with this patch. As I see it, if we fail to get a reference, the error path tries to put a non-existent one. moreover, error paths on lines 4188 and 4196 still goto out_put_disk, leaking the reference. other than that, it fixes the l

RE: [PATCH] st: Take additional queue ref in st_probe

2013-03-04 Thread Seymour, Shane M
With the things I've been doing in st it was easier to reboot than unload/load the st driver since it would likely cause an oops. I applied the patch and have tested it and the st module unloads/reloads with no problems now. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi

Re: [PATCH] st: Take additional queue ref in st_probe

2013-03-04 Thread Ewan Milne
On Mon, 2013-03-04 at 11:14 -0500, Joe Lawrence wrote: > These changes were applied to scsi.git, branch "misc". This patch > fixes a reference count bug in the SCSI tape driver which can be > reproduced with the following: > > * Boot with slub_debug=FZPU, tape drive attached > * echo 1 > /sys/dev