Re: [PATCH 2/2] Rework handling of scsi_device.vpd_pg8[03]

This looks generally good. But I wonder if there is a way to factor the assining/clearing sequence into little helpers instead of duplicating it?

RE: [PATCH 2/2] Rework handling of scsi_device.vpd_pg8[03]

Hi Bart, Comments inline below about the show_vpd_##_page macro. > -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Saturday, August 26, 2017 6:36 AM > To: Martin K . Petersen ; James E . J . > Bottomley