RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-31 Thread Moore, Eric
On Monday, July 30, 2007 5:36 PM, FUJITA Tomonori wrote: > > Looks good for me. > > Here's an updated version. Can you add your signed-off or acked-by? > > --- > From: FUJITA Tomonori <[EMAIL PROTECTED]> > Subject: [PATCH] mptsas: add SAS management protocol handler > > This patch adds support

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-30 Thread FUJITA Tomonori
From: "Moore, Eric" <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Mon, 30 Jul 2007 11:10:07 -0600 > On Sunday, July 29, 2007 1:37 AM, FUJITA Tomonori wrote: > > > Eric, can I get your ACK on this patch? > >

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-30 Thread Moore, Eric
On Sunday, July 29, 2007 1:37 AM, FUJITA Tomonori wrote: > > Eric, can I get your ACK on this patch? > > One comment on the the patch: > > + if (!(ioc->sas_mgmt.status & MPT_IOCTL_STATUS_COMMAND_GOOD)) { > + printk(KERN_ERR "%s: smp response invalid!\n", > __FUNCTION__); > +

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-29 Thread FUJITA Tomonori
From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Sun, 29 Jul 2007 14:07:01 +0900 > From: "Moore, Eric" <[EMAIL PROTECTED]> > Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg >

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-28 Thread FUJITA Tomonori
From: "Moore, Eric" <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Fri, 27 Jul 2007 17:24:19 -0600 > On Thursday, July 26, 2007 6:44 PM, FUJITA Tomonori wrote: > > > > Does this work for you? Sorry, I'm not

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-27 Thread Moore, Eric
On Thursday, July 26, 2007 6:44 PM, FUJITA Tomonori wrote: > > Does this work for you? Sorry, I'm not at the lab now and can't test > it. But I can do next week. > > I also updated bsg's smp_rep_manufacturer to print the mpi's > replay. You can get it from the git tree. > yes this will work, a

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-26 Thread FUJITA Tomonori
From: "Moore, Eric" <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Thu, 26 Jul 2007 16:05:32 -0600 > On Thursday, July 26, 2007 11:09 AM, FUJITA Tomonori wrote: > > For smp request/response, we use: > > > > re

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-26 Thread Moore, Eric
On Thursday, July 26, 2007 11:09 AM, FUJITA Tomonori wrote: > For smp request/response, we use: > > request -> not used > response -> not used > dout_xferp -> pointer to a smp request frame > din_xferp -> pointer to a smp response frame > > > So we could use response field to send vendor's uniqu

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-26 Thread FUJITA Tomonori
From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Fri, 27 Jul 2007 02:09:05 +0900 > Use-space applications can put four memory addresses in the bsg (sg > v4) interface: request, response, dout_xferp, and din_xferp. &

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-26 Thread FUJITA Tomonori
From: "Moore, Eric" <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Thu, 26 Jul 2007 10:32:45 -0600 > On Thursday, July 26, 2007 4:09 AM, FUJITA Tomonori wrote: > > The SMP response's function resu

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-26 Thread Moore, Eric
On Thursday, July 26, 2007 4:09 AM, FUJITA Tomonori wrote: > The SMP response's function result wasn't set correctly? bsg's > smp_rep_manufacturer didn't check the result so it showed garbase, I > guess. > > BTW, I took the code to check the result from Doug's smp_utils and put > bsg's smp_rep_ma

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-26 Thread FUJITA Tomonori
From: "Moore, Eric" <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Wed, 25 Jul 2007 18:21:38 -0600 > > > > # ./sgv4-tools/smp_rep_manufacturer /sys/class/bsg/expander-0:1 > > > > > > > > > >

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-25 Thread Moore, Eric
On Tuesday, July 24, 2007 6:48 PM, FUJITA Tomonori wrote: > > I hadn't enabled bsg support in the linux kernel, that was > my problem. > > What do you mean? You might hit the bug that you can't build scsi as a > modular. It was fixed before rc1. > The issue is I'm new to BSG, and I didn't know

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-24 Thread FUJITA Tomonori
From: "Moore, Eric" <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Tue, 24 Jul 2007 18:22:08 -0600 > > > I'm not sure what the intent of this else case. > > > > This code is for an "invisible" S

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-24 Thread FUJITA Tomonori
From: "Moore, Eric" <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Tue, 24 Jul 2007 18:22:08 -0600 > On Monday, July 23, 2007 11:28 PM, FUJITA Tomonori wrote: > > > > > With 2.6.23-rc1 + mptsas smp patch,

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-24 Thread Moore, Eric
On Monday, July 23, 2007 11:28 PM, FUJITA Tomonori wrote: > > With 2.6.23-rc1 + mptsas smp patch, you get directories /sys/class/bsg > like: I hadn't enabled bsg support in the linux kernel, that was my problem. > > # ./sgv4-tools/smp_rep_manufacturer /sys/class/bsg/expander-0:1 > > > I thin

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-23 Thread FUJITA Tomonori
From: "Moore, Eric" <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Mon, 23 Jul 2007 18:11:34 -0600 > Tomo - do you have any documentation on how to specify a bsg device? Sorry, I don't. But it's not difficult. With

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-23 Thread Moore, Eric
Tomo - do you have any documentation on how to specify a bsg device? I was trying to run the smp_rep_manufacture from sgv4_tools, and I got that error. Due to that, I have not able to test this patch. However, here are some feedback with regards to the patch: On Sunday, July 08, 2007 9:52 PM,