Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-12 Thread Richard Weinberger
Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com; a...@canonical.com; linux-scsi@vger.kernel.org Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler On Tue, Jul 08, 2014 at 05:46:50PM

RE: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-12 Thread KY Srinivasan
...@redhat.com; a...@canonical.com; linux-scsi@vger.kernel.org Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler On Thu, Jul 10, 2014 at 12:33 PM, Richard Weinberger richard.weinber...@gmail.com wrote: On Wed, Jul 9, 2014 at 8:51 PM, KY Srinivasan k...@microsoft.com wrote

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-11 Thread Hannes Reinecke
...@parallels.com; jasow...@redhat.com; a...@canonical.com; linux-scsi@vger.kernel.org Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler Note that you could increase the timeout and/or implement an eh_timed_out handler that just returns BLK_EH_RESET_TIMER

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-11 Thread Christoph Hellwig
On Fri, Jul 11, 2014 at 11:52:55AM +0200, Hannes Reinecke wrote: Something like this should be sufficient: Right. That plus a detailed comment explaining why it's there.. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org

RE: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-11 Thread KY Srinivasan
; a...@canonical.com; linux-scsi@vger.kernel.org Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler On 07/11/2014 12:26 AM, KY Srinivasan wrote: -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Thursday, July 10, 2014 3:13 AM To: KY

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-10 Thread Christoph Hellwig
On Wed, Jul 09, 2014 at 06:51:38PM +, KY Srinivasan wrote: On Azure, we sometimes have unbounded I/O latencies and some distributions (such as SLES12) based on recent kernels are invoking the Abort Handler. Any kernel will invoke the abort handler if present, and then escalate to the

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-10 Thread Richard Weinberger
; jbottom...@parallels.com; jasow...@redhat.com; a...@canonical.com; linux-scsi@vger.kernel.org Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler On Tue, Jul 08, 2014 at 05:46:50PM -0700, K. Y. Srinivasan wrote: Implement a simple abort handler. The host does not support

RE: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-10 Thread KY Srinivasan
; a...@canonical.com; linux-scsi@vger.kernel.org Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler Note that you could increase the timeout and/or implement an eh_timed_out handler that just returns BLK_EH_RESET_TIMER, but if the completion takes too long the expectation

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-09 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 05:46:50PM -0700, K. Y. Srinivasan wrote: Implement a simple abort handler. The host does not support Abort; just ensure that all inflight I/Os have been accounted for. The abort handler should abort a single command, not wait for all of them. What issue do you see that

RE: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-09 Thread KY Srinivasan
-scsi@vger.kernel.org Subject: Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler On Tue, Jul 08, 2014 at 05:46:50PM -0700, K. Y. Srinivasan wrote: Implement a simple abort handler. The host does not support Abort; just ensure that all inflight I/Os have been accounted