Re: [PATCH v1] lpfc 8.3.37: Remove redundant NULL check before kfree

2013-03-07 Thread James Smart
ject: Re: [PATCH v1] lpfc 8.3.37: Remove redundant NULL check before kfree Syam, Thank you for the patch - it is valid. However, I prefer not to merge this. I would rather force the coder to think about the pointer value explicitly rather than depending on the convenience/one line optimization.

RE: [PATCH v1] lpfc 8.3.37: Remove redundant NULL check before kfree

2013-03-06 Thread Elliott, Robert (Server Storage)
ail.com > Cc: linux-scsi@vger.kernel.org; jbottom...@parallels.com; Syam Sidhardhan; > Smart, James > Subject: Re: [PATCH v1] lpfc 8.3.37: Remove redundant NULL check before > kfree > > Syam, > > Thank you for the patch - it is valid. > > However, I prefer not to merge

Re: [PATCH v1] lpfc 8.3.37: Remove redundant NULL check before kfree

2013-03-06 Thread James Smart
Syam, Thank you for the patch - it is valid. However, I prefer not to merge this. I would rather force the coder to think about the pointer value explicitly rather than depending on the convenience/one line optimization. We've had errors in the past covered up by this gracious behavior. Ad