Re: [Patch][RFC] st: provide tape statistics via sysfs

2013-02-22 Thread James Bottomley
On Fri, 2013-02-22 at 02:11 +, Seymour, Shane M wrote: > First forgive me for using outlook for this, if there are any issues with > what I sent let me know and I'll send it again from gmail. This is also my > first attempt at a kernel patch so please be gentle. > > This patch was written to

Re: [Patch][RFC] st: provide tape statistics via sysfs

2013-02-22 Thread Darren Lavender
Hi James On 22/02/13 10:50, James Bottomley wrote: On Fri, 2013-02-22 at 02:11 +, Seymour, Shane M wrote: First forgive me for using outlook for this, if there are any issues with what I sent let me know and I'll send it again from gmail. This is also my first attempt at a kernel patch so

Re: [Patch][RFC] st: provide tape statistics via sysfs

2013-02-22 Thread Darren Lavender
.. I'm afraid we can't do it the way you're proposing. files in sysfs must conform to the one value per file rule (so we avoid the ABI nastiness that plagues /proc). You can create a stat directory with a bunch of files, but not a single file that gives all values. That was initially my

Re: [Patch][RFC] st: provide tape statistics via sysfs

2013-02-26 Thread Kai Mäkisara
On Feb 22, 2013, at 12:50 PM, James Bottomley wrote: > On Fri, 2013-02-22 at 02:11 +, Seymour, Shane M wrote: >> First forgive me for using outlook for this, if there are any issues with >> what I sent let me know and I'll send it again from gmail. This is also my >> first attempt at a ke

RE: [Patch][RFC] st: provide tape statistics via sysfs

2013-02-28 Thread Seymour, Shane M
-Original Message- From: Kai Mäkisara [mailto:kai.makis...@kolumbus.fi] Sent: Wednesday, February 27, 2013 4:38 AM To: James Bottomley Cc: Seymour, Shane M; linux-scsi@vger.kernel.org Subject: Re: [Patch][RFC] st: provide tape statistics via sysfs > The sysfs files in the patch exp