Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Domen Puncer
On 15/03/05 12:59 -0500, Salyzyn, Mark wrote: > FC3 != kernel.org, and the problem may not exist in latest tree. The > code for pci_module_init used to do a return (ret < 0) ? ret : 0. > > The problem is then a 'transition' issue, as patches that appear here > can and will be used for kernel revis

RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Salyzyn, Mark
] Sent: Tuesday, March 15, 2005 12:45 PM To: Salyzyn, Mark Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver On 15/03/05 10:59 -0500, Salyzyn, Mark wrote: > We have tested and seen a positive numbe

Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Domen Puncer
TECTED] > Sent: Tuesday, March 15, 2005 10:57 AM > To: Salyzyn, Mark > Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; > [EMAIL PROTECTED] > Subject: Re: [patch 06/11] drivers/scsi/aacraid/*: convert to > pci_register_driver > > On 15/03/05 08:38 -0500, Salyzyn, Mark wro

RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Salyzyn, Mark
; [EMAIL PROTECTED] Subject: Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver On 15/03/05 08:38 -0500, Salyzyn, Mark wrote: > I have to reject this change since pci_module_init() has a different > return code than pci_register_driver(). pci.h: #define pci_modul

Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Domen Puncer
On 15/03/05 08:38 -0500, Salyzyn, Mark wrote: > I have to reject this change since pci_module_init() has a different > return code than pci_register_driver(). pci.h: #define pci_module_init pci_register_driver pci-driver.c: pci_register_driver: "Returns a negative value on error, otherwis

RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Salyzyn, Mark
I have to reject this change since pci_module_init() has a different return code than pci_register_driver(). The patch should look like: - error = pci_module_init(&aac_pci_driver); + error = pci_register_driver(&aac_pci_driver); - if (error) + if (error < 0)