RE: scsi error handling thread and REQUEST SENSE

2014-05-19 Thread Elliott, Robert (Server Storage)
.org > Subject: Re: scsi error handling thread and REQUEST SENSE > > > On Mon, 2014-05-19 at 10:32 +0200, Hannes Reinecke wrote: > > On 05/16/2014 10:05 PM, Ewan Milne wrote: > > > On Fri, 2014-05-16 at 19:02 +, Elliott, Robert (Server Storage) > > > wrote: &g

Re: scsi error handling thread and REQUEST SENSE

2014-05-19 Thread James Bottomley
On Mon, 2014-05-19 at 10:32 +0200, Hannes Reinecke wrote: > On 05/16/2014 10:05 PM, Ewan Milne wrote: > > On Fri, 2014-05-16 at 19:02 +, Elliott, Robert (Server Storage) > > wrote: > >> There is an issue with a command timeout followed by a failed > >> abort in the linux SCSI stack. > > > > Th

Re: scsi error handling thread and REQUEST SENSE

2014-05-19 Thread Bart Van Assche
On 05/16/14 21:02, Elliott, Robert (Server Storage) wrote: > The command is still outstanding; data transfers might still occur, > and a completion using its tag could still appear at any time. > However, the error handler declares that the command is done, > so all the buffers are freed and the

Re: scsi error handling thread and REQUEST SENSE

2014-05-19 Thread Bart Van Assche
On 05/19/14 12:37, Hannes Reinecke wrote: > Plus this is just a test patch, nothing official yet. > I'm happy to include the changes for SRP if you can confirm that SRP > requires autosense. Hello Hannes, Since the SRP protocol supports returning sense data in the SRP response message and since e

Re: scsi error handling thread and REQUEST SENSE

2014-05-19 Thread Hannes Reinecke
On 05/19/2014 12:29 PM, Bart Van Assche wrote: On 05/19/14 10:32, Hannes Reinecke wrote: Well, problem here is that the 'REQUEST SENSE' command has two problems: a) Most modern HBA (ie all non-SPI HBAs) use autosense, ie the sense code is returned with the command. So issuing 'REQUEST SENSE' her

Re: scsi error handling thread and REQUEST SENSE

2014-05-19 Thread Bart Van Assche
On 05/19/14 10:32, Hannes Reinecke wrote: > Well, problem here is that the 'REQUEST SENSE' command has two problems: > a) Most modern HBA (ie all non-SPI HBAs) use autosense, ie the sense > code is returned with the command. So issuing 'REQUEST SENSE' here is > pointless. > b) The sense code (when

Re: scsi error handling thread and REQUEST SENSE

2014-05-19 Thread Hannes Reinecke
On 05/16/2014 10:05 PM, Ewan Milne wrote: On Fri, 2014-05-16 at 19:02 +, Elliott, Robert (Server Storage) wrote: There is an issue with a command timeout followed by a failed abort in the linux SCSI stack. This might explain some odd crashes I've seen, where it looks like a command might

Re: scsi error handling thread and REQUEST SENSE

2014-05-16 Thread Ewan Milne
On Fri, 2014-05-16 at 19:02 +, Elliott, Robert (Server Storage) wrote: > There is an issue with a command timeout followed by a failed > abort in the linux SCSI stack. This might explain some odd crashes I've seen, where it looks like a command might have completed *long* after it should have