Re: [PATCH v4 3/5] scsi: Move sense handling routines to scsi_common

2015-07-09 Thread Hannes Reinecke
On 07/08/2015 05:23 PM, Sagi Grimberg wrote: > On 7/8/2015 6:06 PM, Hannes Reinecke wrote: > >> We're adding extra fields here, so we need to make sure to not >> overflow the buffer. You probably have to pass in the buffersize >> to avoid an overflow ... >> Yeah, I know, it's theoretical at the mo

Re: [PATCH v4 3/5] scsi: Move sense handling routines to scsi_common

2015-07-09 Thread Martin K. Petersen
> "Sagi" == Sagi Grimberg writes: Sagi> Sense data handling is also done in the target stack. Hence, move Sagi> sense handling routines to scsi_common so the target will be able Sagi> to use them as well. I'm OK with addressing the buffer size in a separate patch. Reviewed-by: Martin K. Pe

Re: [PATCH v4 3/5] scsi: Move sense handling routines to scsi_common

2015-07-08 Thread Sagi Grimberg
On 7/8/2015 6:06 PM, Hannes Reinecke wrote: We're adding extra fields here, so we need to make sure to not overflow the buffer. You probably have to pass in the buffersize to avoid an overflow ... Yeah, I know, it's theoretical at the moment. But there's nothing which prevents anyone to add othe

Re: [PATCH v4 3/5] scsi: Move sense handling routines to scsi_common

2015-07-08 Thread Hannes Reinecke
On 07/08/2015 04:58 PM, Sagi Grimberg wrote: > Sense data handling is also done in the target stack. > Hence, move sense handling routines to scsi_common so > the target will be able to use them as well. > > Signed-off-by: Sagi Grimberg > Reviewed-by: Bart Van Assche > Reviewed-by: Christoph Hel