Re: Compiler warnings in FCoE code

2019-06-04 Thread Hannes Reinecke
On 6/4/19 7:16 PM, Linus Torvalds wrote: > On Mon, Jun 3, 2019 at 2:20 PM Linus Torvalds > wrote: >> >> In fact, what people *are* passing that thing is this: >> >> struct { >> struct fc_rport_priv rdata; >> struct fcoe_rport frport; >> } buf; > > I

Re: Compiler warnings in FCoE code

2019-06-04 Thread Linus Torvalds
On Mon, Jun 3, 2019 at 2:20 PM Linus Torvalds wrote: > > In fact, what people *are* passing that thing is this: > > struct { > struct fc_rport_priv rdata; > struct fcoe_rport frport; > } buf; It is in fact worse than that. Yes, _some_ people pass t

Re: Compiler warnings in FCoE code

2019-06-03 Thread Hannes Reinecke
On 6/3/19 11:20 PM, Linus Torvalds wrote: > So gcc-9 has a new warning about doing memset() across pointer boundaries. > > We didn't have a lot of these things, and most of them got fixed > pretty quickly. The main remaining ones are oin FCoE, and look like > this: > > In function ‘memset’, >