Re: Sparse fix for scsi_request_fn

2007-10-23 Thread Matthew Wilcox
On Mon, Oct 22, 2007 at 07:09:56PM -0700, Linus Torvalds wrote: > Umm. This is why we write things like > > static void double_lock_balance(struct rq *this_rq, struct rq *busiest) > __releases(this_rq->lock) > __acquires(busiest->lock) > __acquires(t

Re: Sparse fix for scsi_request_fn

2007-10-22 Thread Linus Torvalds
On Mon, 22 Oct 2007, Matthew Wilcox wrote: > > Introduce new __holds() macro to tell sparse it's OK to drop and then > reacquire a lock within a function. Use it in scsi_request_fn. Umm. This is why we write things like static void double_lock_balance(struct rq *this_rq, struct rq *bus

Sparse fix for scsi_request_fn

2007-10-22 Thread Matthew Wilcox
Introduce new __holds() macro to tell sparse it's OK to drop and then reacquire a lock within a function. Use it in scsi_request_fn. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 207f1aa..5e0583a 100644 --- a/drivers/scsi/s