Re: Value of __*{init,exit} anotations?

2008-01-30 Thread Sam Ravnborg
> > > > I don't deny we can invest large amounts of work to fix our current > > issues and build large scriptable checks to ensure we keep it fixed ... > > I'm just asking if, at the end of the day, it's really worth it. > > Some people consider it worth it for their memory restricted systems > a

Re: Value of __*{init,exit} anotations?

2008-01-30 Thread Andi Kleen
> Some people consider it worth it for their memory restricted systems > and would like to drive the annotations even further. [1] They could get much better bang-for-the-buck (as in memory saved for amount of work invested) by tackling some the dynamic memory allocation pigs. In general it's a

Re: Value of __*{init,exit} anotations?

2008-01-30 Thread Russell King
On Wed, Jan 30, 2008 at 04:44:12PM -0600, James Bottomley wrote: > On Thu, 2008-01-31 at 00:32 +0200, Adrian Bunk wrote: > > People at linux-arch (Cc'ed) might be better at explaining how often > > CONFIG_HOTPLUG gets used in real-life systems and how big the savings > > are there. > > > > That

Re: Value of __*{init,exit} anotations?

2008-01-30 Thread James Bottomley
On Thu, 2008-01-31 at 00:32 +0200, Adrian Bunk wrote: > On Wed, Jan 30, 2008 at 03:41:35PM -0600, James Bottomley wrote: > > On Wed, 2008-01-30 at 22:20 +0100, Sam Ravnborg wrote: > > > On Wed, Jan 30, 2008 at 03:00:16PM -0600, James Bottomley wrote: > >... > > > > __init is possibly justifiable wi

Value of __*{init,exit} anotations?

2008-01-30 Thread Adrian Bunk
On Wed, Jan 30, 2008 at 03:41:35PM -0600, James Bottomley wrote: > On Wed, 2008-01-30 at 22:20 +0100, Sam Ravnborg wrote: > > On Wed, Jan 30, 2008 at 03:00:16PM -0600, James Bottomley wrote: >... > > > __init is possibly justifiable with a few hundred k savings on boot. > > > __devinit and the rest