Re: cciss CSMI via sysfs for 2.6

2005-02-18 Thread Christoph Hellwig
> /* > + * sysfs stuff > + * this should be moved to it's own file, maybe cciss_sysfs.h > + */ > + > +static ssize_t cciss_firmver_show(struct device *dev, char *buf) > +{ > + ctlr_info_t *h = dev->driver_data; > +return sprintf(buf,"%c%c%c%c\n", h->firm_ver[0], h->firm_ver[1], > +

Re: cciss CSMI via sysfs for 2.6

2005-02-18 Thread Greg KH
On Fri, Feb 18, 2005 at 07:46:28PM +, Christoph Hellwig wrote: > > /* > > + * sysfs stuff > > + * this should be moved to it's own file, maybe cciss_sysfs.h > > + */ > > + > > +static ssize_t cciss_firmver_show(struct device *dev, char *buf) > > +{ > > + ctlr_info_t *h = dev->driver_data; >

Re: cciss CSMI via sysfs for 2.6

2005-02-18 Thread James Bottomley
On Fri, 2005-02-18 at 12:05 -0800, Greg KH wrote: > For a device? It seems a huge overkill to add this attribute for > _every_ device in the system, when only a small minority can actually > use it. Just put it as a default scsi or transport class attribute > instead. Actually, we might be able

Re: cciss CSMI via sysfs for 2.6

2005-03-01 Thread Christoph Hellwig
On Fri, Feb 18, 2005 at 12:05:52PM -0800, Greg KH wrote: > On Fri, Feb 18, 2005 at 07:46:28PM +, Christoph Hellwig wrote: > > > /* > > > + * sysfs stuff > > > + * this should be moved to it's own file, maybe cciss_sysfs.h > > > + */ > > > + > > > +static ssize_t cciss_firmver_show(struct devic