Re: kernel BUG in drivers/scsi/53c700.c:1129

2016-06-13 Thread Christoph Hellwig
On Fri, Jun 10, 2016 at 02:43:52PM -0700, James Bottomley wrote: > OK, I checked: snic and fnic use SCSI_NO_TAG but they don't save > anything in current_cmnd, so they can't rely on the original behaviour. > I think we'll be safe with a local change in 53c700.c Please move the current_cmnd field

Re: kernel BUG in drivers/scsi/53c700.c:1129

2016-06-10 Thread Helge Deller
On 10.06.2016 23:33, James Bottomley wrote: > On Fri, 2016-06-10 at 14:01 -0700, James Bottomley wrote: >> On Fri, 2016-06-10 at 16:58 -0400, Ewan D. Milne wrote: >>> I'm not sure if this is the problem, but the tagging changes to >>> scsi_tcq.h may have altered the 53c700 driver's assumptions.

Re: kernel BUG in drivers/scsi/53c700.c:1129

2016-06-10 Thread James Bottomley
On Fri, 2016-06-10 at 14:33 -0700, James Bottomley wrote: > On Fri, 2016-06-10 at 14:01 -0700, James Bottomley wrote: > > On Fri, 2016-06-10 at 16:58 -0400, Ewan D. Milne wrote: > > > I'm not sure if this is the problem, but the tagging changes to > > > scsi_tcq.h may have altered the 53c700

Re: kernel BUG in drivers/scsi/53c700.c:1129

2016-06-10 Thread James Bottomley
On Fri, 2016-06-10 at 14:01 -0700, James Bottomley wrote: > On Fri, 2016-06-10 at 16:58 -0400, Ewan D. Milne wrote: > > I'm not sure if this is the problem, but the tagging changes to > > scsi_tcq.h may have altered the 53c700 driver's assumptions. > > In one case it sets sdev->current_cmnd and

Re: kernel BUG in drivers/scsi/53c700.c:1129

2016-06-10 Thread James Bottomley
On Fri, 2016-06-10 at 16:58 -0400, Ewan D. Milne wrote: > I'm not sure if this is the problem, but the tagging changes to > scsi_tcq.h may have altered the 53c700 driver's assumptions. > In one case it sets sdev->current_cmnd and then some of the > tagging calls would return it if the tag was

Re: kernel BUG in drivers/scsi/53c700.c:1129

2016-06-10 Thread Ewan D. Milne
I'm not sure if this is the problem, but the tagging changes to scsi_tcq.h may have altered the 53c700 driver's assumptions. In one case it sets sdev->current_cmnd and then some of the tagging calls would return it if the tag was SCSI_NO_TAG. NCR_700_queuecommand_lck() does: if

Re: kernel BUG in drivers/scsi/53c700.c:1129

2016-06-10 Thread Helge Deller
On 10.06.2016 00:23, James Bottomley wrote: > On Thu, 2016-06-09 at 21:36 +0200, Helge Deller wrote: >> Hi James, >> >> I just tried Debian kernel 4.6.1-1 on my historic 715/64 machine, and it >> ran into this BUG() in the LASI scsi driver: >> >> scsi 0:0:6:0: no saved request for untagged cmd

Re: kernel BUG in drivers/scsi/53c700.c:1129

2016-06-09 Thread James Bottomley
On Thu, 2016-06-09 at 21:36 +0200, Helge Deller wrote: > Hi James, > > I just tried Debian kernel 4.6.1-1 on my historic 715/64 machine, and it > ran into this BUG() in the LASI scsi driver: > > scsi 0:0:6:0: no saved request for untagged cmd > > Any idea? > > Helge > > [0.00]