Re: scsi-debug regression with 4.5-rc?

2016-03-05 Thread Martin K. Petersen
> "Mike" == Mike Snitzer writes: Mike> Seems not, I think that BZ may be due to the LBPRZ clause in Mike> commit 397737223 ("sd: Make discard granularity match logical Mike> block size when LBPRZ=1") ? Mike> should be: q->limits.discard_granularity = 1 * logical_block_size; *blush* Will fi

Re: scsi-debug regression with 4.5-rc?

2016-03-04 Thread Mike Snitzer
On Wed, Jan 20 2016 at 10:57am -0500, Martin K. Petersen wrote: > > "Ewan" == Ewan Milne writes: > > Ewan> So I have a report from our test people that the optimal_io_size > Ewan> sysfs value is now different by a factor of 512 from what it used > Ewan> to be... > > Yes, just prepared a pa

Re: scsi-debug regression with 4.5-rc?

2016-01-20 Thread Martin K. Petersen
> "Ewan" == Ewan Milne writes: Ewan> So I have a report from our test people that the optimal_io_size Ewan> sysfs value is now different by a factor of 512 from what it used Ewan> to be... Yes, just prepared a patch this morning. I messed up sectors vs. bytes. -- Martin K. Petersen Or

Re: scsi-debug regression with 4.5-rc?

2016-01-20 Thread Ewan Milne
So I have a report from our test people that the optimal_io_size sysfs value is now different by a factor of 512 from what it used to be... >Here is what is executed: > >modprobe scsi_debug dev_size_mb=32 sector_size=4096 opt_blks=64 >num_tgts=1 > >And here is what our test is capturing: > >/sys/d