Re: making the queue_type attribute read only, was: Re: tag handling refactor V2

2014-11-13 Thread Christoph Hellwig
On Thu, Nov 13, 2014 at 12:33:41AM +, Elliott, Robert (Server Storage) wrote: > A queue_type of "none" disables the SCSI midlayer automatic queue depth > adjustments based on TASK SET FULL vs. other status values, while > "simple" enables them. That's the feature where TASK SET FULL reception

Re: tag handling refactor V2

2014-11-12 Thread James Bottomley
On Mon, 2014-11-10 at 16:56 +0100, Christoph Hellwig wrote: > - for those drivers looking at the command tagged information we'd need >to quiesce the LUN. No driver but the 53c700 driver does that, and the >53c700 does it at a target-level, which despite a comment claiming it's >needed

RE: making the queue_type attribute read only, was: Re: tag handling refactor V2

2014-11-12 Thread Elliott, Robert (Server Storage)
Bart van > Assche; Mike Christie > Subject: making the queue_type attribute read only, was: Re: tag > handling refactor V2 > > > - how is the change_queue_type API supposed to be used for most > >drivers? It only changes the tag type from none to simple > >or

making the queue_type attribute read only, was: Re: tag handling refactor V2

2014-11-12 Thread Christoph Hellwig
> - how is the change_queue_type API supposed to be used for most drivers? It >only changes the tag type from none to simple or back, but except for the >special implementation in the 53c700 driver doesn't change the queue depth, >which might cause it to issue multiple non-tagged comm

Re: tag handling refactor V2

2014-11-10 Thread Jens Axboe
On 2014-11-10 08:56, Christoph Hellwig wrote: The current SCSI handling suffers from large amounts of duplicate code, and a general confusion of multiple concepts of tagging. This series tries to reduce the amount of code, and introduce two separate clear concepts of tagging: a) a driver can

Re: tag handling refactor V2

2014-11-10 Thread Mike Christie
On 11/10/2014 09:56 AM, Christoph Hellwig wrote: > The current SCSI handling suffers from large amounts of duplicate code, and > a general confusion of multiple concepts of tagging. > > This series tries to reduce the amount of code, and introduce two separate > clear concepts of tagging: > > a)

tag handling refactor V2

2014-11-10 Thread Christoph Hellwig
The current SCSI handling suffers from large amounts of duplicate code, and a general confusion of multiple concepts of tagging. This series tries to reduce the amount of code, and introduce two separate clear concepts of tagging: a) a driver can request block-level tagging to always have a vali

Re: tag handling refactor

2014-11-05 Thread Christoph Hellwig
I've pushed an updated branch with the review comments addressed to git://git.infradead.org/users/hch/scsi.git tcq-rework Thansk for all the reviews, and looking forward to the missing ones! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

tag handling refactor

2014-11-03 Thread Christoph Hellwig
The current SCSI handling suffers from large amounts of duplicate code, and a general confusion of multiple concepts of tagging. This series tries to reduce the amount of code, and introduce two separate clear concepts of tagging: a) a driver can request block-level tagging to always have a vali