[PATCH v2 08/16] qla2xxx: Replace QLA_TGT_STATE_ABORTED with a bit.

2015-12-17 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@qlogic.com> Replace QLA_TGT_STATE_ABORTED state with a bit because the current state of the command is lost when an abort is requested by upper layer. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.mad

[PATCH v2 06/16] qla2xxx: Delete session if initiator is gone from FW

2015-12-17 Thread Himanshu Madhani
ertain scenarios it's impossible to tell whether command was received in logged in or logged out state. Signed-off-by: Alexei Potashnik <ale...@purestorage.com> Acked-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Reviewe

Re: qla2xxx: Delete session if initiator is gone from FW

2016-01-04 Thread Himanshu Madhani
Hi Alexie/Dan, I will send follow up patch to fix this. Thanks, -Himanshu On 12/24/15, 12:11 AM, "Alexei Potashnik" wrote: >I my original patch line 3583 was: > >+ bool logged_out = (status & 0x) == >CTIO_PORT_LOGGED_OUT; > >and line 3587

Re: [PATCH v2 00/16] qla2xxx: Patches for target-pending branch

2016-01-06 Thread Himanshu Madhani
Hi Nic, On 12/20/15, 10:57 PM, "Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote: >Hi Himanshu & Co, > >On Thu, 2015-12-17 at 14:56 -0500, Himanshu Madhani wrote: >> Hi Nic, >> >> Please apply this series to target-pending at your earliest con

[PATCH v2 00/16] qla2xxx: Patches for target-pending branch

2015-12-17 Thread Himanshu Madhani
ait for all conflicts before ack'ing PLOGI Dilip Kumar Uppugandla (1): qla2xxx: Check for online flag instead of active reset when transmitting responses Himanshu Madhani (4): qla2xxx: Enable Extended Logins support qla2xxx: Enable Exchange offload support. qla2xxx: Enable Target count

[PATCH v2 05/16] qla2xxx: Added interface to send explicit LOGO.

2015-12-17 Thread Himanshu Madhani
This patch adds interface to send explicit LOGO explicit LOGO using using ELS commands from driver. Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c | 36 +++

[PATCH v2 03/16] qla2xxx: Enable Target counters in DebugFS.

2015-12-17 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_def.h | 15 + dr

[PATCH v2 01/16] qla2xxx: Enable Extended Logins support

2015-12-17 Thread Himanshu Madhani
by driver. ISP firmware supports upto 16k total logins. Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c |9 +-- drivers/scsi/qla2xxx/qla_def.h | 13 - drivers/

[PATCH v2 02/16] qla2xxx: Enable Exchange offload support.

2015-12-17 Thread Himanshu Madhani
firmware can supports upto 32k total active exchanges. Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c |9 +-- drivers/scsi/qla2xxx/qla_def.h | 12 - drivers/

[PATCH v2 04/16] qla2xxx: Add FW resource count in DebugFS.

2015-12-17 Thread Himanshu Madhani
7] MAX VP count[254] MAX FCF count[0] Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/scsi/qla2xxx/qla_def.h | 13 +++-- drivers/scsi/qla2

[PATCH] qla2xxx: Fix regression introduced by configFS changes

2015-11-24 Thread Himanshu Madhani
this patch fixes following regression # targetcli [Errno 13] Permission denied: '/sys/kernel/config/target/qla2xxx/21:00:00:0e:1e:08:c7:20/tpgt_1/enable' Fixes: 2eafd72939fd ("target: use per-attribute show and store methods") Signed-off-by: Himanshu Madhani <himanshu.madh.

[PATCH v2] qla2xxx: Remove unavailable firmware files

2015-11-17 Thread Himanshu Madhani
Remove firmware binary names for the ISPs, which are not submitted to linux-firmware Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Reviewed-by:

[PATCH 2/2] qla2xxx: use TARGET_SCF_USE_CPUID flag to indiate CPU Affinity

2016-02-10 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.com> Fixes: fb3269b ("qla2xxx: Add selective command queuing"

[PATCH 0/2] qla2xxx: Fixes for target-pending

2016-02-10 Thread Himanshu Madhani
Hi Nic, Here are the patches that addresses review comments from Bart and Christoph. See email threads http://www.spinics.net/lists/target-devel/msg11418.html http://www.spinics.net/lists/target-devel/msg11419.html Please apply these patches to target-pending. Thanks, Himanshu Quinn Tran

[PATCH 1/2] target/transport: add flag to indicate CPU Affinity is observed

2016-02-10 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.com> Fixes: fb3269b ("qla2xxx: Add selective command queuing"

Re: [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

2016-02-08 Thread Himanshu Madhani
Hi Nic, On 2/6/16, 8:40 PM, "Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote: >Hi Himanshu & Quinn, > >On Thu, 2016-02-04 at 11:45 -0500, Himanshu Madhani wrote: >> From: Quinn Tran <quinn.t...@qlogic.com> >> >> #cat /sys/kernel/debu

Re: [PATCH-v4 0/5] Fix LUN_RESET active I/O + TMR handling

2016-02-11 Thread Himanshu Madhani
Hi Nic, On 2/11/16, 3:47 PM, "Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote: >On Wed, 2016-02-10 at 22:53 -0800, Nicholas A. Bellinger wrote: >> On Tue, 2016-02-09 at 18:03 +, Himanshu Madhani wrote: >> > On 2/8/16, 9:25 PM, "Nicholas A. Be

Re: [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

2016-02-09 Thread Himanshu Madhani
On 2/8/16, 9:49 PM, "Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote: >On Mon, 2016-02-08 at 17:43 +0000, Himanshu Madhani wrote: >> > >> >So looking at this patch beyond the debugfs part, it does change where >> >->check_initiator_node_acl

Re: [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

2016-02-09 Thread Himanshu Madhani
On 2/6/16, 9:00 PM, "Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote: >On Sat, 2016-02-06 at 20:40 -0800, Nicholas A. Bellinger wrote: >> Hi Himanshu & Quinn, >> >> On Thu, 2016-02-04 at 11:45 -0500, Himanshu Madhani wrote: >> > From: Q

Re: [PATCH-v4 0/5] Fix LUN_RESET active I/O + TMR handling

2016-02-09 Thread Himanshu Madhani
Hi Nic, On 2/8/16, 9:25 PM, "Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote: >Hi Himanshu, > >On Mon, 2016-02-08 at 23:27 +, Himanshu Madhani wrote: >> >> I am testing this series with with 4.5.0-rc2+ kernel and I am seeing >>issue >>

[PATCH 0/4] qla2xxx: Patches for target-pending branch

2016-02-04 Thread Himanshu Madhani
Hi Nic, Please apply following patches to target-pending branch at your earliest convenience. Thanks, Himanshu Quinn Tran (3): qla2xxx: Fix stale pointer access. qla2xxx: Add DebugFS node for target sess list. qla2xxx: Add DebugFS node to show irq vector's cpuid Swapnil Nagle (1):

[PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

2016-02-04 Thread Himanshu Madhani
n Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h|1 + drivers/scsi/qla2xxx/qla_dfs.c| 55 drivers/scsi/qla2xxx/qla_target.c | 56 ---

[PATCH 4/4] qla2xxx: Add DebugFS node to show irq vector's cpuid

2016-02-04 Thread Himanshu Madhani
> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h |2 + drivers/scsi/qla2xxx/qla_dfs.c | 49 drivers/scsi/qla2xxx/qla_isr.c | 16 + 3 files changed, 67 insertions(+), 0 deletions(-) diff

[PATCH 2/4] qla2xxx: Use ATIO type to send correct tmr response

2016-02-04 Thread Himanshu Madhani
From: Swapnil Nagle <swapnil.na...@purestorage.com> The function value inside se_cmd can change if the TMR is cancelled. Use original ATIO Type to correctly determine CTIO response. Signed-off-by: Swapnil Nagle <swapnil.na...@purestroage.com> Signed-off-by: Himanshu Madhani &l

[PATCH 1/4] qla2xxx: Fix stale pointer access.

2016-02-04 Thread Himanshu Madhani
x90 [] ret_from_fork+0x3f/0x70 [] ? flush_kthread_worker+0x90/0x90 8< Cc: <sta...@vger.kernel.org> Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_init.c | 10

[PATCH v2 07/11] qla2xxx: Avoid side effects when using endianizer macros.

2016-01-27 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c |4 +- drivers/scsi/qla2xxx/q

[PATCH v2 05/11] qla2xxx: Add support for buffer to buffer credit value for ISP27XX.

2016-01-27 Thread Himanshu Madhani
From: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_bsg.c | 55 drivers/scsi/qla2xx

[PATCH v2 00/11] qla2xxx: Patches for scsi "misc" branch.

2016-01-27 Thread Himanshu Madhani
2): qla2xxx: Remove unneeded link offline message. qla2xxx: Set relogin flag when we fail to queue login requests. Harish Zunjarrao (2): qla2xxx: Add support for Private link statistics counters. qla2xxx: Provide mbx info in BBCR data after mbx failure Himanshu Madhani (3): qla2xxx: Allow fw t

[PATCH v2 04/11] qla2xxx: Add support for online flash update for ISP27XX.

2016-01-27 Thread Himanshu Madhani
From: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c | 12 - drivers/scsi/qla2xxx

[PATCH v2 08/11] qla2xxx: Provide mbx info in BBCR data after mbx failure

2016-01-27 Thread Himanshu Madhani
From: Harish Zunjarrao <harish.zunjar...@qlogic.com> Signed-off-by: Harish Zunjarrao <harish.zunjar...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_bsg.c |9 +++-- drivers/scsi/qla2xxx/qla_bsg.h |4 +++- 2

[PATCH v2 11/11] qla2xxx: Update driver version to 8.07.00.33-k

2016-01-27 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 6d31faa..0bc93fa 100644 --- a/driver

[PATCH v2 01/11] qla2xxx: Remove unneeded link offline message.

2016-01-27 Thread Himanshu Madhani
From: Chad Dupuis <chad.dup...@qlogic.com> Signed-off-by: Chad Dupuis <chad.dup...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c |1 + drivers/scsi/qla2xxx/qla_isr.c |4 2 files changed, 1 insertio

[PATCH v2 06/11] qla2xxx: Add support for Private link statistics counters.

2016-01-27 Thread Himanshu Madhani
From: Harish Zunjarrao <harish.zunjar...@qlogic.com> Signed-off-by: Harish Zunjarrao <harish.zunjar...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c |6 ++- drivers/scsi/qla2xxx

[PATCH v2 09/11] qla2xxx: Enable T10-DIF for ISP27XX

2016-01-27 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_os.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2

[PATCH v2 10/11] qla2xxx: Set relogin flag when we fail to queue login requests.

2016-01-27 Thread Himanshu Madhani
n flag is not set. Signed-off-by: Chad Dupuis <chad.dup...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_init.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/dr

[PATCH v2 03/11] qla2xxx: Allow fw to hold status before sending ABTS response.

2016-01-27 Thread Himanshu Madhani
Set bit 12 of additional firmware options 3 to let firmware hold status IOCB until ABTS response is received from Target. Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_g

Re: [PATCH 03/11] qla2xxx: Allow fw to hold status before sending ABTS response.

2016-01-27 Thread Himanshu Madhani
On 1/27/16, 12:24 AM, "Hannes Reinecke" <h...@suse.de> wrote: >On 01/26/2016 06:10 PM, Himanshu Madhani wrote: >> Set bit 12 of additional firmware options 3 to let firmware >> hold status IOCB until ABTS response is received from Target. >> >> Sig

Re: [Y2038] [PATCH, RESEND 2] qla2xxx: Remove use of 'struct timeval'

2016-01-25 Thread Himanshu Madhani
t; > >If anyone is going to pick this up, let me know whether you will fix >it up yourself or if I should resend. Please resend the patch and add Acked-by: Himanshu Madhani <himanshu.madh...@qlogic.com> >-- >To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >the body of a message to majord...@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks, - Himanshu <>

[PATCH] qla2xxx: Fix warning reported by static checker

2016-01-20 Thread Himanshu Madhani
ORT LOGGED OUT" : "PORT UNAVAILABLE", Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_target.c |7 +

[PATCH 06/11] qla2xxx: Add support for Private link statistics counters.

2016-01-26 Thread Himanshu Madhani
From: Harish Zunjarrao <harish.zunjar...@qlogic.com> Signed-off-by: Harish Zunjarrao <harish.zunjar...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c |6 ++- drivers/scsi/qla2xxx

[PATCH 03/11] qla2xxx: Allow fw to hold status before sending ABTS response.

2016-01-26 Thread Himanshu Madhani
Set bit 12 of additional firmware options 3 to let firmware hold status IOCB until ABTS response is received from Target. Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_g

[PATCH 11/11] qla2xxx: Update driver version to 8.07.00.33-k

2016-01-26 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 6d31faa..0bc93fa 100644 --- a/driver

[PATCH 05/11] qla2xxx: Add support for buffer to buffer credit value for ISP27XX.

2016-01-26 Thread Himanshu Madhani
From: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_bsg.c | 55 drivers/scsi/qla2xx

[PATCH 01/11] qla2xxx: Remove unneeded link offline message.

2016-01-26 Thread Himanshu Madhani
From: Chad Dupuis <chad.dup...@qlogic.com> Signed-off-by: Chad Dupuis <chad.dup...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c |1 + drivers/scsi/qla2xxx/qla_isr.c |4 2 files changed, 1 insertio

[PATCH 02/11] qla2xxx: Seed init-cb login timeout from nvram exclusively.

2016-01-26 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_init.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH 04/11] qla2xxx: Add support for online flash update for ISP27XX.

2016-01-26 Thread Himanshu Madhani
From: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c | 12 - drivers/scsi/qla2xxx

[PATCH 07/11] qla2xxx: Avoid side effects when using endianizer macros.

2016-01-26 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c |4 +- drivers/scsi/qla2xxx/q

[PATCH 08/11] qla2xxx: Provide mbx info in BBCR data after mbx failure

2016-01-26 Thread Himanshu Madhani
From: Harish Zunjarrao <harish.zunjar...@qlogic.com> Signed-off-by: Harish Zunjarrao <harish.zunjar...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_bsg.c |9 +++-- drivers/scsi/qla2xxx/qla_bsg.h |4 +++- 2

[PATCH 10/11] qla2xxx: Set relogin flag when we fail to queue login requests.

2016-01-26 Thread Himanshu Madhani
n flag is not set. Signed-off-by: Chad Dupuis <chad.dup...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_init.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/dr

[PATCH 09/11] qla2xxx: Enable T10-DIF for ISP27XX

2016-01-26 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_os.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2

[PATCH 00/11] qla2xxx: Patches for scsi "misc" branch.

2016-01-26 Thread Himanshu Madhani
: Add support for Private link statistics counters. qla2xxx: Provide mbx info in BBCR data after mbx failure Himanshu Madhani (3): qla2xxx: Allow fw to hold status before sending ABTS response. qla2xxx: Enable T10-DIF for ISP27XX qla2xxx: Update driver version to 8.07.00.33-k Joe Carnuccio

Re: [PATCH-v4 0/5] Fix LUN_RESET active I/O + TMR handling

2016-02-15 Thread Himanshu Madhani
Hi Nic, On 2/12/16, 11:03 PM, "Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote: >Hi Himanshu & Co, > >On Fri, 2016-02-12 at 00:48 -0800, Nicholas A. Bellinger wrote: >> On Fri, 2016-02-12 at 05:30 +, Himanshu Madhani wrote: > > > >>

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-19 Thread Himanshu Madhani
ly add initializations to >the variables when the compiler should have figured it out. > >In this case, I wouldn't expect the compiler to ever see through >the unlikely() macro, and I'm not adding a potentially counterproductive >initialization, so I see no reason not to apply the patch. I

Re: tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision3

2016-03-31 Thread Himanshu Madhani
Hi Nic, Laurence, On 3/30/16, 10:34 PM, "Nicholas A. Bellinger" wrote: >(Adding target-devel + Qlogic target folks) > >On Tue, 2016-03-29 at 22:05 -0700, Bart Van Assche wrote: >> On 03/29/16 07:42, Laurence Oberman wrote: >> > I have been using this jammer

Re: [PATCH] tcm_qla2xxx Add SCSI command jammer/discard capability to the tcm_qla2xxx module

2016-05-09 Thread Himanshu Madhani
On 5/9/16, 7:56 AM, "Laurence Oberman" <lober...@redhat.com> wrote: > > >- Original Message - >> From: "Laurence Oberman" <lober...@redhat.com> >> To: "Nicholas A. Bellinger" <n...@linux-iscsi.org> >

Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR

2016-07-14 Thread Himanshu Madhani
eld. A possible case for such a race would be in the kdump >Johannes> case when the HBA's IRQs are still enabled but the driver is >Johannes> undergoing a new initialisation and thus is not aware of >Johannes> already activated IRQs in the HBA. > >Qlogic folks: Please review!

Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

2016-07-08 Thread Himanshu Madhani
On 7/8/16, 12:27 AM, "Thorsten Leemhuis" wrote: >Bruno Prémont wrote on 30.06.2016 17:00: >> In qla24xx_process_response_queue() rsp->msix->cpuid may trigger NULL >> pointer dereference when rsp->msix is NULL: >> […] >> The affected code was introduced by commit >>

[PATCH] qla2xxx: Fix compiler warning

2016-07-06 Thread Himanshu Madhani
Fixes: 7f939ab ("qla2xxx: Add bsg interface to support statistics counter reset.") Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_bsg.c |3 +-- 1 files chang

[PATCH 10/19] qla2xxx: Add bsg interface to support D_Port Diagnostics.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_bsg.c | 44 drivers/scsi/qla2xxx/qla_bsg.h | 12

[PATCH 06/19] qla2xxx: Make debug buffer log easier to view.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c | 33 ++--- 1 file changed, 14 insertions(+), 19

[PATCH 09/19] qla2xxx: Check for device state before unloading the driver.

2016-07-06 Thread Himanshu Madhani
allow that function to unload the driver. Signed-off-by: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2

[PATCH 05/19] qla2xxx: Add module parameter alternate/short names.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_os.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/qla2xxx/

[PATCH 19/19] qla2xxx: Update driver version to 8.07.00.38-k

2016-07-06 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/

[PATCH 13/19] qla2xxx: Add support to handle Loop Init error Asynchronus event.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_isr.c | 11 +-- 2 files changed, 1

[PATCH 17/19] qla2xxx: Fix duplicate message id.

2016-07-06 Thread Himanshu Madhani
From: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c | 7 +++ drivers/scsi/qla2xxx/qla_isr.c | 2 +- drivers/scsi/qla2xxx/qla

[PATCH 15/19] qla2xxx: Separate ISP type bits out from device type.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h | 6 -- drivers/scsi/qla2xxx/qla_os.c | 44 +--

[PATCH 14/19] qla2xxx: Correction to function qla26xx_dport_diagnostics().

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_isr.c | 8 +++- drivers/scsi/qla2xxx/qla_

[PATCH 07/19] qla2xxx: Properly initialize IO statistics.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Properly initialize IO statistics to avoid initial 0xFFF (-1) values. Cleanup/simplify usage of pointer to statistics structure. Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani &l

[PATCH 16/19] qla2xxx: Disable the adapter and skip error recovery in case of register disconnect.

2016-07-06 Thread Himanshu Madhani
From: Sawan Chandak <sawan.chan...@qlogic.com> If there is error recovery going on due to command timeout and there is register disconnect, then disable the adapter. Signed-off-by: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.co

[PATCH 11/19] qla2xxx: Add bsg interface to support statistics counter reset.

2016-07-06 Thread Himanshu Madhani
From: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_bsg.c | 48 ++ drivers/scsi/qla2xxx/qla_bsg

[PATCH 12/19] qla2xxx: Let DPORT be enabled purely by nvram.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2x

[PATCH 18/19] qla2xxx: Fix BBCR offset

2016-07-06 Thread Himanshu Madhani
From: Sawan Chandak <sawan.chan...@qlogic.com> Fixes: 969a619 ("qla2xxx: Add support for buffer to buffer credit value for ISP27XX.") Signed-off-by: Sawan Chandak <sawan.chan...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scs

[PATCH 03/19] qla2xxx: Shutdown board on thermal shutdown aen.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2

[PATCH 08/19] qla2xxx: Properly reset firmware statistics.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c | 28 drivers/scsi/qla2xxx/qla_bsg.c |

[PATCH 01/19] qla2xxx: Remove sysfs node fw_dump_template.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c | 89 - drivers/scsi/qla2xxx/qla_dbg.

[PATCH 00/19] qla2xxx: Patches for scsi "misc" branch.

2016-07-06 Thread Himanshu Madhani
Hi James, Martin, Please apply the following patches to the scsi tree, misc branch at your earliest convenience. Thanks, -Himanshu Giridhar Malavali (1): qla2xxx: Set FLOGI retry in additional firmware options for P2P (N2N) mode. Himanshu Madhani (1): qla2xxx: Update driver version

[PATCH 02/19] qla2xxx: Add ram area DDR for fwdump template entry T262.

2016-07-06 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h | 2 ++ drivers/scsi/qla2xxx/qla_mbx.c | 7 +-- drivers/scsi/qla2

[PATCH 04/19] qla2xxx: Set FLOGI retry in additional firmware options for P2P (N2N) mode.

2016-07-06 Thread Himanshu Madhani
har.malav...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com> --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_init.c | 24 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/dr

Re: [patch] qla2xxx: small cleanup in qla2x00_wait_for_hba_ready()

2016-08-04 Thread Himanshu Madhani
while ((qla2x00_reset_active(vha) || ha->dpc_active || >+ ha->flags.mbox_busy) || >+ test_bit(FX00_RESET_RECOVERY, >dpc_flags) || >+ test_bit(FX00_TARGET_SCAN, >dpc_flags)) { >+ if (test_bit(UNLOADING, _vha->dpc_flags)) >+ break; > msleep(1000); > } > } Looks Good. Acked-by: Himanshu Madhani <himanshu.madh...@qlogic.com> >

[PATCH v2 06/14] qla2xxx: Improve T10-DIF/PI handling in driver.

2017-02-03 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@cavium.com> Add routines to support T10 DIF tag. Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Anil Gurumurthy <anil.gurumur...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla

[PATCH v2 11/14] qla2xxx: Fix inadequate lock protection for ABTS.

2017-02-03 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@cavium.com> Normally, ABTS is sent to Target Core as Task MGMT command. In the case of error, qla2xxx needs to send response, hardware_lock is required to prevent request queue corruption. Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-

[PATCH v2 00/14] qla2xxx: Bug Fixes and updates for target.

2017-02-03 Thread Himanshu Madhani
thy (1): qla2xxx: Export DIF stats via debugfs Himanshu Madhani (2): qla2xxx: Add DebugFS node to display Port Database qla2xxx: Update driver version to 9.00.00.00-k Joe Carnuccio (1): qla2xxx: Allow vref count to timeout on vport delete. Quinn Tran (10): qla2xxx: Fix delayed respo

[PATCH v2 12/14] qla2xxx: Add async new target notification

2017-02-03 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_target.c | 6 +++--- drivers/scsi/qla2xxx/qla_target.h | 1 + 2 files changed, 4 insertio

[PATCH v2 08/14] qla2xxx: Change scsi host lookup method

2017-02-03 Thread Himanshu Madhani
search method is based on the full value of the Nport_ID via btree lib. Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/Kconfig | 1 + drivers/scsi/qla2xxx/qla_def.h| 2 + drivers/scsi/qla2xxx

[PATCH v2 09/14] qla2xxx: Fix memory leak for abts processing

2017-02-03 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_target.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_target

[PATCH v2 13/14] qla2xxx: Fix sess_lock & hardware_lock lock order problem.

2017-02-03 Thread Himanshu Madhani
x53/0x70 qlt_sess_work_fn+0x21d/0x480 [qla2xxx] process_one_work+0x1f4/0x6e0 Cc: <sta...@vger.kernel.org> Cc: Bart Van Assche <bart.vanass...@sandisk.com> Reported-by: Bart Van Assche <bart.vanass...@sandisk.com> Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Hi

[PATCH v2 04/14] qla2xxx: Use IOCB interface to submit non-critical MBX.

2017-02-03 Thread Himanshu Madhani
absorb more commands. Following commands are being routed through IOCB interface - Get ID List (007Ch) - Get Port DB (0064h) - Get Link Priv Stats (006Dh) Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi

[PATCH v2 14/14] qla2xxx: Update driver version to 9.00.00.00-k

2017-02-03 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> signed-off-by: Giridhar Malavali <giridhar.malav...@cavium.com> --- drivers/scsi/qla2xxx/qla_version.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/

[PATCH v2 10/14] qla2xxx: Fix request queue corruption.

2017-02-03 Thread Himanshu Madhani
; Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_target.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index b61cbb8..b5fb9c55 100644 --- a/dr

[PATCH v2 05/14] qla2xxx: Add DebugFS node to display Port Database

2017-02-03 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@cavium.com> --- drivers/scsi/qla2xxx/qla_def.h | 2 + drivers/scsi/qla2xxx/qla_dfs.c | 92 -- 2 files changed, 90 insertions(+),

[PATCH v2 01/14] qla2xxx: Fix delayed response to command for loop mode/direct connect.

2017-02-03 Thread Himanshu Madhani
logged in. In the mean time, certain initiators have completed the login and starts IO. Driver needs to start processing all queues if FW is already started. Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx

[PATCH v2 02/14] qla2xxx: Allow relogin to proceed if remote login did not finish

2017-02-03 Thread Himanshu Madhani
t sets an expiration timer for the PRLI. Once the expiration time passes, the relogin retry logic is allowed to go through and perform login with the remote port. Signed-off-by: Quinn Tran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi

[PATCH v2 07/14] qla2xxx: Export DIF stats via debugfs

2017-02-03 Thread Himanshu Madhani
From: Anil Gurumurthy <anil.gurumur...@cavium.com> Signed-off-by: Anil Gurumurthy <anil.gurumur...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_def.h | 12 drivers/scsi/qla2xxx/qla_dfs.c | 15 ++

[PATCH v2 03/14] qla2xxx: Allow vref count to timeout on vport delete.

2017-02-03 Thread Himanshu Madhani
From: Joe Carnuccio <joe.carnuc...@cavium.com> Signed-off-by: Joe Carnuccio <joe.carnuc...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_attr.c | 4 +--- drivers/scsi/qla2xxx/qla_mid.c | 12 +++- 2 files cha

[PATCH v3 05/14] qla2xxx: Add DebugFS node to display Port Database

2017-02-24 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> Signed-off-by: Giridhar Malavali <giridhar.malav...@cavium.com> --- drivers/scsi/qla2xxx/qla_def.h | 2 + drivers/scsi/qla2xxx/qla_dfs.c | 92 -- 2 files changed, 90 insertions(+),

[PATCH v3 06/14] qla2xxx: Improve T10-DIF/PI handling in driver.

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@cavium.com> Add routines to support T10 DIF tag. Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Anil Gurumurthy <anil.gurumur...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla

[PATCH v3 01/14] qla2xxx: Fix delayed response to command for loop mode/direct connect.

2017-02-24 Thread Himanshu Madhani
logged in. In the mean time, certain initiators have completed the login and starts IO. Driver needs to start processing all queues if FW is already started. Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx

[PATCH v3 00/14] qla2xxx: Bug Fixes and updates for target.

2017-02-24 Thread Himanshu Madhani
from v1 -> v2 o Rebased series based on scsi-target-for-v4.11 branch. Please apply to target-pending. Thanks, Himanshu Anil Gurumurthy (1): qla2xxx: Export DIF stats via debugfs Himanshu Madhani (2): qla2xxx: Add DebugFS node to display Port Database qla2xxx: Update driver version to

[PATCH v3 13/14] qla2xxx: Fix sess_lock & hardware_lock lock order problem.

2017-02-24 Thread Himanshu Madhani
x53/0x70 qlt_sess_work_fn+0x21d/0x480 [qla2xxx] process_one_work+0x1f4/0x6e0 Cc: <sta...@vger.kernel.org> Cc: Bart Van Assche <bart.vanass...@sandisk.com> Reported-by: Bart Van Assche <bart.vanass...@sandisk.com> Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Hi

[PATCH v3 10/14] qla2xxx: Fix request queue corruption.

2017-02-24 Thread Himanshu Madhani
ran <quinn.t...@qlogic.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_target.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index

<    1   2   3   4   5   6   7   8   9   10   >