[PATCH 8/8] qla2xxx: Update driver version to 10.00.00.05-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 0843def08356..549bef9afddd 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH 2/8] qla2xxx: Fix recursion while sending terminate exchange

+0x9c/0xb0 [qla2xxx] qlt_term_ctio_exchange+0x9c/0xb0 [qla2xxx] qlt_term_ctio_exchange+0x9c/0xb0 [qla2xxx] qlt_term_ctio_exchange+0x9c/0xb0 [qla2xxx] Fixes: 82de802ad46e ("scsi: qla2xxx: Preparation for Target MQ.") Cc: #4.10 Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/ql

[PATCH 3/8] qla2xxx: Fix warning in qla2x00_async_iocb_timeout()

an Carpenter Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 9c08222e4c8b..08ad1a60cb0d 100644 --- a/drivers/scsi/qla2

[PATCH 0/8] qla2xxx: Minor fixes for the driver

eries to 4.16/scsi-queue at your earliest convenience. Thanks, Himanshu Anil Gurumurthy (1): qla2xxx: Add XCB counters to debugfs Darren Trapp (1): qla2xxx: Fix queue ID for async abort with Multiqueue Himanshu Madhani (6): qla2xxx: Fix NULL pointer crash due to probe failure qla2xxx

[PATCH 1/8] qla2xxx: Fix NULL pointer crash due to probe failure

r functionality."). Cc: # 4.10 Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index b21878a70f6e..12ee6e02d146 100644 --- a/drivers/scsi/ql

[PATCH 4/8] qla2xxx: Fix warning during port_name debug print

This patch fixes following smatch warning drivers/scsi/qla2xxx/qla_iocb.c:2622 qla2x00_els_dcmd2_sp_done() error: '%pC' expects argument of type 'struct clk*', argument 8 has type 'uchar[]' Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_iocb.c | 2 +

[PATCH 0/5] qla2xxx: Fixes for FC-NVMe erorr path.

changes for devloss timeout in driver qla2xxx: Restore ZIO threshold setting Himanshu Madhani (2): qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe qla2xxx: Update driver version to 10.00.00.06-k drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_init.c| 13

[PATCH 1/5] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 6b33a1f24f56..162a523b985e 100644 --- a/drivers/scsi/qla2xxx/qla_nvme.c

[PATCH 4/5] qla2xxx: Restore ZIO threshold setting

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index a8e81fc14c44..5ee447680ddd 100644 --- a/drivers

[PATCH 2/5] qla2xxx: Set IIDMA and fcport state before qla_nvme_register_remote()

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index aececf664654..e7e51ac0bb46 100644

[PATCH 5/5] qla2xxx: Update driver version to 10.00.00.06-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 549bef9afddd..0c55d7057280 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH 3/5] qla2xxx: Add changes for devloss timeout in driver

From: Darren Trapp Add support for error recovery within devloss timeout, now that FC-NVMe transport support devloss timeout. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 1 + drivers/scsi/qla2xxx/qla_init.c | 8 +++ drivers/scsi

[PATCH 0/2] qla2xxx: fixes for the driver

Hi Martin, This series has small fixes for the driver. Please apply to 4.16/scsi-queue. Thanks, Himanshu Himanshu Madhani (2): qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd() qla2xxx: Fix logo flag for qlt_free_session_done() drivers/scsi/qla2xxx/qla_init.c | 5

[PATCH 1/2] qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd()

This patch fixes following sparse warning drivers/scsi/qla2xxx/qla_init.c:1570:44: sparse: incorrect type in assignment (different base types) Fixes: 07a21872cf2b ("scsi: qla2xxx: Fix queue ID for async abort with Multiqueue") Signed-off-by: Himanshu Madhani --- drivers/sc

[PATCH 2/2] qla2xxx: Fix logo flag for qlt_free_session_done()

From: Himanshu Madhani Commit 3515832cc61467bfb87191a30401de1700e9956a fixed the target re-login after session relogin is complete, but missed out the qlt_free_session_done() path. This patch clears send_els_logo flag in qlt_free_session_done() callback. Fixes: 3515832cc614 ("scsi: ql

[PATCH] qla2xxx: Fix memory corruption during hba reset test

[ 466.476718] Oops: [#1] SMP Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- Hi Martin, This patch fixes the crash for HBA reset test. From core dump analysis, memory corruption was discoverd during session cleanup. To prevent this memory corruption, driver needs to wait for

[PATCH 0/2] qla2xxx: Bug fixes for driver

Hi Martin, These are couple of bug fixes for the driver. Patch#1 is the issue reported by Max using KASAN tool. Patch#2 fixes use of wrong queue handle for abort IOCB. Please apply them to 4.16/scsi-fixes at your earliest convenience. Thanks, Himanshu Himanshu Madhani (1): qla2xxx: Fix

[PATCH 2/2] qla2xxx: Fix incorrect handle for abort IOCB

This patch fixes incorrect handle used for abort IOCB. Fixes: b027a5ace443 ("scsi: qla2xxx: Fix queue ID for async abort with Multiqueue") Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_iocb.c | 7 +++ 1 file changed, 3 insertions(+), 4

[PATCH 1/2] qla2xxx: Fix double free bug after firmware timeout

mer_fn+0x36/0x200 The buggy address belongs to the object at 88278147a440 which belongs to the cache qla2xxx_srbs of size 344 The buggy address is located 336 bytes inside of 344-byte region [88278147a440, 88278147a598) Reported-by: Max Kellermann Signed-off-by: Quinn Tran Signed-

[PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

d at offset 0xf8 within that structure (i.e. 95e5ff621080 + f8 -> 95e5ff621178) is a struct timer_list. Cc: #4.4+ Signed-off-by: Himanshu Madhani --- Hi Martin, This patch addresses crash due to NULL pointer access because driver left active timer running for abort IOCB. Please apply this p

Re: [PATCH 1/3] qla2xxx: Fixup locking for session deletion

ducing a separate lock for processing the GNLIST response, and > ensures that sess_lock is released before calling > qlt_schedule_sess_delete(). > > Cc: Himanshu Madhani > Cc: Quinn Tran > Fixes: d8630bb95f46 ("scsi: qla2xxx: Serialize session deletion by using &

Re: [PATCH 2/3] qla2xxx: do not check login_state if no loop id is assigned

On Thu, 22 Feb 2018, 12:49am, Hannes Reinecke wrote: > When no loop id is assigned in qla24xx_fcport_handle_login() > the login state needs to be ignored; it will get set later on > in qla_chk_n2n_b4_login(). > > Cc: Quinn Tran > Cc: Himanshu Madhani > Fixes: 040036b

Re: [PATCH 3/3] qla2xxx: ensure async flags are reset correctly

and no login attempt into > remote ports. > > Cc: Quinn Tran > Cc: Himanshu Madhani > Fixes: 3dbec59bdf63 ("scsi: qla2xxx: Prevent multiple active discovery > commands per session") > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/qla2xxx/qla_gs.c

Re: [PATCH v2] scsi: qla2xxx: Use dma_pool_zalloc()

;dl_dma_pool, GFP_ATOMIC, &crc_ctx_dma); > + dma_pool_zalloc(ha->dl_dma_pool, GFP_ATOMIC, &crc_ctx_dma); > > if (!crc_ctx_pkt) > goto crc_queuing_error; > > - /* Zero out CTX area. */ > - clr_ptr = (uint8_t *)crc_ctx_pkt; > - memset(clr_ptr, 0, sizeof(*crc_ctx_pkt)); > - > crc_ctx_pkt->crc_ctx_dma = crc_ctx_dma; > INIT_LIST_HEAD(&crc_ctx_pkt->dsd_list); > > -- > 1.9.1 > > Looks Good. Acked-by: Himanshu Madhani Thanks, Himanshu

[PATCH] qla2xxx: Fix FC-NVMe LUN discovery

bric discovery") Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- Hi Martin, This patch fixes FC-NVMe LUN discovery for the series sent out during merge window. Please apply this to 4.16/scsi-fixes at your earliest convenience. Thanks, Himanshu --- drivers/scsi/qla2xxx/qla_d

[PATCH] qla2xxx: Remove FC_NO_LOOP_ID for FCP and FC-NVMe Discovery

FC_NO_LOOP_ID will result into discovery failure for FCP LUNs. Fixes: a084fd68e1d26 ("scsi: qla2xxx: Fix re-login for Nport Handle in use") Signed-off-by: Himanshu Madhani --- Hi Martin, This patch fixes the FCP discovery on same port with FC-NVMe enabled. Please apply to 4.16/scsi-fix

[PATCH 09/13] qla2xxx: Fix retry for PRLI RJT with reason of BUSY

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_init.c | 13 - drivers/scsi/qla2xxx/qla_mbx.c | 7 +-- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 04/13] qla2xxx: Restore ZIO threshold setting

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index a8e81fc14c44..5ee447680ddd 100644 --- a/drivers

[PATCH 05/13] qla2xxx: Add FC-NVMe abort processing

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 36 ++-- drivers/scsi/qla2xxx/qla_nvme.h | 1 + 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/qla2xxx

[PATCH 12/13] qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan

From: Quinn Tran This patch combines FCP and FC-NVMe scan into single scan when driver detects FC-NVMe capability on same port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 7 ++ drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi

[PATCH 08/13] qla2xxx: Remove nvme_done_list

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_gbl.h | 2 -- drivers/scsi/qla2xxx/qla_init.c | 1 - drivers/scsi/qla2xxx/qla_mid.c | 6 -- drivers/scsi/qla2xxx/qla_nvme.c | 13

[PATCH 13/13] qla2xxx: Update driver version to 10.00.00.06-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 549bef9afddd..0c55d7057280 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH 02/13] qla2xxx: Set IIDMA and fcport state before qla_nvme_register_remote()

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index cb182b102bfd..6caccc52376a 100644

[PATCH 00/13] qla2xxx: Fixes for FC-NVMe

error handling Himanshu Madhani (2): qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe qla2xxx: Update driver version to 10.00.00.06-k Quinn Tran (1): qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_def.h

[PATCH 10/13] qla2xxx: Fix FC-NVMe IO abort during driver reset

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 17 - drivers/scsi/qla2xxx/qla_nvme.h | 2 +- drivers/scsi/qla2xxx/qla_os.c | 2 +- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 11/13] qla2xxx: Cleanup code to improve FC-NVMe error handling

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_isr.c | 78 +++-- drivers/scsi/qla2xxx/qla_nvme.c | 2 +- 2 files changed, 29 insertions(+), 51 deletions(-) diff --git a/drivers/scsi/qla2xxx

[PATCH 03/13] qla2xxx: Add changes for devloss timeout in driver

From: Darren Trapp Add support for error recovery within devloss timeout, now that FC-NVMe transport support devloss timeout. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 1 + drivers/scsi/qla2xxx/qla_init.c | 8 +++ drivers/scsi

[PATCH 07/13] qla2xxx: Return busy if rport going away

From: Darren Trapp This patch adds mechanism to retur EBUSY if rport is going away to prevent exhausting FC-NVMe layer's retry counter. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_isr.c | 4 +++- dr

[PATCH 01/13] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 6b33a1f24f56..162a523b985e 100644 --- a/drivers/scsi/qla2xxx/qla_nvme.c

[PATCH 06/13] qla2xxx: Fix n2n_ae flag to prevent dev_loss on PDB change

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 2 -- drivers/scsi/qla2xxx/qla_isr.c | 3 --- drivers/scsi/qla2xxx/qla_mbx.c | 3 +++ 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qla2xxx

[PATCH v2 00/13] qla2xxx: Fixes for FC-NVMe

PRLI RJT with reason of BUSY qla2xxx: Fix FC-NVMe IO abort during driver reset qla2xxx: Cleanup code to improve FC-NVMe error handling Himanshu Madhani (2): qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe qla2xxx: Update driver version to 10.00.00.06-k Quinn Tran (1): qla2

[PATCH v2 09/13] qla2xxx: Fix retry for PRLI RJT with reason of BUSY

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_init.c | 13 - drivers/scsi/qla2xxx/qla_mbx.c | 7 +-- 3 files changed, 18 insertions(+), 4

[PATCH v2 01/13] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_nvme.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 6b33a1f24f56..162a523b985e 100644 --- a

[PATCH v2 06/13] qla2xxx: Fix n2n_ae flag to prevent dev_loss on PDB change

From: Darren Trapp On a port db changes, this patch will set n2n_ae flag for N2N connection when requesting for Report ID Acquition MBX, instead of Loop Initialization or point to point asynchronous events. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes

[PATCH v2 03/13] qla2xxx: Add changes for devloss timeout in driver

From: Darren Trapp Add support for error recovery within devloss timeout, now that FC-NVMe transport support devloss timeout. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_def.h| 1 + drivers/scsi/qla2xxx

[PATCH v2 02/13] qla2xxx: Set IIDMA and fcport state before qla_nvme_register_remote()

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index

[PATCH v2 04/13] qla2xxx: Restore ZIO threshold setting

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_nvme.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index a8e81fc14c44

[PATCH v2 07/13] qla2xxx: Return busy if rport going away

From: Darren Trapp This patch adds mechanism to return EBUSY if rport is going away to prevent exhausting FC-NVMe layer's retry counter. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/ql

[PATCH v2 05/13] qla2xxx: Add FC-NVMe abort processing

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_nvme.c | 36 ++-- drivers/scsi/qla2xxx/qla_nvme.h | 1 + 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a

[PATCH v2 08/13] qla2xxx: Remove nvme_done_list

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_gbl.h | 2 -- drivers/scsi/qla2xxx/qla_init.c | 1 - drivers/scsi/qla2xxx/qla_mid.c | 6 -- drivers/scsi/qla2xxx/qla_nvme.c | 13

[PATCH v2 12/13] qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan

From: Quinn Tran This patch combines FCP and FC-NVMe scan into single scan when driver detects FC-NVMe capability on same port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 7 + drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi

[PATCH v2 10/13] qla2xxx: Fix FC-NVMe IO abort during driver reset

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_nvme.c | 17 - drivers/scsi/qla2xxx/qla_nvme.h | 2 +- drivers/scsi/qla2xxx/qla_os.c | 2 +- 3 files changed, 14 insertions(+), 7

[PATCH v2 11/13] qla2xxx: Cleanup code to improve FC-NVMe error handling

From: Darren Trapp This patch cleans up ABTS handling for FC-NVMe by - Removing allocation of sp, instead pass the sp pointer for abort IOCB - Fix error handling from Transport failure - set outstanding_cmds array to NULL for nvme completion Signed-off-by: Darren Trapp Signed-off-by: Himanshu

[PATCH v2 13/13] qla2xxx: Update driver version to 10.00.00.06-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 549bef9afddd..0c55d7057280 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH v3 08/13] qla2xxx: Remove nvme_done_list

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_gbl.h | 2 -- drivers/scsi/qla2xxx/qla_init.c | 1 - drivers/scsi/qla2xxx/qla_mid.c | 6 -- drivers

[PATCH v3 10/13] qla2xxx: Fix FC-NVMe IO abort during driver reset

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 17 - drivers/scsi/qla2xxx/qla_nvme.h | 2 +- drivers/scsi/qla2xxx/qla_os.c | 2 +- 3 files

[PATCH v3 12/13] qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan

From: Quinn Tran This patch combines FCP and FC-NVMe scan into single scan when driver detects FC-NVMe capability on same port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 8 ++ drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi

[PATCH v3 03/13] qla2xxx: Add changes for devloss timeout in driver

From: Darren Trapp Add support for error recovery within devloss timeout, now that FC-NVMe transport support devloss timeout. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_def.h| 1

[PATCH v3 00/13] qla2xxx: Fixes for FC-NVMe

Fix FC-NVMe IO abort during driver reset qla2xxx: Cleanup code to improve FC-NVMe error handling Himanshu Madhani (2): qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe qla2xxx: Update driver version to 10.00.00.06-k Quinn Tran (1): qla2xxx: Fix Async GPN_FT for FCP and FC-NVM

[PATCH v3 04/13] qla2xxx: Restore ZIO threshold setting

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx

[PATCH v3 09/13] qla2xxx: Fix retry for PRLI RJT with reason of BUSY

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_init.c | 13 - drivers/scsi/qla2xxx/qla_mbx.c | 7 +-- 3 files

[PATCH v3 06/13] qla2xxx: Fix n2n_ae flag to prevent dev_loss on PDB change

From: Darren Trapp On a port db changes, this patch will set n2n_ae flag for N2N connection when requesting for Report ID Acquition MBX, instead of Loop Initialization or point to point asynchronous events. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes

[PATCH v3 05/13] qla2xxx: Add FC-NVMe abort processing

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 36 ++-- drivers/scsi/qla2xxx/qla_nvme.h | 1 + 2 files changed, 19 insertions

[PATCH v3 02/13] qla2xxx: Set IIDMA and fcport state before qla_nvme_register_remote()

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers

[PATCH v3 01/13] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 6b33a1f24f56

[PATCH v3 13/13] qla2xxx: Update driver version to 10.00.00.06-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 549bef9afddd..0c55d7057280 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH v3 11/13] qla2xxx: Cleanup code to improve FC-NVMe error handling

From: Darren Trapp This patch cleans up ABTS handling for FC-NVMe by - Removing allocation of sp, instead pass the sp pointer for abort IOCB - Fix error handling from Trasport failure - set outstanding_cmds array to NULL for nvme completion Signed-off-by: Darren Trapp Signed-off-by: Himanshu

[PATCH v3 07/13] qla2xxx: Return busy if rport going away

From: Darren Trapp This patch adds mechanism to return EBUSY if rport is going away to prevent exhausting FC-NVMe layer's retry counter. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/ql

[PATCH v4 01/13] qla2xxx: Restore ZIO threshold setting

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx

[PATCH v4 00/13] qla2xxx: Fixes for FC-NVMe

x: Remove nvme_done_list qla2xxx: Fix retry for PRLI RJT with reason of BUSY qla2xxx: Fix FC-NVMe IO abort during driver reset qla2xxx: Cleanup code to improve FC-NVMe error handling Himanshu Madhani (2): qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe qla2xxx: Update driver

[PATCH v4 08/13] qla2xxx: Remove nvme_done_list

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_gbl.h | 2 -- drivers/scsi/qla2xxx/qla_init.c | 1 - drivers/scsi/qla2xxx/qla_mid.c | 6 -- drivers

[PATCH v4 07/13] qla2xxx: Return busy if rport going away

From: Darren Trapp This patch adds mechanism to return EBUSY if rport is going away to prevent exhausting FC-NVMe layer's retry counter. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/ql

[PATCH v4 06/13] qla2xxx: Fix n2n_ae flag to prevent dev_loss on PDB change

From: Darren Trapp On a port db changes, this patch will set n2n_ae flag for N2N connection when requesting for Report ID Acquition MBX, instead of Loop Initialization or point to point asynchronous events. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes

[PATCH v4 13/13] qla2xxx: Update driver version to 10.00.00.06-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 549bef9afddd..0c55d7057280 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH v4 03/13] qla2xxx: Set IIDMA and fcport state before qla_nvme_register_remote()

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers

[PATCH v4 04/13] qla2xxx: Add changes for devloss timeout in driver

From: Darren Trapp Add support for error recovery within devloss timeout, now that FC-NVMe transport support devloss timeout. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_def.h| 1

[PATCH v4 02/13] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 7a292421a7d7

[PATCH v4 10/13] qla2xxx: Fix FC-NVMe IO abort during driver reset

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 17 - drivers/scsi/qla2xxx/qla_nvme.h | 2 +- drivers/scsi/qla2xxx/qla_os.c | 2 +- 3 files

[PATCH v4 11/13] qla2xxx: Cleanup code to improve FC-NVMe error handling

From: Darren Trapp This patch cleans up ABTS handling for FC-NVMe by - Removing allocation of sp, instead pass the sp pointer for abort IOCB - Fix error handling from Trasport failure - set outstanding_cmds array to NULL for nvme completion Signed-off-by: Darren Trapp Signed-off-by: Himanshu

[PATCH v4 09/13] qla2xxx: Fix retry for PRLI RJT with reason of BUSY

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_init.c | 13 - drivers/scsi/qla2xxx/qla_mbx.c | 7 +-- 3 files

[PATCH v4 05/13] qla2xxx: Add FC-NVMe abort processing

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 36 ++-- drivers/scsi/qla2xxx/qla_nvme.h | 1 + 2 files changed, 19 insertions

[PATCH v4 12/13] qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan

From: Quinn Tran This patch combines FCP and FC-NVMe scan into single scan when driver detects FC-NVMe capability on same port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 8 ++ drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi

Re: [EXT] [PATCH] nvme,scsi: display FC-NVMe port roles

_DUMMY_INITIATOR 0x08 +#define FC_PORT_ROLE_NVME_INITIATOR0x10 +#define FC_PORT_ROLE_NVME_TARGET 0x20 +#define FC_PORT_ROLE_NVME_DISCOVERY0x40 /* The following are for compatibility */ #define FC_RPORT_ROLE_UNKNOWN FC_PORT_ROLE_UNKNOWN -- 2.16.4 Looks Good. Reviewed-by: Himanshu Madhani

[PATCH] qla2xxx: Fix read offset in qla24xx_load_risc_flash()

c fc fc fc fc fc fc == Fixes: f8f97b0c5b7f ("scsi: qla2xxx: Cleanups for NVRAM/Flash read/write path") Reported-by: Bart Van Assche Tested-by: Bart Van Assche Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 16 +--- 1 file changed,

Re: [PATCH 00/10] Improve qla2xxx coding style

_target.c | 25 +-- drivers/scsi/qla2xxx/qla_target.h | 4 +- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 2 - 22 files changed, 149 insertions(+), 87 deletions(-) -- 2.21.0.196.g041f5ea1cf98 Looks Good For the whole series Acked-by: Himanshu Madhani

[PATCH 1/2] qla2xxx: Fix device staying in blocked state

n Cc: sta...@vger.kernel.org #4.19 Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 57cdd762230d..fc8914dd9dde 100644 --- a/dr

[PATCH 2/2] qla2xxx: Silence Sucessful ELS IOCB message

ELS IOCB done message should be moved to verbose logging to prevent confusion about the error case v/s sucessful submission case. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c

[PATCH 0/2] qla2xxx: Minor fixes

Hi Martin, These patches fix small issue where device stays in blocked state due to driver not marking port offline and moving debug message to correct verbose level. Please apply to 5.2/scsi-queue branch for inclusion at your earliest convenience. Thanks, Himanshu Himanshu Madhani (1

Re: [PATCH 00/35] qla2xxx source code cleanup and bug fixes

Hi Bart, Still reviewing it. About half way done. Will ACK if no issues found during testing. Thanks, Himanshu On 4/25/19, 3:04 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van Assche" wrote: On Wed, 2019-04-17 at 14:44 -0700, Bart Van Assche wrote: > This patch serie

Re: [PATCH 00/35] qla2xxx source code cleanup and bug fixes

Hi Martin, Please add for the series, Acked-by: Himanshu Madhani On 4/29/19, 10:59 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Martin K. Petersen" wrote: Himanshu, > Still reviewing it. About half way done. Will ACK if no issues found >

[PATCH 2/2] qla2xxx: Add cleanup for PCI EEH recovery

abled due to PCIe error. This patch does cleanup for EEH recovery code path and prevents adapter from getting disabled. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 221 -- 1 file changed, 82 insertions(+)

[PATCH 0/2] qla2xxx: Bug fixes for the driver

Hi Martin, This series fixes issue with driver's EEH handling and NULL pointer access while accessing optrom. Please apply these patches to 5.2/scsi-queue at your earliest convenience. Thanks, Himanshu Quinn Tran (2): qla2xxx: Fix Crash due to NULL pointer access in qla2x00_sysfs_read_opt

[PATCH 1/2] qla2xxx: Fix Crash due to NULL pointer access in qla2x00_sysfs_read_optrom()

RSP [3130734.630487] CR2: Fixes: c7702b8c2271 ("scsi: qla2xxx: Get mutex lock before checking optrom_state") Cc: sta...@vger.kernel.org # 4.10 Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 3 ++- 1 file chan

Re: [EXT] Re: [PATCH 1/2] qla2xxx: Fix Crash due to NULL pointer access in qla2x00_sysfs_read_optrom()

Hi Ewan, On 5/8/19, 8:36 AM, "Ewan D. Milne" wrote: External Email -- See below. On Mon, 2019-05-06 at 13:52 -0700, Himanshu Madhani wrote: > From: Quinn Tran > >

Re: [PATCH 00/20] qla2xxx Patches

Hi Bart, Thanks for the series. We will provide ACK after these patches have gone through our internal testing. Thanks, Himanshu > On May 29, 2019, at 1:28 PM, Bart Van Assche wrote: > > Hi Martin, > > This patch series is the result of code review, inspection of the Coverity > output and a

Re: [EXT] Re: [PATCH] qla2xxx: remove double assignment in qla2x00_update_fcport

port->logout_on_delete = 1; > - fcport->login_retry = vha->hw->login_retry_count; > fcport->n2n_chip_reset = fcport->n2n_link_reset_cnt = 0; > > switch (vha->hw->current_topology) { > -- > 2.12.3 > >

Re: [EXT] [PATCH 00/20] qla2xxx Patches

Hi Martin, > On Jun 5, 2019, at 7:05 PM, Martin K. Petersen > wrote: > > External Email > > -- > > Himanshu, > >> Thanks for the series. We will provide ACK after these patches have >> gone through our internal testing. >

Re: [EXT] [PATCH 00/20] qla2xxx Patches

Hi Martin, > On Jun 6, 2019, at 2:57 PM, Martin K. Petersen > wrote: > > > Himanshu, > >> Sorry for delay. I need bit more time. I will let my automation work >> thru weekend and will respond in early next week > > OK, thanks! > I am running into issue with this series applied on my tree

Re: [EXT] [PATCH 00/20] qla2xxx Patches

Hello Bart, > On Jun 11, 2019, at 12:27 PM, Bart Van Assche wrote: > > On 6/11/19 11:12 AM, Himanshu Madhani wrote: >> I am running into issue with this series applied on my tree while executing >> abort path. >> >> Investigating if the issue is

[PATCH] qla2xxx: Fix hardlockup in abort command during driver remove.

[qla2xxx] [436194.66] pci_device_remove+0x3b/0xb0 Fixes: 219d27d7147e (scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands) Cc: sta...@vger.kernel.org # 5.2 Signed-off-by: Arun Easi Signed-off-by: Himanshu Madhani --- Hi Martin, This patch fixes issue we found during

<    2   3   4   5   6   7   8   9   10   11   >