[PATCH 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-14 Thread Himanshu Madhani
rt_work [qla2xxx] [ 5631.004097] RIP: 0010:[] [] qla_nvme_abort_work+0x22/0x100 [qla2xxx] [ 5631.004109] Call Trace: [ 5631.004115] [] ? pwq_dec_nr_in_flight+0x64/0xb0 [ 5631.004117] [] process_one_work+0x17f/0x440 [ 5631.004120] [] worker_thread+0x126/0x3c0 Signed-off-by: Quinn Tran Signed-off-by: H

[PATCH 1/3] qla2xxx: Fix kernel crash after disconnecting NVMe devices

2019-06-14 Thread Himanshu Madhani
protected, and when a remoteport_delete callback is called, driver traverses the list and crashes. Actually, the list could be removed and driver could traverse the main fcport list instead. Fix does exactly that. Signed-off-by: Arun Easi Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx

[PATCH 2/3] qla2xxx: on session delete return nvme cmd

2019-06-14 Thread Himanshu Madhani
From: Quinn Tran - on session delete or chip reset, reject all NVME commands. - on NVME command submission error, free srb resource. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 20 +--- 1 file changed, 13 insertions(+), 7

[PATCH 0/3] qla2xxx: Fix crashes with FC-NVMe devices

2019-06-14 Thread Himanshu Madhani
Hi Martin, This series fixes crash during abort handling with FC-NVMe devices. Also, we discovered race condition between nvme command and ls completion with FC-NVMe devices. Please apply this series to 5.3/scsi-queue at your earliest convenience. Thanks, Himanshu Arun Easi (1): qla2xxx: Fix

Re: [EXT] Re: [PATCH 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-14 Thread Himanshu Madhani
Hi Bart, On 6/14/19, 3:24 PM, "Bart Van Assche" wrote: External Email -- On 6/14/19 3:10 PM, Himanshu Madhani wrote: > From: Quinn Tran > > This patch uses kref to pro

[PATCH 1/1] qla2xxx: move IO flush to the front of NVME rport unregistration

2019-06-16 Thread Himanshu Madhani
during session deletion. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- Hi Martin, we found one more issue where NVMe IO would be stuck while doing a port toggle or lip_reset test case. This patch fixes issue by flushing IO before unregistering NVMe session. This patch depends on

[PATCH v2 0/3] qla2xxx: Fix crashes with FC-NVMe devices

2019-06-18 Thread Himanshu Madhani
Hi Martin, This series fixes crash during abort handling with FC-NVMe devices. Also, we discovered race condition between nvme command and ls completion with FC-NVMe devices. Please apply this series to 5.3/scsi-queue at your earliest convenience. Thanks, Himanshu Changes from v1 -> v2 o Remov

[PATCH v2 1/3] qla2xxx: Fix kernel crash after disconnecting NVMe devices

2019-06-18 Thread Himanshu Madhani
protected, and when a remoteport_delete callback is called, driver traverses the list and crashes. Actually, the list could be removed and driver could traverse the main fcport list instead. Fix does exactly that. Signed-off-by: Arun Easi Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx

[PATCH v2 2/3] qla2xxx: on session delete return nvme cmd

2019-06-18 Thread Himanshu Madhani
From: Quinn Tran - on session delete or chip reset, reject all NVME commands. - on NVME command submission error, free srb resource. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 20 +--- 1 file changed, 13 insertions(+), 7

[PATCH v2 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-18 Thread Himanshu Madhani
rt_work [qla2xxx] [ 5631.004097] RIP: 0010:[] [] qla_nvme_abort_work+0x22/0x100 [qla2xxx] [ 5631.004109] Call Trace: [ 5631.004115] [] ? pwq_dec_nr_in_flight+0x64/0xb0 [ 5631.004117] [] process_one_work+0x17f/0x440 [ 5631.004120] [] worker_thread+0x126/0x3c0 Signed-off-by: Quinn Tran Signed-off-by: H

[PATCH v3 0/3] qla2xxx: Fix crashes with FC-NVMe devices

2019-06-21 Thread Himanshu Madhani
Hi Martin, This series fixes crash during abort handling with FC-NVMe devices. Also, we discovered race condition between nvme command and ls completion with FC-NVMe devices. Please apply this series to 5.3/scsi-queue at your earliest convenience. Thanks, Himanshu Changes from v2 -> v3 o Chang

[PATCH v3 1/3] qla2xxx: Fix kernel crash after disconnecting NVMe devices

2019-06-21 Thread Himanshu Madhani
protected, and when a remoteport_delete callback is called, driver traverses the list and crashes. Actually, the list could be removed and driver could traverse the main fcport list instead. Fix does exactly that. Signed-off-by: Arun Easi Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx

[PATCH v3 2/3] qla2xxx: on session delete return nvme cmd

2019-06-21 Thread Himanshu Madhani
From: Quinn Tran - on session delete or chip reset, reject all NVME commands. - on NVME command submission error, free srb resource. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 28 +++- 1 file changed, 19 insertions

[PATCH v3 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-21 Thread Himanshu Madhani
rt_work [qla2xxx] [ 5631.004097] RIP: 0010:[] [] qla_nvme_abort_work+0x22/0x100 [qla2xxx] [ 5631.004109] Call Trace: [ 5631.004115] [] ? pwq_dec_nr_in_flight+0x64/0xb0 [ 5631.004117] [] process_one_work+0x17f/0x440 [ 5631.004120] [] worker_thread+0x126/0x3c0 Signed-off-by: Quinn Tran Signed-off-by: H

[PATCH 01/15] qla2xxx: Fix DMA unmap leak

2019-07-26 Thread Himanshu Madhani
] [28809.523964] One of leaked entries details: [device address=0x0002aefe4000] [size=8208 bytes] [mapped with DMA_BIDIRECTIONAL] [mapped as coherent] Fix this by unmapping DMA memory. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 4 1 file changed

[PATCH 00/15] qla2xxx: Bug fixes for the driver

2019-07-26 Thread Himanshu Madhani
initialization failures qla2xxx: Use common update-firmware-options routine for ISP27xx+ Arun Easi (1): qla2xxx: Fix failed NVME port discovery after a short device port loss Himanshu Madhani (2): qla2xxx: Fix DMA unmap leak qla2xxx: Update driver version to 10.01.00.18-k Quinn Tran (10): qla2xxx

[PATCH 03/15] qla2xxx: Fix abort timeout race condition.

2019-07-26 Thread Himanshu Madhani
From: Quinn Tran If an abort times out, the Abort IOCB completion and Abort timer can race against each other. This patch provides unique error code for timer path to allow proper cleanup Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1

[PATCH 02/15] qla2xxx: Fix different size DMA Alloc/Unmap

2019-07-26 Thread Himanshu Madhani
: Fix inconsistent DMA mem alloc/free") Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index 9f58e591666d..ebf223cfe

[PATCH 09/15] qla2xxx: Retry fabric Scan on IOCB queue full

2019-07-26 Thread Himanshu Madhani
From: Quinn Tran when fabric scan thread encounters IOCB Q Full, schedule a delayed work to retry fabric scan. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff

[PATCH 08/15] qla2xxx: Fix premature timer expiration

2019-07-26 Thread Himanshu Madhani
18 [99652fc03ff0] apic_timer_interrupt at 96575df2 Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_iocb.c | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_

[PATCH 10/15] qla2xxx: Correct error handling during initialization failures

2019-07-26 Thread Himanshu Madhani
initialization. - Release SCSI host reference when memory allocations fail. Signed-off-by: Andrew Vasquez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 4 drivers/scsi/qla2xxx/qla_os.c | 16 ++-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a

[PATCH 11/15] qla2xxx: Fix failed NVME port discovery after a short device port loss

2019-07-26 Thread Himanshu Madhani
1|2 login 1|2 fl 1 qla2xxx [:41:00.0]-28e9:3: qla24xx_handle_relogin_event 1666 21:00:00:24:ff:17:9e:91 post gidpn qla2xxx [:41:00.0]-480e:3: Relogin end. --8<-- Signed-off-by: Arun Easi Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 4 ++-- 1 file changed, 2 inser

[PATCH 07/15] qla2xxx: Fix Relogin to prevent modifying scan_state flag

2019-07-26 Thread Himanshu Madhani
ned-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 25 - drivers/scsi/qla2xxx/qla_os.c | 1 + drivers/scsi/qla2xxx/qla_target.c | 1 - 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/ql

[PATCH 05/15] qla2xxx: Skip FW dump on LOOP initialization error

2019-07-26 Thread Himanshu Madhani
From: Quinn Tran Firmware dump captured during LOOP Init error does not yield any significant information. This patch removes call to trigger firmware dump collection during Loop Initialization. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_isr.c | 1

[PATCH 06/15] qla2xxx: Reject EH_{abort|device_reset|target_request}

2019-07-26 Thread Himanshu Madhani
From: Quinn Tran Reject eh_{abort|device_reset|target_reset}, when rport is being torn down or chip is down. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_os.c

[PATCH 04/15] qla2xxx: Use Correct index for Q-Pair array

2019-07-26 Thread Himanshu Madhani
From: Quinn Tran For target mode, the default number of Q-Pairs allowed to use is 2. If the number of Q-Pair allocated is lower than the default Q-Pairs, then lower value should be the set as default. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx

[PATCH 14/15] qla2xxx: Allow NVME IO to resume with short cable pull

2019-07-26 Thread Himanshu Madhani
allows IO to resume afterward. Signed-off-by: Arun Easi Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index

[PATCH 12/15] qla2xxx: Use common update-firmware-options routine for ISP27xx+

2019-07-26 Thread Himanshu Madhani
From: Andrew Vasquez Leverage the generic routine, qla24xx_update_fw_options(), for the configuration of firmware options for ISP27xx/ISP28xx. Signed-off-by: Andrew Vasquez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 13/15] qla2xxx: Fix hang in fcport delete path

2019-07-26 Thread Himanshu Madhani
a2xxx] #5 [8e2370297e20] process_one_work at b48bcfdf #6 [8e2370297e68] worker_thread at b48bdca6 #7 [8e2370297ec8] kthread at b48c4f81 Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 3 --- 1 file changed, 3 deletions(-) di

[PATCH 15/15] qla2xxx: Update driver version to 10.01.00.18-k

2019-07-26 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index cd6bdf71e533..0833546a1b43 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

Re: [PATCH 00/59] qla2xxx patches for kernel v5.4

2019-08-05 Thread Himanshu Madhani
Hi Bart, > On Aug 1, 2019, at 12:55 PM, Bart Van Assche wrote: > > Hi Martin, > > The patches in this series improve the robustness of the QLogic Fibre Channel > initiator and target drivers. These patches are a result of manual code > inspection, analysis of Coverity reports and stress testi

Re: [PATCH 00/59] qla2xxx patches for kernel v5.4

2019-08-08 Thread Himanshu Madhani
Hi Bart, > On Aug 1, 2019, at 12:55 PM, Bart Van Assche wrote: > > Hi Martin, > > The patches in this series improve the robustness of the QLogic Fibre Channel > initiator and target drivers. These patches are a result of manual code > inspection, analysis of Coverity reports and stress testi

Re: [PATCH v2 00/58] qla2xxx patches for kernel v5.4

2019-08-09 Thread Himanshu Madhani
-- 2.22.0 Thanks for posting v2 of the series. For the series, Tested-by: Himanshu Madhani Reviewed-by: Himanshu Madhani

Re: [PATCH] qla2xxx: Fix gnl.l memory leak on adapter init failure

2019-08-14 Thread Himanshu Madhani
e_host(struct scsi_host_template *sht, "Alloc failed for scan database.\n"); dma_free_coherent(&ha->pdev->dev, vha->gnl.size, vha->gnl.l, vha->gnl.ldma); + vha->gnl.l = NULL; scsi_remove_host(vha->host); return NULL; } -- 1.8.3.1 Looks Good. Acked-by: Himanshu Madhani

Re: [PATCH] scsi: qla2xxx: replace snprintf with strscpy

2019-08-14 Thread Himanshu Madhani
quot;, str); -- 2.11.0 Looks Good. Acked-by: Himanshu Madhani

Re: [PATCH 2/3] scsi: qla2xxx: unset RCE/EFT fields in failure case

2019-08-14 Thread Himanshu Madhani
> > > Fixes: ad0a0b01f088 "scsi: qla2xxx: Fix Firmware dump size for > > Extended > > login and Exchange Offload" > > Fixes: a28d9e4ef997 "scsi: qla2xxx: Add support for multiple fwdump > > templates/segments" >

Re: [PATCH RESEND] qla2xxx: Fix gnl.l memory leak on adapter init failure

2019-08-14 Thread Himanshu Madhani
e_host(struct scsi_host_template *sht, "Alloc failed for scan database.\n"); dma_free_coherent(&ha->pdev->dev, vha->gnl.size, vha->gnl.l, vha->gnl.ldma); + vha->gnl.l = NULL; scsi_remove_host(vha->host); return NULL; } -- 1.8.3.1 Thanks for resend Bill Patch Looks Good. Acked-by: Himanshu Madhani

Re: [PATCH] scsi: qla2xxx: replace snprintf with strscpy

2019-08-14 Thread Himanshu Madhani
On 8/14/19, 10:25 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van Assche" wrote: On 7/24/19 10:46 PM, Wang Xiayang wrote: > As commit a86028f8e3ee ("staging: most: sound: replace snprintf > with strscpy") suggested, using snprintf without a format specifier > is p

Re: [EXT] [PATCH v2 0/2] scsi: qla2xxx: fixes for FW trace/dump buffers

2019-08-14 Thread Himanshu Madhani
series and did not see this issue. Tested-by: Himanshu Madhani Reviewed-by: Himanshu Madhani Thanks, Himanshu

[PATCH 2/6] qla2xxx: Fix flash read for Qlogic ISPs

2019-08-30 Thread Himanshu Madhani
From: Quinn Tran Use adapter specific callback to read flash instead of ISP adapter specific. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 4 ++-- drivers/scsi/qla2xxx/qla_nx.c | 1 + drivers/scsi/qla2xxx/qla_sup.c | 8 3 files

[PATCH 1/6] qla2xxx: Fix message indicating vectors used by driver

2019-08-30 Thread Himanshu Madhani
allocated vectors. This is normal and does not imply failure in driver. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_isr.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index d81b5ecce24b

[PATCH 0/6] qla2xxx: Bug fixes for the driver

2019-08-30 Thread Himanshu Madhani
Hi Martin, This series has few bug fixes for the driver. Please apply this series to 5.4/scsi-queue at your earliest convenience. Thanks, Himanshu Himanshu Madhani (3): qla2xxx: Fix message indicating vectors used by driver qla2xxx: Fix driver reload for ISP82xx qla2xxx: Update driver

[PATCH 6/6] qla2xxx: Update driver version to 10.01.00.19-k

2019-08-30 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 0833546a1b43..a8f2a953ceff 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH 3/6] qla2xxx: Fix driver reload for ISP82xx

2019-08-30 Thread Himanshu Madhani
HINT_MBX_INT_PENDING is not guaranteed to be cleared by firmware. Remove check that prevent driver load with ISP82XX. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 16 ++-- drivers/scsi/qla2xxx/qla_nx.c | 3 ++- 2 files changed, 4

[PATCH 4/6] qla2xxx: Fix stuck login session

2019-08-30 Thread Himanshu Madhani
relogin. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 8161f08f3a4d..2bbadcf60295

[PATCH 5/6] qla2xxx: Fix stale session

2019-08-30 Thread Himanshu Madhani
port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index 03f94eb372b6..dc0e36676313 100644 --- a/drivers/scsi

Re: [EXT] SRR response handling.

2019-09-04 Thread Himanshu Madhani
Adding correct Quinn and removing qlogic.com email ID. It's nice to hear from you Dr Greg __ We will look at the request and get back to you. Thanks, Himanshu On 9/3/19, 3:39 PM, "Dr. G.W. Wettstein" wrote: External Email --

Re: [PATCH 0/4] scsi: qla2xxx: Bug fixes

2019-09-12 Thread Himanshu Madhani
Adding Correct Quinn. Please use "qut...@mavell.com" We'll take a look at the series On 9/12/19, 8:49 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Roman Bolshakov" wrote: On Thu, Sep 12, 2019 at 06:37:22AM +0100, Bart Van Assche wrote: > On 9/12/19 1:39 AM, Roman Bolshakov wrote

[PATCH 00/14] qla2xxx: Bug fixes for the driver.

2019-09-12 Thread Himanshu Madhani
s series. Please hold off on merging that series until review is complete. Thanks, Himanshu Himanshu Madhani (3): qla2xxx: Silence fwdump template message qla2xxx: Improve logging for scan thread qla2xxx: Update driver version to 10.01.00.20-k Michael Hernandez (1): qla2xxx: Dual

[PATCH 03/14] qla2xxx: Fix stale mem access on driver unload

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran On driver unload, 'remove_one' thread was allow to advance, while session cleanup still lag behind. This patch ensure session deletion will finish before remove_one can advance. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xx

[PATCH 02/14] qla2xxx: Fix unbound sleep in fcport delete path.

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran There are instances, though rare, where a LOGO request cannot be sent out and the thread in free session done can wait indefinitely. Fix this by putting an upper bound to sleep. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c

[PATCH 05/14] qla2xxx: Fix N2N link reset

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran Fix stalled link recovery for N2N with FC-NVMe connection Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 3 +- drivers/scsi/qla2xxx/qla_init.c | 107 +--- drivers/scsi/qla2xxx/qla_mbx.c

[PATCH 07/14] qla2xxx: Fix Nport ID display value

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran For N2N, the NPort ID is assigned by driver in the PLOGI ELS. According to FW Spec the byte order for SID is not the same as DID. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_iocb.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH 06/14] qla2xxx: Fix N2N link up fail

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran During link up/bounce, qla driver would do command flush as part of cleanup. In this case, the flush can intefere with FW state. This patch allows FW to be in control of link up. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c

[PATCH 04/14] qla2xxx: Optimize NPIV tear down process

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran In the case of NPIV port is being torn down, this patch will set a flag to indicate VPORT_DELETE. This would prevent relogin to be triggered. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 2 ++ drivers/scsi/qla2xxx

[PATCH 01/14] qla2xxx: Silence fwdump template message

2019-09-12 Thread Himanshu Madhani
Print fwdt template is present or not, only when ql2xextended_error_logging is enabled. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index

[PATCH 13/14] qla2xxx: Improve logging for scan thread

2019-09-12 Thread Himanshu Madhani
move messages to verbose logging for scan thread Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index ad7f02a8f6d7

[PATCH 11/14] qla2xxx: Check for MB timeout while capturing ISP27/28xx FW dump

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran Add mailbox timeout checkout for ISP 27xx/28xx during FW dump procedure. Without the timeout check, hardware lock can be held for long period. This patch would shorten the dump procedure, if a timeout condition is encountered. Signed-off-by: Quinn Tran Signed-off-by: Himanshu

[PATCH 08/14] qla2xxx: Dual FCP-NVMe target port support

2019-09-12 Thread Himanshu Madhani
ff-by: Michael Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 26 ++-- drivers/scsi/qla2xxx/qla_fw.h | 2 ++ drivers/scsi/qla2xxx/qla_gs.c | 42 ++--- drivers/scsi/qla2xxx/qla_init.c

[PATCH 14/14] qla2xxx: Update driver version to 10.01.00.20-k

2019-09-12 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index a8f2a953ceff..225e401b62fa 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH 09/14] qla2xxx: Add error handling for PLOGI ELS passthrough

2019-09-12 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_iocb.c | 95 +++-- 1 file changed, 92 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 5c279449ca1c..840c3bf2a364 100644 --- a/drivers

[PATCH 10/14] qla2xxx: Set remove flag for all VP

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran During driver unload, the remove flag will be set for all scsi_qla_host/NPIV. This allows each NPIV to see the flag instead of reaching for base_vha to search for it. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 30

[PATCH 12/14] qla2xxx: Capture FW dump on MPI heartbeat stop event

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran For MPI heartbeat stop Async Event, this patch would capture MPI FW dump and chip reset. FW will tell which function to capture FW dump for. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 4 +++- drivers/scsi/qla2xxx

Re: [EXT] Re: [PATCH 07/14] qla2xxx: Fix Nport ID display value

2019-09-12 Thread Himanshu Madhani
rnal Email -- On Thu, Sep 12, 2019 at 08:19:42AM -0700, Himanshu Madhani wrote: > From: Quinn Tran > > For N2N, the NPort ID is assigned by driver in the PLOGI ELS. > According to FW Spec the byte order for

[PATCH v2 04/14] qla2xxx: Optimize NPIV tear down process

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran In the case of NPIV port is being torn down, this patch will set a flag to indicate VPORT_DELETE. This would prevent relogin to be triggered. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 2 ++ drivers/scsi/qla2xxx

[PATCH v2 07/14] qla2xxx: Fix Nport ID display value

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran For N2N, the NPort ID is assigned by driver in the PLOGI ELS. According to FW Spec the byte order for SID is not the same as DID. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_iocb.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH v2 03/14] qla2xxx: Fix stale mem access on driver unload

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran On driver unload, 'remove_one' thread was allow to advance, while session cleanup still lag behind. This patch ensure session deletion will finish before remove_one can advance. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xx

[PATCH v2 02/14] qla2xxx: Fix unbound sleep in fcport delete path.

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran There are instances, though rare, where a LOGO request cannot be sent out and the thread in free session done can wait indefinitely. Fix this by putting an upper bound to sleep. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c

[PATCH v2 05/14] qla2xxx: Fix N2N link reset

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran Fix stalled link recovery for N2N with FC-NVMe connection Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 3 +- drivers/scsi/qla2xxx/qla_init.c | 107 +--- drivers/scsi/qla2xxx/qla_mbx.c

[PATCH v2 06/14] qla2xxx: Fix N2N link up fail

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran During link up/bounce, qla driver would do command flush as part of cleanup. In this case, the flush can intefere with FW state. This patch allows FW to be in control of link up. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c

[PATCH v2 00/14] qla2xxx: Bug fixes for the driver

2019-09-12 Thread Himanshu Madhani
s series. Please hold off on merging that series until review is complete. changes from v1 -> v2 o Rebased series on updated 5.4/queue branch Thanks, Himanshu Himanshu Madhani (3): qla2xxx: Silence fwdump template message qla2xxx: Improve logging for scan thread qla2xxx: Update dri

[PATCH v2 01/14] qla2xxx: Silence fwdump template message

2019-09-12 Thread Himanshu Madhani
Print fwdt template is present or not, only when ql2xextended_error_logging is enabled. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index

[PATCH v2 10/14] qla2xxx: Set remove flag for all VP

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran During driver unload, the remove flag will be set for all scsi_qla_host/NPIV. This allows each NPIV to see the flag instead of reaching for base_vha to search for it. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 30

[PATCH v2 09/14] qla2xxx: Add error handling for PLOGI ELS passthrough

2019-09-12 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_iocb.c | 95 +++-- 1 file changed, 92 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 518eb954cf42..eeb526411536 100644 --- a/drivers

[PATCH v2 08/14] qla2xxx: Dual FCP-NVMe target port support

2019-09-12 Thread Himanshu Madhani
ff-by: Michael Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 26 ++-- drivers/scsi/qla2xxx/qla_fw.h | 2 ++ drivers/scsi/qla2xxx/qla_gs.c | 42 ++--- drivers/scsi/qla2xxx/qla_init.c

[PATCH v2 13/14] qla2xxx: Improve logging for scan thread

2019-09-12 Thread Himanshu Madhani
move messages to verbose logging for scan thread Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index 5b5ac09f38db

[PATCH v2 11/14] qla2xxx: Check for MB timeout while capturing ISP27/28xx FW dump

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran Add mailbox timeout checkout for ISP 27xx/28xx during FW dump procedure. Without the timeout check, hardware lock can be held for long period. This patch would shorten the dump procedure, if a timeout condition is encountered. Signed-off-by: Quinn Tran Signed-off-by: Himanshu

[PATCH v2 14/14] qla2xxx: Update driver version to 10.01.00.20-k

2019-09-12 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index a8f2a953ceff..225e401b62fa 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH v2 12/14] qla2xxx: Capture FW dump on MPI heartbeat stop event

2019-09-12 Thread Himanshu Madhani
From: Quinn Tran For MPI heartbeat stop Async Event, this patch would capture MPI FW dump and chip reset. FW will tell which function to capture FW dump for. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 4 +++- drivers/scsi/qla2xxx

Re: [EXT] SRR response handling.

2019-09-16 Thread Himanshu Madhani
Hello Dr Greg, On 9/16/19, 10:36 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Dr. G.W. Wettstein" wrote: On Sep 4, 3:03pm, Himanshu Madhani wrote: } Subject: Re: [EXT] SRR response handling. > Adding correct Quinn and removing qlogic.com email ID.

Re: [EXT] Re: [PATCH 2/6] qla2xxx: Fix flash read for Qlogic ISPs

2019-09-16 Thread Himanshu Madhani
Hi Martin, On 9/13/19, 5:37 PM, "Martin K. Petersen" wrote: External Email -- Hi Martin, > I believe this patch should be tagged with > > Fixes: 5fa8774c7f38 (scsi: qla2xxx: Add 28xx fla

[PATCH] MAINTAINERS: Update qla2xxx driver

2019-10-01 Thread Himanshu Madhani
Update maintainer's entries for qla2xxx driver now that email addresses have been changed to Marvell. Signed-off-by: Himanshu Madhani --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 783569e3c4b4..91f33522393a 100644

[PATCH 1/2] qla2xxx: Initialized mailbox to prevent driver load failure

2019-10-22 Thread Himanshu Madhani
mb[0]=4005 mb[1]=37 mb[2]=20 mb[3]=8 [ 18.819596] cmd=2 Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 1cc6913f76c4

[PATCH 2/2] qla2xxx: Fix partial flash write of MBI

2019-10-22 Thread Himanshu Madhani
mit FLASH region write access from SysFS") Cc: sta...@vger.kernel.org # 5.2 Signed-off-by: Quinn Tran Signed-off-by: Girish Basrur Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xx

[PATCH 0/2] qla2xxx: Fixes for the driver

2019-10-22 Thread Himanshu Madhani
-rc5. Thanks, Himanshu Himanshu Madhani (1): qla2xxx: Initialized mailbox to prevent driver load failure Quinn Tran (1): qla2xxx: Fix partial flash write of MBI drivers/scsi/qla2xxx/qla_attr.c | 7 +++ drivers/scsi/qla2xxx/qla_mbx.c | 3 ++- 2 files changed, 5 insertions(+), 5 deletions

Re: [PATCH][next] scsi: qla2xxx: fix spelling mistake "alredy" -> "already"

2019-04-08 Thread Himanshu Madhani
: command already aborted on sp: %p\n", __func__, sp); return; } -- 2.20.1 Thanks for the patch. Acked-by: Himanshu Madhani

[PATCH v3 01/15] qla2xxx: Allow ABTS, PURX, RIDA on ATIOQ for ISP83XX/27XX

2017-06-02 Thread Himanshu Madhani
SP83XX and ISP27XX. Cc: # 4.11 Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_init.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_in

[PATCH v3 00/15] qla2xxx: Cleanup and minor fixes

2017-06-02 Thread Himanshu Madhani
Hi Martin, This series contains patches that were dropped from 4.12.0-rc3 inclusion, since they can go to 4.13 merge window. Changes from v2 --> v3 o Added Reviewed-by tag from Bart. o Droped couple patches for rework. o Addressed minor comments from Bart where applicable. Changes from v1 -->

[PATCH v3 02/15] qla2xxx: Replace usage of spin_lock with spin_lock_irqsave

2017-06-02 Thread Himanshu Madhani
From: Quinn Tran Convert usage of spin_lock to spin_lock_irqsave because qla2xxx driver can access all the data structures in an interrupt context. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.c | 26

[PATCH v3 08/15] qla2xxx: Fix name server relogin

2017-06-02 Thread Himanshu Madhani
From: Quinn Tran Name server login is normally handle by FW. In some rare case where one of the switches is being updated, name server login could get affected. Trigger relogin to name server when driver detects this condition. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH v3 04/15] qla2xxx: Fix path recovery

2017-06-02 Thread Himanshu Madhani
From: Quinn Tran If the port is moved/changed, current code would trigger a deletion. If the port is already deleted, then do relogin. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_gs.c | 21 - 1 file

[PATCH v3 06/15] qla2xxx: Use flag PFLG_DISCONNECTED.

2017-06-02 Thread Himanshu Madhani
Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_mbx.c | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index eddbc1218a39..4127f35b669c 100644 --- a

[PATCH v3 07/15] qla2xxx: Convert 32-bit LUN usage to 64-bit

2017-06-02 Thread Himanshu Madhani
From: Quinn Tran Acked-by: Nicholas Bellinger Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.c | 32 +++- drivers/scsi/qla2xxx/qla_target.h | 4 ++-- drivers/scsi/qla2xxx/tcm_qla2xxx.c

[PATCH v3 10/15] qla2xxx: Turn on FW option for exchange check

2017-06-02 Thread Himanshu Madhani
From: Quinn Tran Tell FW to track exchange/cmd state to prevent driver from using stale exchange or exchange that is not meant for this command. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 18 ++ drivers/scsi/qla2xxx

[PATCH v3 05/15] tcm_qla2xxx: Do not allow aborted cmd to advance.

2017-06-02 Thread Himanshu Madhani
already started the command free process. Acked-by: Nicholas Bellinger Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Bart Van Assche --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/scsi/qla2xxx

[PATCH v3 13/15] qla2xxx: Accelerate SCSI BUSY status generation in target mode

2017-06-02 Thread Himanshu Madhani
From: Quinn Tran Accelerate generation of SCSI busy to let initiators slow down when target is running low in resources. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 13 +++-- drivers/scsi/qla2xxx/qla_mbx.c | 2 ++ 2 files changed

[PATCH v3 11/15] qla2xxx: Add ql2xiniexchg parameter

2017-06-02 Thread Himanshu Madhani
exchange offload feature will be automatically enabled when the total number of exchanges exceeds 2048 limit. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 6 +- drivers/scsi/qla2xxx/qla_gbl.h| 3 +- drivers/scsi/qla2xxx/qla_init.c | 2

[PATCH v3 03/15] qla2xxx: Retain loop test for fwdump length exceeding buffer length

2017-06-02 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani Reviewed-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_init.c | 8 drivers/scsi/qla2xxx/qla_tmpl.c | 16 +--- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH v3 15/15] qla2xxx: Remove extra register read

2017-06-02 Thread Himanshu Madhani
From: Quinn Tran Remove extra register read in each interrupt processing to improve performance. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_iocb.c | 4 +++- drivers/scsi/qla2xxx/qla_target.c | 11 ++- 2 files changed, 5 insertions(+), 10

[PATCH v3 14/15] qla2xxx: Remove unused irq_cmd_count field.

2017-06-02 Thread Himanshu Madhani
not needed. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 9 + drivers/scsi/qla2xxx/qla_target.h | 1 - 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c

<    3   4   5   6   7   8   9   10   11   12   >