[PATCH 5/11] lpfc 8.3.37: Fixed no-context ABTS failed with BA_RJT

Fixed no-context ABTS received on unsolicited receive queue failed with BA_RJT Signed-off-by: James Smart --- lpfc.h |8 +-- lpfc_bsg.c | 51 ++-- lpfc_crtn.h |4 - lpfc_ct.c | 37 -- lpfc_sli.c | 151

[PATCH 6/11] lpfc 8.3.37: Fix potential memory corruption bug

Fix potential memory corruption bug Signed-off-by: James Smart --- lpfc_sli.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c 2013-01-02 13:13:05.944087718 -0500 +++ b

[PATCH 7/11] lpfc 8.3.37: Fixed stale ndlp state when the node is marked for deferred removal.

Fixed processing stale ndlp state when the node is marked for deferred removal. Signed-off-by: James Smart --- lpfc_nportdisc.c | 10 ++ 1 file changed, 10 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c --- a/drivers/scsi/lpfc

[PATCH 8/11] lpfc 8.3.37: Provide support for FCoE protocol dual-chute (ULP) operation

Provide support for FCoE protocol dual-chute (ULP) operation Signed-off-by: James Smart --- lpfc.h |9 ++ lpfc_hw4.h | 176 ++-- lpfc_init.c | 72 +- lpfc_sli.c | 188

[PATCH 9/11] lpfc 8.3.37: Fixed crash due to SLI Port invalid resource count

Fixed system crash due to SLI Port provisioning of invalid resource count Signed-off-by: James Smart --- lpfc_sli.c | 28 1 file changed, 28 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc

[PATCH 10/11] lpfc 8.3.37: Fixed infinite loop in lpfc_sli4_fcf_rr_next_index_get.

Fixed infinite loop in lpfc_sli4_fcf_rr_next_index_get. Signed-off-by: James Smart --- lpfc_sli.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c 2013-01-02

[PATCH 11/11] lpfc 8.3.37: Update lpfc version for 8.3.37 driver release

Update lpfc version for 8.3.37 driver release Signed-off-by: James Smart --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h --- a/drivers/scsi/lpfc/lpfc_version.h 2012-12-12 13:32

Re: [PATCH 47/62] scsi/lpfc: convert to idr_alloc()

Acked-by: James Smart -- james s On 2/2/2013 8:20 PM, Tejun Heo wrote: Convert to the much saner new idr interface. Only compile tested. Signed-off-by: Tejun Heo Cc: James Smart Cc: linux-scsi@vger.kernel.org --- This patch depends on an earlier idr changes and I think it would be best

Re: [PATCH 63/77] scsi/lpfc: convert to idr_alloc()

Acked-by: James Smart -- james s On 2/6/2013 2:40 PM, Tejun Heo wrote: Convert to the much saner new idr interface. Only compile tested. Signed-off-by: Tejun Heo Cc: James Smart Cc: linux-scsi@vger.kernel.org --- drivers/scsi/lpfc/lpfc_init.c | 12 1 file changed, 4

Re: [SCSI] lpfc 8.3.37: Provide support for FCoE protocol dual-chute (ULP) operation

Dan, Thanks for pointing this out. I'm addressing it as the first patch in 8.3.38, which I'll be pushing shortly. -- james s On 2/5/2013 4:04 AM, Dan Carpenter wrote: Hello James Smart, The patch 962bc51b04b2: "[SCSI] lpfc 8.3.37: Provide support for FCoE protocol

Re: [PATCH] scsi: fix lpfc build when wmb() is defined as mb()

Acked-By: James Smart Thanks -- james s On 2/22/2013 1:23 PM, Randy Dunlap wrote: From: Randy Dunlap On architectures where wmb() is defined as mb(), a build error happens since there is also a variable named 'mb' in lpfc_sli.c's lpfc_sli_issue_mbox_s3() function. Rena

[PATCH 0/11] lpfc 8.3.38: Update lpfc to revision 8.3.38

l mis-interpretation of READ_TOPOLOGY reserved fields - Update lpfc version for 8.3.38 driver release The patches were cut against scsi.git, branch "misc". -- james s Signed-off-by: James Smart -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the bo

[PATCH 1/11] lpfc 8.3.38: Fixed NMI watch dog panic's when resetting the hba.

Fixed NMI watch dog panic's when resetting the hba. Signed-off-by: James Smart --- lpfc_attr.c |2 - lpfc_bsg.c |2 - lpfc_els.c |6 +-- lpfc_hbadisc.c |5 +- lpfc_init.c |1 lpfc_nportdisc.c |1 lpfc_scsi.c |4 +- lpfc_

[PATCH 2/11] lpfc 8.3.38: Fixed degraded performance after cable pulls

Fixed degraded performance after cable pulls The service parameters for the VPI/RPIs were incorrect, resulting in lower utilization Signed-off-by: James Smart --- lpfc_crtn.h|1 + lpfc_els.c | 15 +++ lpfc_hbadisc.c |5 + lpfc_hw4.h |3

[PATCH 3/11] lpfc 8.3.38: Fixed bsg timeout handling issues that would result in crashes

Fixed bsg timeout handling issues that would result in crashes Signed-off-by: James Smart --- lpfc_bsg.c | 1107 + 1 file changed, 602 insertions(+), 505 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc

[PATCH 5/11] lpfc 8.3.38: Fixed async FCF modified event to in-use FCF failure to trigger recovery

Fixed async FCF modified event to in-use FCF failure to trigger recovery Signed-off-by: James Smart --- lpfc_init.c | 97 ++-- 1 file changed, 62 insertions(+), 35 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers

[PATCH 4/11] lpfc 8.3.38: Fixed deadlock condition in FCF round robin handling

Fixed deadlock condition in FCF round robin handling Signed-off-by: James Smart --- lpfc_hbadisc.c |2 ++ lpfc_sli.c |9 - 2 files changed, 10 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c --- a/drivers

[PATCH 6/11] lpfc 8.3.38: Fixed OXID reuse issue.

Fixed OXID reuse issue. Signed-off-by: James Smart --- lpfc_attr.c |8 +++- lpfc_sli.c |6 -- 2 files changed, 11 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 2013-02-27 08

[PATCH 7/11] lpfc 8.3.38: Fixed PT2PT bring up problem for FC SLI4.

Fixed PT2PT bring up problem for FC SLI4. Signed-off-by: James Smart --- lpfc_hbadisc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c --- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2013-02-27 08

[PATCH 8/11] lpfc 8.3.38: Fixed circular locking dependency and inconsistent lock state issues

Fixed circular locking dependency and inconsistent lock state issues Signed-off-by: James Smart --- lpfc_hbadisc.c | 18 ++ lpfc_init.c|8 lpfc_scsi.c|4 ++-- lpfc_sli.c |8 4 files changed, 20 insertions(+), 18 deletions(-) diff

[PATCH 9/11] lpfc 8.3.38: Fix default value for lpfc_enable_rrq.

Fix default value for lpfc_enable_rrq. Signed-off-by: James Smart --- lpfc_attr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 2013-02-27 08:17:26.095047546 -0500

[PATCH 10/11] lpfc 8.3.38: Fixed potential mis-interpretation of READ_TOPOLOGY reserved fields

Fixed potential mis-interpretation of READ_TOPOLOGY reserved fields Signed-off-by: James Smart --- lpfc_hbadisc.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c --- a

[PATCH 11/11] lpfc 8.3.38: Update lpfc version for 8.3.38 driver release

Update lpfc version for 8.3.38 driver release Signed-off-by: James Smart --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h --- a/drivers/scsi/lpfc/lpfc_version.h 2013-02-22 14:06

Re: [PATCH v1] lpfc 8.3.37: Remove redundant NULL check before kfree

Syam, Thank you for the patch - it is valid. However, I prefer not to merge this. I would rather force the coder to think about the pointer value explicitly rather than depending on the convenience/one line optimization. We've had errors in the past covered up by this gracious behavior. Ad

Re: [PATCH v1] lpfc 8.3.37: Remove redundant NULL check before kfree

-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of James Smart Sent: Wednesday, 06 March, 2013 3:10 PM To: syamsidha...@gmail.com Cc: linux-scsi@vger.kernel.org; jbottom...@parallels.com; Syam Sidhardhan; Smart, James Sub

Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

On 3/11/2013 1:05 PM, Hannes Reinecke wrote: On 03/07/2013 09:35 PM, Jeremy Linton wrote: On 3/7/2013 2:20 PM, Mike Christie wrote: On 03/07/2013 02:13 PM, Jeremy Linton wrote: For lpfc, you never get to the code. Or rather when I was testing it, I couldn't find any way to propagate an e

Re: [PATCH -next] [SCSI] lpfc 8.3.36: fix potential NULL pointer dereference in lpfc_sli4_rq_put()

James, Can you please merge this fix into scsi git for merging into 3.9 ? -- james s On 12/6/2012 10:46 AM, James Smart wrote: Acked-By: James Smart Thanks -- james s On 12/2/2012 8:33 AM, Wei Yongjun wrote: From: Wei Yongjun The dereference to 'put_index' should be moved

error handler scheduling

In looking through the error handler, if a command times out and is added to the eh_cmd_q for the shost, the error handler is only awakened once shost->host_busy (total number of i/os posted to the shost) is equal to shost->host_failed (number of i/o that have been failed and put on the eh_cmd_

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

Hannes, I'm finally going through this thread. I'm a bit uncomfortable about making the rport state writeable. The rport state is tightly tied to the driver's discovery engine, and I'm concerned about some of the callbacks firing, such as the rport_delete(), and the driver taking an action

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

On 3/18/2013 3:09 AM, Hannes Reinecke wrote: On 03/15/2013 08:13 PM, Bart Van Assche wrote: On 03/15/13 19:51, Mike Christie wrote: On 03/15/2013 08:41 AM, Bart Van Assche wrote: How about using the value of scsi_cmnd.jiffies_at_alloc to finish only those SCSI commands in the host reset handl

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

s On 4/4/2013 2:26 AM, Hannes Reinecke wrote: On 04/01/2013 11:06 PM, James Smart wrote: I think lpfc survives your rport state change as : part of the lld behavior on the callback, to clean up reference counts, is to abort all i/o that is outstanding to the rport. So the ref checking not only pro

Re: [PATCH 0/4] scsi: 64-bit LUN support

On 4/4/2013 6:17 AM, Hannes Reinecke wrote: On 03/31/2013 07:44 PM, Tomas Henzl wrote: What we can do is to decode the LUN and compare it to max_lun provided by the driver, I think that sg_luns is able to do that, so what is needed is just to follow the SAM. I have seen reports of problem on

[PATCH 0/22] lpfc 8.3.39: Update lpfc to revision 8.3.39

zero - Reduced tmo value set to FLOGI WQE for quick recovery from FLOGI sequence timeout - Fixed driver handling of CLEAR_LA with NPIV enabled causing SID=0 frames out - Update lpfc version for 8.3.39 driver release The patches were cut against scsi.git, branch "misc". -- james s Signe

[PATCH 1/22] lpfc 8.3.39: Fixed VPI allocation issues after firmware dump is performed

Fixed VPI allocation issues after firmware dump is performed Signed-off-by: James Smart --- lpfc_hbadisc.c | 14 +- lpfc_init.c| 12 +++- lpfc_sli.c |2 ++ lpfc_vport.c | 25 - lpfc_vport.h |1 + 5 files changed, 51

[PATCH 2/22] lpfc 8.3.39: Fixed BlockGuard error reporting

Fixed BlockGuard error reporting Signed-off-by: James Smart --- lpfc_logmsg.h |1 lpfc_scsi.c | 279 -- 2 files changed, 255 insertions(+), 25 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_logmsg.h b/drivers/scsi/lpfc

[PATCH 3/22] lpfc 8.3.39: Remove driver dependency on HZ

Remove driver dependency on HZ Signed-off-by: James Smart --- lpfc.h |6 -- lpfc_bsg.c |6 -- lpfc_ct.c|3 ++- lpfc_els.c | 10 ++ lpfc_hbadisc.c |5 +++-- lpfc_init.c | 45

[PATCH 4/22] lpfc 8.3.39: Fixed pt2pt and loop discovery problems on topology changes.

Fixed pt2pt and loop discovery problems on topology changes. Signed-off-by: James Smart --- lpfc.h |1 lpfc_attr.c |2 + lpfc_els.c | 93 +++ lpfc_hbadisc.c | 55

[PATCH 5/22] lpfc 8.3.39: Fix driver issues with large lpfc_sg_seg_cnt values

Fix driver issues with large lpfc_sg_seg_cnt values Signed-off-by: James Smart --- lpfc.h |3 +++ lpfc_init.c | 31 +-- 2 files changed, 16 insertions(+), 18 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h --- a/drivers

[PATCH 6/22] lpfc 8.3.39: Fix driver issues with large s/g lists for BlockGuard

Fix driver issues with large s/g lists for BlockGuard Signed-off-by: James Smart --- lpfc.h |7 + lpfc_attr.c | 15 ++- lpfc_init.c | 132 -- lpfc_mem.c | 14 ++- lpfc_scsi.c | 229

[PATCH 7/22] lpfc 8.3.39: Doorbell formation information logged in dual-chute mode WQ and RQ setup

Doorbell formation information logged in dual-chute mode WQ and RQ setup Signed-off-by: James Smart --- lpfc_sli.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c

[PATCH 8/22] lpfc 8.3.39: Fix driver issues with SCSI Host reset

Fix driver issues with SCSI Host reset Signed-off-by: James Smart --- lpfc_attr.c |7 ++- lpfc_hw4.h |2 +- lpfc_init.c |7 ++- 3 files changed, 13 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers

[PATCH 9/22] lpfc 8.3.39: Fix lpfc_fcp_look_ahead module parameter

Fix lpfc_fcp_look_ahead module parameter Signed-off-by: James Smart --- lpfc_attr.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 2013-04-15 18:26

[PATCH 10/22] lpfc 8.3.39: Fixed crash when processing bsg's sg list with high memory pages

Fixed crash when processing bsg's sg list with high memory pages Signed-off-by: James Smart --- lpfc_bsg.c | 33 +++-- lpfc_sli.c |3 +-- 2 files changed, 24 insertions(+), 12 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi

[PATCH 11/22] lpfc 8.3.39: Reduced spinlock contention on SCSI buffer list

Reduced spinlock contention on SCSI buffer list Signed-off-by: James Smart --- lpfc.h |6 ++- lpfc_init.c | 54 -- lpfc_scsi.c | 93 ++-- 3 files changed, 102 insertions(+), 51 deletions

[PATCH 12/22] lpfc 8.3.39: Fixed BlockGuard to take advantage of rdprotect/wrprotect info when available

Fixed BlockGuard to take advantage of rdprotect/wrprotect info when available Signed-off-by: James Smart --- lpfc_hw.h |1 lpfc_scsi.c | 181 ++-- 2 files changed, 116 insertions(+), 66 deletions(-) diff -upNr a/drivers/scsi

[PATCH 13/22] lpfc 8.3.39: Fixed deadlock between hbalock and nlp_lock use

Fixed deadlock between hbalock and nlp_lock use. Signed-off-by: James Smart --- lpfc_hbadisc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c --- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2013-04-15 18

[PATCH 14/22] lpfc 8.3.39: Fixed bad book keeping in posting els sgls to port

Fixed bad book keeping in posting els sgls to port Signed-off-by: James Smart --- lpfc_sli.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c 2013-04-15 18

[PATCH 15/22] lpfc 8.3.39: Fixed not returning FAILED status when SCSI invoking host reset handler failed

Fixed not returning FAILED status when SCSI invoking host reset handler failed Signed-off-by: James Smart --- lpfc_crtn.h |1 + lpfc_init.c |2 +- lpfc_scsi.c | 14 +++--- 3 files changed, 13 insertions(+), 4 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_crtn.h b

[PATCH 16/22] lpfc 8.3.39: Fixed system panic during EEH recovery due to midlayer acting on outstanding I/O

Fixed system panic during EEH recovery due to midlayer acting on outstanding I/O Signed-off-by: James Smart --- lpfc_init.c | 12 ++-- lpfc_sli.c |4 2 files changed, 10 insertions(+), 6 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc

[PATCH 17/22] lpfc 8.3.39: Fixed iocb flags not being reset for scsi commands

Fixed iocb flags not being reset for scsi commands. Signed-off-by: James Smart --- lpfc_scsi.c |2 ++ 1 file changed, 2 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c --- a/drivers/scsi/lpfc/lpfc_scsi.c 2013-04-15 18:26:46.934041346 -0400

[PATCH 18/22] lpfc 8.3.39: Fixed driver vector mapping to CPU affinity

Fixed driver vector mapping to CPU affinity Signed-off-by: James Smart --- lpfc.h |1 lpfc_attr.c | 137 + lpfc_hw4.h |5 lpfc_init.c | 322 ++-- lpfc_sli.c | 22 ++-- lpfc_sli4.h | 16

[PATCH 19/22] lpfc 8.3.39: Add log message when completes with clean address bit set to zero

Add log message when completes with clean address bit set to zero Signed-off-by: James Smart --- lpfc_els.c |3 +++ 1 file changed, 3 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c --- a/drivers/scsi/lpfc/lpfc_els.c 2013-04-15 18:26

[PATCH 20/22] lpfc 8.3.39: Reduced tmo value set to FLOGI WQE for quick recovery from FLOGI sequence timeout

Reduced tmo value set to FLOGI WQE for quick recovery from FLOGI sequence timeout Signed-off-by: James Smart --- lpfc_els.c |9 ++--- lpfc_hbadisc.c |7 +-- lpfc_sli.c | 11 ++- 3 files changed, 17 insertions(+), 10 deletions(-) diff -upNr a/drivers/scsi

[PATCH 21/22] lpfc 8.3.39: Fixed driver handling of CLEAR_LA with NPIV enabled causing SID=0 frames out

Fixed driver handling of CLEAR_LA with NPIV enabled causing SID=0 frames out Signed-off-by: James Smart --- lpfc_hbadisc.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c --- a/drivers/scsi

[PATCH 22/22] lpfc 8.3.39: Update lpfc version for 8.3.39 driver release

Update lpfc version for 8.3.39 driver release Signed-off-by: James Smart --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h --- a/drivers/scsi/lpfc/lpfc_version.h 2013-04-10 16:46

[PATCH 12/17] lpfc: Fix mbox reuse in PLOGI completion

Fix mbox reuse in PLOGI completion. Moved allocations so that buffer properly init'd. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nportdisc.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/dr

[PATCH 14/17] lpfc: Add logging for misconfigured optics.

Add logging for misconfigured optics acqe reported by fw. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hw4.h | 51 drivers/scsi/lpfc/lpfc_init.c | 67 ++- drivers/scsi/lpfc/lpfc_sli4

[PATCH 02/17] lpfc: Fix the FLOGI discovery logic to comply with T11 standards

y are reset on link bounce. Required reworking the call sequence in the discovery threads. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_crtn.h | 1 + drivers/scsi/lpfc/lpfc_els.c | 342 + drivers/scsi

[PATCH 04/17] lpfc: Fix RegLogin failed error seen on Lancer FC during port bounce

Fix RegLogin failed error seen on Lancer FC during port bounce Fix the statemachine and ref counting. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 14 +- drivers/scsi/lpfc/lpfc_hbadisc.c | 8 drivers/scsi/lpfc

[PATCH 07/17] lpfc: Modularize and cleanup FDMI code in driver

Modularize, cleanup, add comments - for FDMI code in driver Note: I don't like the comments with leading # - but as we have a lot if present, I'm deferring to handle it in one big fix later. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h

[PATCH 17/17] lpfc: Update version to 11.0.0.10 for upstream patch set

Update version to 11.0.0.10 for upstream patch set Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index ea53aa6

[PATCH 03/17] lpfc: Added throttle logging support.

Implemented a throttle on error logging. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 5 +++ drivers/scsi/lpfc/lpfc_attr.c| 18 +++ drivers/scsi/lpfc/lpfc_crtn.h| 1 + drivers/scsi/lpfc/lpfc_disc.h| 11 +++ drivers

[PATCH 13/17] lpfc: Fix external loopback failure.

Fix external loopback failure. Rx sequence reassembly was incorrect. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc

[PATCH 11/17] lpfc: Use new FDMI speed definitions for 10G, 25G and 40G FCoE.

Use new FDMI speed definitions for 10G, 25G and 40G FCoE. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c| 2 +- drivers/scsi/lpfc/lpfc_ct.c | 146 ++- drivers/scsi/lpfc/lpfc_els.c | 3 + drivers

[PATCH 09/17] lpfc: Fix RDP ACC being too long.

Fix RDP ACC being too long. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index f7a2967..817cdfc 100644 --- a/drivers/scsi/lpfc

[PATCH 15/17] lpfc: Delete unnecessary checks before the function call "mempool_destroy"

From: Markus Elfring The mempool_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: James Smart --- drivers

[PATCH 08/17] lpfc: Fix RDP Speed reporting.

Fix RDP Speed reporting. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 3394648..f7a2967 100644

[PATCH 00/17] lpfc: Update to revision 11.0.0.10

This patch set updates the lpfc driver to revision 11.0.0.10 The patches were cut against scsi-misc James Smart (17): Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get. Fix the FLOGI discovery logic to comply with T11 standards Added throttle logging support. Fix RegLogin failed

[PATCH 06/17] lpfc: Fix crash in fcp command completion path.

Fix crash in fcp command completion path. Missed null check. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index

[PATCH 01/17] lpfc: Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get.

Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index

[PATCH 10/17] lpfc: Make write check error processing more resilient

Make write check error processing more resilient. Checks to catch writes that fw reports weren't fully complete yet SCSI status indicated fine needed correction. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 27 +-- 1

[PATCH 05/17] lpfc: Fix driver crash when module parameter lpfc_fcp_io_channel set to 16

Fix driver crash when module parameter lpfc_fcp_io_channel set to 16 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc

[PATCH 16/17] lpfc: Use kzalloc instead of kmalloc

From: Punit Vara This patch is to the lpfc_els.c which resolves following warning reported by coccicheck: WARNING: kzalloc should be used for rdp_context, instead of kmalloc/memset Signed-off-by: Punit Vara Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 3 +-- 1 file

Re: [PATCH] SCSI-lpfc: Delete unnecessary checks before the function call "mempool_destroy"

fyi - this patch was just pushed in our 11.0.0.10 patch set - patch 15/17 -- james s On 11/17/2015 12:44 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Tue, 17 Nov 2015 09:34:27 +0100 The mempool_destroy() function tests whether its argument is NULL and then returns immediately. Thu

Re: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc

fyi - this patch was just pushed in our 11.0.0.10 patch set - patch 16/17 Note: Patch 16 contains the exact same patch submitted by Punit Vara. I posted Punit's change only as it arrived earlier. -- james s On 11/18/2015 11:34 PM, Saurabh Sengar wrote: replacing kmalloc and memset by a sin

Re: [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc

fyi - this patch was just pushed in our 11.0.0.10 patch set - patch 16/17 -- james s On 10/24/2015 8:25 PM, Matthew R. Ochs wrote: On Oct 24, 2015, at 2:06 AM, Punit Vara wrote: This patch is to the lpfc_els.c which resolves following warning reported by coccicheck: WARNING: kzalloc should

Re: [RFC PATCH] lpfc: Add lockdep assertions

Johannes, Thank you for the time and effort on the patch. At this time, as it doesn't functionally change anything, I did not include the patch. I will consider it if we see additional issues it can help resolve. -- james s On 11/20/2015 4:37 AM, Johannes Thumshirn wrote: Several functions

Re: [PATCH 08/17] lpfc: Fix RDP Speed reporting.

See patch 11/17 for the 32G additions -- james s On 12/17/2015 12:25 AM, Hannes Reinecke wrote: What happened to 32G? Has development ceased on that? Cheers, Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 14/17] lpfc: Add logging for misconfigured optics.

On 12/17/2015 12:38 AM, Hannes Reinecke wrote: On 12/17/2015 12:12 AM, James Smart wrote: Why isn't this special cased anymore? Is it now supported by all HBAs? Yes - if and when/where an async event is generated by the adapter is in the fw. The special casing wasn't needed in

Re: [PATCH 03/17] lpfc: Added throttle logging support.

e at the kernel level. -- james s On 12/17/2015 12:14 AM, Hannes Reinecke wrote: On 12/17/2015 12:11 AM, James Smart wrote: Implemented a throttle on error logging. Weee ... that stuff doesn't really belong into the driver. _If_ that really is an issue it should be moved into a gener

Re: [PATCH 11/17] lpfc: Use new FDMI speed definitions for 10G, 25G and 40G FCoE.

On 12/17/2015 12:32 AM, Hannes Reinecke wrote: Ah. So here is the missing 32G speed. Should be moved into the 'Fix RDP Speed reporting' patch, no? which of these 2 patches is not that meaningful. -- james -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

[PATCH 14/14] lpfc: Update version to 11.0.0.0 for upstream patch set

Update version to 11.0.0.0 for upstream patch set Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 6258d3d

[PATCH 13/14] lpfc: Fix default RA_TOV and ED_TOV in the FC/FCoE driver for all topologies

Fix default RA_TOV and ED_TOV in the FC/FCoE driver for all topologies Initial link up defaults were not properly being tracked relative to initial FLOGI or pt2pt PLOGI. Add code to initialize them. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c

[PATCH 08/14] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

hys as function arguments. This is the use after free. Following the use after free mp gets kfree()d again which is a double free. Signed-off-by: Johannes Thumshirn Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_mbox.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff -

[PATCH 04/14] lpfc: Destroy lpfc_hba_index IDR on module exit

y(&idr); } Signed-off-by: Johannes Thumshirn Signed-off-by: James Smart Reviewed-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 81bfb2d..eaf121a 100644 --- a/dri

[PATCH 09/14] fix: lpfc_send_rscn_event sends bigger buffer size

From: Ales Novak lpfc_send_rscn_event() allocates data for sizeof(struct lpfc_rscn_event_header) + payload_len, but claims that the data has size of sizeof(struct lpfc_els_event_header) + payload_len. That leads to buffer overruns. Signed-off-by: Ales Novak Signed-off-by: James Smart

[PATCH 12/14] lpfc: The linux driver does not reinitiate discovery after a failed FLOGI

The linux driver does not reinitiate discovery after a failed FLOGI Forgot to clear FCF Discovery in-progress flag upon FLOGI failures. Thus we didn't restart FLOGI. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 9 +++-- 1 file chang

[PATCH 06/14] lpfc:Make the function lpfc_sli4_mbox_completions_pending static in order to comply with function prototype

From: Nicholas Krause This makes the function lpfc_sli4_mbox_completion's definition static now in order to comply with its prototype being also declared as static too. Signed-off-by: Nicholas Krause Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 2 +- 1 file chang

Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

On 8/18/2015 6:27 PM, Sebastian Herbszt wrote: Johannes Thumshirn wrote: Sebastian Herbszt writes: Johannes Thumshirn wrote: If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution continues normally and mp gets kfree()d. If the subsequent call to lpfc_sli_issue_mbox()

Re: [PATCH] lpfc: fix memory leak and NULL dereference

Looks Good - Thank you Sudip. Reviewed-by: James Smart -- james s On 9/23/2015 6:32 AM, Sudip Mukherjee wrote: kmalloc() can return NULL and without checking we were dereferencing it. Moreover if kmalloc succeeds but the function fails in other parts then we were returning the error code

Re: [PATCH] Fix up tag usage in lpfc

Yep, this was an oversight... In looking through it though, there are some additional things that should be checked. We're about to post our next set of patches, so I'll include this fix with them. thanks. -- james s Hannes Reinecke wrote: Hi James, appearently the lpfc driver is sligtly conf

Re: [2.6 patch] scsi/lpfc/lpfc_debugfs.c: fix typo

ACK -- james s Adrian Bunk wrote: This patch fixes a typo introduced by commit bbfbbbc1182f8b44c8cc4c99f4a3f3a512149022. It wasn't a compile error since CONFIG_LPFC_DEBUG_FS is not (yet?) available as an option. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 74e14a2a4ed066aa8fedd557a67

[PATCH 0/9] lpfc 8.2.3 : lpfc 8.2.3 patches

This set of patches updates the lpfc driver to revision 8.2.3. All are bug fixes targeted for 2.6.25 - Added support for ASICs that report temperature. - NPIV bug fixes: - Remove flawed MBX_STOP_IOCB logic - Miscellaneous Small Fixes - part 1 - FC Discovery Fixes: - Miscellaneous Small Fixes - pa

[PATCH 1/9] lpfc 8.2.3 : Added support for ASICs that report temperature

Added support for ASICs that report temperature. Temperature notices are reported as events and logged. Temperature can be read via sysfs. Signed-off-by: James Smart <[EMAIL PROTECTED]> diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scs

[PATCH 2/9] lpfc 8.2.3 : NPIV bug fixes

NPIV bug fixes: - Remove vport params on physical hba when npiv is disabled - Implement new DA_ID CT command to remove vport information from the switch after delete. Some switches didn't clean this up unless the physical link dropped. Signed-off-by: James Smart <[EMAIL PROTECTED]

[PATCH 3/9] lpfc 8.2.3 : Remove flawed MBX_STOP_IOCB logic

Remove flawed MBX_STOP_IOCB logic Signed-off-by: James Smart <[EMAIL PROTECTED]> diff -upNr a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c --- a/drivers/scsi/lpfc/lpfc_els.c 2007-08-18 10:49:08.0 -0400 +++ b/drivers/scsi/lpfc/lpfc_els.c 2007-10-27

[PATCH 4/9] lpfc 8.2.3 : Miscellaneous Small Fixes - part 1

s during vport_create - Fix too many retries in FC-AL mode - Pull lpfc_port_link_failure out of lpfc_linkdown_port Signed-off-by: James Smart <[EMAIL PROTECTED]> diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 2007-10-27 10:3

[PATCH 5/9] lpfc 8.2.3 : FC Discovery Fixes

PLOGI receptions Signed-off-by: James Smart <[EMAIL PROTECTED]> diff -upNr a/drivers/scsi/lpfc/lpfc_crtn.h b/drivers/scsi/lpfc/lpfc_crtn.h --- a/drivers/scsi/lpfc/lpfc_crtn.h 2007-10-27 10:45:06.0 -0400 +++ b/drivers/scsi/lpfc/lpfc_crtn.h 2007-10-27 13:07:36.0 -0400 @@

[PATCH 6/9] lpfc 8.2.3 : Miscellaneous Small Fixes - part 2

- Defer ndlp cleanup to dev-loss timeout handler - Added support for WRITE_VPARMS mailbox command by applications Signed-off-by: James Smart <[EMAIL PROTECTED]> diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 2007-10-27

[PATCH 7/9] lpfc 8.2.3 : Internal loopback fixes

Internal loopback fixes: - Use HBQs rather than Q_RING_BUFF - Correct HBQs continuation entries - Update CT handler to SLI3 iocbs Signed-off-by: James Smart <[EMAIL PROTECTED]> diff -upNr a/drivers/scsi/lpfc/lpfc_crtn.h b/drivers/scsi/lpfc/lpfc_crtn.h --- a/drivers/scsi/lpfc/lpfc_

<    1   2   3   4   5   6   7   8   9   10   >