Re: lpfc: Unknown ELS command x18 received from NPORT xfffc2b

This would silence it. However, I'm about to push a new patch set which adds full RDP support. -- james s On 4/14/2015 7:07 PM, Sebastian Herbszt wrote: We recently started to get [8043768.238110] lpfc :10:00.1: 1:(0):0115 Unknown ELS command x18 received from NPORT xfffc2b

[PATCH 09/21] lpfc: Parse the new 20G, 25G and 40G link speeds in the lpfc driver

Parse the new 20G, 25G and 40G link speeds in the lpfc driver This patch is dependent upon the following patch to the FC transport which adds the 25G speed: http://www.spinics.net/lists/linux-scsi/msg83840.html Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart

[PATCH 08/21] lpfc: Add support for reporting option_rom_version on newer adapters

Add support for reporting option_rom_version on newer adapters Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_attr.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc

[PATCH 13/21] lpfc: Initiator sends wrong BBCredit value for either FLOGI or FLOGI_ACC

Initiator sends wrong BBCredit value for either FLOGI or FLOGI_ACC Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_els.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers

[PATCH 14/21] lpfc: Fix premature release of rpi bit in bitmask

adapters have a different access pattern that requires us to wait for a later mailbox completion. This changes the put call location on the newer sli4 adapters. Symptoms of the error are 0110 ELS and the 0372 iotag errors. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart

[PATCH 15/21] lpfc: Implement support for wire-only DIF devices

enablement, and if set, turns on write-only DIF. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc.h | 41 drivers/scsi/lpfc/lpfc_attr.c| 65 ++- drivers/scsi/lpfc/lpfc_crtn.h| 3 +- drivers/scsi

[PATCH 16/21] lpfc: Fix internal loopback failure.

Fix internal loopback failure. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_els.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc

[PATCH 17/21] lpfc: Fix OS crash when running loopback test in applications

Fix OS crash when running loopback test in applications Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_bsg.c | 1 + drivers/scsi/lpfc/lpfc_sli.c | 12 drivers/scsi/lpfc/lpfc_sli.h | 1 + 3 files

[PATCH 21/21] lpfc: Update version to 10.5.0.0 for upstream patch set

Update version to 10.5.0.0 for upstream patch set Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b

[PATCH 19/21] lpfc: Fix for lun discovery issue with saturn adapter.

Fix for lun discovery issue with saturn adapter. FCP_CMD payload was not always properly initialized on SLI-3 devices. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_scsi.c | 41

[PATCH 20/21] lpfc: Update copyright to 2015

Update copyright to 2015 Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc.h | 2 +- drivers/scsi/lpfc/lpfc_attr.c | 2 +- drivers/scsi/lpfc/lpfc_bsg.c | 2 +- drivers/scsi/lpfc/lpfc_bsg.h

[PATCH 12/21] lpfc: Fix null ndlp dereference in target_reset_handler

Fix null ndlp dereference in target_reset_handler Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_scsi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b

[PATCH 10/21] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command

Fix provide host name and OS name in RSNN-NN FC-GS command Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_ct.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/scsi

[PATCH 07/21] lpfc: Fix setting of EQ (interrupt) delay Multiplier

Fix setting of EQ (interrupt) delay Multiplier Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_init.c | 8 drivers/scsi/lpfc/lpfc_sli.c | 9 +++-- drivers/scsi/lpfc/lpfc_sli4.h | 2 +- 3 files changed

[PATCH 11/21] lpfc: Fix FDMI Fabric support in driver for Brocade

Fix FDMI Fabric support in driver for Brocade Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc.h | 3 + drivers/scsi/lpfc/lpfc_attr.c| 16 +- drivers/scsi/lpfc/lpfc_ct.c | 715

[PATCH 02/21] lpfc: Add Lancer Temperature Event support to the lpfc driver

Add Lancer Temperature Event support to the lpfc driver This will detect and send an async event if overtemp is detected Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_hw4.h | 1 + drivers/scsi/lpfc/lpfc_init.c

[PATCH 05/21] lpfc: Linux lpfc driver doesn't re-establish the link after a cable pull on LPe12002

Linux lpfc driver doesn't re-establish the link after a cable pull on LPe12002 Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_els.c | 3 +-- drivers/scsi/lpfc/lpfc_hbadisc.c | 6 ++ 2 files changed, 3

[PATCH 04/21] lpfc: Fix to handle PLOGI when already logged in

Fix to handle PLOGI when already logged in Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_nportdisc.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/drivers/scsi

[PATCH 00/21] lpfc: V2: Update lpfc version to driver version 10.5.0.0

first posting. -- james s James Smart (21): Fix the iteration count to match the 30 sec comment in the routine lpfc_pci_function_reset Add Lancer Temperature Event support to the lpfc driver Add new mbx cmd recognition Fix to handle PLOGI when already logged in Linux lpfc driver

[PATCH 03/21] lpfc: Add new mbx cmd recognition

Add new mbx cmd recognition Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_bsg.c | 1 + drivers/scsi/lpfc/lpfc_bsg.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi

[PATCH 06/21] lpfc: Fix host reset escalation killing all IOs.

Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_crtn.h | 1 + drivers/scsi/lpfc/lpfc_init.c | 11 --- drivers/scsi/lpfc/lpfc_scsi.c | 25 + 3 files changed, 34 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_crtn.h b

[PATCH 01/21] lpfc: Fix the iteration count to match the 30 sec comment in the routine lpfc_pci_function_reset

Fix the iteration count to match the 30 sec comment in the routine lpfc_pci_function_reset Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 01/20] lpfc: Fix the iteration count to match the 30 sec comment in the routine lpfc_pci_function_reset

Fix the iteration count to match the 30 sec comment in the routine lpfc_pci_function_reset Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 00/20] lpfc: Update lpfc driver to revision 10.5.0.0

Additional comments added on some patches. Prior Patch 9 and 10 have minor 1 line changes per review comments The patches were cut against Christoph's scsi-queue.git, branch drivers-for-3.20. -- james s *** BLURB HERE *** James Smart (20): Fix the iteration count to match the 30 sec

[PATCH v3 03/20] lpfc: Add new mbx cmd recognition

Add new mbx cmd recognition Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_bsg.c | 1 + drivers/scsi/lpfc/lpfc_bsg.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers

[PATCH v3 04/20] lpfc: Fix to handle PLOGI when already logged in

Fix to handle PLOGI when already logged in Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_nportdisc.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/drivers/scsi

[PATCH v3 08/20] lpfc: Add support for reporting option_rom_version on newer adapters

Add support for reporting option_rom_version on newer adapters Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_attr.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc

[PATCH v3 05/20] lpfc: Linux lpfc driver doesn't re-establish the link after a cable pull on LPe12002

Linux lpfc driver doesn't re-establish the link after a cable pull on LPe12002 Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_els.c | 3 +-- drivers/scsi/lpfc/lpfc_hbadisc.c | 6 ++ 2 files changed, 3

[PATCH v3 10/20] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command

Fix provide host name and OS name in RSNN-NN FC-GS command Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_ct.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v3 14/20] lpfc: Fix premature release of rpi bit in bitmask

adapters have a different access pattern that requires us to wait for a later mailbox completion. This changes the put call location on the newer sli4 adapters. Symptoms of the error are 0110 ELS and the 0372 iotag errors. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James

[PATCH v3 06/20] lpfc: Fix host reset escalation killing all IOs.

...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_crtn.h | 1 + drivers/scsi/lpfc/lpfc_init.c | 11 --- drivers/scsi/lpfc/lpfc_scsi.c | 25 + 3 files changed, 34 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_crtn.h b

[PATCH v3 02/20] lpfc: Add Lancer Temperature Event support to the lpfc driver

Add Lancer Temperature Event support to the lpfc driver This will detect and send an async event if overtemp is detected Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_hw4.h | 1 + drivers/scsi/lpfc

[PATCH v3 09/20] lpfc: Parse the new 20G, 25G and 40G link speeds in the lpfc driver

Parse the new 20G, 25G and 40G link speeds in the lpfc driver This patch is dependent upon the following patch to the FC transport which adds the 25G speed: http://www.spinics.net/lists/linux-scsi/msg83840.html Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart

[PATCH v3 07/20] lpfc: Fix setting of EQ (interrupt) delay Multiplier

Fix setting of EQ (interrupt) delay Multiplier Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_init.c | 8 drivers/scsi/lpfc/lpfc_sli.c | 9 +++-- drivers/scsi/lpfc/lpfc_sli4.h | 2 +- 3 files changed

[PATCH v3 12/20] lpfc: Fix null ndlp dereference in target_reset_handler

Fix null ndlp dereference in target_reset_handler Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_scsi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c

[PATCH v3 11/20] lpfc: Fix FDMI Fabric support in driver for Brocade

Fix FDMI Fabric support in driver for Brocade Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc.h | 3 + drivers/scsi/lpfc/lpfc_attr.c| 16 +- drivers/scsi/lpfc/lpfc_ct.c | 715

[PATCH v3 18/20] lpfc: Fix for lun discovery issue with saturn adapter.

Fix for lun discovery issue with saturn adapter. FCP_CMD payload was not always properly initialized on SLI-3 devices. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_scsi.c | 41

[PATCH v3 19/20] lpfc: Update copyright to 2015

Update copyright to 2015 Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc.h | 2 +- drivers/scsi/lpfc/lpfc_attr.c | 2 +- drivers/scsi/lpfc/lpfc_bsg.c | 2 +- drivers/scsi/lpfc/lpfc_bsg.h

[PATCH v3 15/20] lpfc: Fix internal loopback failure.

Fix internal loopback failure. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_els.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc

[PATCH v3 16/20] lpfc: Fix OS crash when running loopback test in applications

Fix OS crash when running loopback test in applications Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_bsg.c | 1 + drivers/scsi/lpfc/lpfc_sli.c | 12 drivers/scsi/lpfc/lpfc_sli.h | 1 + 3 files

[PATCH v3 17/20] lpfc: Fix crash in device reset handler.

Fix crash in device reset handler. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_scsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc

[PATCH v3 13/20] lpfc: Initiator sends wrong BBCredit value for either FLOGI or FLOGI_ACC

Initiator sends wrong BBCredit value for either FLOGI or FLOGI_ACC Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_els.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers

[PATCH v3 20/20] lpfc: Update version to 10.5.0.0 for upstream patch set

Update version to 10.5.0.0 for upstream patch set Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b

Re: [PATCH 10/21] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command

On 4/5/2015 8:07 AM, Sebastian Herbszt wrote: James Smart wrote: + /* Note :- OS name is Linux as per requirement BZ168199. */ + if (size n) + return n; + n += snprintf(symbol + n, size - n, OS:%s, init_utsname()-sysname); + return n; } Care

Re: [PATCH 15/21] lpfc: Implement support for wire-only DIF devices

fyi - in the v3 of the lpfc 10.5.0.0 patches I just posted, I pulled the patch. We will see what to do with it. We may come back with a set of generic midlayer patches. -- james s On 4/5/2015 12:06 PM, Christoph Hellwig wrote: On Fri, Apr 03, 2015 at 05:13:00PM -0400, James Smart wrote

Re: [PATCH kernel] commit 4fbdf9cb (lpfc: Fix for lun discovery issue with saturn adapter.)

Not sure - I'll go look. -- james On 5/19/2015 11:55 PM, Alexey Kardashevskiy wrote: On 05/06/2015 07:46 AM, Sebastian Herbszt wrote: James Smart wrote: Reviewed-By: James Smart james.sm...@emulex.com Alexey, Sebastian, Yes - this section needs to be reverted. This patch is good

Re: [PATCH kernel] commit 4fbdf9cb (lpfc: Fix for lun discovery issue with saturn adapter.)

Alexey, Can you send me boot messages so I can see everything the lpfc driver may have done ? And you're using 10.5.0.0 verbatim ? -- james On 5/20/2015 9:11 AM, James Smart wrote: Not sure - I'll go look. -- james On 5/19/2015 11:55 PM, Alexey Kardashevskiy wrote: On 05/06/2015 07:46

Re: [PATCH] lpfc: fix model description

Yes - this is acceptable. Not a big deal per-say, but good to be uniform. Reviewed-By: James Smart james.sm...@avagotech.com -- james s On 5/27/2015 5:40 PM, Sebastian Herbszt wrote: I wrote: Remove trailing space from model description. Signed-off-by: Sebastian Herbszt herb...@gmx.de

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

That's good to know. We have a fair amount of existing strings that are split, so I don't want to retrofit those. But, on future submits, we'll keep the string on a single line. Thanks -- james On 5/27/2015 5:32 PM, Sebastian Herbszt wrote: James Smart wrote: Sebastian, Re: more than 1

Re: [PATCH] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

Bodo, This is a valid fix. Thank you. I assume you were changing the driver module parameter to up the SG count ? without the fix we would have been capped at 64 sges. -- james Reviewed-By: James Smart james.sm...@avagotech.com On 5/29/2015 8:22 AM, bstroes...@ts.fujitsu.com wrote: Hi

[PATCH v2 07/15] lpfc: Correct reporting of vport state on fdisc command failure.

Correct reporting of vport state on fdisc command failure. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_els.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc

[PATCH v2 13/15] lpfc: Fix incorrect log message reported for empty FCF record.

Fix incorrect log message reported for empty FCF record. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_hbadisc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc

[PATCH v2 15/15] lpfc: Update driver version for upstream patch set 10.6.0.1.

Update driver version for upstream patch set 10.6.0.1. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc

[PATCH v2 14/15] lpfc: Change buffer pool empty message to miscellaneous category

Change buffer pool empty message to miscellaneous category Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc

[PATCH v2 12/15] lpfc: Fix rport leak.

Fix rport leak. Correct locking and refcounting in tracking our rports Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_disc.h| 4 +- drivers/scsi/lpfc/lpfc_els.c | 12 +++- drivers/scsi/lpfc

[PATCH v2 11/15] lpfc: Correct loss of RSCNs during array takeaway/giveback testing.

Correct loss of RSCNs during array takeaway/giveback testing. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_els.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH v2 03/15] lpfc: Add support for ELS LCB.

Add support for ELS LCB. Also has a little whitespace fixing. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_els.c | 239

[PATCH v2 09/15] lpfc: Fix to remove IRQF_SHARED flag for MSI/MSI-X vectors.

Fix to remove IRQF_SHARED flag for MSI/MSI-X vectors. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_init.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc

[PATCH v2 05/15] lpfc: Fix ABORTs WQ selection in terminate_rport_io

Fix ABORTs WQ selection in terminate_rport_io Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_sli.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git

[PATCH v2 04/15] lpfc: Correct reference counting of rport

Correct reference counting of rport Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_hbadisc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers

[PATCH v2 06/15] lpfc: Add support for RDP ELS command.

Add support for RDP ELS command. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_crtn.h | 2 + drivers/scsi/lpfc/lpfc_els.c | 420

[PATCH v2 10/15] lpfc: Fix crash in vport_delete.

Fix crash in vport_delete. We inadvertantly took the path to recreate the vport while in a driver teardown path Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_init.c | 8 +++- drivers/scsi/lpfc

[PATCH v2 08/15] lpfc: Fix discovery issue when changing from Pt2Pt to Fabric.

Fix discovery issue when changing from Pt2Pt to Fabric. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_hbadisc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/scsi

[PATCH v2 02/15] lpfc: Correct loss of target discovery after cable swap.

Correct loss of target discovery after cable swap. Fix incorrect reference counting Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 01/15] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence

The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 00/15] lpfc: Update to revision 10.6.0.1

double spacing with single spacing Revised LS_RJT codes for lpfc_els_rcv_rdp() The patches were cut against scsi-misc -- james James Smart (15): The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence Correct loss of target discovery after cable swap. Add

[PATCH 3/9] lpfc: Devices are not discovered during takeaway/giveback testing

the state of the 2 ndlp's when a DID swap is detected. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_els.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/scsi

[PATCH 2/9] lpfc: Fix vport deletion failure.

Fix vport deletion failure. If a vport was deleted while in the middle of discovery, we weren't clearing the nport discovery flag. Correct by clearing the flag and cancelling our discovery timeout timer. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm

[PATCH 1/9] lpfc: Check for active portpeerbeacon.

-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_els.c | 19 +++ drivers/scsi/lpfc/lpfc_hw4.h | 6 ++ 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b

[PATCH 7/9] lpfc: Fix scsi task management error message.

Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_scsi.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index b3b195f..e5eb40d 100644

[PATCH 8/9] lpfc: Fix to drop PLOGIs from fabric node till LOGO processing completes

in Warning messages indicating kref.h via lfpc_nlp_get+0x128. Correct by dropping any new PLOGI until the prior nport state has settled. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_els.c | 14

[PATCH 4/9] lpfc: Add support for using block multi-queue

be turned on via CONFIG_SCSI_MQ_DEFAULT or passing scsi_mod.use_blk_mq=Y as a parameter to the kernel. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_init.c | 4 ++- drivers/scsi/lpfc/lpfc_scsi.c | 43

[PATCH 9/9] lpfc: Update version to 10.7.0.0 for upstream patch set.

Update version to 10.7.0.0 for upstream patch set. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc

[PATCH 5/9] lpfc: Fix scsi prep dma buf error.

Fix scsi prep dma buf error. Didn't check for less-than-or-equal zero. Means we may later call scsi_dma_unmap() even though we don't have valid mappings. Signed-off-by: Dick Kennedy dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc

[PATCH 6/9] lpfc: Fix cq_id masking problem.

dick.kenn...@avagotech.com Signed-off-by: James Smart james.sm...@avagotech.com --- drivers/scsi/lpfc/lpfc_hw4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h index b94fa46..33ec4fa 100644 --- a/drivers/scsi/lpfc

Re: [PATCH trivial] lpfc: Grammar s/an negative/a negative/

Reviewed-By: James Smart james.sm...@avagotech.com looks fine. Thanks -- james s On 5/21/2015 8:11 AM, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- drivers/scsi/lpfc/lpfc_debugfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

a bit in the past and believe we have been grandfathered as there's a lot of this already. James B - any comments on the above ? -- james s On 5/24/2015 7:56 AM, Sebastian Herbszt wrote: James Smart wrote: Fix rport leak. Correct locking and refcounting in tracking our rports Signed-off

Re: [PATCH 3/9] lpfc: Devices are not discovered during takeaway/giveback testing

uh - we're flagging issues with in a patch explanation (such as 2 spaces after a period) and not something in the patch itself ?? I'm not going to revise patches for minor typos or styles disagreements in patch descriptions. -- james On 5/24/2015 3:56 PM, Sebastian Herbszt wrote: James

Re: [PATCH] scsi: Export SCSI Inquiry data to sysfs

On 8/14/2015 2:32 AM, Hannes Reinecke wrote: On 08/13/2015 01:50 PM, Johannes Thumshirn wrote: Export the RAW SCSI Inquiry to sysfs as binfile. This way the data can be used by userlang without the need to have and ioctl or use the sg_inq tool. userland! Just be careful. There are

Re: [PATCH] lpfc: Use instead of for boolean expression

Reviewed-by: James Smart james.sm...@avagotech.com Thanks -- james On 7/22/2015 4:53 AM, Sebastian Herbszt wrote: Use logical instead of bitwise AND. Signed-off-by: Sebastian Herbszt herb...@gmx.de --- diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c

Re: [PATCH] Fix kmalloc overflow in LPFC driver at large core count

Looks fine. If not merged prior, we'll pull it in our next update. Reviewed-By: James Smart james.sm...@avagotech.com -- james s On 7/10/2015 12:31 PM, ian mitchell wrote: This patch allows the LPFC to start up without a fatal kernel bug based on an exceeded KMALLOC_MAX_SIZE and a too

Re: [PATCH] lpfc: fix memory leak and NULL dereference

Looks Good - Thank you Sudip. Reviewed-by: James Smart <james.sm...@avagotech.com> -- james s On 9/23/2015 6:32 AM, Sudip Mukherjee wrote: kmalloc() can return NULL and without checking we were dereferencing it. Moreover if kmalloc succeeds but the function fails in other parts then w

Re: [PATCH] lpfc: Destroy lpfc_hba_index IDR on module exit

Reviewed-By: James Smart james.sm...@avagotech.com -- james s On 7/8/2015 11:19 AM, Johannes Thumshirn wrote: Destroy lpfc_hba_index IDR on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez mcg...@suse.com) SmPL

Re: [RESEND][PATCH] lpfc: fix model description

As mentioned previously, it's a nit, and not too meaningful, but fine. If not merged prior, we'll repost as part of an upcoming commit that cleans up sparse warnings. Reviewed-By: James Smart james.sm...@avagotech.com -- james s On 7/6/2015 5:22 PM, Sebastian Herbszt wrote: Remove

[PATCH 00/14] lpfc: Update to revision 11.0.0.0

This patch set updates the lpfc driver to revision 11.0.0.0 The patches were cut against scsi-misc -- james s James Smart (14): Pull in patches posted to linux-scsi prior: lpfc: fix model description lpfc: Remove unnessary cast lpfc: in sli3 use configured sg_seg_cnt

[PATCH 02/14] lpfc: Remove unnessary cast

From: Firo Yang <fir...@gmail.com> kzalloc() returns a void pointer - no need to cast it in drivers/scsi/lpfc/lpfc_init.c::lpfc_sli_driver_resource_setup() Signed-off-by: Firo Yang <fir...@gmail.com> Signed-off-by: James Smart <james.sm...@avagotech.com> --- drivers/scsi/lp

[PATCH 03/14] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

lesize. But lpfc_template is the template used for sli4 only. Thus the value should correctly be written to lpfc_template_s3->sg_tablesize. This patch is for kernel 4.1-rc5, but is tested with lpfc 10.2.405.26 only. Signed-off-by: Bodo Stroesser <bstroes...@ts.fujitsu.com> Signed-off-

[PATCH 01/14] lpfc: fix model description

From: Sebastian Herbszt <herb...@gmx.de> Remove trailing space from model description. Signed-off-by: Sebastian Herbszt <herb...@gmx.de> Signed-off-by: James Smart <james.sm...@avagotech.com> --- drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 10/14] lpfc: Add support for Lancer G6 and 32G FC links

Add support for Lancer G6 and 32G FC links Signed-off-by: Dick Kennedy <dick.kenn...@avagotech.com> Signed-off-by: James Smart <james.sm...@avagotech.com> --- drivers/scsi/lpfc/lpfc.h | 8 +--- drivers/scsi/lpfc/lpfc_attr.c| 17 + drivers/scsi/lp

[PATCH 11/14] lpfc: Fix for discovery failure in PT2PT when FLOGI's ELS ACC response gets aborted

processing PLOGI's. Signed-off-by: Dick Kennedy <dick.kenn...@avagotech.com> Signed-off-by: James Smart <james.sm...@avagotech.com> --- drivers/scsi/lpfc/lpfc_els.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/lpfc/

[PATCH 05/14] Fix kmalloc overflow in LPFC driver at large core count

0.003652)| [] ? kthread_freezable_should_stop+0x5b/0x5b 2199383.192333 (0.012247)| ehci-pci :00:1a.0: EHCI Host Controller >8 The proposed solution was approved by James Smart at Emulex and tested on a UV2 machine with 6144 core

[PATCH 07/14] lpfc: remove set but not used variables

From: Sebastian Herbszt <herb...@gmx.de> Remove set but not used variables. Signed-off-by: Sebastian Herbszt <herb...@gmx.de> Signed-off-by: James Smart <james.sm...@avagotech.com> --- drivers/scsi/lpfc/lpfc_attr.c | 6 drivers/scsi/lpfc/lpfc_bsg.c | 20 -

[PATCH 14/14] lpfc: Update version to 11.0.0.0 for upstream patch set

Update version to 11.0.0.0 for upstream patch set Signed-off-by: Dick Kennedy <dick.kenn...@avagotech.com> Signed-off-by: James Smart <james.sm...@avagotech.com> --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH 13/14] lpfc: Fix default RA_TOV and ED_TOV in the FC/FCoE driver for all topologies

Fix default RA_TOV and ED_TOV in the FC/FCoE driver for all topologies Initial link up defaults were not properly being tracked relative to initial FLOGI or pt2pt PLOGI. Add code to initialize them. Signed-off-by: Dick Kennedy <dick.kenn...@avagotech.com> Signed-off-by: James Smart <

[PATCH 08/14] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

ith mp->virt and mp->phys as function arguments. This is the use after free. Following the use after free mp gets kfree()d again which is a double free. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Signed-off-by: James Smart <james.sm...@avagotech.com> --- drivers/s

[PATCH 04/14] lpfc: Destroy lpfc_hba_index IDR on module exit

it.exit; @@ exit(void) { ... +idr_destroy(); } Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Signed-off-by: James Smart <james.sm...@avagotech.com> Reviewed-by: Hannes Reinecke <h...@suse.de> --- drivers/scsi/lpfc/lpfc_init.c | 1 + 1 file changed, 1 insertion(+)

[PATCH 09/14] fix: lpfc_send_rscn_event sends bigger buffer size

.@suse.cz> Signed-off-by: James Smart <james.sm...@avagotech.com> Reviewed-by: Hannes Reinecke <h...@suse.de> --- drivers/scsi/lpfc/lpfc_els.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index

[PATCH 12/14] lpfc: The linux driver does not reinitiate discovery after a failed FLOGI

The linux driver does not reinitiate discovery after a failed FLOGI Forgot to clear FCF Discovery in-progress flag upon FLOGI failures. Thus we didn't restart FLOGI. Signed-off-by: Dick Kennedy <dick.kenn...@avagotech.com> Signed-off-by: James Smart <james.sm...@avagotech.com> ---

[PATCH 06/14] lpfc:Make the function lpfc_sli4_mbox_completions_pending static in order to comply with function prototype

From: Nicholas Krause <xerofo...@gmail.com> This makes the function lpfc_sli4_mbox_completion's definition static now in order to comply with its prototype being also declared as static too. Signed-off-by: Nicholas Krause <xerofo...@gmail.com> Signed-off-by: James Sma

Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

On 8/18/2015 6:27 PM, Sebastian Herbszt wrote: Johannes Thumshirn wrote: Sebastian Herbszt writes: Johannes Thumshirn wrote: If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution continues normally and mp gets kfree()d. If the subsequent call to

<    1   2   3   4   5   6   7   8   9   10   >