ething to test soon.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürn
= 6
ioctl(6, SG_SET_RESERVED_SIZE, [131072]) = 0
ioctl(6, SG_SET_TIMEOUT, [1080])= 0
write(6, "\0\0\0\0H\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"...,
42) = -1 EINVAL (Invalid argument)
--
Johannes Thumshirn
On Wed, Jul 05, 2017 at 10:44:47AM +0200, Johannes Thumshirn wrote:
> On Wed, Jul 05, 2017 at 08:57:54AM +0100, Chris Clayton wrote:
> > Thanks for the reply, Johannes.
> > The strace log for 4.12.0 is attached.
>
> Thanks Chris.
>
> Can I have a known good versi
Add a regression test for the patch titled "scsi: sg: fix
SG_DXFER_FROM_DEV transfers" which reassembles the syscalls done by Nero
Burning ROM to discover CD and DVD burners.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
common/sg | 2 +-
src/.gitigno
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
So here we are again,
Tested-by: Johannes Thumshirn <jthumsh...@suse.de>
FCoE will follow as soon as my setup can speak FCoE again.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINU
NVMe devices and
> PCIe switches.
Hi Suganath,
Can you please also Cc linux-n...@lists.infradead.org for NVMe related topics.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
On Wed, Jul 05, 2017 at 01:19:09PM +0100, Chris Clayton wrote:
> I'm happy to test any patches you may propose.
Can you verify this fix? Preferedably with using Nero. It passes my small
reproducer:
>From f52502180cc3843f8acc956253af2575245546a8 Mon Sep 17 00:00:00 2001
From: Johannes Thu
SG_DXFER_FROM_DEV transfers do not have a dxferp as we set it to NULL,
but must have a length bigger than 0. This fixes a regression introduced
by commit 28676d869bbb ("scsi: sg: check for valid direction before
starting the request")
Signed-off-by: Johannes Thumshirn <jthumsh...@s
On Wed, Jul 05, 2017 at 02:45:06PM +0100, Chris Clayton wrote:
> With your patch applied to 4.12.0, all three of the nero applications can now
> detect my drives again.
>
> Excellent work! Thank you.
>
> Tested-by: Chris Clayton <chris2...@googlemail.com>
Thanks for con
ode more readable IMHO. But
ultimately it's your driver so if you insist I'll do.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jan
.
>
> Fixes: 1bc0eb0 ("scsi: sg: protect accesses to 'reserved' page array")
> Signed-off-by: Hannes Reinecke <h...@suse.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@
On Mon, Apr 24, 2017 at 02:38:40PM +0100, John Garry wrote:
> On 24/04/2017 11:09, John Garry wrote:
> >On 21/04/2017 13:11, Johannes Thumshirn wrote:
> >>Move scsi_remove_host call into sas_remove_host and remove it from SAS
> >>HBA
> >>drivers, so we don
Looks good,
Acked-by: Johannes Thumshirn <j...@kernel.org>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB
On Mon, Aug 07, 2017 at 01:28:18PM -0400, Martin K . Petersen wrote:
> However, having a bazillion identical commit messages is also really
> annoying. So for automated changes like this, I'd rather just have a
> single patch.
Thought so ;-)
--
Johannes
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
>nvmet_ctx_list,
> + _infop->nvmet_ctx_list);
> + INIT_LIST_HEAD(_infop->nvmet_ctx_list);
list_splice_init(_infop->nvmet_ctx_list,
_infop->nvmet
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
t;Slides" from my LSF/MM session which have the function
protoypes on 'em. See 'lib/irq_poll.c' or the be2iscsi driver for further
details.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX Gm
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Thanks James,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
goto out_retry;
> + }
> + }
if (stat.un.b.lsRjtRsnCodeExp ==
LSEXP_REQ_UNSUPPORTED && cmd == ELS_CMD_PRLI ) {
in, which isn't applicable here. Can we maybe reprase it to something like:
/* For NVMe, cache new_ndlp->nrport and override with ndlp->nrport */
Otherwise,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn
Thanks Bart,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
DID,
> + ndlp->nlp_state,
> + ndlp->nlp_rpi,
> + ndlp->nlp_flag);
> + mp = (struct
vme_register_rport if it isn't configured for
handling NVMe?
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham No
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Thanks,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
The change itself is OK, but the Changelog is a bit odd to read, IMHO.
Unfortunately I can't come up with a better version either. If you can think
of one I'd be very happy.
Thanks,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thu
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
lpfc_printf_log(phba, KERN_ERR,
LOG_INIT,
"6132 NVME restore reg "
"failed on nvmei error "
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
On 05/17/2017 05:00 PM, Varun Prakash wrote:
> Signed-off-by: Varun Prakash <va...@chelsio.com>
> ---
Please be a bit more verbose with the changelog.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthums
group probably) I'll look through my reproducer collection and work on a
patch set.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF
from
cxgb4/t4fw_version.h")
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409
If the list search in sg_get_rq_mark() fails to find a valid request, we
return a bogus element. This then can later lead to a GPF in sg_remove_scat().
So don't return bogus Sg_requests in sg_get_rq_mark() but NULL in case the
list search doesn't find a valid request.
Signed-off-by: Johannes
If the list search in sg_get_rq_mark() fails to find a valid request, we
return a bogus element. This then can later lead to a GPF in sg_remove_scat().
So don't return bogus Sg_requests in sg_get_rq_mark() but NULL in case the
list search doesn't find a valid request.
Signed-off-by: Johannes
think you forgot to Cc the linux-nvme [1] list on your submission. It
would be good to have it on linux-nvme as well as on linux-scsi so Sagi,
Christoph and Keith see it as well.
Byte,
Johannes
[1] linux-n...@lists.infradead.org
--
Johannes Thumshirn
nge of the
> release string.
>
> Signed-off-by: Johannes Berg <johannes.b...@intel.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de
ore?
Thanks,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
On Wed, Jun 21, 2017 at 01:48:44PM -0700, Madhani, Himanshu wrote:
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINU
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
bsc#1025461
and our internal Bugzilla IDs
How about:
The hpsa firmware will bypass the cache for any requests larger than 1MB, so
we shoould cap the request size to avoid any performance regressions in
kernels later than 4.3
The same applies for Patch 2/2
--
Johann
endif
> +module_param(ql2xnvmeenable, int, 0644);
> +MODULE_PARM_DESC(ql2xnvmeenable,
> +"Enables NVME support. "
> +"0 - no NVMe. Default is Y");
Default is Y IFF CONFIG_NVME_FC is enabled. Is it possible to guard the whole
module
paraneter with IS_ENABLED(CONFIG_NVME_F
In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the
qpair->qp_lock but do access members of the qpair before having the lock.
Re-order the locking sequence to have all read and write access to qpair
members under the qpair->qp_lock.
Signed-off-by: Johannes Thumshirn &l
> on ndlp state are needed, there is no race.
Thanks for the explanation
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smit
semantic that after the registration is done the object can be
used and thus assigning private pointer afterwards is an error. Damn I didn't
realize this in the nmve-fc review.
--
Johannes Thumshirn Storage
jthumsh...@suse.de
()
> >`-> nvme_fc_queue_rq()
> >`-> nvme_fc_start_fcp_op()
> >`-> qla_nvme_post_cmd()
> > isn't called from an IRQ context and qla2xxx_get_qpair_sp() internally
> > uses mempool_alloc(). From mempool_alloc()'s documentatio
ned-off-by: Bart Van Assche <bart.vanass...@wdc.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Johannes Thumshirn <jthumsh...@suse.de>
> ---
Thanks Bart,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Joha
I driver.")
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
>
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 7405
In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the
qpair->qp_lock but do access members of the qpair before having the lock.
Re-order the locking sequence to have all read and write access to qpair
members under the qpair->qp_lock.
Signed-off-by: Johannes Thumshirn &l
is caused from d2be537c3ba3568acd79cd178327b842e60d035e,
> which changed max_sectors_kb to 1280k, but the hardware is able to
> work fine with it, so the true fix should be from hpsa driver.
>
> Signed-off-by: Yadan Fan <yd...@suse.com>
> ---
Reviewed-by: Johannes Thumshirn <jth
is caused from d2be537c3ba3568acd79cd178327b842e60d035e,
> which changed max_sectors_kb to 1280k, but the hardware is able to
> work fine with it, so the true fix should be from smartpqi driver.
>
> Signed-off-by: Yadan Fan <yd...@suse.com>
> ---
Reviewed-by: Johannes Thumshirn <jth
On Thu, Jun 22, 2017 at 03:19:27PM +0100, John Garry wrote:
> On 22/06/2017 14:43, Johannes Thumshirn wrote:
> >In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the
> >qpair->qp_lock but do access members of the qpair before having the lock.
> >Re-order the
3400e64d377 ("scsi: aacraid: Include HBA direct interface")
> Fixes: c799d519bf088 ("scsi: aacraid: Retrieve HBA host information ioctl")
> Signed-off-by: Seth Forshee <seth.fors...@canonical.com>
> ---
Looks good,
Reviewed-by: Johannes T
se we can make a generic sg_io tool but IMHO it's quite convenient
to just throw in the reproducers we get.
And as it exercises the /dev/sg character device I decided to make a new
group.
Johannes
--
Johannes Thumshirn Storage
jthumsh..
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key finger
I'll pack it into the prepare stage.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürn
/git/mkp/scsi.git/commit/?h=4.12/scsi-fixes=48ae8484e9fc324b4968d33c585e54bc98e44d61
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard
directly return
*iff* one of the pci_enable_device() calls fails.
Additionally rename the 'probe_out' goto label's name to the more
descriptive 'disable_device'.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Fixes: e315cd28b9ef ("[SCSI] qla2xxx: Code changes for qla dat
Add a regression test for commit 48ae8484e9fc ("scsi: sg: don't return
bogus Sg_requests"). This is a general protection fault triggered by
syzcaller via issuing bogus read(2)s on the /dev/sg devices.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
tests
Add the ability to build test cases from C files. This is handy for
things like syzcaller reproducers and all other kinds of test
binaries.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
Makefile | 26 +++-
src/.gitignore | 1 +
src/Makefile | 16 +++
src/sg-001.c
Add a test group for tests of the SCSI generic driver and and
functions common to the SCSI generic driver and it's test cases.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
common/sg | 41 +
tests/sg/grou
name
* Fixed Makefile so it can build more than one target
Johannes Thumshirn (3):
Add ability to build test-cases
tests/sg: add SCSI generic test grouop
sg/001: add regression test for syzcaller generated GPF in sg_read
path
Makefile | 26 +++-
common/sg| 41 ++
src
up a bit so it compiles with the "-Wall
-Wextra -Werror" trinity.
I'll send you a v2 once I'm done with it (and all other comments).
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 7
On 05/24/2017 02:33 AM, Bart Van Assche wrote:
> This will make it easier to serialize SCSI device state changes
> through a mutex.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@s
h a mutex.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Johannes Thumshirn <jthumsh...@suse.de>
> Cc: Sreekanth Reddy <sreekanth.re...@broadcom.com>
Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Johannes Thumshirn <jthumsh...@suse.de>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
J
. Hence convert these
> two assignment statements into warning statements.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Johannes Thumshirn <jthumsh...@suse.
Naresh Bannoth <nbann...@in.ibm.com>
> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de
hy...@in.ibm.com>
> Reported-by: Naresh Bannoth <nbann...@in.ibm.com>
> Tested-by: Raphael Silva <rapha...@linux.vnet.ibm.com>
> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de
'pending' and 'requested' settings?
With an a bit more verbose changelog
Acked-by: Johannes Thumshirn <j...@kernel.org>
for the whole series
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH,
future tests if it makes sense to run them on a real
> device. Thanks!
Yes I wanted to go to it tomorrow and send you a v3, I got stuck in NVMe
;-). Thanks for applying it anyways, I'll send a follow up.
Johannes
--
Johannes Thumshirn Storage
jth
ase, etc...
The cyclomatic complexity GCC plugin we have in scripts/gcc-plugins
could be of help here, though I only have read about it and never really
used myself.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74
over.
>
> Signed-off-by: Long Li <lon...@microsoft.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX Gmb
On 06/14/2017 02:57 PM, John Garry wrote:
> On 14/06/2017 12:52, Johannes Thumshirn wrote:
>> libsas uses scsi_queue_work() to queue it's internal event
>> notifications. scsi_queue_work() can return -EINVAL if the work queue
>> doesn't exist and it does call queue_work() w
fcport);
> + nvme_fc_unregister_remoteport(
> + fcport->nvme_remote_port);
> + qla_nvme_wait_on_rport_del(fcport);
> + qla_nvme_abort_all(fcport);
> + }
> + }
> +
> +
)) {
if (vha->flags.nvme_enabled &&
qla2x00_rff_id(vha, FC4_TYPE_NVME))
ql_dbg(ql_dbg_disc, vha, 0x2049, )
> + ql_dbg(ql_dbg_disc, vha, 0x2049,
> +
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Nort
urthy <anil.gurumur...@cavium.com>
> Signed-off-by: Giridhar Malavali <giridhar.malav...@cavium.com>
> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com>
> ---
A bit more of a change log would be highly apprechiated.
Other than that,
Reviewed-by: Jo
(fcport->fw_login_state == DSC_LS_PLOGI_COMP) ||
> + (fcport->fw_login_state == DSC_LS_PRLI_PEND))
> + return rval;
Minor nit, superfluous parenthesis.
Anyways,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn
On Fri, Jun 16, 2017 at 07:57:08PM -0400, Will Simoneau wrote:
> Is this is a known / obvious issue, or should I try to bisect it?
This is a known issue with SAS (and FC) drivers, although no soulution exists
to this point.
Johannes
--
Johannes Thumsh
f (scmnd->device->host->transportt == fc_transport_template)
> + return fc_eh_timed_out(scmnd);
> +#endif
Can you please change the #if IS_ENABLED() to
if(IS_ENABLED(CONFIG_SCSI_FC_ATTRS)
&& scmnd->device->ho
e
>we use former wait-complete to achieve a sas event atomic process and use
> latter to
>make a sas discovery sync.
> 4. remove disco_mutex in sas_revalidate_domain, since now
> sas_revalidate_domain sync
>the destruct discovery event execution, it's no need t
* their siblings when forming wide ports */
/* LLDD calls these to notify the class of an event. */
- void (*notify_ha_event)(struct sas_ha_struct *, enum ha_event);
+ int (*notify_ha_event)(struct sas_ha_struct *, enum ha_event);
void (*notify_port_event)(struct asd_sas
1001 - 1100 of 1470 matches
Mail list logo
