Re: [PATCH] libfc: Fix variable name in fc_set_wwpn

2017-01-13 Thread Johannes Thumshirn
On Fri, Jan 13, 2017 at 11:40:01AM +0800, Fam Zheng wrote: > The parameter name should be wwpn instead of wwnn. > > Signed-off-by: Fam Zheng > --- Yup, looks good Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthums

Re: [PATCH] Set elsiocb contexts to NULL after freeing it

2017-01-13 Thread Johannes Thumshirn
[+Cc James S. I'm sorry] On Tue, Jan 10, 2017 at 12:05:54PM +0100, Johannes Thumshirn wrote: > Set the elsiocb contexts to NULL after freeing as others depend on it. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/lpfc/lpfc_els.c | 2 ++ > 1 file changed, 2

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

2017-01-13 Thread Johannes Thumshirn
On Wed, Jan 11, 2017 at 08:13:02AM -0700, Jens Axboe wrote: > On 01/11/2017 08:07 AM, Jens Axboe wrote: > > On 01/11/2017 06:43 AM, Johannes Thumshirn wrote: > >> Hi all, > >> > >> I'd like to attend LSF/MM and would like to discuss polling for block >

Re: [PATCH] ses: Fix SAS device detection in enclosure

2017-01-16 Thread Johannes Thumshirn
835831c57e9b ("ses: use scsi_is_sas_rphy instead of > Ewan> is_sas_attached") Reviewed-by: Johannes Thumshirn > Ewan> Signed-off-by: Ewan D. Milne > Ewan> --- > Ewan> drivers/scsi/ses.c | 2 +- 1 file changed, 1 insertion(+), 1 > Ewan> deletion(-) > >

[ANOUNCE] New open-fcoe release v1.0.32

2017-01-17 Thread Johannes Thumshirn
target segfault with other FC storage present sanmac isn't required Hannes Reinecke (3): fcoemon: fixup log_nlmsg_error() fcoemon: Add debugging message for 'recv' Fallback to default MAC address for FIP Johannes Thumshirn (2): fcoeadm: Fix possible buf

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

2017-01-17 Thread Johannes Thumshirn
s, as expected. [1] lib/irq_poll.c:13 Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham N

Re: [PATCH 02/17] lpfc: NVME Initiator: Base modifications Part A

2017-01-18 Thread Johannes Thumshirn
t; + chann = (chann % phba->cfg_fcp_max_hw_queue); No need for the parenthesis. [...] > @@ -4959,11 +4968,11 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct > scsi_cmnd *cmnd, > int status; > > rdata = lpfc_rport_data_from_scsi_device(cmnd->device); > -

Re: [PATCH 03/17] lpfc: NVME Initiator: Base modifications Part B

2017-01-18 Thread Johannes Thumshirn
} > + spin_lock_irq(lock); > + } > + spin_unlock_irq(lock); > + return 1; > +} > + Aren't you using lpc_emptyq_wait() in patches prior to that already? This breaks git bisect. Pleas test-build (ideally + checkpatch and sparse/smatch) each patch

Re: [PATCH 04/17] lpfc: NVME Initiator: Base modifications Part C

2017-01-18 Thread Johannes Thumshirn
LPFC_WQE128_DEF_COUNT); > + } else { > + qdesc = lpfc_sli4_queue_alloc(phba, > + phba->sli4_hba.wq_esize, > + phba->sli

Re: [PATCH 05/17] lpfc: NVME Initiator: Base modifications Part D

2017-01-18 Thread Johannes Thumshirn
mplete Queue */ > + if (!phba->sli4_hba.nvme_cq) { Hint, if you write a comment what the specific code block is doing, you might actually write a function. Here sth. like 'lpfc_nvme_setup_fast_path_cq()' comes to my mind. Especially if you have to use more than 3 levels

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

2017-01-18 Thread Johannes Thumshirn
fact > that drivers can poll more than their given budget? So what you say is you saw a consomed == 1 [1] most of the time? [1] from http://git.infradead.org/nvme.git/commitdiff/eed5a9d925c59e43980047059fde29e3aa0b7836 -- Johannes Thumshirn Storage jthu

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

2017-01-18 Thread Johannes Thumshirn
UE_OK; out_cleanup_iod: nvme_free_iod(dev, req); out_free_cmd: nvme_cleanup_cmd(req); return ret; } So we're draining the CQ on submit. This of cause makes polling for completions in the IRQ handler rather pointless as we already did in the submission path. -- Johannes Thu

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

2017-01-18 Thread Johannes Thumshirn
gt;return ret; > >} > > > >So we're draining the CQ on submit. This of cause makes polling for > >completions in the IRQ handler rather pointless as we already did in the > >submission path. > > I think you

Re: [PATCH 02/17] lpfc: NVME Initiator: Base modifications Part A

2017-01-19 Thread Johannes Thumshirn
On Wed, Jan 18, 2017 at 06:34:02PM -0800, James Smart wrote: > > > On 1/18/2017 1:50 AM, Johannes Thumshirn wrote: > > >>@@ -4959,11 +4968,11 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct > >>scsi_cmnd *cmnd, > >>int status; > >>

Re: [PATCH 03/17] lpfc: NVME Initiator: Base modifications Part B

2017-01-19 Thread Johannes Thumshirn
On Wed, Jan 18, 2017 at 06:45:46PM -0800, James Smart wrote: > > > On 1/18/2017 2:11 AM, Johannes Thumshirn wrote: > >On Tue, Jan 17, 2017 at 05:20:46PM -0800, James Smart wrote: > >>NVME Initiator: Base modifications > >> > >>This is part B of

Re: [PATCH 04/17] lpfc: NVME Initiator: Base modifications Part C

2017-01-19 Thread Johannes Thumshirn
On Wed, Jan 18, 2017 at 06:54:37PM -0800, James Smart wrote: > > > On 1/18/2017 3:03 AM, Johannes Thumshirn wrote: > > > >>+ /* maximum number of xris available for nvme buffers */ > >>+ els_xri_cnt = lpfc_sli4_get_els_iocb_cnt(phba); > >

Re: [PATCH 1/7] scsi: hisi_sas: workaround v2 hw SATA IO timeout issue

2017-01-19 Thread Johannes Thumshirn
may cause some IO timeouts. > > We need to periodically configure the SAS controller so it > doesn't receive STP setup requests from SATA disks for a while, > so IO can be sent during this period. > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry > --- Looks good,

Re: [PATCH 2/7] scsi: hisi_sas: modify some values of ITCT table

2017-01-19 Thread Johannes Thumshirn
lt;< ITCT_HDR_VALID_OFF) | > (device->linkrate << ITCT_HDR_MCR_OFF) | > (1 << ITCT_HDR_VLN_OFF) | > + (0xfa << ITCT_HDR_SMP_TIMEOUT_OFF) | ^~ You may want to give that magic value a name. Other

Re: [PATCH 3/7] scsi: hisi_sas: downgrade refclk message

2017-01-19 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) K

Re: [PATCH 6/7] scsi: hisi_sas: fix probe ordering problem

2017-01-19 Thread Johannes Thumshirn
ohn Garry > --- Looks OK, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 7/7] scsi: hisi_sas: decrease running_req in hisi_sas_slot_task_free()

2017-01-19 Thread Johannes Thumshirn
igned-off-by: Xiang Chen > Signed-off-by: John Garry > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnbe

Re: [PATCH 4/7] scsi: hisi_sas: modify hard reset for directed-attached disk

2017-01-19 Thread Johannes Thumshirn
On Thu, Jan 19, 2017 at 12:32:50AM +0800, John Garry wrote: > From: Xiang Chen > > Correctly set registers in v2 for root PHY hardreset for directly > attached disk. > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry > --- Looks good, Reviewed-by: Johannes

Re: [PATCH 5/7] scsi: hisi_sas: downgrade internal abort exit print

2017-01-19 Thread Johannes Thumshirn
On Thu, Jan 19, 2017 at 12:32:51AM +0800, John Garry wrote: > Downgrade the exit print in hisi_sas_internal_task_abort() > to dbg level, as info is not required. > > Signed-off-by: John Garry > Reviewed-by: Xiang Chen > --- Looks good, Reviewed-by: Johannes Thumshirn --

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

2017-01-19 Thread Johannes Thumshirn
eded in order for it to > work well. I know that some networking drivers implemented adaptive > moderation in SW before having HW support for it. It can be done by > maintaining stats and having a periodic work that looks at it and > changes the mode

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

2017-01-19 Thread Johannes Thumshirn
that sounds reasonable to you guys as well? Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

2017-01-20 Thread Johannes Thumshirn
5 deletions(-) Otherwise, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graha

Re: [PATCH 0/4] mpt3sas driver Enhancements and

2017-01-20 Thread Johannes Thumshirn
rs/scsi/mpt3sas/mpt3sas_base.h |7 +++-- > drivers/scsi/mpt3sas/mpt3sas_ctl.c |4 ++- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 47 + > 5 files changed, 70 insertions(+), 10 deletions(-) Please be sure you have appropriate Signed

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

2017-01-20 Thread Johannes Thumshirn
t we'd need is a link to know "we've sent 10 requests out, now poll for the 10 completions after the 1st IRQ". So basically what NVMe already did with calling __nvme_process_cq() after submission. Maybe we should even disable IRQs when submitting and re-enable after submitting

Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

2017-01-20 Thread Johannes Thumshirn
func, where func is func() { spin_lock(); __func(); spin_unlock(); } -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane S

Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

2017-01-20 Thread Johannes Thumshirn
at > optimal speed. > > Signed-off-by: Chaitra P B > Signed-off-by: Suganath Prabu S > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Ma

Re: [PATCH v2 4/4] mpt3sas: Updating driver version to v15.100.00.00

2017-01-20 Thread Johannes Thumshirn
On Fri, Jan 20, 2017 at 08:12:13PM +0530, Chaitra P B wrote: > > Signed-off-by: Chaitra P B > Signed-off-by: Suganath Prabu S > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH v2 3/4] mpt3sas: Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test.

2017-01-20 Thread Johannes Thumshirn
->ReplyPostHostIndex); > + } > + completed_cmds = 1; > + } > if (request_desript_type == MPI2_RPY_DESCRIPT_FLAGS_UNUSED) > goto out; > if (!reply_q->reply_post_host_index) Do I u

Re: [PATCH 12/16] scsi: remove __scsi_alloc_queue

2017-01-24 Thread Johannes Thumshirn
On Mon, Jan 23, 2017 at 04:29:17PM +0100, Christoph Hellwig wrote: > Instead do an internal export of __scsi_init_queue for the transport > classes that export BSG nodes. > > Signed-off-by: Christoph Hellwig > --- Looks good, Reviewed-by: Johannes Thumshirn -- Joh

Re: [PATCH v3 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

2017-01-24 Thread Johannes Thumshirn
unsigned long flags; struct scsi_cmnd *scmnd; spin_lock_irqsave(&ioc->scsi_lookup_lock, flags); - scmd = ioc->scsi_lookup[smid - 1].scmd; - ioc->scsi_lookup[smid - 1].scmd = NULL; + scmnd = __scsih_scsi_lookup_get_clear(ioc, smid); spin_unloc

Re: [PATCH v3 3/4] mpt3sas: Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test.

2017-01-24 Thread Johannes Thumshirn
->ReplyPostHostIndex); > + } > + completed_cmds = 1; > + } > if (request_desript_type == MPI2_RPY_DESCRIPT_FLAGS_UNUSED) > goto out; > if (!reply_q->reply_post_host_index)

Re: [PATCH 09/16] scsi: remove gfp_flags member in scsi_host_cmd_pool

2017-01-24 Thread Johannes Thumshirn
A flag to > kmem_cache_alloc. Drop all the infrastructure for doing so. > > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE L

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-24 Thread Johannes Thumshirn
si: qla2xxx: Utilize > pci_alloc_irq_vectors/pci_free_irq_vectors calls") > Signed-off-by: Bart Van Assche > Cc: Michael Hernandez > Cc: Himanshu Madhani > Cc: Christoph Hellwig > Cc: > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

2017-01-24 Thread Johannes Thumshirn
invalid DMA access after command aborts in > PCI device remove") > Signed-off-by: Bart Van Assche > Cc: Naresh Bannoth > Cc: Mauricio Faria de Oliveira > Cc: Himanshu Madhani > Cc: > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH] sd: always scan VPD pages if thin provisioning is enabled

2017-01-24 Thread Johannes Thumshirn
evices which > have the LBPME bit set in the output of READ CAPACITY(16)) need > to support VPD pages. So this patch always enables VPD pages > even for older SCSI revisions if thin provisioning is enabled. > > Signed-off-by: Hannes Reinecke > --- Looks good, Reviewed-by: Joh

Re: [PATCH v3 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

2017-01-26 Thread Johannes Thumshirn
d-off-by: Suganath Prabu S > --- Sorry for misreading the patch, it's exactly what I've requestd. Therefore: Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689

Re: [PATCH v3 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

2017-01-26 Thread Johannes Thumshirn
at > optimal speed. > > Signed-off-by: Chaitra P B > Signed-off-by: Suganath Prabu S > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Ma

Re: [PATCH V2 01/24] aacraid: Remove duplicate irq management code

2017-01-26 Thread Johannes Thumshirn
s' is two different things so it should be split into two different patches ;-). But if noone else objects: Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE L

Re: [PATCH V2 02/24] aacraid: Added aacraid.h include guard

2017-01-26 Thread Johannes Thumshirn
On Wed, Jan 25, 2017 at 10:00:49AM -0800, Raghava Aditya Renukunta wrote: > Added aacraid.h include guard > > Signed-off-by: Raghava Aditya Renukunta > > Signed-off-by: Dave Carroll > > --- Reviewed-by: Johannes Thumshirn -

Re: [PATCH V2 03/24] aacraid: added support for init_struct_8

2017-01-26 Thread Johannes Thumshirn
; + } rrq[1]; /* up to 64 RRQ addresses */ > + } r8; > }; Is this CamelCase pollution really needed? You're touching it anyways, so wouldn't it be a great chance to run sed -e 's/\([A-Z]\)/_\l\1/g' -e 's/^_\([a-z]\)/\1/g' on the new structures? [...]

Re: [PATCH V2 04/24] aacraid: Added sa firmware support

2017-01-26 Thread Johannes Thumshirn
e + AAC_NUM_MGT_FIB) / > - msi_count; > + if (dev->comm_interface == AAC_COMM_MESSAGE_TYPE3 && dev->sa_firmware) > + dev->vector_cap = (dev->scsi_host_ptr->can_queue + > + AAC_NUM_MGT_FIB); '+'

Re: [PATCH V2 05/24] aacraid: Retrieve and update the device types

2017-01-26 Thread Johannes Thumshirn
for Thor */ > + __le16 VirtDeviceTarget; > + __le16 VirtDeviceLUN; > + __le16 Unused; > + __le32 ReservedForFutureGrowth[68]; > + :-( Appart from that, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...

Re: [PATCH V2 06/24] aacraid: Reworked scsi command submission path

2017-01-26 Thread Johannes Thumshirn
On Wed, Jan 25, 2017 at 10:00:53AM -0800, Raghava Aditya Renukunta wrote: > Moved the READ and WRITE switch cases to the top. Added a default > case to the switch case and replaced duplicate scsi result value with a > macro. Can you please explain why you did the changes as well? --

Re: [PATCH V2 07/24] aacraid: Process Error for response I/O

2017-01-26 Thread Johannes Thumshirn
; > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N

Re: [PATCH V2 05/24] aacraid: Retrieve and update the device types

2017-01-27 Thread Johannes Thumshirn
nuary 26, 2017 10:44 AM > > To: Johannes Thumshirn > > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > > s...@vger.kernel.org; Dave Carroll ; Gana > > Sridaran ; Scott Benesh > > > > Subject: RE: [PATCH V2 05/24] aacraid: Retrieve and update the

Re: [PATCH V3 03/24] aacraid: added support for init_struct_8

2017-01-30 Thread Johannes Thumshirn
d is used for both > Series-8, HBA-1000 and SmartIOC-2000. > > Signed-off-by: Raghava Aditya Renukunta > > Signed-off-by: Dave Carroll > > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH V3 06/24] aacraid: Reworked scsi command submission path

2017-01-30 Thread Johannes Thumshirn
; Signed-off-by: Dave Carroll > > --- I really whished this one had a better commit message (not only explaining what you've changes but also why you did it). But if this is the only issue there's hardly a reason to repost. Reviewed-by: Johann

Re: [PATCH V3 04/24] aacraid: Added sa firmware support

2017-01-30 Thread Johannes Thumshirn
; > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N

Re: [PATCH V3 08/24] aacraid: Added support for response path

2017-01-30 Thread Johannes Thumshirn
> +unsigned int aac_intr_normal(struct aac_dev *dev, u32 index, int isAif, > + int isFastResponse, struct hw_fib *aif_fib) Isn't this exactly the same but now with broken indent? [...] -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH V3 05/24] aacraid: Retrieve and update the device types

2017-01-30 Thread Johannes Thumshirn
oll > Reviewed-by: Johannes Thumshirn > > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendör

Re: [PATCH V3 09/24] aacraid: Added support for read medium error

2017-01-30 Thread Johannes Thumshirn
On Fri, Jan 27, 2017 at 11:28:38AM -0800, Raghava Aditya Renukunta wrote: > This patch processes Raw IO read medium errors. > > Signed-off-by: Raghava Aditya Renukunta > > Signed-off-by: Dave Carroll > > --- Reviewed-by: Johannes Thumshirn -

Re: [PATCH V3 12/24] aacraid: Retrieve Queue Depth from Adapter FW

2017-01-30 Thread Johannes Thumshirn
efine AAC_NUM_IO_FIB (1024 - AAC_NUM_MGT_FIB) > #define AAC_NUM_FIB (AAC_NUM_IO_FIB + AAC_NUM_MGT_FIB) > > -#define AAC_MAX_LUN (8) > +#define AAC_MAX_LUN (256) > > #define AAC_MAX_HOSTPHYSMEMPAGES (0xf) > #define AAC_MAX_32BIT_SGBCOUNT

Re: [PATCH V3 13/24] aacraid: Added support to set QD of attached drives

2017-01-30 Thread Johannes Thumshirn
} > - if (num_lsu == 0) > - ++num_lsu; > - depth = (host->can_queue - num_one) / num_lsu; > - if (depth > 256) > - depth = 256; > - else if (depth < 2) > - dep

Re: [PATCH V3 10/24] aacraid: Reworked aac_command_thread

2017-01-30 Thread Johannes Thumshirn
(ST_OK); > + aac_fib_adapter_complete(fib, sizeof(u32)); > + spin_unlock_irqrestore(&dev->fib_lock, flagv); > + /* Free up the remaining resources */ > + hw_fib_p = hw_fib_pool; > + fib_p = fib_pool; > +

Re: [PATCH V3 11/24] aacraid: Added support for periodic wellness sync

2017-01-30 Thread Johannes Thumshirn
> - /* FIB should be freed only after > - * getting the response from the F/W */ > - if (status != -ERESTARTSYS) > - aac_fib_free(fibptr)

Re: [PATCH V3 15/24] aacraid: Include HBA direct interface

2017-01-30 Thread Johannes Thumshirn
YPE_SCSI_CMD_REQ, srbfib, > + NULL, NULL); > + > + } else if (dev->adapter_info.options & AAC_OPT_SGMAP_HOST64) { > struct user_sgmap64* upsg = (struct > user_sgmap64*)&user_srbcmd->sg; > struct sgmap

Re: [PATCH V3 16/24] aacraid: Add task management functionality

2017-01-30 Thread Johannes Thumshirn
} else { > + /* not embedded */ > + hbacmd->sge[0].flags = cpu_to_le32(0x8000); > + hbacmd->emb_data_desc_count = (u8)cpu_to_le32(1); > + hbacmd->sge[0].addr_hi = > +

Re: [PATCH V3 17/24] aacraid: Added support to abort cmd and reset lun

2017-01-30 Thread Johannes Thumshirn
ed-off-by: Dave Carroll > > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard

Re: [PATCH V3 19/24] aacraid: Added new IWBR reset

2017-01-30 Thread Johannes Thumshirn
al; struct aac_dev *adap = shost_priv(class_to_shost(device)); int bled = buf[0] == "!"; retval = aac_reset_adapter(adap, bled, IOP_HWSOFT_RESET); > - retval = aac_reset_adapter((struct > aac_dev*)class_to_shost(device)->hostdata, buf[0] == '!

Re: [PATCH V3 20/24] aacraid: Added ioctl to trigger IOP/IWBR reset

2017-01-30 Thread Johannes Thumshirn
f-by: Dave Carroll > > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH V3 21/24] aacraid: Retrieve HBA host information ioctl

2017-01-30 Thread Johannes Thumshirn
mInterface:1; > + u8 NewCommandsSupported:1; > + u8 DisablePassthrough:1; > + u8 ExposeNonDasd:1; > + u8 QueueAllowed:1; > + u8 BLEDCheckEnabled:1; > + u8 reserved1:1; > + u8 reserted2:1; > + &g

Re: [PATCH V3 23/24] aacraid: Change Driver Version Prefix

2017-01-30 Thread Johannes Thumshirn
On Fri, Jan 27, 2017 at 11:28:52AM -0800, Raghava Aditya Renukunta wrote: > Change the aacraid driver prefix from 1.2-1 to 1.2.1 > > Signed-off-by: Raghava Aditya Renukunta > > Signed-off-by: Dave Carroll > > --- Reviewed-by: Johannes Thumshirn -

Re: [PATCH V3 22/24] aacraid: Update copyrights

2017-01-30 Thread Johannes Thumshirn
On Fri, Jan 27, 2017 at 11:28:51AM -0800, Raghava Aditya Renukunta wrote: > Added new copyright messages > > Signed-off-by: Raghava Aditya Renukunta > > Signed-off-by: Dave Carroll > > --- Reviewed-by: Johannes Thumshirn -

Re: [PATCH V3 24/24] aacraid: update version

2017-01-30 Thread Johannes Thumshirn
On Fri, Jan 27, 2017 at 11:28:53AM -0800, Raghava Aditya Renukunta wrote: > Update the driver version to 50740 > > Signed-off-by: Raghava Aditya Renukunta > > Signed-off-by: Dave Carroll > > --- Reviewed-by: Johannes Thumshirn -

Re: [PATCH V3 08/24] aacraid: Added support for response path

2017-01-31 Thread Johannes Thumshirn
On Mon, Jan 30, 2017 at 08:16:48PM +, Raghava Aditya Renukunta wrote: > > > > -Original Message- > > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > > Sent: Monday, January 30, 2017 1:50 AM > > To: Raghava Aditya Renukunta > > > >

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread Johannes Thumshirn
0:00:00 2001 From: Johannes Thumshirn Date: Tue, 31 Jan 2017 10:16:00 +0100 Subject: [PATCH] scsi: don't BUG_ON() empty DMA transfers Don't crash the machine just because of an empty transfer. Use WARN_ON() combined with returning an error. Signed-off-by: Johannes Thumshirn --- drivers

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread Johannes Thumshirn
On Tue, Jan 31, 2017 at 10:50:49AM +0100, Dmitry Vyukov wrote: > On Tue, Jan 31, 2017 at 10:20 AM, Johannes Thumshirn > wrote: > > On Tue, Jan 31, 2017 at 09:55:52AM +0100, Dmitry Vyukov wrote: [...] > Please-please-please, let's not use WARN for something that is not a

Re: [PATCH] sg: protect access to to 'reserved' page array

2017-02-01 Thread Johannes Thumshirn
to protect it against concurrent accesses. > > Cc: sta...@vger.kernel.org > Reported-by: Dmitry Vyukov > Link: http://www.spinics.net/lists/linux-scsi/msg104326.html > Signed-off-by: Hannes Reinecke > Tested-by: Johannes Thumshirn > --- Rev

Re: [PATCH] sg: protect access to to 'reserved' page array

2017-02-01 Thread Johannes Thumshirn
t; b) a flag is a reservations is in use I did have a patch doing exactly that but (appart from lockdep complaints) we decided to drop it, as it made the code even more confusing. -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH V4 08/24] aacraid: Added support for response path

2017-02-03 Thread Johannes Thumshirn
: Johannes Thumshirn

Re: [PATCH V4 10/24] aacraid: Reworked aac_command_thread

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 12:53 AM, Raghava Aditya Renukunta wrote: Reworked aac_command_thread into aac_process_events Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Reviewed-by: Johannes Thumshirn

Re: [PATCH V4 11/24] aacraid: Added support for periodic wellness sync

2017-02-03 Thread Johannes Thumshirn
Aditya Renukunta Signed-off-by: Dave Carroll --- Reviewed-by: Johannes Thumshirn

Re: [PATCH V4 12/24] aacraid: Retrieve Queue Depth from Adapter FW

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 12:53 AM, Raghava Aditya Renukunta wrote: Retrieved queue depth from fw and saved it for future use. Only applicable for HBA1000 drives. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Reviewed-by: Johannes Thumshirn

Re: [PATCH V4 13/24] aacraid: Added support to set QD of attached drives

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 12:53 AM, Raghava Aditya Renukunta wrote: Added support to set qd of drives in slave_configure.This only works for HBA1000 attached drives. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Reviewed-by: Johannes Thumshirn

Re: [PATCH V4 14/24] aacraid: Added support for hotplug

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 12:53 AM, Raghava Aditya Renukunta wrote: Added support for drive hotplug add and removal Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Reviewed-by: Johannes Thumshirn

Re: [PATCH V4 16/24] aacraid: Add task management functionality

2017-02-03 Thread Johannes Thumshirn
) +{ + struct aac_hba_cmd_req *hbacmd = aac_construct_hbacmd(fib, cmd); + struct aac_dev *dev; + // u16 fibsize; Here you missed one ;-) Anyways, Reviewed-by: Johannes Thumshirn

Re: [PATCH V4 18/24] aacraid: VPD 83 type3 support

2017-02-03 Thread Johannes Thumshirn
Aditya Renukunta Signed-off-by: Dave Carroll --- Reviewed-by: Johannes Thumshirn

Re: [PATCH V4 19/24] aacraid: Added new IWBR reset

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 12:53 AM, Raghava Aditya Renukunta wrote: Added a new IWBR soft reset type, reworked the IOP reset interface for a bit. Signed-off-by: Raghava Aditya Renukunta Signed-off-by: Dave Carroll --- Reviewed-by: Johannes Thumshirn

Re: [PATCH 1/4] sg: disable SET_FORCE_LOW_DMA

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 09:54 AM, Hannes Reinecke wrote: The ioctl SET_FORCE_LOW_DMA has never worked since the initial git check-in, and the respective setting is nowadays handled correctly. So disable it entirely. Signed-off-by: Hannes Reinecke --- [...] case SG_SET_FORCE_LOW_DMA: -

Re: [PATCH 2/4] sg: protect access to to 'reserved' page array

2017-02-03 Thread Johannes Thumshirn
t accesses. Cc: sta...@vger.kernel.org Reported-by: Dmitry Vyukov Link: http://www.spinics.net/lists/linux-scsi/msg104326.html Signed-off-by: Hannes Reinecke Tested-by: Johannes Thumshirn --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storag

Re: [PATCH 4/4] sg: use standard lists for sg_requests

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 09:54 AM, Hannes Reinecke wrote: 'Sg_request' is using a private list implementation; convert it to standard lists. Signed-off-by: Hannes Reinecke --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Stora

Re: [PATCHv2 1/6] sg: disable SET_FORCE_LOW_DMA

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 01:18 PM, Hannes Reinecke wrote: The ioctl SET_FORCE_LOW_DMA has never worked since the initial git check-in, and the respective setting is nowadays handled correctly. So disable it entirely. Signed-off-by: Hannes Reinecke --- Reviewed-by: Johannes Thumshirn

Re: [PATCHv2 2/6] sg: remove 'save_scat_len'

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 01:18 PM, Hannes Reinecke wrote: Unused. Signed-off-by: Hannes Reinecke --- Reviewed-by: Johannes Thumshirn

Re: [PATCHv2 3/6] sg: protect accesses to 'reserved' page array

2017-02-03 Thread Johannes Thumshirn
tect 'sg_fd' against concurrent accesses. Signed-off-by: Hannes Reinecke --- Tested-by: Johannes Thumshirn Reviewed-by: Johannes Thumshirn

Re: [PATCHv2 4/6] sg: check for valid direction before starting the request

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 01:18 PM, Hannes Reinecke wrote: From: Johannes Thumshirn Check for a valid direction before starting the request, otherwise we risk running into an assertion in the scsi midlayer checking for vaild requests. Signed-off-by: Johannes Thumshirn Link: http://www.spinics.net/lists

Re: [PATCHv2 5/6] sg: use standard lists for sg_requests

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 01:18 PM, Hannes Reinecke wrote: 'Sg_request' is using a private list implementation; convert it to standard lists. Signed-off-by: Hannes Reinecke --- [..] static bool sg_is_valid_dxfer(sg_io_hdr_t *hp) { - switch (dxfer_direction) { + switch (hp->dxfer_dire

Re: [PATCHv2 0/6] sanitize sg

2017-02-03 Thread Johannes Thumshirn
sg: close race condition in sg_remove_sfp_usercontext() Johannes Thumshirn (1): sg: check for valid direction before starting the request drivers/scsi/sg.c | 284 +++--- include/scsi/sg.h | 1 - 2 files changed, 141 insertions(+), 144 deletions(-)

Re: [PATCHv3 3/6] sg: protect accesses to 'reserved' page array

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 05:19 PM, Christoph Hellwig wrote: On Fri, Feb 03, 2017 at 02:38:35PM +0100, Hannes Reinecke wrote: On 02/03/2017 02:31 PM, Christoph Hellwig wrote: - if (sg_res_in_use(sfp)) { + mutex_lock(&sfp->f_mutex); + if (sfp->res_in_use) { +

Re: [PATCHv1] net-next: treewide use is_vlan_dev() helper function.

2017-02-05 Thread Johannes Thumshirn
On 02/04/2017 06:00 PM, Parav Pandit wrote: This patch makes use of is_vlan_dev() function instead of flag comparison which is exactly done by is_vlan_dev() helper function. Signed-off-by: Parav Pandit Reviewed-by: Daniel Jurgens --- For drivers/scsi/fcoe/fcoe.c: Acked-by: Johannes

Re: [PATCH v2 01/18] lpfc: Correct WQ creation for pagesize

2017-02-07 Thread Johannes Thumshirn
+#define LPFC_RQ_PAGE_SIZE_4096 0x1 I wonder why do we need the two LPFC_RQ_PAGE_SIZE_4096 and LPFC_WQ_PAGE_SIZE_4096 both being 1? Wouldn't a more global LPFC_PAGE_SIZE_4096 or LPFC_Q_PAGE_SIZE_4096 be sufficient? But I don't have a strong opinion on this either. Otherwise, Reviewed-by:

Re: [PATCH v2 02/18] lpfc: use pci_irq_alloc_vectors and pci_irq_free_vectors

2017-02-07 Thread Johannes Thumshirn
> Signed-off-by: Christoph Hellwig > Signed-off-by: James Smart > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N

Re: [PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E

2017-02-07 Thread Johannes Thumshirn
les than > just lpfc_sli.c Yes but patch 03/18 'lpfc: NVME Initiator: Base modifications Part A' still has calls to lpfc_sli_hbq_count(phba) (and in fact introduces this change). -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits

2017-02-07 Thread Johannes Thumshirn
_8") > Fixes: 423400e64d37 ("scsi: aacraid: Include HBA direct interface") > Signed-off-by: Arnd Bergmann > --- The coolest thing with your patches is, one gets to know new cool functions/macros. Anyways looks good, Reviewed-by: Johannes Thumshirn -- Johannes Th

Re: [PATCH v3 03/16] lpfc: minor code cleanups

2017-02-13 Thread Johannes Thumshirn
on stack > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr.

Re: [PATCH v3 15/16] lpfc: Update copyrights

2017-02-13 Thread Johannes Thumshirn
On 02/12/2017 10:52 PM, James Smart wrote: > > Update copyrights to 2017 for all files touched in this patch set > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH v3 16/16] lpfc: Update lpfc version to 11.2.0.7

2017-02-13 Thread Johannes Thumshirn
On 02/12/2017 10:52 PM, James Smart wrote: > > Update lpfc version to 11.2.0.7 > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage

<    1   2   3   4   5   6   7   8   9   10   >