On Fri, Jan 13, 2017 at 11:40:01AM +0800, Fam Zheng wrote:
> The parameter name should be wwpn instead of wwnn.
>
> Signed-off-by: Fam Zheng
> ---
Yup, looks good
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthums
[+Cc James S. I'm sorry]
On Tue, Jan 10, 2017 at 12:05:54PM +0100, Johannes Thumshirn wrote:
> Set the elsiocb contexts to NULL after freeing as others depend on it.
>
> Signed-off-by: Johannes Thumshirn
> ---
> drivers/scsi/lpfc/lpfc_els.c | 2 ++
> 1 file changed, 2
On Wed, Jan 11, 2017 at 08:13:02AM -0700, Jens Axboe wrote:
> On 01/11/2017 08:07 AM, Jens Axboe wrote:
> > On 01/11/2017 06:43 AM, Johannes Thumshirn wrote:
> >> Hi all,
> >>
> >> I'd like to attend LSF/MM and would like to discuss polling for block
>
835831c57e9b ("ses: use scsi_is_sas_rphy instead of
> Ewan> is_sas_attached") Reviewed-by: Johannes Thumshirn
> Ewan> Signed-off-by: Ewan D. Milne
> Ewan> ---
> Ewan> drivers/scsi/ses.c | 2 +- 1 file changed, 1 insertion(+), 1
> Ewan> deletion(-)
>
>
target segfault with other FC storage present
sanmac isn't required
Hannes Reinecke (3):
fcoemon: fixup log_nlmsg_error()
fcoemon: Add debugging message for 'recv'
Fallback to default MAC address for FIP
Johannes Thumshirn (2):
fcoeadm: Fix possible buf
s, as expected.
[1] lib/irq_poll.c:13
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham N
t; + chann = (chann % phba->cfg_fcp_max_hw_queue);
No need for the parenthesis.
[...]
> @@ -4959,11 +4968,11 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct
> scsi_cmnd *cmnd,
> int status;
>
> rdata = lpfc_rport_data_from_scsi_device(cmnd->device);
> -
}
> + spin_lock_irq(lock);
> + }
> + spin_unlock_irq(lock);
> + return 1;
> +}
> +
Aren't you using lpc_emptyq_wait() in patches prior to that already? This
breaks git bisect. Pleas test-build (ideally + checkpatch and sparse/smatch)
each patch
LPFC_WQE128_DEF_COUNT);
> + } else {
> + qdesc = lpfc_sli4_queue_alloc(phba,
> + phba->sli4_hba.wq_esize,
> + phba->sli
mplete Queue */
> + if (!phba->sli4_hba.nvme_cq) {
Hint, if you write a comment what the specific code block is doing, you might
actually write a function. Here sth. like 'lpfc_nvme_setup_fast_path_cq()'
comes to my mind. Especially if you have to use more than 3 levels
fact
> that drivers can poll more than their given budget?
So what you say is you saw a consomed == 1 [1] most of the time?
[1] from
http://git.infradead.org/nvme.git/commitdiff/eed5a9d925c59e43980047059fde29e3aa0b7836
--
Johannes Thumshirn Storage
jthu
UE_OK;
out_cleanup_iod:
nvme_free_iod(dev, req);
out_free_cmd:
nvme_cleanup_cmd(req);
return ret;
}
So we're draining the CQ on submit. This of cause makes polling for
completions in the IRQ handler rather pointless as we already did in the
submission path.
--
Johannes Thu
gt;return ret;
> >}
> >
> >So we're draining the CQ on submit. This of cause makes polling for
> >completions in the IRQ handler rather pointless as we already did in the
> >submission path.
>
> I think you
On Wed, Jan 18, 2017 at 06:34:02PM -0800, James Smart wrote:
>
>
> On 1/18/2017 1:50 AM, Johannes Thumshirn wrote:
>
> >>@@ -4959,11 +4968,11 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct
> >>scsi_cmnd *cmnd,
> >>int status;
> >>
On Wed, Jan 18, 2017 at 06:45:46PM -0800, James Smart wrote:
>
>
> On 1/18/2017 2:11 AM, Johannes Thumshirn wrote:
> >On Tue, Jan 17, 2017 at 05:20:46PM -0800, James Smart wrote:
> >>NVME Initiator: Base modifications
> >>
> >>This is part B of
On Wed, Jan 18, 2017 at 06:54:37PM -0800, James Smart wrote:
>
>
> On 1/18/2017 3:03 AM, Johannes Thumshirn wrote:
> >
> >>+ /* maximum number of xris available for nvme buffers */
> >>+ els_xri_cnt = lpfc_sli4_get_els_iocb_cnt(phba);
> >
may cause some IO timeouts.
>
> We need to periodically configure the SAS controller so it
> doesn't receive STP setup requests from SATA disks for a while,
> so IO can be sent during this period.
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
> ---
Looks good,
lt;< ITCT_HDR_VALID_OFF) |
> (device->linkrate << ITCT_HDR_MCR_OFF) |
> (1 << ITCT_HDR_VLN_OFF) |
> + (0xfa << ITCT_HDR_SMP_TIMEOUT_OFF) |
^~ You may want to give that magic value a name.
Other
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
K
ohn Garry
> ---
Looks OK,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB
igned-off-by: Xiang Chen
> Signed-off-by: John Garry
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnbe
On Thu, Jan 19, 2017 at 12:32:50AM +0800, John Garry wrote:
> From: Xiang Chen
>
> Correctly set registers in v2 for root PHY hardreset for directly
> attached disk.
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
> ---
Looks good,
Reviewed-by: Johannes
On Thu, Jan 19, 2017 at 12:32:51AM +0800, John Garry wrote:
> Downgrade the exit print in hisi_sas_internal_task_abort()
> to dbg level, as info is not required.
>
> Signed-off-by: John Garry
> Reviewed-by: Xiang Chen
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
eded in order for it to
> work well. I know that some networking drivers implemented adaptive
> moderation in SW before having HW support for it. It can be done by
> maintaining stats and having a periodic work that looks at it and
> changes the mode
that sounds reasonable to
you guys as well?
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham
5 deletions(-)
Otherwise,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graha
rs/scsi/mpt3sas/mpt3sas_base.h |7 +++--
> drivers/scsi/mpt3sas/mpt3sas_ctl.c |4 ++-
> drivers/scsi/mpt3sas/mpt3sas_scsih.c | 47 +
> 5 files changed, 70 insertions(+), 10 deletions(-)
Please be sure you have appropriate Signed
t we'd need is a link to know "we've sent 10 requests out, now poll for the
10 completions after the 1st IRQ". So basically what NVMe already did with
calling __nvme_process_cq() after submission. Maybe we should even disable
IRQs when submitting and re-enable after submitting
func,
where func is
func()
{
spin_lock();
__func();
spin_unlock();
}
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane S
at
> optimal speed.
>
> Signed-off-by: Chaitra P B
> Signed-off-by: Suganath Prabu S
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Ma
On Fri, Jan 20, 2017 at 08:12:13PM +0530, Chaitra P B wrote:
>
> Signed-off-by: Chaitra P B
> Signed-off-by: Suganath Prabu S
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
->ReplyPostHostIndex);
> + }
> + completed_cmds = 1;
> + }
> if (request_desript_type == MPI2_RPY_DESCRIPT_FLAGS_UNUSED)
> goto out;
> if (!reply_q->reply_post_host_index)
Do I u
On Mon, Jan 23, 2017 at 04:29:17PM +0100, Christoph Hellwig wrote:
> Instead do an internal export of __scsi_init_queue for the transport
> classes that export BSG nodes.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Joh
unsigned long flags;
struct scsi_cmnd *scmnd;
spin_lock_irqsave(&ioc->scsi_lookup_lock, flags);
- scmd = ioc->scsi_lookup[smid - 1].scmd;
- ioc->scsi_lookup[smid - 1].scmd = NULL;
+ scmnd = __scsih_scsi_lookup_get_clear(ioc, smid);
spin_unloc
->ReplyPostHostIndex);
> + }
> + completed_cmds = 1;
> + }
> if (request_desript_type == MPI2_RPY_DESCRIPT_FLAGS_UNUSED)
> goto out;
> if (!reply_q->reply_post_host_index)
A flag to
> kmem_cache_alloc. Drop all the infrastructure for doing so.
>
> Signed-off-by: Christoph Hellwig
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE L
si: qla2xxx: Utilize
> pci_alloc_irq_vectors/pci_free_irq_vectors calls")
> Signed-off-by: Bart Van Assche
> Cc: Michael Hernandez
> Cc: Himanshu Madhani
> Cc: Christoph Hellwig
> Cc:
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
invalid DMA access after command aborts in
> PCI device remove")
> Signed-off-by: Bart Van Assche
> Cc: Naresh Bannoth
> Cc: Mauricio Faria de Oliveira
> Cc: Himanshu Madhani
> Cc:
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
evices which
> have the LBPME bit set in the output of READ CAPACITY(16)) need
> to support VPD pages. So this patch always enables VPD pages
> even for older SCSI revisions if thin provisioning is enabled.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Reviewed-by: Joh
d-off-by: Suganath Prabu S
> ---
Sorry for misreading the patch, it's exactly what I've requestd.
Therefore:
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
at
> optimal speed.
>
> Signed-off-by: Chaitra P B
> Signed-off-by: Suganath Prabu S
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Ma
s' is two different things so it
should be split into two different patches ;-). But if noone else objects:
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE L
On Wed, Jan 25, 2017 at 10:00:49AM -0800, Raghava Aditya Renukunta wrote:
> Added aacraid.h include guard
>
> Signed-off-by: Raghava Aditya Renukunta
>
> Signed-off-by: Dave Carroll
>
> ---
Reviewed-by: Johannes Thumshirn
-
; + } rrq[1]; /* up to 64 RRQ addresses */
> + } r8;
> };
Is this CamelCase pollution really needed? You're touching it anyways, so
wouldn't it be a great chance to run
sed -e 's/\([A-Z]\)/_\l\1/g' -e 's/^_\([a-z]\)/\1/g'
on the new structures?
[...]
e + AAC_NUM_MGT_FIB) /
> - msi_count;
> + if (dev->comm_interface == AAC_COMM_MESSAGE_TYPE3 && dev->sa_firmware)
> + dev->vector_cap = (dev->scsi_host_ptr->can_queue +
> + AAC_NUM_MGT_FIB);
'+'
for Thor */
> + __le16 VirtDeviceTarget;
> + __le16 VirtDeviceLUN;
> + __le16 Unused;
> + __le32 ReservedForFutureGrowth[68];
> +
:-(
Appart from that,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...
On Wed, Jan 25, 2017 at 10:00:53AM -0800, Raghava Aditya Renukunta wrote:
> Moved the READ and WRITE switch cases to the top. Added a default
> case to the switch case and replaced duplicate scsi result value with a
> macro.
Can you please explain why you did the changes as well?
--
;
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
nuary 26, 2017 10:44 AM
> > To: Johannes Thumshirn
> > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> > s...@vger.kernel.org; Dave Carroll ; Gana
> > Sridaran ; Scott Benesh
> >
> > Subject: RE: [PATCH V2 05/24] aacraid: Retrieve and update the
d is used for both
> Series-8, HBA-1000 and SmartIOC-2000.
>
> Signed-off-by: Raghava Aditya Renukunta
>
> Signed-off-by: Dave Carroll
>
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
; Signed-off-by: Dave Carroll
>
> ---
I really whished this one had a better commit message (not only explaining
what you've changes but also why you did it).
But if this is the only issue there's hardly a reason to repost.
Reviewed-by: Johann
;
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
> +unsigned int aac_intr_normal(struct aac_dev *dev, u32 index, int isAif,
> + int isFastResponse, struct hw_fib *aif_fib)
Isn't this exactly the same but now with broken indent?
[...]
--
Johannes Thumshirn Storage
jthumsh...@suse.de
oll
> Reviewed-by: Johannes Thumshirn
>
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendör
On Fri, Jan 27, 2017 at 11:28:38AM -0800, Raghava Aditya Renukunta wrote:
> This patch processes Raw IO read medium errors.
>
> Signed-off-by: Raghava Aditya Renukunta
>
> Signed-off-by: Dave Carroll
>
> ---
Reviewed-by: Johannes Thumshirn
-
efine AAC_NUM_IO_FIB (1024 - AAC_NUM_MGT_FIB)
> #define AAC_NUM_FIB (AAC_NUM_IO_FIB + AAC_NUM_MGT_FIB)
>
> -#define AAC_MAX_LUN (8)
> +#define AAC_MAX_LUN (256)
>
> #define AAC_MAX_HOSTPHYSMEMPAGES (0xf)
> #define AAC_MAX_32BIT_SGBCOUNT
}
> - if (num_lsu == 0)
> - ++num_lsu;
> - depth = (host->can_queue - num_one) / num_lsu;
> - if (depth > 256)
> - depth = 256;
> - else if (depth < 2)
> - dep
(ST_OK);
> + aac_fib_adapter_complete(fib, sizeof(u32));
> + spin_unlock_irqrestore(&dev->fib_lock, flagv);
> + /* Free up the remaining resources */
> + hw_fib_p = hw_fib_pool;
> + fib_p = fib_pool;
> +
> - /* FIB should be freed only after
> - * getting the response from the F/W */
> - if (status != -ERESTARTSYS)
> - aac_fib_free(fibptr)
YPE_SCSI_CMD_REQ, srbfib,
> + NULL, NULL);
> +
> + } else if (dev->adapter_info.options & AAC_OPT_SGMAP_HOST64) {
> struct user_sgmap64* upsg = (struct
> user_sgmap64*)&user_srbcmd->sg;
> struct sgmap
} else {
> + /* not embedded */
> + hbacmd->sge[0].flags = cpu_to_le32(0x8000);
> + hbacmd->emb_data_desc_count = (u8)cpu_to_le32(1);
> + hbacmd->sge[0].addr_hi =
> +
ed-off-by: Dave Carroll
>
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard
al;
struct aac_dev *adap = shost_priv(class_to_shost(device));
int bled = buf[0] == "!";
retval = aac_reset_adapter(adap, bled, IOP_HWSOFT_RESET);
> - retval = aac_reset_adapter((struct
> aac_dev*)class_to_shost(device)->hostdata, buf[0] == '!
f-by: Dave Carroll
>
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB
mInterface:1;
> + u8 NewCommandsSupported:1;
> + u8 DisablePassthrough:1;
> + u8 ExposeNonDasd:1;
> + u8 QueueAllowed:1;
> + u8 BLEDCheckEnabled:1;
> + u8 reserved1:1;
> + u8 reserted2:1;
> +
&g
On Fri, Jan 27, 2017 at 11:28:52AM -0800, Raghava Aditya Renukunta wrote:
> Change the aacraid driver prefix from 1.2-1 to 1.2.1
>
> Signed-off-by: Raghava Aditya Renukunta
>
> Signed-off-by: Dave Carroll
>
> ---
Reviewed-by: Johannes Thumshirn
-
On Fri, Jan 27, 2017 at 11:28:51AM -0800, Raghava Aditya Renukunta wrote:
> Added new copyright messages
>
> Signed-off-by: Raghava Aditya Renukunta
>
> Signed-off-by: Dave Carroll
>
> ---
Reviewed-by: Johannes Thumshirn
-
On Fri, Jan 27, 2017 at 11:28:53AM -0800, Raghava Aditya Renukunta wrote:
> Update the driver version to 50740
>
> Signed-off-by: Raghava Aditya Renukunta
>
> Signed-off-by: Dave Carroll
>
> ---
Reviewed-by: Johannes Thumshirn
-
On Mon, Jan 30, 2017 at 08:16:48PM +, Raghava Aditya Renukunta wrote:
>
>
> > -Original Message-
> > From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> > Sent: Monday, January 30, 2017 1:50 AM
> > To: Raghava Aditya Renukunta
> >
> >
0:00:00 2001
From: Johannes Thumshirn
Date: Tue, 31 Jan 2017 10:16:00 +0100
Subject: [PATCH] scsi: don't BUG_ON() empty DMA transfers
Don't crash the machine just because of an empty transfer. Use WARN_ON()
combined with returning an error.
Signed-off-by: Johannes Thumshirn
---
drivers
On Tue, Jan 31, 2017 at 10:50:49AM +0100, Dmitry Vyukov wrote:
> On Tue, Jan 31, 2017 at 10:20 AM, Johannes Thumshirn
> wrote:
> > On Tue, Jan 31, 2017 at 09:55:52AM +0100, Dmitry Vyukov wrote:
[...]
> Please-please-please, let's not use WARN for something that is not a
to protect it against concurrent accesses.
>
> Cc: sta...@vger.kernel.org
> Reported-by: Dmitry Vyukov
> Link: http://www.spinics.net/lists/linux-scsi/msg104326.html
> Signed-off-by: Hannes Reinecke
> Tested-by: Johannes Thumshirn
> ---
Rev
t; b) a flag is a reservations is in use
I did have a patch doing exactly that but (appart from lockdep complaints) we
decided to drop it, as it made the code even more confusing.
--
Johannes Thumshirn Storage
jthumsh...@suse.de
: Johannes Thumshirn
On 02/03/2017 12:53 AM, Raghava Aditya Renukunta wrote:
Reworked aac_command_thread into aac_process_events
Signed-off-by: Raghava Aditya Renukunta
Signed-off-by: Dave Carroll
---
Reviewed-by: Johannes Thumshirn
Aditya Renukunta
Signed-off-by: Dave Carroll
---
Reviewed-by: Johannes Thumshirn
On 02/03/2017 12:53 AM, Raghava Aditya Renukunta wrote:
Retrieved queue depth from fw and saved it for future use.
Only applicable for HBA1000 drives.
Signed-off-by: Raghava Aditya Renukunta
Signed-off-by: Dave Carroll
---
Reviewed-by: Johannes Thumshirn
On 02/03/2017 12:53 AM, Raghava Aditya Renukunta wrote:
Added support to set qd of drives in slave_configure.This only works for
HBA1000 attached drives.
Signed-off-by: Raghava Aditya Renukunta
Signed-off-by: Dave Carroll
---
Reviewed-by: Johannes Thumshirn
On 02/03/2017 12:53 AM, Raghava Aditya Renukunta wrote:
Added support for drive hotplug add and removal
Signed-off-by: Raghava Aditya Renukunta
Signed-off-by: Dave Carroll
---
Reviewed-by: Johannes Thumshirn
)
+{
+ struct aac_hba_cmd_req *hbacmd = aac_construct_hbacmd(fib, cmd);
+ struct aac_dev *dev;
+ // u16 fibsize;
Here you missed one ;-)
Anyways,
Reviewed-by: Johannes Thumshirn
Aditya Renukunta
Signed-off-by: Dave Carroll
---
Reviewed-by: Johannes Thumshirn
On 02/03/2017 12:53 AM, Raghava Aditya Renukunta wrote:
Added a new IWBR soft reset type, reworked the IOP reset interface for
a bit.
Signed-off-by: Raghava Aditya Renukunta
Signed-off-by: Dave Carroll
---
Reviewed-by: Johannes Thumshirn
On 02/03/2017 09:54 AM, Hannes Reinecke wrote:
The ioctl SET_FORCE_LOW_DMA has never worked since the initial
git check-in, and the respective setting is nowadays handled
correctly.
So disable it entirely.
Signed-off-by: Hannes Reinecke
---
[...]
case SG_SET_FORCE_LOW_DMA:
-
t accesses.
Cc: sta...@vger.kernel.org
Reported-by: Dmitry Vyukov
Link: http://www.spinics.net/lists/linux-scsi/msg104326.html
Signed-off-by: Hannes Reinecke
Tested-by: Johannes Thumshirn
---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storag
On 02/03/2017 09:54 AM, Hannes Reinecke wrote:
'Sg_request' is using a private list implementation; convert it
to standard lists.
Signed-off-by: Hannes Reinecke
---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Stora
On 02/03/2017 01:18 PM, Hannes Reinecke wrote:
The ioctl SET_FORCE_LOW_DMA has never worked since the initial
git check-in, and the respective setting is nowadays handled
correctly.
So disable it entirely.
Signed-off-by: Hannes Reinecke
---
Reviewed-by: Johannes Thumshirn
On 02/03/2017 01:18 PM, Hannes Reinecke wrote:
Unused.
Signed-off-by: Hannes Reinecke
---
Reviewed-by: Johannes Thumshirn
tect
'sg_fd' against concurrent accesses.
Signed-off-by: Hannes Reinecke
---
Tested-by: Johannes Thumshirn
Reviewed-by: Johannes Thumshirn
On 02/03/2017 01:18 PM, Hannes Reinecke wrote:
From: Johannes Thumshirn
Check for a valid direction before starting the request, otherwise we risk
running into an assertion in the scsi midlayer checking for vaild requests.
Signed-off-by: Johannes Thumshirn
Link: http://www.spinics.net/lists
On 02/03/2017 01:18 PM, Hannes Reinecke wrote:
'Sg_request' is using a private list implementation; convert it
to standard lists.
Signed-off-by: Hannes Reinecke
---
[..]
static bool sg_is_valid_dxfer(sg_io_hdr_t *hp)
{
- switch (dxfer_direction) {
+ switch (hp->dxfer_dire
sg: close race condition in sg_remove_sfp_usercontext()
Johannes Thumshirn (1):
sg: check for valid direction before starting the request
drivers/scsi/sg.c | 284 +++---
include/scsi/sg.h | 1 -
2 files changed, 141 insertions(+), 144 deletions(-)
On 02/03/2017 05:19 PM, Christoph Hellwig wrote:
On Fri, Feb 03, 2017 at 02:38:35PM +0100, Hannes Reinecke wrote:
On 02/03/2017 02:31 PM, Christoph Hellwig wrote:
- if (sg_res_in_use(sfp)) {
+ mutex_lock(&sfp->f_mutex);
+ if (sfp->res_in_use) {
+
On 02/04/2017 06:00 PM, Parav Pandit wrote:
This patch makes use of is_vlan_dev() function instead of flag
comparison which is exactly done by is_vlan_dev() helper function.
Signed-off-by: Parav Pandit
Reviewed-by: Daniel Jurgens
---
For drivers/scsi/fcoe/fcoe.c:
Acked-by: Johannes
+#define LPFC_RQ_PAGE_SIZE_4096 0x1
I wonder why do we need the two LPFC_RQ_PAGE_SIZE_4096 and
LPFC_WQ_PAGE_SIZE_4096 both being 1? Wouldn't a more global
LPFC_PAGE_SIZE_4096 or LPFC_Q_PAGE_SIZE_4096 be sufficient?
But I don't have a strong opinion on this either.
Otherwise,
Reviewed-by:
> Signed-off-by: Christoph Hellwig
> Signed-off-by: James Smart
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N
les than
> just lpfc_sli.c
Yes but patch 03/18 'lpfc: NVME Initiator: Base modifications Part A'
still has calls to lpfc_sli_hbq_count(phba) (and in fact introduces this
change).
--
Johannes Thumshirn Storage
jthumsh...@suse.de
_8")
> Fixes: 423400e64d37 ("scsi: aacraid: Include HBA direct interface")
> Signed-off-by: Arnd Bergmann
> ---
The coolest thing with your patches is, one gets to know new cool
functions/macros.
Anyways looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Th
on stack
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr.
On 02/12/2017 10:52 PM, James Smart wrote:
>
> Update copyrights to 2017 for all files touched in this patch set
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
On 02/12/2017 10:52 PM, James Smart wrote:
>
> Update lpfc version to 11.2.0.7
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
301 - 400 of 1576 matches
Mail list logo