On 02/12/2017 10:52 PM, James Smart wrote:
>
> Create common wq, cq, eq, rq print functions
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
On 02/12/2017 10:52 PM, James Smart wrote:
>
> Create common wq, cq, eq, rq dump functions
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> Replaced camel case with snake case for init supported options.
>
> Suggested-by: Johannes Thumshirn
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
> ---
\o/
Bonus-points-awarded-b
direct interface")
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE
if (aac_check_eeh_failure(dev))
> + return -EFAULT;
> +#endif
> +
So the #if defined() blocks become unnecessary.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de
gt; +
> + if (hw_fib->header.XferState & cpu_to_le32(AdapterProcessed))
> + return -EINVAL;
> +
As far as I can see the fib_xfer_state enum isn't an exported as an
official ABI, so it's a good candidate (whole of aacraid.h actually) for
the next round of came
M_MGT_FIB;
alloc_size = (dev->max_cmd_size + sizeof(struct aac_fib_xporthdr)) *
numtags + 31;
pci_free_consistent(dev->pdev, alloc_size, dev->hw_fib_va,
dev->hw_fib_pa);
And please indent correctly. If it indentation does
ditya Renukunta
>
> Reviewed-by: David Carroll
> ---
Can't this be retrieved via modinfo?
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Fel
s: 495c021767bd78c998 (aacraid: MSI-x support)
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
; Fixes: 3d77d8404478353358 (scsi: aacraid: Added support for periodic wellness
> sync)
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthum
vid Carroll
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 212
Carroll
> ---
This look a bit scary. Can't the kthread be converted to a workqueue so
we could call cancel_work_sync()?
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90
y: David Carroll
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
need for the
parenthesis
> + reset_type &= ~HW_IOP_RESET;
> +
> dev->a_ops.adapter_enable_int = aac_src_disable_interrupt;
>
> switch (reset_type) {
>
Apart from that,
Reviewed-by: Johannes Thumshirn
--
r family)
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
> ---
Apart from the odd comma placement in the 2nd paragraph of the commit
message
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...
trigger I/O log file save in the adapter
> firmware before issuing an IOP reset.
>
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> Updated driver version to 50792
>
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
fore freeing it.
>
> Thank you dan for finding this issue out.
>
> Fixes: 6223a39fe6fbbeef (scsi: aacraid: Added support for hotplug)
> Reported-by: Dan Carpenter
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
> ---
Reviewed-by: J
On 02/15/2017 07:08 PM, Raghava Aditya Renukunta wrote:
>
> I will put in the queue for the next set of patch submissions and chip away
> at it bit by bit.
Yay, thanks.
--
Johannes Thumshirn Storage
jthumsh...@suse.de
rmation as
> opposed to modinfo to get the driver version running.
OK then.
Speaking of test automation, is there something you may be able to share?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de
eues
or timers (or a combination of both).
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
H
arroll
>
> ---
> Changes for V2:
> Refactored code to remove CONFIG_EEH macros
Thanks,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr.
er.kernel.org
> Fixes: e8b12f0fb835223 ([SCSI] aacraid: Add new code for PMC-Sierra's SRC
> based controller family)
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
>
> ---
> Changes in V2:
> Refactored memory free code to make it easier to
ditya Renukunta
>
> Reviewed-by: David Carroll
>
> ---
Thanks,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
f (WARN_ON(!smid))
return NULL;
Should fix both.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284
On 02/17/2017 10:35 AM, Johannes Thumshirn wrote:
> On 02/17/2017 09:23 AM, Hannes Reinecke wrote:
>> +struct scsiio_tracker *
>> +mpt3sas_get_st_from_smid(struct MPT3SAS_ADAPTER *ioc, u16 smid)
>> +{
>> +WARN_ON(!smid);
>> +WARN_ON(smid >= ioc->
ou maybe have a chance to
bisect it?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norto
es: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver
> framework.")
> Signed-off-by: Arnd Bergmann
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
The subject is wrong, should be something like "scsi: libfc convert
fc_fcp_pkt.ref_cnt from atomic_t to refcount_t" but not s390.
Other than that
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
On Mon, Feb 22, 2016 at 08:51:01AM +0100, Hannes Reinecke wrote:
> On larger installations it makes sense to disable the target scan
> per default on boot, and scan the required LUNs directly via udev
> rules.
>
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
#x27; parameter moves the actual
> LUN scanning to a workqueue, thereby unblocking the process.
>
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49
On Tue, Mar 01, 2016 at 05:52:25AM +0100, Hannes Reinecke wrote:
> Add 'is_bin_visible' callback to blank out unsupported vpd pages.
>
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
addition of another #ifdef.
>
> Signed-off-by: Arnd Bergmann
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Fe
-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 2128
Reinecke
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nü
oph Hellwig
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Sm
On Thu, Mar 03, 2016 at 07:54:10AM +0100, Hannes Reinecke wrote:
> Track attached SCSI devices and update the 'access_state'
> whenever the path state of the device changes.
>
> Reviewed-by: Christoph Hellwig
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes
ll never be visible.
>
> This patch moves the code around so that the device handler
> is present by the time 'is_visible' is evaluated to
> correctly display the 'access_state' attribute.
>
> Reviewed-by: Christoph Hellwig
> Signed
On Thu, Mar 03, 2016 at 07:54:11AM +0100, Hannes Reinecke wrote:
> Update the 'access_state' field of the SCSI device whenever
> the path state changes.
>
> Reviewed-by: Christoph Hellwig
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
There was a patch from Arnd earlier this day
On Fri, Mar 04, 2016 at 10:41:49AM +0100, Maurizio Lombardi wrote:
> In beiscsi_setup_boot_info(), the boot_kset pointer should be set
> to NULL in case of failure otherwise an invalid pointer dereference
> may occur later.
>
> Signed-off-by: Maurizio Lombardi
Reviewed-by: Joh
his in user space, though,
> than to limit the value range for the session ID here.
>
> Signed-off-by: Lee Duncan
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053
On Thu, Mar 10, 2016 at 11:25:26AM +0100, Hannes Reinecke wrote:
> The test for the existence vpd_pg83 is inverted.
>
> Fixes: 7e47976bcff ("scsi_sysfs: add 'is_bin_visible' callback")
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Th
is removed
> as pd_list_not_supported better reflect the purpose.
>
> Signed-off-by: Sumit Saxena
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH,
On Fri, Mar 11, 2016 at 07:22:19PM +0100, Sebastian Andrzej Siewior wrote:
> after sending a few patches to the odin.com email address I noticed that
> it is no longer valid.
>
> Signed-off-by: Sebastian Andrzej Siewior
Reviewed-by: Johannes Thumshirn
--
Johann
ed', which work like
> 'none', but can be overriden by setting the 'rescan' value
> from scsi_scan_target to '2'.
> And it updates all relevant callers to set the 'rescan' value
> to '2' if invoked via the 'scan' opti
On Mon, Mar 14, 2016 at 10:43:08AM +0100, Hannes Reinecke wrote:
> There is no way to detect the scsi_target_id for any given SAS
> remote port, so add a new sysfs attribute 'scsi_target_id'.
>
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
gt; target have changed. The Linux SCSI layer does not automatical
>
> This is a truncated message. Avoid that such truncation happens
> by increasing the SCSI_LOG_BUFSIZE constant.
>
> Fixes: ded85c193a39 (scsi: Implement per-cpu logging buffer)
> Signed-off-by: Bart Van Assche
AL' if invoked via the 'scan' option in sysfs.
>
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfel
--
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Can you please remove the check for shost_use_blk_mq() in fnic_scsi.c as well
[] load_module+0x6729/0x8dc0
> [] SYSC_init_module+0x183/0x1a0
> [] SyS_init_module+0xe/0x10
> [] entry_SYSCALL_64_fastpath+0x12/0x6a
>
> Fix this by pulling the value at the beginning of the loop.
>
> Signed-off-by: Calvin Owens
Reviewed-by: Johannes Thumshirn
--
Johan
ory.
This patch adds an intermediate state 'STARGET_REMOVE', which is set
as soon as the target is scheduled to be removed.
With this any concurrent invocation will be able to skip these
targets and avoid the above scenario.
Signed-off-by: Johannes Thumshirn
Fixes: 90a88d6ef '
On Donnerstag, 24. März 2016 11:42:44 CEST Ewan D. Milne wrote:
> On Thu, 2016-03-24 at 10:56 +0100, Johannes Thumshirn wrote:
> > The target state machine only knows 'STARGET_DEL', which is set once
> > scsi_target_destroy() is called.
> > However, by that time the
rd or 4th patch
targeting it.
Changes to v1:
* Fix error (hit BUG_ON()) discovered by the 0-Day bot.
* Revert "scsi: fix soft lockup in scsi_remove_target() on module removal"
Johannes Thumshirn (2):
Revert "scsi: fix soft lockup in scsi_remove_target() on module
removal"
sc
This reverts commit 90a88d6ef88edcfc4f644dddc7eef4ea41bccf8b.
Signed-off-by: Johannes Thumshirn
Cc: sta...@vger.kernel.org
---
drivers/scsi/scsi_sysfs.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 00bc721
Add intermediate STARGET_REMOVE state to scsi_target_state to avoid running
into the BUG_ON() in scsi_target_reap().
This intermediate state is only valid in the path from scsi_remove_target() to
scsi_target_destroy() indicating this target is going to be removed.
Signed-off-by: Johannes
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t;cmd_flags |= BIT_14;
- }
-
return target_put_sess_cmd(se_cmd);
}
Apart from the qla24xx_els_dcmd_iocb() thingy (which has nothing to do
with your patch)
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2016-03-31 01:26, Bart Van Assche wrote:
Use a C bitfield instead of emulating this functionality with
bit manipulations. Since only bits 5, 16 and 20 are ever tested,
remove the code that sets the other bits. This is easy to verify
by running the following command:
$ git grep -nH 'BIT_[0-9]'
,6 @@ done:
mutex_unlock(&session->eh_mutex);
return rc;
}
-EXPORT_SYMBOL_GPL(iscsi_eh_target_reset);
/**
* iscsi_eh_recover_target - reset target and possibly the session
Looks good to me,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the
ooks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
turn(1, &iscsi_session_nr);
if (target_id == ISCSI_MAX_TARGET) {
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
csi_flashnode_bus;
}
-EXPORT_SYMBOL_GPL(iscsi_is_flashnode_conn_dev);
static int iscsi_destroy_flashnode_conn(struct iscsi_bus_flash_conn
*fnode_conn)
{
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the
_match,
};
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
verse the order of patches as pointed out by James
Changes to v1:
* Fix error (hit BUG_ON()) discovered by the 0-Day bot.
* Revert "scsi: fix soft lockup in scsi_remove_target() on module removal"
Johannes Thumshirn (2):
scsi: Add intermediate STARGET_REMOVE state to scsi_target_state
Add intermediate STARGET_REMOVE state to scsi_target_state to avoid running
into the BUG_ON() in scsi_target_reap().
This intermediate state is only valid in the path from scsi_remove_target() to
scsi_target_destroy() indicating this target is going to be removed.
Signed-off-by: Johannes
This reverts commit 90a88d6ef88edcfc4f644dddc7eef4ea41bccf8b.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/scsi_sysfs.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 0df82e8..9e5f893 100644
--- a
_level has been moved out of scsi_add_lun and into
scsi_attach_vpd so that all callers will not scan VPD for devices that
don't support it.
Fixes: 09e2b0b14690 ("scsi: rescan VPD attributes")
Suggested-by: Alexander Duyck
Signed-off-by: Hannes Reinecke
Looks good,
Reviewed
On 2016-04-01 08:57, Hannes Reinecke wrote:
VPD pages 0x0 and 0x83 are mandatory even for SPC-2, so we should
be lowering the restriction to avoid having to whitelist every
SPC-2 compliant device.
Signed-off-by: Hannes Reinecke
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe
On 2016-03-31 20:05, Lee Duncan wrote:
This commit adds the read-write attribute "dbroot", in
the top-level CONFIGFS (core) target directory,
normally /sys/kernel/config/target. This attribute
defaults to "/var/target" but can be changed by
writing a new pathname string to it.
Target modules tha
On 2016-03-31 20:05, Lee Duncan wrote:
This commit updates the target core ALUA and PR
modules to use the new "dbroot" attribute instead
of assuming the target database is in "/var/target".
Same goes for this one,
Reviewed-by: Johannes Thumshirn
as soon as it has a Sign
e this the patches you pointed Hannes to?
If yes, please add my Tested-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2016-03-31 22:04, Mike Snitzer wrote:
Mechanical change that doesn't make any real effort to reduce the use
of
m->lock; that will come later (once atomics are used for counters,
etc).
Suggested-by: Hannes Reinecke
Signed-off-by: Mike Snitzer
Looks good,
Reviewed-by: Johannes T
On 2016-03-31 22:04, Mike Snitzer wrote:
The use of atomic_t for nr_valid_paths, pg_init_in_progress and
pg_init_count will allow relaxing the use of the m->lock spinlock.
Suggested-by: Hannes Reinecke
Signed-off-by: Mike Snitzer
Looks good,
Reviewed-by: Johannes Thumshirn
--
On 2016-03-31 22:04, Mike Snitzer wrote:
Allows the 'work_mutex' member to no longer cross a cacheline.
Signed-off-by: Mike Snitzer
---
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of
iled via fail_path().
Suggested-by: Jeff Moyer
Signed-off-by: Mike Snitzer
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[ +Cc Hannes ]
On 2016-04-01 15:22, Mike Snitzer wrote:
On Fri, Apr 01 2016 at 4:12am -0400,
Johannes Thumshirn wrote:
On 2016-03-31 22:04, Mike Snitzer wrote:
>I developed these changes some weeks ago but have since focused on
>regression and performance testing on larger NUMA s
On 2016-04-01 15:10, Chad Dupuis wrote:
From: Joe Carnuccio
Per customer request, add the following driver tunables:
o devloss_tmo
o max_luns
o queue_depth
o tm_timeout
Signed-off-by: Joe Carnuccio
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 38
+
On 2016-04-01 15:10, Chad Dupuis wrote:
Signed-off-by: Chad Dupuis
---
Looks like a nice debug feature,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
On 2016-04-01 15:10, Chad Dupuis wrote:
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index d95eee6..60423cf 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fco
the upper layers finish the session recovery
and
rediscover the device.
Signed-off-by: Chad Dupuis
---
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majo
On 2016-04-01 15:10, Chad Dupuis wrote:
Signed-off-by: Chad Dupuis
---
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On 2016-04-01 16:06, Chad Dupuis wrote:
On Fri, 1 Apr 2016, Johannes Thumshirn wrote:
On 2016-04-01 15:10, Chad Dupuis wrote:
From: Joe Carnuccio
Per customer request, add the following driver tunables:
o devloss_tmo
o max_luns
o queue_depth
o tm_timeout
Signed-off-by: Joe Carnuccio
On 2016-04-02 18:36, James Bottomley wrote:
On Thu, 2016-03-31 at 14:53 +0200, Johannes Thumshirn wrote:
Add intermediate STARGET_REMOVE state to scsi_target_state to avoid
running
into the BUG_ON() in scsi_target_reap().
This intermediate state is only valid in the path from
Now that we've done a more comprehensive fix with the intermediate
target state we can remove the previous hack introduced with commit
90a88d6ef88edcfc4f644dddc7eef4ea41bccf8b.
Signed-off-by: Johannes Thumshirn
Cc: sta...@vger.kernel.org
Reviewed-by: Ewan D. Milne
Reviewed-by: Hannes Rei
introduced in commits
bc3f02a795d3b4faa99d37390174be2a75d091bd and
40998193560dab6c3ce8d25f4fa58a23e252ef38 in a more comprehensive way.
Signed-off-by: Johannes Thumshirn
Fixes: 40998193560dab6c3ce8d25f4fa58a23e252ef38
Cc: sta...@vger.kernel.org
Reviewed-by: Ewan D. Milne
Reviewed-by: Hannes Reinecke
Changes to v1:
* Fix error (hit BUG_ON()) discovered by the 0-Day bot.
* Revert "scsi: fix soft lockup in scsi_remove_target() on module removal".
Johannes Thumshirn (2):
scsi: Add intermediate STARGET_REMOVE state to scsi_target_state
Revert "scsi: fix soft lockup in
On 2016-04-05 13:18, Martin K. Petersen wrote:
"Johannes" == Johannes Thumshirn writes:
Johannes> This is a follow up to "scsi: Add intermediate STARGET_REMOVE
Johannes> state to scsi_target_state".
James suggested we should let this incubate before hitting stable.
ass/scsi_host/hostX/tm_timeout.
>
> Signed-off-by: Joe Carnuccio
> Signed-off-by: Chad Dupuis
> ---
Looks good to me,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053
On Donnerstag, 7. April 2016 09:07:57 CEST Chad Dupuis wrote:
> Signed-off-by: Chad Dupuis
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINU
On Donnerstag, 7. April 2016 09:07:58 CEST Chad Dupuis wrote:
> Signed-off-by: Chad Dupuis
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINU
On Donnerstag, 7. April 2016 09:08:00 CEST Chad Dupuis wrote:
> Signed-off-by: Chad Dupuis
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINU
o the midlayer so as
> to prevent the crash and let the upper layers finish the session recovery
> and rediscover the device.
>
> Signed-off-by: Chad Dupuis
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh..
S | BW|
--++---+
4k | 330066 | 1289.4MB/s |
8k | 452792 | 3537.5MB/s |
16k | 334481 | 5226.3MB/s |
32k | 186916 | 5841.2MB/s |
64k | 88698 | 5543.7MB/s |
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 7405
On Freitag, 8. April 2016 15:29:39 CEST Mike Snitzer wrote:
> On Fri, Apr 08 2016 at 7:42am -0400,
> Johannes Thumshirn wrote:
>
> > Ladies and Gentlemen,
> > To show off some numbers from our testing:
> >
> > All tests are performed against the cache
lock */
> + starget->state = STARGET_REMOVE;
> scsi_target_destroy(starget);
> return NULL;
> }
Here starget->state is STARGET_CREATED and the assertion is already aware of
this state transitoin. IOTW this /shouldn&#
Hi Sergey, Xiong,
Can you try below patch?
On Montag, 11. April 2016 18:01:47 CEST Sergey Senozhatsky wrote:
> Hello,
>
> commit 7b106f2de6938c31ce5e9c86bc70ad3904666b96
> Author: Johannes Thumshirn
> Date: Tue Apr 5 11:50:44 2016 +0200
>
> scsi: Add intermediate
On Mittwoch, 13. April 2016 23:47:04 CEST Sergey Senozhatsky wrote:
> Hi,
>
> On (04/13/16 10:41), Johannes Thumshirn wrote:
> > Hi Sergey, Xiong,
> >
> > Can you try below patch?
>
> it panics my system.
> first it warn_on-s in lib/kobject.c:244
>
&
h provides
> 64-bit seconds value. The timestamp computed remains unaffected (milliseconds
> since Unix epoch).
>
> Signed-off-by: Tina Ruchandani
> Reviewed-by: Arnd Bergmann
> ---
Reviewed-by: Johann
quot;)
> Signed-off-by: Sebastian Herbszt
>
Good catch,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
Storage
jthumsh...@suse.de
+49 911 74053 689
401 - 500 of 1576 matches
Mail list logo
