it
> to the workqueue, thereby ensuring that the workqueue item
> will always be valid.
>
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 7
msg136998.html
> which was fixed by 55ff8cfbc4e1 ("USB: uas: Reduce can_queue to MAX_CMNDS").
> Does a similar fix need to be applied here?
>
> Thanks,
> Laura
Can you (or better the reporter) try below? Unfortunately I don't have a
qla1280 setup here, so I couldn't
ent. It's even possible that these are all totally
unrelated issues, again, I'm not certain at all.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 904
+0x12/0x71
[4.804371] ---[ end trace 0ea3b625f86705f7 ]---
[4.804581] qla1280: probe of :11:04.0 failed with error -12
In qla1280_set_defaults() the maximum queue depth is
set to 32 so adopt the scsi_host_template to it as well.
Signed-off-by: Johannes Thumshirn
Cc: Laura Abbott
Cc: Michae
is my analysis, feel free to correct my assumptions.
>
> Reviewed-by Laurence Oberman
>
> Laurence Oberman
> Principal Software Maintenance Engineer
> Red Hat Global Support Services
>
> - Original Message -
> From: "Johannes Thumshirn"
> To: "
: probe of :11:04.0 failed with error -12
In qla1280_set_defaults() the maximum queue depth is
set to 32 so adopt the scsi_host_template to it as well.
Signed-off-by: Johannes Thumshirn
Fixes: 64d513ac31b - "scsi: use host wide tags by default"
Cc: Laura Abbott
Cc: M
: probe of :11:04.0 failed with error -12
Reduce can_queue to 512 to solve the allocation error.
Signed-off-by: Johannes Thumshirn
Fixes: 64d513ac31b - "scsi: use host wide tags by default"
Cc: Laura Abbott
Cc: Michael Reed
Cc: sta...@vger.kernel.org
Reviewed-by: Laurence Oberma
: probe of :11:04.0 failed with error -12
Reduce can_queue to 512 to solve the allocation error.
Signed-off-by: Johannes Thumshirn
Cc: Laura Abbott
Cc: Michael Reed
Cc: sta...@vger.kernel.org
Reviewed-by: Laurence Oberman
---
Changes to v3:
* Use MAX_OUTSTANDING_COMMANDS insted of
tags by default".
Reduce can_queue to MAX_OUTSTANDING_COMMANDS (512) to solve the allocation
error.
Signed-off-by: Johannes Thumshirn
Fixes: 64d513ac31b - "scsi: use host wide tags by default"
Cc: sta...@vger.kernel.org # v4.4
Cc: Laura Abbott
Cc: Michael Reed
Reviewed-by: Laurence Ob
a Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
H
On Mon, Apr 25, 2016 at 11:31:03PM -0700, Raghava Aditya Renukunta wrote:
> Suggested-by: Seymour, Shane M
> Signed-off-by: Raghava Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh..
On Mon, Apr 25, 2016 at 11:31:43PM -0700, Raghava Aditya Renukunta wrote:
> As the firmware for series 6, 7, 8 cards does not support msi, remove it
> in the driver
>
> Signed-off-by: Raghava Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Joh
the user.
>
> Signed-off-by: Raghava Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörf
ot;));
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Johannes Thumshirn
nfo(&dev->pdev->dev, "Changed firmware to INTX mode");
> + }
> +
> if ((!aac_adapter_sync_cmd(dev, GET_ADAPTER_PROPERTIES,
> 0, 0, 0, 0, 0, 0,
> status+0, status+1, status+2, status+3, NULL)) &&
>
> --
> T
On Mon, Apr 25, 2016 at 11:32:44PM -0700, Raghava Aditya Renukunta wrote:
> Signed-off-by: Raghava Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 740
quot; (which is
> responsible for completing the command from being timed out) from
> starting because it could not get the CPU.
>
> Fixed by replacing "cpu_relax()" call with "schedule()"
> Cc: sta...@vger.kernel.org
>
> Signed-off-by: R
Fixed by: Adding another kthread_should_stop() before schedule_timeout()
> Cc: sta...@vger.kernel.org
>
> Signed-off-by: Raghava Aditya Renukunta
>
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
hat was why
> I used info,
> It should not impact the flow of the driver.
OK, I'm fine with the explanation
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE
On Wed, Apr 27, 2016 at 04:49:50PM +, Raghava Aditya Renukunta wrote:
> Hello Johannes,
>
> > -Original Message-
> > From: Johannes Thumshirn [mailto:jthmsh...@suse.de]
> > Sent: Wednesday, April 27, 2016 2:30 AM
> > To: Raghava Aditya Renukunta
> >
cared" messages and the driver to hang.
>
> This patch enables interrupts before the call to scsi_scan_host.
>
> Reported-by: Piotr Karbowski
> Reviewed-by: Scott Teel
> Reviewed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-b
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fing
On Wed, Apr 27, 2016 at 05:13:51PM -0500, Don Brace wrote:
> faulty drives can cause the driver to hang during a
> scan operation.
>
> Reviewed-by: Scott Teel
> Reviewed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-by: Johannes Thumshirn
--
On Wed, Apr 27, 2016 at 05:13:59PM -0500, Don Brace wrote:
> offload_to_be_enabled also needs to be set to 0 during a state
> change.
>
> Reviewed-by: Scott Teel
> Reviewed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-by: Johannes Thumshirn
--
wed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane
t Teel
> Reviewed-by: Kevin Barnett
> Signed-off-by: Don Brace
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix
On Wed, Apr 27, 2016 at 05:14:26PM -0500, Don Brace wrote:
> Reviewed-by: Gerry Morong
> Signed-off-by: Don Brace
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 68
r details cf https://lkml.org/lkml/2015/2/11/245
>
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5,
king for blk_rq_bytes(req) == 0 && error in
scsi_end_request()?
>
> /*
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majo
On Fri, May 20, 2016 at 08:56:14AM -0400, Ewan D. Milne wrote:
> From: "Ewan D. Milne"
>
> A spinlock is sufficient for this purpose, and much smaller.
>
> Signed-off-by: Ewan D. Milne
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
on Sep 17 00:00:00 2001
From: Johannes Thumshirn
Date: Tue, 24 May 2016 17:25:59 +0200
Subject: [RFC PATCH] mpt3sas: Don't do atomic memory allocations for firmware
update DMA
Currently mpt3sas uses pci_alloc_consistent() to allocate memory for the DMA
used to do firmware updates. pci_alloc_con
> Signed-off-by: Maurizio Lombardi
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Gra
oughly , as I don’t see allocation of
> several non-contiguous chunks of memory in below patch...,
The question here is if it would be possible to replace the kmalloc()
call with a vmalloc() (which is non-contiguous) and then pass the allocated
memory to a sg list?
Thanks,
Johann
Now that we do have pci_request_mem_regions() and pci_release_mem_regions() at
hand, use it in the lpfc driver.
Suggested-by: Christoph Hellwig
Signed-off-by: Johannes Thumshirn
Cc: James Smart
Cc: Dick Kennedy
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen&q
(pdev);
Johannes Thumshirn (5):
PCI: Add helpers to request/release memory and I/O regions
NVMe: Use pci_(request|release)_mem_regions
scsi: Use pci_(request|release)_mem_regions
GenWQE: Use pci_(request|release)_mem_regions
ethernet: Use pci_(request|release)_mem_regions
drivers/misc/g
:00/00:00:00:00:00/a0 Emask 0x2 (HSM violation)
> [4.646685] ata2.00: status: { DRDY DRQ }
> [4.648193] ata2: soft resetting link
>
> ...
>
> Fix this by suppressing VPD inquiry for this device.
>
> Reported-by: Jan Stancek
> Tested-by: Jan Stance
On Wed, Jun 01, 2016 at 12:59:29AM -0700, Christoph Hellwig wrote:
> On Tue, May 31, 2016 at 02:05:11PM +0200, Johannes Thumshirn wrote:
> > Now that we do have pci_request_mem_regions() and pci_release_mem_regions()
> > at
> > hand, use it in the lpfc driver.
>
> Th
Now that we do have pci_request_mem_regions() and pci_release_mem_regions() at
hand, use it in the lpfc driver.
Suggested-by: Christoph Hellwig
Signed-off-by: Johannes Thumshirn
Cc: James Smart
Cc: Dick Kennedy
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen&q
(pdev);
Changes since v1:
* Fixed indendatoin in pci.h patch to not cross the 80 chars boundary.
* Split Ethernet patches into two, one for Atheros and one for Intel drivers.
* Correctly named lpfc patch.
* Converted init-path of lpfc driver as well.
* Added Reviewed-by tags were appropriate.
Joh
On Thu, Jun 02, 2016 at 07:57:43AM -0400, Dick Kennedy wrote:
> Thanks Johannes, it looks good.
Hi Dick,
Can I use this as an Acked-by in the next submission?
Thanks,
Johannes
>
> On Thu, Jun 2, 2016 at 3:30 AM, Johannes Thumshirn
> wrote:
>
> >
Now that we do have pci_request_mem_regions() and pci_release_mem_regions() at
hand, use it in the lpfc driver.
Suggested-by: Christoph Hellwig
Signed-off-by: Johannes Thumshirn
Acked-by: Dick Kennedy
Cc: James Smart
Cc: Dick Kennedy
Cc: "James E.J. Bottomley"
Cc: "Martin K
atches into two, one for Atheros and one for Intel drivers.
* Correctly named lpfc patch.
* Converted init-path of lpfc driver as well.
* Added Reviewed-by tags were appropriate.
Johannes Thumshirn (6):
PCI: Add helpers to request/release memory and I/O regions
NVMe: Use pci_(request|release)_mem
On Tue, Jun 07, 2016 at 09:44:00AM +0200, Johannes Thumshirn wrote:
> The first patch in this series introduces the following 4 helper functions to
> the PCI core:
>
> * pci_request_mem_regions()
> * pci_request_io_regions()
> * pci_release_mem_regions()
> * pci_release_io
Bottomley"
> Cc: "Martin K. Petersen"
> Cc: Christoph Hellwig
> Cc: fcoe-de...@open-fcoe.org
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior
Tested in a Boot from FCoE scenario using a BCM57840.
Tested-by: Johannes Thumshirn
Reviewed
Mahesh Rajashekhara writes:
> Add MSI-x interrupt mode support.
>
> Signed-off-by: Mahesh Rajashekhara
> ---
> drivers/scsi/aacraid/aacraid.h | 80 -
> drivers/scsi/aacraid/comminit.c | 95 +-
> drivers/scsi/aacraid/commsup.c | 20 ++-
> drivers/scsi/aacraid/dpcsup.c |
vel;
> char inq_periph_qual; /* PQ from INQUIRY data */
> + struct mutex inquiry_mutex;
> unsigned char inquiry_len; /* valid bytes in 'inquiry' */
> unsigned char * inquiry;/* INQUIRY response data */
> const char * vendo
On Thu, 2015-11-26 at 02:43 -0500, anil.gurumur...@qlogic.com wrote:
> From: Anil Gurumurthy
Can you please explain a bit more why it is crashing in the commit message,
i.e. copy the comment you added to the source here as well.
And as I spot the words fix and crash in the subject, you might co
/bfad_im.h
> +++ b/drivers/scsi/bfa/bfad_im.h
> @@ -1,7 +1,8 @@
> /*
> - * Copyright (c) 2005-2010 Brocade Communications Systems, Inc.
> + * Copyright (c) 2005-2014 Brocade Communications Systems, Inc.
> + * Copyright (c) 2014- QLogic Corporation.
> * All rights reserved
RSION
> #else
> -#define BFAD_DRIVER_VERSION"3.2.23.0"
> +#define BFAD_DRIVER_VERSION"3.2.25.0"
> #endif
>
> #define BFAD_PROTO_NAME FCPI_NAME
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-
re; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License (GPL) Version 2 as
> diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c
> index 2c0cf8a..6c805e1 100644
> --- a/drivers/scsi/bfa/bfad_im.c
> +++ b/drivers/scsi/bfa/bfad
(sdebug_sectors_per * sdebug_heads);
> if (sdebug_cylinders_per >= 1024) {
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
fad, bfa_log_level,
> + "lun reset, bfa_itnim is NULL\n");
> + spin_unlock_irqrestore(&bfad->bfad_lock, flags);
> + rc = FAILED;
> + goto out;
> + }
> int_to_scsilun(cmnd->device->lun, &scsilun);
> bfa_ts
; + sdev_printk(KERN_INFO, sdev,
> + "%s: disable for non-disk devices\n",
> + ALUA_DH_NAME);
> + return SCSI_DH_DEV_UNSUPP;
> + }
> +
> h->tpgs = scsi_device_tpgs(sdev);
> swi
SI_DH_DEV_UNSUPP;
> break;
> + default:
> + sdev_printk(KERN_INFO, sdev,
> + "%s: unsupported TPGS setting %d\n",
> + ALUA_DH_NAME, h->tpgs);
> + h->tpgs = TPGS_MODE_NONE;
>
: port group %02x rel port %02x\n",
> - ALUA_DH_NAME, h->group_id, h->rel_port);
> + return SCSI_DH_DEV_UNSUPP;
> }
> + sdev_printk(KERN_INFO, sdev,
> + "%s: port group %02x rel port %02x\n",
> +
On Tue, 2015-12-01 at 10:16 +0100, Hannes Reinecke wrote:
> Fixup submit_rtpg() to always return a standard SCSI return code.
>
> Reviewed-by: Ewan Milne
> Reviewed-by: Johannes Thumshirn
> Reviewed-by: Christoph Hellwig
> Signed-off-by: Hannes Reinecke
> ---
> dri
- * Send a SET TARGET GROUP STATES command to the device.
> - * We only have to test here if we should resubmit the command;
> - * any other error is assumed as a failure.
> + * Evaluate a SET TARGET GROUP STATES command response.
> */
> static void stpg_endio(struct request *req, i
t; - const struct scsi_sense_hdr *);
> extern void scsi_print_sense_hdr(const struct scsi_device *, const char *,
> const struct scsi_sense_hdr *);
> extern void scsi_print_sense(const struct scsi_cmnd *);
Reviewed-by: Johannes Thumshir
mp; ALUA_RTPG_EXT_HDR_UNSUPP) &&
> sense_hdr.sense_key == ILLEGAL_REQUEST &&
> sense_hdr.asc == 0x24 && sense_hdr.ascq == 0) {
> - rtpg_ext_hdr_req = 0;
> + h->flags |= ALUA_RTPG_EXT_HDR_UNSUPP;
> goto retry;
> }
>
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
; - (h->buff[2] << 8) + h->buff[3] + 4;
> + len = get_unaligned_be32(&h->buff[0]) + 4;
>
> if (len > h->bufflen) {
> /* Resubmit with the correct length */
> @@ -576,7 +569,7 @@ static int alua_rtpg(struct scsi_device *sdev,
sense_hdr.asc == 0x04 && sense_hdr.ascq == 0x0a)
> + err = SCSI_DH_RETRY;
> + else if (sense_hdr.sense_key == UNIT_ATTENTION)
> + err = SCSI_DH_RETRY;
> + if (err == SCSI_DH_RETRY && time_before(jiffies, expiry)) {
> sdev_printk(KERN_ERR, sdev, "%s: rtpg retry\n",
> ALUA_DH_NAME);
> scsi_print_sense_hdr(sdev, ALUA_DH_NAME,
> &sense_hdr);
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
atted as a SCSI name string.
> + *
> + * Returns the length of the identification or error on failure.
> + * If the identifier is longer than the supplied buffer the actual
> + * identifier length is returned and the buffer is not zero-padded.
> + */
> +int scsi_vpd_lun_id(struct scsi_d
MSR_ARC1214_OUTBOUND_LIST_COPY_POINTER);
> + reg->outboundlist_read_pointer =
> MEM_BASE0(ARCMSR_ARC1214_OUTBOUND_LIST_READ_POINTER);
> + reg->outboundlist_interrupt_cause =
> MEM_BASE0(ARCMSR_ARC1214_OUTBOUND_INTERRUPT_CAUSE);
> + reg->outboundlist_interrupt_enable =
> MEM_BASE0
L_ENABLE);
> - reg->inboundlist_base_low =
> MEM_BASE0(ARCMSR_ARC1214_INBOUND_LIST_BASE_LOW);
> - reg->inboundlist_base_high =
> MEM_BASE0(ARCMSR_ARC1214_INBOUND_LIST_BASE_HIGH);
> - reg->inboundlist_write_pointer =
> MEM_BASE0(ARCMSR_ARC1214_INBOUND_LIST_WR
> 512
> #define ARCMSR_MAX_XFER_SECTORS_B
> 4096
>
>
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Josh,
On Tue, 2015-12-01 at 11:34 -0500, Josh Boyer wrote:
> The driver is missing calls to pci_dma_mapping_error() after
> performing the DMA mapping, which caused DMA-API warning to
> show up in dmesg's output. Though that happens only when
> DMA_API_DEBUG option is enabled. This change fixes
Hi Raghava,
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> During EEH PCI hotplug activity kernel unloads and loads the driver,
> causing character device to be unregistered(aac_remove_one).When the
> driver is loaded back using aac_probe_o
(&dev->rrq_outstanding[vector_no]);
> - if (dev->fibs_pushed_no == 0x)
> - dev->fibs_pushed_no = 0;
> - else
> - dev->fibs_pushed_no++;
> + vector_no = fib->vector_no;
>
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> Added support for PCI EEH(extended error handling).
>
> Signed-off-by: Raghava Aditya Renukunta
> ---
> drivers/scsi/aacraid/aacraid.h | 1 +
> drivers/scsi/aacraid/linit.c | 138
> +
->can_queue + AAC_NUM_MGT_FIB)),
> + dev->hw_fib_va, dev->hw_fib_pa);
> + }
> dev->hw_fib_va = NULL;
> dev->hw_fib_pa = 0;
> }
Fixes: 9ad5204d6 - "[SCSI] aacraid: incorrect dma mapping mask during blinkled
recover or user
ev->needs_freset = 1;
> +
> list_for_each_entry(aac, &aac_devices, entry) {
> if (aac->id > unique_id)
> break;
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Raghava,
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> while driver removal is in progress or PCI shutdown is invoked, driver
> kills AIF aacraid thread, but IOCTL requests from the management tools
> re-start AIF thread leading to IOP
t; +++ b/drivers/scsi/aacraid/linit.c
> @@ -1135,6 +1135,11 @@ static int aac_probe_one(struct pci_dev *pdev, const
> struct pci_device_id *id)
> u64 dmamask;
> extern int aac_sync_mode;
>
> + if (aac_disable_device_id_wildcards &&
> + id-&
Hi Raghava,
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> During EEH PCI hotplug activity kernel unloads and loads the driver,
> causing character device to be unregistered(aac_remove_one).When the
> driver is loaded back using aac_probe_
0x0001
>
> #ifndef AAC_DRIVER_BUILD
> -# define AAC_DRIVER_BUILD 41010
> +# define AAC_DRIVER_BUILD 41052
> # define AAC_DRIVER_BRANCH "-ms"
> #endif
> #define MAXIMUM_NUM_CONTAINERS 32
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this lis
Hi Raghava,
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> During EEH recovery number of online CPU's might change thereby changing
> the number of MSIx vectors. Since each fib is allocated to a vector,
> changes in the number of vectors c
er to free tag allocated fibs
> + * Does not do anything
> + */
> +
> +void aac_fib_free_tag(struct fib *fibptr)
> +{
> + (void)fibptr;
> +}
> +
I'm not sure if I like this placeholder. Sure it's a NOP and doesn't cost
anything but it's dead code. But if I'm the only one objecting here I'm fine
with it.
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Raghava,
On Wed, 2015-12-02 at 22:29 +, Raghava Aditya Renukunta wrote:
> Hello Johannes,
>
> > -Original Message-
[...]
> Originally the problem was that dev->adapter_shutdown was set after the
> Shutdown command was sent to the controller, leading to a race
> condition If afte
t != host->ehandler)
> - return FAILED;
> -
> if (!i->dft->lldd_abort_task)
> return FAILED;
>
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
gt; }
>
> diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
> index 27b4d0a..8c26823 100644
> --- a/drivers/scsi/scsi_priv.h
> +++ b/drivers/scsi/scsi_priv.h
> @@ -71,7 +71,7 @@ extern enum blk_eh_timer_return scsi_times_out(struct
> request *req);
> extern int scsi_
list_move_tail(&scmd->eh_entry, done_q);
> }
> EXPORT_SYMBOL(scsi_eh_finish_cmd);
> diff --git a/include/scsi/scsi_eh.h b/include/scsi/scsi_eh.h
> index dbb8c64..f2f876c 100644
> --- a/include/scsi/scsi_eh.h
> +++ b/include/scsi/scsi_eh.h
> @@ -30,6 +30,7 @@
t; --- a/drivers/scsi/scsi_priv.h
> +++ b/drivers/scsi/scsi_priv.h
> @@ -18,7 +18,6 @@ struct scsi_nl_hdr;
> /*
> * Scsi Error Handler Flags
> */
> -#define SCSI_EH_CANCEL_CMD 0x0001 /* Cancel this cmd */
> #define SCSI_EH_ABORT_SCHEDULED 0x0002 /* Abort has been
> scheduled */
>
>
recovery
> * @scmd: SCSI command structure to hijack
> @@ -1063,7 +1054,7 @@ retry:
> break;
> }
> } else if (rtn != FAILED) {
> - scsi_abort_eh_cmnd(scmd);
> + scsi_try_to_abort_cmd(shost->hostt, scmd);
>
rc = -EPERM;
> goto err2;
> @@ -1508,7 +1508,7 @@ static int recover_context(struct cxlflash_cfg *cfg,
> struct ctx_info *ctxi)
> }
>
> ctxid = cxl_process_element(ctx);
> - if (unlikely((ctxid > MAX_CONTEXT) || (ctxid < 0))) {
> + if (unlik
ic int alua_check_tpgs(struct scsi_device *sdev)
> */
> static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h)
> {
> - unsigned char *d;
> - unsigned char __rcu *vpd_pg83;
> int rel_port = -1, group_id;
>
> group_id = scsi_vpd_tpg_id(sde
change fixes the issue
> and makes pvscsi_map_buffers() function more robust.
>
> Signed-off-by: Arvind Kumar
> Cc: Josh Boyer
> Reviewed-by: Thomas Hellstrom
> Signed-off-by: Josh Boyer
> ---
>
> v2: Use -ENOMEM instead of -1 for the error return code as suggested by
/vger.kernel.org/majordomo-info.html
Should this go through stable as well?
If yes:
Fixes: 8b612fa23 '[SCSI] storvsc: Update the storage protocol to win8 level'
Cc: sta...@vger.kernel.org # v3.11+
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
)));
>
> - return vmbus_driver_register(&storvsc_drv);
> + fc_transport_template = fc_attach_transport(&fc_transport_functions);
> + if (!fc_transport_template)
> + return -ENODEV;
> +
> + ret = vmbus_driver_register(&storvsc_drv);
>
e_delta),
> -(unsigned long)request,
> -VM_PKT_DATA_INBAND,
> -VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
> -
> - if (ret != 0)
> - goto cleanup;
> -
> - t = wait_f
vmscsi_size_delta));
> complete(&request->wait_event);
> } else {
> - storvsc_on_receive(device,
> + storvsc_on_receive(stor_device,
>
irq = irq_of_parse_and_map(np, idx);
> + irq = platform_get_irq(pdev, idx);
> if (!irq) {
> dev_err(dev, "irq init: could not map fatal interrupt
> %d\n",
> idx);
> --
> 1.9.1
>
> --
&
u16 type_range, u8 use)
{
- struct iscsi_param *param = NULL;
+ struct iscsi_param *param;
param = kzalloc(sizeof(struct iscsi_param), GFP_KERNEL);
if (!param) {
pr_err("Unable to allocate memory for parameter.\n");
This way it would be
A8044_FLASH_STATUS,
> &flash_status);
> if (ret_val) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://
"fix"
in the subject or commit message), please add a
Fixes: 1234abcf 'Buggy commit'
Cc: sta...@vger.kernel.org # vX.Y
To the SOB area of your patch. This really makes our lives as distribution
maintainers - who have to care about actual users - a _lot_ easier.
Thanks
solve.
As I already said in the patch mail, I'm not sure if it is of intereset for
upstream, but can actually be quite handy to find something if it goes wrong.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911
This removes a redundant code block that will either be executed if the
ENABLE_FCP_RING_POLLING flag is set in phba->cfg_poll or not. The code is just
duplicated in both cases, hence we unify it again.
This probably is a left over from some sort of refactoring.
Signed-off-by: Johannes Thumsh
Several functions in lpfc have comments stating that the function must be
called with the hbalock (or hostlock, or ringlock) held. Add
lockdep_assert_held() annotations to these functions, so one can actually
verify the locks are held.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/lpfc
"unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
ring(&inq_result[32], 4);
>
> response_len = inq_result[4] + 5;
> if (response_len > 255)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> Mor
501 - 600 of 1576 matches
Mail list logo
