nux-scsi-ow...@vger.kernel.org
> [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Matthew R. Ochs
> Sent: Monday, April 27, 2015 2:50 PM
> To: linux-scsi@vger.kernel.org; james.bottom...@hansenpartnership.com;
> n...@linux-iscsi.org; brk...@linux.vnet.ibm.com
> Cc: mi...@neuling.org; im
Mikey,
Thanks for reviewing. Responses are inline below.
-matt
On Jul 2, 2015, at 1:39 AM, Michael Neuling wrote:
> On Fri, 2015-06-19 at 17:37 -0500, Matthew R. Ochs wrote:
>>
>> --- a/drivers/scsi/cxlflash/common.h
>> +++ b/drivers/scsi/cxlflash/common.h
>>
Hi Brian,
Thanks for reviewing. Comments inline below.
-matt
On Jul 10, 2015, at 2:49 PM, Brian King wrote:
> On 06/19/2015 05:37 PM, Matthew R. Ochs wrote:
>>
>> cfg->init_state = INIT_STATE_NONE;
>> cfg->dev = pdev;
>> +cfg->last_lun_index[0
s
- Sleep instead of busy-wait
- Remove duplicate parenths
- Refine patch staging
Matthew R. Ochs (3):
cxlflash: Base error recovery support
cxlflash: Superpipe support
cxlflash: Virtual LUN support
Documentation/powerpc/cxlflash.txt | 298 +
drivers/scsi/cxlflash/Makefile |
Introduce support for enhanced I/O error handling.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h | 11 +++-
drivers/scsi/cxlflash/main.c | 135 ++---
2 files changed, 133 insertions(+), 13 deletions
: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/Makefile |2 +-
drivers/scsi/cxlflash/common.h |3 +
drivers/scsi/cxlflash/main.c | 12 +
drivers/scsi/cxlflash/sislite.h|3 +
drivers/scsi/cxlflash/superpipe.c | 56 ++
drivers/scsi
Add superpipe supporting infrastructure to device driver for the IBM CXL
Flash adapter. This patch allows userspace applications to take advantage
of the accelerated I/O features that this adapter provides and bypass the
traditional filesystem stack.
Signed-off-by: Matthew R. Ochs
Signed-off-by
Hi Brian,
Thanks for reviewing. Comments inline below.
-matt
On Jul 24, 2015, at 3:15 PM, Brian King wrote:
> On 07/16/2015 06:26 PM, Matthew R. Ochs wrote:
>> +
>> +/**
>> + * ba_clone() - frees a block from the block allocator
>> + * @ba_lun: Block allocator fro
ve duplicate parenths
- Refine patch staging
Matthew R. Ochs (4):
cxlflash: Updates to legacy I/O
cxlflash: Base error recovery support
cxlflash: Superpipe support
cxlflash: Virtual LUN support
Documentation/ioctl/ioctl-number.txt |1 +
Documentation/powerpc/cxlflash.txt | 29
- parameter/comment updates
- making functions static
- supporting host rescan
- refining prints, using dev_* prints
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h |9 +-
drivers/scsi/cxlflash/main.c| 1329
Introduce support for enhanced I/O error handling.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/Kconfig | 2 +-
drivers/scsi/cxlflash/common.h | 11 ++-
drivers/scsi/cxlflash/main.c | 151 ++---
3 files changed
Add superpipe supporting infrastructure to device driver for the IBM CXL
Flash adapter. This patch allows userspace applications to take advantage
of the accelerated I/O features that this adapter provides and bypass the
traditional filesystem stack.
Signed-off-by: Matthew R. Ochs
Signed-off-by
: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
Documentation/powerpc/cxlflash.txt | 63 +-
drivers/scsi/cxlflash/Makefile |2 +-
drivers/scsi/cxlflash/common.h |3 +
drivers/scsi/cxlflash/main.c | 12 +
drivers/scsi/cxlflash/main.h |2 +-
drivers/scsi
> On Aug 5, 2015, at 10:44 AM, Brian King wrote:
>
> Hi Matt,
>
> Can you break this up into separate patches for these separate logical bug
> fixes / changes?
> There is too much bundled all into a single patch here from my perspective.
Sure, I can do that for v4.
>
> Thanks,
>
> Brian
>
Hi Brian,
Thanks for reviewing. Comments inline below.
-matt
> On Aug 5, 2015, at 11:04 AM, Brian King wrote:
>
> On 08/02/2015 11:33 PM, Matthew R. Ochs wrote:
>
>> diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi/cxlflash/common.h
>> index ba070a5.
Hi Daniel,
Thanks for reviewing. Comments inline below.
-matt
> On Aug 7, 2015, at 12:12 AM, Daniel Axtens wrote:
>
> Hi,
>
>> @@ -1857,9 +1884,18 @@ static int cxlflash_eh_device_reset_handler(struct
>> scsi_cmnd *scp)
>> get_unaligned_be32(&((u32 *)scp->cmnd)[2]),
>>
Introduce support for enhanced I/O error handling.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/Kconfig | 2 +-
drivers/scsi/cxlflash/common.h | 11 ++-
drivers/scsi/cxlflash/main.c | 166 ++---
drivers/scsi
: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/Makefile |2 +-
drivers/scsi/cxlflash/common.h |4 +
drivers/scsi/cxlflash/main.c | 14 +-
drivers/scsi/cxlflash/sislite.h|3 +
drivers/scsi/cxlflash/superpipe.c | 63 +-
drivers/scsi
Add superpipe supporting infrastructure to device driver for the IBM CXL
Flash adapter. This patch allows userspace applications to take advantage
of the accelerated I/O features that this adapter provides and bypass the
traditional filesystem stack.
Signed-off-by: Matthew R. Ochs
Signed-off-by
e slave_* routines
- Tone down branch hints
- Use scsi_execute() to issue SCSI commands
- Use existing SCSI defines
- Sleep instead of busy-wait
- Remove duplicate parenths
- Refine patch staging
Matthew R. Ochs (3):
cxlflash: Base error recovery support
cxlflash: Superpipe support
> On Aug 10, 2015, at 6:52 PM, Daniel Axtens wrote:
>
>> @@ -487,11 +515,27 @@ static int cxlflash_eh_host_reset_handler(struct
>> scsi_cmnd *scp)
>> get_unaligned_be32(&((u32 *)scp->cmnd)[2]),
>> get_unaligned_be32(&((u32 *)scp->cmnd)[3]));
>>
>> -rcr = cxlflash
> On Aug 10, 2015, at 8:32 PM, Michael Neuling wrote:
>
>> This patch set is intended for the 4.3 release and adds support for
>> error recovery and the superpipe features provided by the IBM CXL
>> Flash adapter. The superpipe function was originally presented in an
>> RFC patch set in late Apri
Mikey,
Thanks for reviewing. Responses to your comments inline below.
-matt
> On Aug 10, 2015, at 9:05 PM, Michael Neuling wrote:
>
> On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
>> Introduce support for enhanced I/O error handling.
>
> This needs mor
> On Aug 10, 2015, at 10:41 PM, Benjamin Herrenschmidt
> wrote:
>
> On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
>> Introduce support for enhanced I/O error handling.
>>
>> Signed-off-by: Matthew R. Ochs
>> Signed-off-by: Manoj N. Kumar
>
> On Aug 11, 2015, at 12:23 AM, Michael Neuling wrote:
>
> Some comments inline
Thanks for reviewing, responses below.
> On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
>> Add superpipe supporting infrastructure to device driver for the IBM CXL
>> Flash ad
Hi Wendy,
Thanks for reviewing. Comments inline below.
-matt
> On Aug 11, 2015, at 11:15 PM, wenxi...@linux.vnet.ibm.com wrote:
>
>
> Quoting "Matthew R. Ochs" :
>
>> Introduce support for enhanced I/O error handling.
>>
>> Signed-off-by: Matthe
Hi Wendy,
Thanks for reviewing. Comments inline below.
-matt
> On Aug 11, 2015, at 11:18 PM, wenxi...@linux.vnet.ibm.com wrote:
> Quoting "Matthew R. Ochs" :
>> +struct ctx_info *get_context(struct cxlflash_cfg *cfg, u64 rctxid,
>> + void
> On Aug 11, 2015, at 10:54 PM, Michael Neuling wrote:
>
>
+ pr_debug("%s: Wait for user context to quiesce...\n", __func__);
+ wake_up_all(&cfg->limbo_waitq);
+ ssleep(1);
>>>
>>> Why 1 sec and why in a loop? Can’t you poll/wait for completion somewhe
Add cxlflash_ioctl.h to UAPI Kbuild
- Remove unnecessary initialization code
- Fix spelling/grammar errors
- Remove the slave_* routines
- Tone down branch hints
- Use scsi_execute() to issue SCSI commands
- Use existing SCSI defines
- Sleep instead of busy-wait
- Remove duplicate parenths
- Refin
state,
normal operations are no longer allowed. Only specially designated
operations related to graceful cleanup are permitted.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reviewed-by: Daniel Axtens
---
drivers/scsi/cxlflash/Kconfig | 2 +-
drivers/scsi/cxlflash/common.h | 12
: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
Documentation/powerpc/cxlflash.txt | 63 +-
drivers/scsi/cxlflash/Makefile |2 +-
drivers/scsi/cxlflash/common.h |4 +
drivers/scsi/cxlflash/lunmgt.c |3 +
drivers/scsi/cxlflash/main.c | 13 +
drivers/scsi
Add superpipe supporting infrastructure to device driver for the IBM CXL
Flash adapter. This patch allows userspace applications to take advantage
of the accelerated I/O features that this adapter provides and bypass the
traditional filesystem stack.
Signed-off-by: Matthew R. Ochs
Signed-off-by
si_execute() to issue SCSI commands
- Use existing SCSI defines
- Sleep instead of busy-wait
- Remove duplicate parenths
- Refine patch staging
Matthew R. Ochs (3):
cxlflash: Base error recovery support
cxlflash: Superpipe support
cxlflash: Virtual LUN support
Documentation/ioctl/ioctl-number.
state,
normal operations are no longer allowed. Only specially designated
operations related to graceful cleanup are permitted.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reviewed-by: Daniel Axtens
Reviewed-by: Michael Neuling
Reviewed-by: Wen Xiong
---
drivers/scsi/cxlflash
: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reviewed-by: Michael Neuling
Reviewed-by: Wen Xiong
---
Documentation/powerpc/cxlflash.txt | 63 +-
drivers/scsi/cxlflash/Makefile |2 +-
drivers/scsi/cxlflash/common.h |4 +
drivers/scsi/cxlflash/lunmgt.c |3 +
drivers
Add superpipe supporting infrastructure to device driver for the IBM CXL
Flash adapter. This patch allows userspace applications to take advantage
of the accelerated I/O features that this adapter provides and bypass the
traditional filesystem stack.
Signed-off-by: Matthew R. Ochs
Signed-off-by
> On Aug 14, 2015, at 3:35 PM, Dan Carpenter wrote:
>
> The > should be >= or we read one element past the end of the array.
Dan - Good catch!
Acked-by: Matthew R. Ochs
>
> Fixes: c21e0bbfc485 ('cxlflash: Base support for IBM CXL Flash Adapter')
> Signed
Hi Brian,
Thanks for reviewing.
All good suggestions that I am fine with implementing. As these are fairly
minor,
would you be okay with these being made in a separate ‘fix' patch series?
-matt
> On Aug 17, 2015, at 9:38 AM, Brian King wrote:
>
> On 08/13/2015 09:47 PM, M
; port);
> + port_sel |= (1ULL << port);
> writeq_be(port_sel, &afu->afu_map->global.regs.afu_port_sel);
> cxlflash_afu_sync(afu, 0, 0, AFU_GSYNC);
>
Acked-by: Matthew R. Ochs
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Flash Error
Recovery and Superpipe" series.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reported-by: kbuild test robot
---
drivers/scsi/cxlflash/main.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlfl
ssues can get addressed in a follow on patch.
>
> Reviewed-by: Brian King
>
> On 08/13/2015 09:47 PM, Matthew R. Ochs wrote:
>> +/**
>> + * cxlflash_term_global_luns() - frees resources associated with global LUN
>> list
>> + */
>> +void cxlflash_
From: Manoj Kumar
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/superpipe.c | 3 ++-
drivers/scsi/cxlflash/superpipe.h | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/cxlflash/superpipe.c
b/drivers/scsi/cxlflash
From: Manoj Kumar
Make literals for number of retries as well.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/superpipe.c | 8
drivers/scsi/cxlflash/superpipe.h | 3 ++-
drivers/scsi/cxlflash/vlun.c | 5 +++--
3 files changed, 9
Fix sparse sizeof(bool) warning by changing type from bool to u8.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/superpipe.c | 2 +-
drivers/scsi/cxlflash/superpipe.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi
ugh a second (or greater) adapter is configured
correctly by programming the adapter's LUN table.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/vlun.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/scs
The context encode mask covers more than 32-bits, making it
a long integer. This should be noted by appending a specifier,
'ULL' in this case.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/superpipe.h | 2 +-
1 file changed, 1 insertion(+),
From: Manoj Kumar
Since the retrieved LUN is modified in the caller, hold the mutex
across modifications as well.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/lunmgt.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a
Create the ability to drain ioctls by wrapping the ioctl handler
call in a read semaphore and then implementing a small routine that
obtains the write semaphore, effectively creating a wait point for
all currently executing ioctls.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
resovles a potential Oops in the release handler when a dealing with
a LUN that has already been removed.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/superpipe.c | 36
1 file changed, 24 insertions(+), 12 deletions
To avoid processing an interrupt while memory may be yanked, check for
while in the interrupt handler. Bail when removal is imminent.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h | 2 ++
drivers/scsi/cxlflash/main.c | 21
init_pcr(struct cxlflash_cfg *);
int init_global(struct cxlflash_cfg *);
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h |5 -
drivers/scsi/cxlflash/main.c | 1018
2 files changed, 509 insertions
Rename the state and waitq.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h| 4 ++--
drivers/scsi/cxlflash/main.c | 26 +-
drivers/scsi/cxlflash/superpipe.c | 14 +++---
3 files changed, 22 insertions
find_and_create_lun()
cxlflash: Add a literal for units of max_sector
cxlflash: Increase timeout value for read capacity to 30 seconds
Matthew R. Ochs (26):
cxlflash: Obtain additional sdev reference
cxlflash: Always attempt LUN table initialization
cxlflash: Change rht_needs_ws from bool to u8
Implement the following suggestions by Shane Seymour and add
two new attributes to allow for debugging the port LUN table.
- use scnprintf() instead of snprintf()
- use DEVICE_ATTR_RO and DEVICE_ATTR_RW
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash
Various print changes: pr_* to dev_*, *_dbg to *_devel, and
*_dbg to *_dbg_ratelimited.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 105 ---
1 file changed, 58 insertions(+), 47 deletions(-)
diff --git
Use a spinlock to protect the TMF waitq instead of borrowing
the internal waitq lock. Also introduce a timeout for when the
TMF fails to complete so the appropriate status can be sent back
to the stack.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash
The resid should only be set in an underrun scenario.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash
: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
index 39ad7a3..74eb742 100644
--- a/drivers/scsi/cxlflash/main.c
+++ b/drivers/scsi/cxlflash
The host should be rescanned after a link up event.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h | 2 +-
drivers/scsi/cxlflash/main.c | 17 +
drivers/scsi/cxlflash/main.h | 1 +
3 files changed, 15 insertions(+), 5
At present, both ports must be online for the device to
configure properly. Remove this dependency and the unnecessary
internal LUN override logic as well. Additionally, change the
return code variable to match that used throughout the driver.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj
The workq should be terminated prior to freeing memory. Move the
termination call earlier in remove and use cancel_work_sync() instead
of flush_work().
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 2 +-
1 file changed, 1 insertion(+), 1
The host reset handler is called with I/O already blocked, thus
there is no need to explicitly block and unblock I/O in the handler.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi
Fix spelling and grammar issues. Update some comments for clarity and
consistency. Remove extra lines and a few unneeded variables/statements.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h| 2 --
drivers/scsi/cxlflash/main.c | 62
Introduce __iomem and proper endianness tags/swaps where
appropriate to make driver sparse clean.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h| 10 +-
drivers/scsi/cxlflash/main.c | 25 +
drivers/scsi
context is made available
again. The context can be safely moved to the error state if
needed during the unavailable window as no other threads will
hold its reference.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/superpipe.c | 9 +
1 file changed
Add a state recheck in the device reset handler such that a TMF
will still be send out after an adapter reset.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi
Update the function prologs to properly reflect parameter names
and return codes.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 68
1 file changed, 25 insertions(+), 43 deletions(-)
diff --git a
.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
index fc77cd4..1856a73 100644
--- a/drivers/scsi/cxlflash/main.c
+++ b
rface.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h | 2 +-
drivers/scsi/cxlflash/main.c| 18 --
drivers/scsi/cxlflash/sislite.h | 2 +-
3 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/cxlflash/commo
The AFU RRQ in host memory needs to be cleared after each reset
to avoid stale entries from being processed by the AFU.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/cxlflash
Add stanza for cxlflash SCSI driver.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 67a4443..49084ad 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3153,6 +3153,15 @@ F
> On Sep 13, 2015, at 8:12 PM, Ian Munsie wrote:
>
> Hi Matt & Manoj,
>
> Just a general comment about this series - I'd like to see more detailed
> commit messages for almost all these patches. Of course James is the
> scsi maintainer and it's up to him whether to take these as is or not,
> but
> On Sep 15, 2015, at 9:50 PM, Ian Munsie wrote:
>
> Hi Matt & Manoj,
>
> Can you also add linuxppc-...@lists.ozlabs.org to the Cc list for
> version 2?
Will do.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More
cxlflash: Fix read capacity timeout
Matthew R. Ochs (27):
cxlflash: Fix potential oops following LUN removal
cxlflash: Fix data corruption when vLUN used over multiple cards
cxlflash: Fix to avoid sizeof(bool)
cxlflash: Fix context encode mask width
cxlflash: Fix to avoid CXL services
y to drain ioctls by wrapping the ioctl handler
call in a read semaphore and then implementing a small routine that
obtains the write semaphore, effectively creating a wait point for
all currently executing ioctls.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflas
Using sizeof(bool) is considered poor form for various reasons and
sparse warns us of that. Correct by changing type from bool to u8.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/superpipe.c | 2 +-
drivers/scsi/cxlflash/superpipe.h | 2 +-
2 files
From: Manoj Kumar
Magic numbers are not meaningful and can create confusion. As a
remedy, replace them with descriptive literals.
Replace 512 with literal MAX_SECTOR_UNIT.
Replace 5 with literal CMD_RETRIES.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Suggested-by: Brian
The context encode mask covers more than 32-bits, making it
a long integer. This should be noted by appending the ULL
width suffix to the mask.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/superpipe.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
that card needs to be programmed. The mode
word would be setup by the first card, causing the LUN table for the
second card to not be programmed.
By unconditionally initializing the LUN table (not depending on the
mode word), the problem is avoided.
Signed-off-by: Matthew R. Ochs
Signed-off-by:
resolves a potential Oops in the release handler when a
dealing with a LUN that has already been removed.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Suggested-by: Brian King
---
drivers/scsi/cxlflash/superpipe.c | 36
1 file changed, 24
of port_sel will be set
incorrectly to indicate a single port, though in this case
it should have been set to both ports.
To fix, use the global mutex to serialize the lookup of the
WWID and the subsequent modification of port_sel.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
timeout literal to a more appropriate description.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Suggested-by: Brian King
---
drivers/scsi/cxlflash/superpipe.c | 9 -
drivers/scsi/cxlflash/superpipe.h | 2 +-
drivers/scsi/cxlflash/vlun.c | 4 ++--
3 files changed, 7
removal is imminent.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h | 2 ++
drivers/scsi/cxlflash/main.c | 21 +++--
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi
Limbo is not an accurate representation of this state and is
also not consistent with the terminology that other drivers
use to represent this concept. Rename the state and and its
associated waitq to 'reset'.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Suggested-by:
Implement the following suggestions and add two new attributes
to allow for debugging the port LUN table.
- use scnprintf() instead of snprintf()
- use DEVICE_ATTR_RO and DEVICE_ATTR_RW
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Suggested-by: Shane Seymour
---
drivers
*);
struct afu_cmd *cxlflash_cmd_checkout(struct afu *);
void cxlflash_cmd_checkin(struct afu_cmd *);
void init_pcr(struct cxlflash_cfg *);
int init_global(struct cxlflash_cfg *);
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h |5 -
drivers/scsi
- pr_debug to pr_debug_ratelimited
- pr_err to dev_err
- pr_debug to dev_dbg
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 105 ---
1 file changed, 58 insertions(+), 47 deletions(-)
diff --git a/drivers
The resid is incorrectly set which can lead to unnecessary retry
attempts by the stack. This is due to resid _always_ being set
using a value returned from the adapter. Instead, the value
should only be interpreted and set when in an underrun scenario.
Signed-off-by: Matthew R. Ochs
Signed-off
-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h | 2 +-
drivers/scsi/cxlflash/main.c | 17 +
drivers/scsi/cxlflash/main.h | 1 +
3 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi
such that a bigger hammer reset
can occur.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h | 1 +
drivers/scsi/cxlflash/main.c | 55 +-
2 files changed, 34 insertions(+), 22 deletions(-)
diff --git a/dr
: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
index 39ad7a3..74eb742 100644
--- a/drivers/scsi/cxlflash/main.c
+++ b/drivers/scsi/cxlflash
R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
index 74eb742..e2cc410 100644
--- a/drivers/scsi/cxlflash/main.c
+++ b
Several function prologs have incorrect parameter names and return
code descriptions. This can lead to confusion when reviewing the
source and creates inaccurate documentation.
To remedy, update the function prologs to properly reflect parameter
names and return codes.
Signed-off-by: Matthew R
there is not a need to process any scheduled work when
shutting down.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
The host reset handler is called with I/O already blocked, thus
there is no need to explicitly block and unblock I/O in the handler.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Suggested-by: Brian King
---
drivers/scsi/cxlflash/main.c | 2 --
1 file changed, 2 deletions
the TMF was not sent.
To fix, the state is rechecked after coming out of the reset
state. When the state is normal, a TMF will be sent out.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Suggested-by: Brian King
---
drivers/scsi/cxlflash/main.c | 5 ++---
1 file changed, 2
remove to be the last cleanup action taken
and introduce a call to scsi_host_put() in the one initialization
error path that does not use remove to cleanup.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/main.c | 3 ++-
1 file changed, 2 insertions(+), 1
-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h | 2 +-
drivers/scsi/cxlflash/main.c| 18 --
drivers/scsi/cxlflash/sislite.h | 2 +-
3 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/cxlflash/common.h b
Sparse uncovered several errors with MMIO operations (accessing
directly) and handling endianness. These can cause issues when
running in different environments.
Introduce __iomem and proper endianness tags/swaps where
appropriate to make driver sparse clean.
Signed-off-by: Matthew R. Ochs
consistency. Remove extra lines and a few unneeded variables/statements.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
---
drivers/scsi/cxlflash/common.h| 2 --
drivers/scsi/cxlflash/main.c | 62 +--
drivers/scsi/cxlflash/sislite.h
1 - 100 of 452 matches
Mail list logo
