Re: [PATCH 1 20/25] hpsa: add discovery polling for PT RAID devices.

> On Oct 29, 2015, at 3:51 PM, Don Brace <brace77...@gmail.com> wrote: > On 10/29/2015 03:20 PM, Matthew R. Ochs wrote: >>> On Oct 28, 2015, at 5:06 PM, Don Brace <don.br...@pmcs.com> >>> wrote: >>> >>> From: Scott Teel >>> <

Re: [PATCH v6 00/37] cxlflash: Miscellaneous bug fixes and corrections

Hi James, This series has been reviewed/acked. Is there anything else you're looking for before this can make it into -next? -matt > On Oct 21, 2015, at 3:08 PM, Matthew R. Ochs <mro...@linux.vnet.ibm.com> > wrote: > > This patch set contains various fixes and corr

Re: [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code

_up_period(struct device *dev, > return -EINVAL; > > sdev->queue_ramp_up_period = msecs_to_jiffies(period); > - return period; > + return count; > } > > static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR, Reviewed-by: Matthew R.

Re: [PATCH] scsi: Set sg_tablesize to 1, for LLDDs that set SG_NONE

ze ? sht->sg_tablesize : 1); > shost->sg_prot_tablesize = sht->sg_prot_tablesize; > shost->cmd_per_lun = sht->cmd_per_lun; > shost->unchecked_isa_dma = sht->unchecked_isa_dma; Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc

Hi Punit, Aren't you missing the removal of the memset() as part of this conversion? -matt > On Oct 23, 2015, at 3:03 PM, Punit Vara wrote: > > This patch is to the lpfc_els.c which resolves following warning > reported by coccicheck: > > WARNING: kzalloc should be used

Re: [PATCH 2/2] scsi: remove useless casting value returned by kmalloc to structure

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1 24/25] hpsa: add in sas transport class

> On Oct 30, 2015, at 5:00 PM, Don Brace <brace77...@gmail.com> wrote: > On 10/30/2015 03:07 PM, Matthew R. Ochs wrote: >>> On Oct 28, 2015, at 5:06 PM, Don Brace <don.br...@pmcs.com> wrote: >>> >>> From: Kevin Barnett <kevin.barn...@pmcs.com> &g

Re: [PATCH] st: trivial: remove form feed characters

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 18/27] hpsa: refactor hpsa_figure_bus_target_lun

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 20/27] hpsa: generalize external arrays

> struct ctlr_info *h, > c->Request.CDB[7] = (size >> 16) & 0xFF; > c->Request.CDB[8] = (size >> 8) & 0XFF; > break; > + case BMIC_IDENTIFY_CONTROLLER: > +

Re: [PATCH 1 17/25] hpsa: move scsi_add_device and scsi_remove_device calls to new function

> On Oct 29, 2015, at 3:30 PM, Don Brace <brace77...@gmail.com> wrote: > > On 10/29/2015 12:21 PM, Matthew R. Ochs wrote: >>> On Oct 28, 2015, at 5:06 PM, Don Brace <don.br...@pmcs.com> wrote: >>> >>> From: Kevin Barnett <kevin.barn...@pmcs.com

Re: [PATCH 1 21/25] hpsa: disable report lun data caching

+ > + /* Now verify that it got set: */ > + if (fill_cmd(c, BMIC_SENSE_DIAG_OPTIONS, h, options, 4, 0, > + RAID_CTLR_LUNID, TYPE_CMD)) > + goto errout; > + > + rc = hpsa_scsi_do_simple_cmd_with_retry(h, c, > + PCI_DMA_FROMDEVICE,

Re: [PATCH 1 20/25] hpsa: add discovery polling for PT RAID devices.

> On Oct 30, 2015, at 9:08 AM, Don Brace <brace77...@gmail.com> wrote: > > On 10/29/2015 03:59 PM, Matthew R. Ochs wrote: >>> On Oct 29, 2015, at 3:51 PM, Don Brace <brace77...@gmail.com> wrote: >>> On 10/29/2015 03:20 PM, Matthew R. Ochs wrote: >&

Re: [PATCH 1 22/25] hpsa: enhance device messages

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1 23/25] hpsa: fix multiple issues in path_info_show

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1 24/25] hpsa: add in sas transport class

> On Oct 28, 2015, at 5:06 PM, Don Brace wrote: > > From: Kevin Barnett > > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett > Signed-off-by:

Re: [PATCH 1 25/25] hpsa: bump the driver version

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] cxlflash: Base superpipe support

Hi Brian, Thanks for reviewing. Comments inline below. -matt On Jul 10, 2015, at 2:49 PM, Brian King wrote: On 06/19/2015 05:37 PM, Matthew R. Ochs wrote: cfg-init_state = INIT_STATE_NONE; cfg-dev = pdev; +cfg-last_lun_index[0] = 0; +cfg-last_lun_index[1] = 0

[PATCH] cxlflash: Remove unused variable from queuecommand

Error Recovery and Superpipe series. Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com Reported-by: kbuild test robot fengguang...@intel.com --- drivers/scsi/cxlflash/main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

Re: [PATCH v6 2/3] cxlflash: Superpipe support

merged as-is, as long as > these issues can get addressed in a follow on patch. > > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > > On 08/13/2015 09:47 PM, Matthew R. Ochs wrote: >> +/** >> + * cxlflash_term_global_luns() - frees resources associated with global L

Re: [PATCH 00/29] cxlflash: Miscellaneous bug fixes and corrections

> On Sep 15, 2015, at 9:50 PM, Ian Munsie wrote: > > Hi Matt & Manoj, > > Can you also add linuxppc-...@lists.ozlabs.org to the Cc list for > version 2? Will do. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH 00/29] cxlflash: Miscellaneous bug fixes and corrections

> On Sep 13, 2015, at 8:12 PM, Ian Munsie wrote: > > Hi Matt & Manoj, > > Just a general comment about this series - I'd like to see more detailed > commit messages for almost all these patches. Of course James is the > scsi maintainer and it's up to him whether to take

[PATCH v2 00/30] cxlflash: Miscellaneous bug fixes and corrections

cxlflash: Fix read capacity timeout Matthew R. Ochs (27): cxlflash: Fix potential oops following LUN removal cxlflash: Fix data corruption when vLUN used over multiple cards cxlflash: Fix to avoid sizeof(bool) cxlflash: Fix context encode mask width cxlflash: Fix to avoid CXL services

[PATCH v2 08/30] cxlflash: Fix to avoid CXL services during EEH

ioctls by wrapping the ioctl handler call in a read semaphore and then implementing a small routine that obtains the write semaphore, effectively creating a wait point for all currently executing ioctls. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kum

[PATCH v2 06/30] cxlflash: Fix to avoid sizeof(bool)

Using sizeof(bool) is considered poor form for various reasons and sparse warns us of that. Correct by changing type from bool to u8. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/sup

[PATCH v2 02/30] cxlflash: Replace magic numbers with literals

From: Manoj Kumar <kuma...@us.ibm.com> Magic numbers are not meaningful and can create confusion. As a remedy, replace them with descriptive literals. Replace 512 with literal MAX_SECTOR_UNIT. Replace 5 with literal CMD_RETRIES. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.co

[PATCH v2 07/30] cxlflash: Fix context encode mask width

The context encode mask covers more than 32-bits, making it a long integer. This should be noted by appending the ULL width suffix to the mask. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/s

[PATCH v2 05/30] cxlflash: Fix data corruption when vLUN used over multiple cards

for that card needs to be programmed. The mode word would be setup by the first card, causing the LUN table for the second card to not be programmed. By unconditionally initializing the LUN table (not depending on the mode word), the problem is avoided. Signed-off-by: Matthew R. Ochs <

[PATCH v2 04/30] cxlflash: Fix potential oops following LUN removal

. This resolves a potential Oops in the release handler when a dealing with a LUN that has already been removed. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Suggested-by: Brian King <brk...@linux.vnet.ibm.com> --- dri

[PATCH v2 01/30] cxlflash: Fix to avoid invalid port_sel value

n from find_and_create_lun(), the value of port_sel will be set incorrectly to indicate a single port, though in this case it should have been set to both ports. To fix, use the global mutex to serialize the lookup of the WWID and the subsequent modification of port_sel. Signed-off-by: Matthew R. Och

[PATCH v2 10/30] cxlflash: Correct naming of limbo state and waitq

Limbo is not an accurate representation of this state and is also not consistent with the terminology that other drivers use to represent this concept. Rename the state and and its associated waitq to 'reset'. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: M

[PATCH v2 03/30] cxlflash: Fix read capacity timeout

e used in sd.c) and rework the timeout literal to a more appropriate description. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Suggested-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/

[PATCH v2 09/30] cxlflash: Fix to stop interrupt processing on remove

removal is imminent. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 2 ++ drivers/scsi/cxlflash/main.c | 21 +++-- 2 files changed, 17 insertions(+), 6 deletions(-)

[PATCH v2 12/30] cxlflash: Refine host/device attributes

Implement the following suggestions and add two new attributes to allow for debugging the port LUN table. - use scnprintf() instead of snprintf() - use DEVICE_ATTR_RO and DEVICE_ATTR_RW Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kum

[PATCH v2 11/30] cxlflash: Make functions static

*); struct afu_cmd *cxlflash_cmd_checkout(struct afu *); void cxlflash_cmd_checkin(struct afu_cmd *); void init_pcr(struct cxlflash_cfg *); int init_global(struct cxlflash_cfg *); Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vne

[PATCH v2 13/30] cxlflash: Fix to avoid spamming the kernel log

- pr_debug to pr_debug_ratelimited - pr_err to dev_err - pr_debug to dev_dbg Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 105 --- 1 file

[PATCH v2 15/30] cxlflash: Fix location of setting resid

The resid is incorrectly set which can lead to unnecessary retry attempts by the stack. This is due to resid _always_ being set using a value returned from the adapter. Instead, the value should only be interpreted and set when in an underrun scenario. Signed-off-by: Matthew R. Ochs <

[PATCH v2 16/30] cxlflash: Fix host link up event handling

-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 2 +- drivers/scsi/cxlflash/main.c | 17 + drivers/scsi/cxlflash/main.h | 1 + 3 files changed, 15 insertions(+), 5 deleti

[PATCH v2 14/30] cxlflash: Fix to avoid stall while waiting on TMF

such that a bigger hammer reset can occur. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 1 + drivers/scsi/cxlflash/main.c | 55 +- 2 files

[PATCH v2 17/30] cxlflash: Fix async interrupt bypass logic

-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index 39ad7a3..74eb742 100644 -

[PATCH v2 18/30] cxlflash: Remove dual port online dependency

R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c i

[PATCH v2 22/30] cxlflash: Correct behavior in device reset handler following EEH

the TMF was not sent. To fix, the state is rechecked after coming out of the reset state. When the state is normal, a TMF will be sent out. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Suggested-by: Bri

[PATCH v2 20/30] cxlflash: Correct usage of scsi_host_put()

on remove to be the last cleanup action taken and introduce a call to scsi_host_put() in the one initialization error path that does not use remove to cleanup. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/s

[PATCH v2 19/30] cxlflash: Fix AFU version access/storage and add check

-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 2 +- drivers/scsi/cxlflash/main.c| 18 -- drivers/scsi/cxlflash/sislite.h | 2 +- 3 files changed, 14 insertions(+),

[PATCH v2 25/30] cxlflash: Fix MMIO and endianness errors

Sparse uncovered several errors with MMIO operations (accessing directly) and handling endianness. These can cause issues when running in different environments. Introduce __iomem and proper endianness tags/swaps where appropriate to make driver sparse clean. Signed-off-by: Matthew R. Ochs <

[PATCH v2 23/30] cxlflash: Remove unnecessary scsi_block_requests

The host reset handler is called with I/O already blocked, thus there is no need to explicitly block and unblock I/O in the handler. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Suggested-by: Bri

[PATCH v2 24/30] cxlflash: Fix function prolog parameters and return codes

Several function prologs have incorrect parameter names and return code descriptions. This can lead to confusion when reviewing the source and creates inaccurate documentation. To remedy, update the function prologs to properly reflect parameter names and return codes. Signed-off-by: Matthew R

[PATCH v2 21/30] cxlflash: Fix to prevent workq from accessing freed memory

() as there is not a need to process any scheduled work when shutting down. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v2 27/30] cxlflash: Correct spelling, grammar, and alignment mistakes

and consistency. Remove extra lines and a few unneeded variables/statements. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h| 2 -- drivers/scsi/cxlflash/main

[PATCH v2 26/30] cxlflash: Fix to prevent EEH recovery failure

mutex is reacquired and the context is made available again. The context can be safely moved to the error state if needed during the unavailable window as no other threads will hold its reference. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kum

[PATCH v2 28/30] cxlflash: Fix to prevent stale AFU RRQ

after each reset. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c i

[PATCH v2 29/30] cxlflash: Fix to avoid state change collision

-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Suggested-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h| 1 + drivers/scsi/cxlflash/main.c | 40 +--

[PATCH 01/29] cxlflash: Move global.mutex to caller of find_and_create_lun()

From: Manoj Kumar <kuma...@us.ibm.com> Since the retrieved LUN is modified in the caller, hold the mutex across modifications as well. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxl

[PATCH 07/29] cxlflash: Add ULL specifier to context encode mask

The context encode mask covers more than 32-bits, making it a long integer. This should be noted by appending a specifier, 'ULL' in this case. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash

[PATCH 06/29] cxlflash: Change rht_needs_ws from bool to u8

Fix sparse sizeof(bool) warning by changing type from bool to u8. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.c | 2 +- drivers/scsi/cxlflash/superpipe.h | 2 +- 2 file

[PATCH 05/29] cxlflash: Always attempt LUN table initialization

a second (or greater) adapter is configured correctly by programming the adapter's LUN table. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/vlun.c | 16 1 file changed,

[PATCH 02/29] cxlflash: Add a literal for units of max_sector

From: Manoj Kumar <kuma...@us.ibm.com> Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.c | 3 ++- drivers/scsi/cxlflash/superpipe.h | 2 ++ 2 files changed, 4 inserti

[PATCH 03/29] cxlflash: Increase timeout value for read capacity to 30 seconds

From: Manoj Kumar <kuma...@us.ibm.com> Make literals for number of retries as well. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.c | 8 drivers/scsi/cxlfla

[PATCH 15/29] cxlflash: Only set resid when needed

The resid should only be set in an underrun scenario. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 20 1 file changed, 8 insertions(+), 12 deletions(-)

[PATCH 17/29] cxlflash: Bypass async interrupt bits that are off

-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index 39ad7a3..74eb742 100644 -

[PATCH 16/29] cxlflash: Rescan host following link up event

The host should be rescanned after a link up event. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 2 +- drivers/scsi/cxlflash/main.c | 17 + drivers/scsi/cxl

[PATCH 21/29] cxlflash: Move workq termination earlier on remove

The workq should be terminated prior to freeing memory. Move the termination call earlier in remove and use cancel_work_sync() instead of flush_work(). Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/s

[PATCH 18/29] cxlflash: Remove dual port online dependency

At present, both ports must be online for the device to configure properly. Remove this dependency and the unnecessary internal LUN override logic as well. Additionally, change the return code variable to match that used throughout the driver. Signed-off-by: Matthew R. Ochs <

[PATCH 11/29] cxlflash: Make functions static

init_pcr(struct cxlflash_cfg *); int init_global(struct cxlflash_cfg *); Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h |5 - drivers/scsi/cxlflash/mai

[PATCH 10/29] cxlflash: Rename limbo to reset

Rename the state and waitq. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h| 4 ++-- drivers/scsi/cxlflash/main.c | 26 +- drivers/scsi/cxlflash

[PATCH 00/29] cxlflash: Miscellaneous bug fixes and corrections

of find_and_create_lun() cxlflash: Add a literal for units of max_sector cxlflash: Increase timeout value for read capacity to 30 seconds Matthew R. Ochs (26): cxlflash: Obtain additional sdev reference cxlflash: Always attempt LUN table initialization cxlflash: Change rht_needs_ws from bool to u8

[PATCH 08/29] cxlflash: Add ioctl drain

Create the ability to drain ioctls by wrapping the ioctl handler call in a read semaphore and then implementing a small routine that obtains the write semaphore, effectively creating a wait point for all currently executing ioctls. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

[PATCH 09/29] cxlflash: Check for removal when processing interrupt

To avoid processing an interrupt while memory may be yanked, check for while in the interrupt handler. Bail when removal is imminent. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/c

[PATCH 23/29] cxlflash: Remove unnecessary scsi_block_requests

The host reset handler is called with I/O already blocked, thus there is no need to explicitly block and unblock I/O in the handler. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c |

[PATCH 27/29] cxlflash: Spelling, grammar, and alignment changes

Fix spelling and grammar issues. Update some comments for clarity and consistency. Remove extra lines and a few unneeded variables/statements. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlfl

[PATCH 25/29] cxlflash: Fix MMIO and endianness errors

Introduce __iomem and proper endianness tags/swaps where appropriate to make driver sparse clean. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h| 10 +- drivers/s

[PATCH 26/29] cxlflash: Drop context mutex while processing sense

and the context is made available again. The context can be safely moved to the error state if needed during the unavailable window as no other threads will hold its reference. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> ---

[PATCH 22/29] cxlflash: Recheck state after adapter reset

Add a state recheck in the device reset handler such that a TMF will still be send out after an adapter reset. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 5 ++--- 1 fil

[PATCH 24/29] cxlflash: Update function prologs

Update the function prologs to properly reflect parameter names and return codes. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 68 1

[PATCH 20/29] cxlflash: Correct usage of scsi_host_put()

. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c i

[PATCH 29/29] MAINTAINERS: Add cxlflash driver

Add stanza for cxlflash SCSI driver. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 67a4443..49

[PATCH 19/29] cxlflash: Properly obtain AFU version and check it

. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 2 +- drivers/scsi/cxlflash/main.c| 18 -- drivers/scsi/cxlflash/sislite.h | 2 +- 3 files changed, 14 inse

[PATCH 28/29] cxlflash: Clear AFU RRQ following reset

The AFU RRQ in host memory needs to be cleared after each reset to avoid stale entries from being processed by the AFU. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 3 +++ 1 fil

[PATCH 13/29] cxlflash: Refine print statements

Various print changes: pr_* to dev_*, *_dbg to *_devel, and *_dbg to *_dbg_ratelimited. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 105 ---

[PATCH 14/29] cxlflash: Protect TMF waitq with spinlock

Use a spinlock to protect the TMF waitq instead of borrowing the internal waitq lock. Also introduce a timeout for when the TMF fails to complete so the appropriate status can be sent back to the stack. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kum

[PATCH 12/29] cxlflash: Refine host/device attributes

Implement the following suggestions by Shane Seymour and add two new attributes to allow for debugging the port LUN table. - use scnprintf() instead of snprintf() - use DEVICE_ATTR_RO and DEVICE_ATTR_RW Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N.

[PATCH v2 26/30] cxlflash: Fix to prevent EEH recovery failure

mutex is reacquired and the context is made available again. The context can be safely moved to the error state if needed during the unavailable window as no other threads will hold its reference. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kum

[PATCH v2 00/30] cxlflash: Miscellaneous bug fixes and corrections

cxlflash: Fix read capacity timeout Matthew R. Ochs (27): cxlflash: Fix potential oops following LUN removal cxlflash: Fix data corruption when vLUN used over multiple cards cxlflash: Fix to avoid sizeof(bool) cxlflash: Fix context encode mask width cxlflash: Fix to avoid CXL services

[PATCH v2 10/30] cxlflash: Correct naming of limbo state and waitq

Limbo is not an accurate representation of this state and is also not consistent with the terminology that other drivers use to represent this concept. Rename the state and and its associated waitq to 'reset'. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: M

[PATCH v2 07/30] cxlflash: Fix context encode mask width

The context encode mask covers more than 32-bits, making it a long integer. This should be noted by appending the ULL width suffix to the mask. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/s

[PATCH v2 11/30] cxlflash: Make functions static

*); struct afu_cmd *cxlflash_cmd_checkout(struct afu *); void cxlflash_cmd_checkin(struct afu_cmd *); void init_pcr(struct cxlflash_cfg *); int init_global(struct cxlflash_cfg *); Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vne

[PATCH v2 09/30] cxlflash: Fix to stop interrupt processing on remove

removal is imminent. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 2 ++ drivers/scsi/cxlflash/main.c | 21 +++-- 2 files changed, 17 insertions(+), 6 deletions(-)

[PATCH v2 08/30] cxlflash: Fix to avoid CXL services during EEH

ioctls by wrapping the ioctl handler call in a read semaphore and then implementing a small routine that obtains the write semaphore, effectively creating a wait point for all currently executing ioctls. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kum

Re: [PATCH v2 01/30] cxlflash: Fix to avoid invalid port_sel value

> On Sep 16, 2015, at 2:18 PM, James Bottomley > wrote: > > Could you please add a cover letter (a 0/30) and thread your patches > from that? For large patch series, it really does make following > everything a lot easier for me (and most other people who

[PATCH v2 28/30] cxlflash: Fix to prevent stale AFU RRQ

after each reset. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c i

[PATCH v2 29/30] cxlflash: Fix to avoid state change collision

-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Suggested-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h| 1 + drivers/scsi/cxlflash/main.c | 40 +--

[PATCH v2 30/30] MAINTAINERS: Add cxlflash driver

Add stanza for cxlflash SCSI driver. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 310da42..b0

[PATCH v2 13/30] cxlflash: Fix to avoid spamming the kernel log

- pr_debug to pr_debug_ratelimited - pr_err to dev_err - pr_debug to dev_dbg Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 105 --- 1 file

[PATCH v2 14/30] cxlflash: Fix to avoid stall while waiting on TMF

such that a bigger hammer reset can occur. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 1 + drivers/scsi/cxlflash/main.c | 55 +- 2 files

[PATCH v2 15/30] cxlflash: Fix location of setting resid

The resid is incorrectly set which can lead to unnecessary retry attempts by the stack. This is due to resid _always_ being set using a value returned from the adapter. Instead, the value should only be interpreted and set when in an underrun scenario. Signed-off-by: Matthew R. Ochs <

[PATCH v2 19/30] cxlflash: Fix AFU version access/storage and add check

-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 2 +- drivers/scsi/cxlflash/main.c| 18 -- drivers/scsi/cxlflash/sislite.h | 2 +- 3 files changed, 14 insertions(+),

[PATCH v2 17/30] cxlflash: Fix async interrupt bypass logic

-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index 39ad7a3..74eb742 100644 -

[PATCH v2 18/30] cxlflash: Remove dual port online dependency

R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c i

[PATCH v2 16/30] cxlflash: Fix host link up event handling

-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 2 +- drivers/scsi/cxlflash/main.c | 17 + drivers/scsi/cxlflash/main.h | 1 + 3 files changed, 15 insertions(+), 5 deleti

[PATCH v2 12/30] cxlflash: Refine host/device attributes

Implement the following suggestions and add two new attributes to allow for debugging the port LUN table. - use scnprintf() instead of snprintf() - use DEVICE_ATTR_RO and DEVICE_ATTR_RW Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kum

<    1   2   3   4   5   >