Re: [AppArmor 32/44] Enable LSM hooks to distinguish operations on file descriptors from operations on pathnames

2007-07-03 Thread Stephen Smalley
On Thu, 2007-06-28 at 20:15 +0200, Andreas Gruenbacher wrote: On Thursday 28 June 2007 18:12, James Morris wrote: Are you trying to cater for the case where you're holding an open fd for a file which has been deleted, and thus has no pathname? Yes, see the AA_CHECK_FD flag in

Re: [AppArmor 32/44] Enable LSM hooks to distinguish operations on file descriptors from operations on pathnames

2007-07-03 Thread Andreas Gruenbacher
On Tuesday 03 July 2007 15:49, Stephen Smalley wrote: So you don't actually need/use the struct file pointer; you just need a flag indicating whether or not access was by open file descriptor or by pathname? Yes, indeed. Given that struct iattr already defines ATTR_FILE and ia_file, I didn't

Re: [AppArmor 01/44] Pass struct vfsmount to the inode_create LSM hook

2007-07-03 Thread Andreas Gruenbacher
On Saturday 30 June 2007 11:29, Christoph Hellwig wrote: On Tue, Jun 26, 2007 at 04:07:57PM -0700, [EMAIL PROTECTED] wrote: This is needed for computing pathnames in the AppArmor LSM. Please see the various per-mountpoint r/o thread that NACKed all the vfsmount additions and have the