Re: [PATCH] Smack: Fix wrong copy size

2015-10-08 Thread Casey Schaufler
On 10/2/2015 6:19 AM, José Bollo wrote: > The function strncpy was copying an extra character > when i == len (what is possible via revoke interface). > > Change-Id: Ic7452da05773e620a1d7bbc55e859c25a86c65f6 > Signed-off-by: José Bollo > Signed-off-by: Stephane Desneux Thank you for the patch. I

Re: [PATCH v2 5/5] firmware: add an extensible system data helpers

2015-10-08 Thread Luis R. Rodriguez
On Thu, Oct 08, 2015 at 01:59:11PM -0400, Josh Boyer wrote: > On Thu, Oct 1, 2015 at 1:44 PM, Luis R. Rodriguez > > +static inline int desc_sync_found_call_cb(const struct sysdata_file_desc > > *desc, > > + const struct sysdata_file > > *sysdata) > > +{ > >

Re: [PATCH v2 4/5] firmware: generalize reading file contents as a helper

2015-10-08 Thread Luis R. Rodriguez
On Thu, Oct 08, 2015 at 01:36:53PM -0400, Josh Boyer wrote: > On Thu, Oct 1, 2015 at 1:44 PM, Luis R. Rodriguez > wrote: > > From: David Howells > > > > We'll want to reuse this same code later in order to > > read two separate types of file contents. This generalizes > > fw_read_file() for readi

Re: [PATCH 1/4] firmware: generalize "firmware" as "system data" helpers

2015-10-08 Thread Josh Boyer
On Tue, Oct 6, 2015 at 5:08 AM, Greg KH wrote: > Just responding to one thing at the moment: > > On Mon, Oct 05, 2015 at 11:22:22PM +0200, Luis R. Rodriguez wrote: >> * we should phase out the usermode helper from firmware_class long term > > You can "phase out", but you can not delete it as it'

Re: [PATCH] Introduces generic __list_splice_init_rcu();

2015-10-08 Thread Mimi Zohar
On Tue, 2015-10-06 at 11:37 -0700, Paul E. McKenney wrote: > On Sun, Sep 27, 2015 at 06:10:28PM +0300, Petko Manolov wrote: > > __list_splice_init_rcu() can be used to splice lists forming both stack and > > queue structures, depending on its arguments. It is based on the initial > > list_splice_i

Re: [PATCH v2 5/5] firmware: add an extensible system data helpers

2015-10-08 Thread Josh Boyer
On Thu, Oct 1, 2015 at 1:44 PM, Luis R. Rodriguez wrote: > diff --git a/include/linux/sysdata.h b/include/linux/sysdata.h > new file mode 100644 > index ..a69cf5ef082c > --- /dev/null > +++ b/include/linux/sysdata.h > @@ -0,0 +1,208 @@ > +#ifndef _LINUX_SYSDATA_H > +#define _LINUX_SYSD

Re: [PATCH v2 4/5] firmware: generalize reading file contents as a helper

2015-10-08 Thread Josh Boyer
On Thu, Oct 1, 2015 at 1:44 PM, Luis R. Rodriguez wrote: > From: David Howells > > We'll want to reuse this same code later in order to > read two separate types of file contents. This generalizes > fw_read_file() for reading a file rebrands it as fw_read_file(). Er, maybe that should read "...f

Re: [PATCH] security: selinux: Use a kmem_cache for allocation struct file_security_struct

2015-10-08 Thread Paul Moore
On Monday, October 05, 2015 02:45:41 PM Sangwoo wrote: > The size of struct file_security_struct is 16byte at my setup. > But, the real allocation size for per each file_security_struct > is 64bytes in my setup that kmalloc min size is 64bytes > because ARCH_DMA_MINALIGN is 64. > > This allocation

Re: [RFC PATCH v3 5/5] selinux: introduce kdbus access controls

2015-10-08 Thread Paul Moore
On Wednesday, October 07, 2015 07:08:48 PM Paul Moore wrote: > +static int selinux_kdbus_conn_see_notification(const struct cred *creds) > +{ > + return avc_has_perm(SECINITSID_KERNEL, cred_sid(creds), > + SECCLASS_KDBUS, KDBUS__SEE_NOTIFICATION, NULL); > +} I'm

Re: [PATCH 1/5] fs: Verify access of user towards block device file when mounting

2015-10-08 Thread Seth Forshee
On Thu, Oct 01, 2015 at 09:41:37AM -0500, Seth Forshee wrote: > On Thu, Oct 01, 2015 at 09:40:52AM -0400, Mike Snitzer wrote: > > On Thu, Oct 01 2015 at 8:55am -0400, > > Seth Forshee wrote: > > > > > On Wed, Sep 30, 2015 at 07:42:15PM -0400, Mike Snitzer wrote: > > > > On Wed, Sep 30 2015 at 4

Re: [PATCH] af_unix: introduce unix_sk_const helper

2015-10-08 Thread Arnd Bergmann
On Thursday 08 October 2015 04:03:32 David Miller wrote: > From: Arnd Bergmann > Date: Tue, 06 Oct 2015 22:52:46 +0200 > > > Commit 124613012db1 ("af_unix: Convert the unix_sk macro to an inline > > function for type safety") was recently added to catch incorrect > > uses of the unix_sk helper us

Re: [PATCH] af_unix: introduce unix_sk_const helper

2015-10-08 Thread David Miller
From: Arnd Bergmann Date: Tue, 06 Oct 2015 22:52:46 +0200 > Commit 124613012db1 ("af_unix: Convert the unix_sk macro to an inline > function for type safety") was recently added to catch incorrect > uses of the unix_sk helper using compiler warnings. > > It has now caught one such case in lsm_au