Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-29 Thread Trond Myklebust
On Wed, 2008-01-30 at 03:25 +, David Howells wrote: > Chuck Lever <[EMAIL PROTECTED]> wrote: > > > This patch really ought to be broken into more manageable atomic > > changes to make it easier to review, and to provide more fine-grained > > explanation and rationalization for each specific c

Re: [PATCH 23/27] NFS: Fix memory leak [try #2]

2008-01-24 Thread Trond Myklebust
On Wed, 2008-01-23 at 17:22 +, David Howells wrote: > Fix a memory leak whereby multiple clientaddr=xxx mount options just overwrite > the duplicated client_address option pointer, without freeing the old memory. > > Signed-off-by: David Howells <[EMAIL PROTECTED]> > --- > > fs/nfs/super.c

Re: [PATCH 25/27] NFS: Configuration and mount option changes to enable local caching on NFS [try #2]

2008-01-24 Thread Trond Myklebust
On Wed, 2008-01-23 at 17:22 +, David Howells wrote: > Changes to the kernel configuration defintions and to the NFS mount options to > allow the local caching support added by the previous patch to be enabled. > > Signed-off-by: David Howells <[EMAIL PROTECTED]> > --- > > fs/Kconfig

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-24 Thread Trond Myklebust
On Wed, 2008-01-23 at 17:22 +, David Howells wrote: > The attached patch makes it possible for the NFS filesystem to make use of the > network filesystem local caching service (FS-Cache). > > To be able to use this, an updated mount program is required. This can be > obtained from: > >

Re: [TOMOYO #5 02/18] Add wrapper functions for VFShelperfunctions.

2007-11-16 Thread Trond Myklebust
On Sat, 2007-11-17 at 13:04 +0900, Tetsuo Handa wrote: > Hello. > > Trond Myklebust wrote: > > The problem is that you have thrown away the main tool for documenting > > the requirement, and for enforcing correctness (i.e. function argument > > checking by the compiler

Re: [TOMOYO #5 02/18] Add wrapper functions for VFS helperfunctions.

2007-11-16 Thread Trond Myklebust
On Sat, 2007-11-17 at 03:20 +0900, Tetsuo Handa wrote: > Hello. > > Trond Myklebust wrote: > > > This patch allows LSM hooks refer previously associated "struct vfsmount" > > > parameter > > > so that they can calculate pathname of given "stru

Re: [TOMOYO #5 02/18] Add wrapper functions for VFS helper functions.

2007-11-16 Thread Trond Myklebust
On Sat, 2007-11-17 at 02:34 +0900, [EMAIL PROTECTED] wrote: > plain text document attachment > (add-wrapper-functions-for-vfs-helper-functions.patch) > This patch allows LSM hooks refer previously associated "struct vfsmount" > parameter > so that they can calculate pathname of given "struct dent

Re: [PATCH 11/22] CacheFiles: Permit the page lock state to be monitored

2007-09-21 Thread Trond Myklebust
On Fri, 2007-09-21 at 15:48 +0100, David Howells wrote: > Add a function to install a monitor on the page lock waitqueue for a > particular > page, thus allowing the page being unlocked to be detected. > > This is used by CacheFiles to detect read completion on a page in the backing > filesystem

Re: [PATCH 10/22] CacheFiles: Add a hook to write a single page of data to an inode

2007-09-21 Thread Trond Myklebust
On Fri, 2007-09-21 at 15:47 +0100, David Howells wrote: > Add an address space operation to write one single page of data to an inode at > a page-aligned location (thus permitting the implementation to be highly > optimised). > > This is used by CacheFiles to store the contents of netfs pages into

Re: [PATCH 3/3] CRED: Move the effective capabilities into the cred struct

2007-09-20 Thread Trond Myklebust
On Thu, 2007-09-20 at 08:36 -0700, Casey Schaufler wrote: > Ok, what can't be copied, and why can't it be copied? In practice, no security information can be copied because the checks are all made on the "current" pointer. There is no mechanism other than 'current' for passing security informatio

Re: [PATCH 3/3] CRED: Move the effective capabilities into the cred struct

2007-09-20 Thread Trond Myklebust
On Wed, 2007-09-19 at 21:11 -0700, Andrew Morgan wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > David Howells wrote: > > Move the effective capabilities mask from the task struct into the > > credentials > > record. > > > > Note that the effective capabilities mask in the cred stru

Re: file capabilities: clear fcaps on inode change (v3)

2007-08-07 Thread Trond Myklebust
On Tue, 2007-08-07 at 17:17 -0500, Serge E. Hallyn wrote: > diff --git a/fs/splice.c b/fs/splice.c > index e36c003..2df95f3 100644 > --- a/fs/splice.c > +++ b/fs/splice.c > @@ -827,6 +827,12 @@ generic_file_splice_write(struct pipe_inode_info *pipe, > struct file *out, > ssize_t ret; >

Re: [RFD 0/4] AppArmor - Don't pass NULL nameidata to vfs_create/lookup/permission IOPs

2007-06-26 Thread Trond Myklebust
On Tue, 2007-06-26 at 16:15 -0700, [EMAIL PROTECTED] wrote: > To remove conditionally passing of vfsmounts to the LSM, a nameidata > struct can be instantiated in the nfsd and mqueue filesystems. This > however results in useless information being passed down, as not > all fields in the nameidata

Re: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks

2007-02-06 Thread Trond Myklebust
On Mon, 2007-02-05 at 19:20 -0800, Andreas Gruenbacher wrote: > On Monday 05 February 2007 11:02, Christoph Hellwig wrote: > > On Mon, Feb 05, 2007 at 10:58:26AM -0800, Trond Myklebust wrote: > > > On Mon, 2007-02-05 at 18:44 +, Christoph Hellwig wrote: > > > >

Re: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks

2007-02-05 Thread Trond Myklebust
On Mon, 2007-02-05 at 18:44 +, Christoph Hellwig wrote: > Just FYI: Al was very opposed to the idea of passing the vfsmount to > the vfs_ helpers, so you should discuss this with him. > > Looking at the actual patches I see you're lazy in a lot of places. > Please make sure that when you intr