James Morris <[EMAIL PROTECTED]> wrote:
> I suspect it may be useful ensure all global identifiers for the key
> subsystem are prefixed with key_, as 'copy_keys' does seem a little
> generic.
Many of the fork helpers are called copy_xxx().
David
-
To unsubscribe from this list: send the line "
On Tue, 25 Dec 2007, Andrew Morton wrote:
> On Thu, 20 Dec 2007 15:11:40 +1100 (EST) James Morris <[EMAIL PROTECTED]>
> wrote:
>
> > > > +#ifdef CONFIG_SECURITY
> > > > +extern unsigned long mmap_min_addr;
> > > > +#endif
> > > > +
> > > > #include
> > > > #include
> > > > #include
> > >
On Thu, 20 Dec 2007 15:11:40 +1100 (EST) James Morris <[EMAIL PROTECTED]> wrote:
> > > +#ifdef CONFIG_SECURITY
> > > +extern unsigned long mmap_min_addr;
> > > +#endif
> > > +
> > > #include
> > > #include
> > > #include
> >
> > Fine by me.
>
> I'll queue it for -mm & 2.6.25.
I don't thin
On Thu, 2007-12-20 at 11:07 +1100, James Morris wrote:
> On Wed, 19 Dec 2007, David Chinner wrote:
>
> > Folks,
> >
> > I just updated a git tree and started getting errors on a
> > "copy_keys" macro warning.
> >
> > The code I've been working on uses a ->copy_keys() method for
> > copying the
On Thu, 20 Dec 2007, David Chinner wrote:
> > I'm not sure I understand your namespace pollution issue, either.
>
> doing this globally:
>
> #ifdef CONFIG_SOMETHING
> extern intsome_common_name(int a, int b, int c);
> #else
> #define some_common_name(a,b,c) 0
> #endif
I suspect it may
On Thu, Dec 20, 2007 at 11:07:01AM +1100, James Morris wrote:
> On Wed, 19 Dec 2007, David Chinner wrote:
>
> > Folks,
> >
> > I just updated a git tree and started getting errors on a
> > "copy_keys" macro warning.
> >
> > The code I've been working on uses a ->copy_keys() method for
> > copyin
On Wed, 19 Dec 2007, David Chinner wrote:
> Folks,
>
> I just updated a git tree and started getting errors on a
> "copy_keys" macro warning.
>
> The code I've been working on uses a ->copy_keys() method for
> copying the keys in a btree block from one place to another. I've
> been working on th
