Re: [patch] Smack: harmless underflow in smk_set_cipso()

2015-12-04 Thread Dan Carpenter
On Thu, Dec 03, 2015 at 02:23:22PM -0800, Casey Schaufler wrote: > On 11/3/2015 2:15 PM, Dan Carpenter wrote: > >Also checkpatch complains that we should use kstrtouint() instead of > >sscanf here. > > > >Signed-off-by: Dan Carpenter > > This no longer parses cipso specifications correctly. > I h

Re: [patch] Smack: harmless underflow in smk_set_cipso()

2015-12-03 Thread Casey Schaufler
On 11/3/2015 2:15 PM, Dan Carpenter wrote: This causes a static checker warning because "maplevel" is set by the user and we cap the upper bound but not the lower bound. It seems harmless to me and it's root only but we may as well make the static checker happy. Also checkpatch complains that w

[patch] Smack: harmless underflow in smk_set_cipso()

2015-11-03 Thread Dan Carpenter
This causes a static checker warning because "maplevel" is set by the user and we cap the upper bound but not the lower bound. It seems harmless to me and it's root only but we may as well make the static checker happy. Also checkpatch complains that we should use kstrtouint() instead of sscanf h