Re: [PATCH] fix double ;;s in code

2018-02-20 Thread Andrew Morton
On Tue, 20 Feb 2018 10:03:56 +0200 Jani Nikula wrote: > On Mon, 19 Feb 2018, Pavel Machek wrote: > > On Mon 2018-02-19 16:41:35, Daniel Vetter wrote: > >> Yeah, pls split this into one patch per area, with a suitable patch > >> subject prefix. Look at git log of each file to get a feeling for w

Re: [PATCH] fix double ;;s in code

2018-02-20 Thread Alex Deucher
On Tue, Feb 20, 2018 at 3:03 AM, Jani Nikula wrote: > On Mon, 19 Feb 2018, Pavel Machek wrote: >> On Mon 2018-02-19 16:41:35, Daniel Vetter wrote: >>> Yeah, pls split this into one patch per area, with a suitable patch >>> subject prefix. Look at git log of each file to get a feeling for what's >

Re: [PATCH] fix double ;;s in code

2018-02-20 Thread Joe Perches
On Tue, 2018-02-20 at 17:19 +1100, Michael Ellerman wrote: > Daniel Vetter writes: > > On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: > > > Le 17/02/2018 à 22:19, Pavel Machek a écrit : > > > > > > > > Fix double ;;'s in code. > > > > > > > > Signed-off-by: Pavel Machek > > >

Re: [PATCH 1/2] dmaengine: Introduce DW AXI DMAC driver

2018-02-20 Thread Andy Shevchenko
On Tue, Feb 20, 2018 at 2:30 PM, Eugeniy Paltsev wrote: > This patch adds support for the DW AXI DMAC controller. > DW AXI DMAC is a part of HSDK development board from Synopsys. > > In this driver implementation only DMA_MEMCPY transfers are > supported. Just few comments, code looks fine I hope

Re: [PATCH 9/9] serial: xuartps: Fix out-of-bounds access through DT alias

2018-02-20 Thread Michal Simek
On 20.2.2018 13:27, Geert Uytterhoeven wrote: > Hi Michal, > > On Tue, Feb 20, 2018 at 12:27 PM, Michal Simek > wrote: >> On 20.2.2018 11:38, Geert Uytterhoeven wrote: >>> On Tue, Feb 20, 2018 at 11:22 AM, Michal Simek >>> wrote: On 20.2.2018 10:40, Geert Uytterhoeven wrote: > The cdn

[PATCH 2/2] dt-bindings: Document the Synopsys DW AXI DMA bindings

2018-02-20 Thread Eugeniy Paltsev
This patch adds documentation of device tree bindings for the Synopsys DesignWare AXI DMA controller. Signed-off-by: Eugeniy Paltsev --- .../devicetree/bindings/dma/snps,dw-axi-dmac.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/b

[PATCH 1/2] dmaengine: Introduce DW AXI DMAC driver

2018-02-20 Thread Eugeniy Paltsev
This patch adds support for the DW AXI DMAC controller. DW AXI DMAC is a part of HSDK development board from Synopsys. In this driver implementation only DMA_MEMCPY transfers are supported. Signed-off-by: Eugeniy Paltsev --- MAINTAINERS|6 + drivers/dma/Kconf

[PATCH 0/2] Introduce DW AXI DMAC driver

2018-02-20 Thread Eugeniy Paltsev
This patch series add support for the DW AXI DMAC controller. DW AXI DMAC is a part of HSDK development board from Synopsys. In this driver implementation only DMA_MEMCPY transfers are supported. Eugeniy Paltsev (2): dmaengine: Introduce DW AXI DMAC driver dt-bindings: Document the Synopsys

Re: [PATCH 9/9] serial: xuartps: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
Hi Michal, On Tue, Feb 20, 2018 at 12:27 PM, Michal Simek wrote: > On 20.2.2018 11:38, Geert Uytterhoeven wrote: >> On Tue, Feb 20, 2018 at 11:22 AM, Michal Simek >> wrote: >>> On 20.2.2018 10:40, Geert Uytterhoeven wrote: The cdns_uart_port[] array is indexed using a value derived from th

Re: [PATCH 9/9] serial: xuartps: Fix out-of-bounds access through DT alias

2018-02-20 Thread Michal Simek
On 20.2.2018 11:38, Geert Uytterhoeven wrote: > Hi Michal, > > On Tue, Feb 20, 2018 at 11:22 AM, Michal Simek > wrote: >> On 20.2.2018 10:40, Geert Uytterhoeven wrote: >>> The cdns_uart_port[] array is indexed using a value derived from the >>> "serialN" alias in DT, which may lead to an out-of-

Re: [PATCH 8/9] serial: sirf: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
On Tue, Feb 20, 2018 at 10:40 AM, Geert Uytterhoeven wrote: > The sirf_ports[] array is indexed using a value derived from the > "serialN" alias in DT, which may lead to an out-of-bounds access. > > Fix this by adding a range check. > > Fixes: 66c7ab1120585d18 ("serial: sirf: Fix out-of-bounds acc

Re: [PATCH 5/9] serial: pxa: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
On Tue, Feb 20, 2018 at 10:40 AM, Geert Uytterhoeven wrote: > The serial_pxa_ports[] array is indexed using a value derived from the > "serialN" alias in DT, which may lead to an out-of-bounds access. > > Fix this by adding a range check. > > Fixes: c8dcdc77298dde67 ("serial: pxa: Fix out-of-bound

Re: [PATCH 7/9] serial: sh-sci: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
On Tue, Feb 20, 2018 at 10:40 AM, Geert Uytterhoeven wrote: > The sci_ports[] array is indexed using a value derived from the > "serialN" alias in DT, which may lead to an out-of-bounds access. > > Fix this by adding a range check. > > Note that the array size is defined by a Kconfig symbol > (CON

Re: [PATCH 6/9] serial: samsung: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
On Tue, Feb 20, 2018 at 10:40 AM, Geert Uytterhoeven wrote: > The s3c24xx_serial_ports[] array is indexed using a value derived from > the "serialN" alias in DT, which may lead to an out-of-bounds access. > > Fix this by adding a range check. > > Note that the array size is defined by a Kconfig sy

Re: [PATCH 4/9] serial: mxs-auart: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
On Tue, Feb 20, 2018 at 10:40 AM, Geert Uytterhoeven wrote: > The auart_port[] array is indexed using a value derived from the > "serialN" alias in DT, which may lead to an out-of-bounds access. > > Fix this by adding a range check. > > Fixes: cabf23e7aa00b145 ("serial: mxs-auart: Fix out-of-bound

Re: [PATCH 2/9] serial: fsl_lpuart: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
On Tue, Feb 20, 2018 at 10:40 AM, Geert Uytterhoeven wrote: > The lpuart_ports[] array is indexed using a value derived from the > "serialN" alias in DT, which may lead to an out-of-bounds access. > > Fix this by adding a range check. > > Fixes: 970416c691dc68b5 ("serial: fsl_lpuart: Fix out-of-bo

Re: [PATCH 1/9] serial: arc_uart: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
On Tue, Feb 20, 2018 at 10:40 AM, Geert Uytterhoeven wrote: > The arc_uart_ports[] array is indexed using a value derived from the > "serialN" alias in DT, which may lead to an out-of-bounds access. > > Fix this by adding a range check. > > Note that the array size is defined by a Kconfig symbol >

Re: [PATCH 3/9] serial: imx: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
Hi Uwe, On Tue, Feb 20, 2018 at 11:31 AM, Uwe Kleine-König wrote: > On Tue, Feb 20, 2018 at 10:40:18AM +0100, Geert Uytterhoeven wrote: >> The imx_ports[] array is indexed using a value derived from the >> "serialN" alias in DT, which may lead to an out-of-bounds access. >> >> Fix this by adding

Re: [PATCH 9/9] serial: xuartps: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
Hi Michal, On Tue, Feb 20, 2018 at 11:22 AM, Michal Simek wrote: > On 20.2.2018 10:40, Geert Uytterhoeven wrote: >> The cdns_uart_port[] array is indexed using a value derived from the >> "serialN" alias in DT, which may lead to an out-of-bounds access. >> >> Fix this by adding a range check. >>

Re: [PATCH 3/9] serial: imx: Fix out-of-bounds access through DT alias

2018-02-20 Thread Uwe Kleine-König
Hello Geert, On Tue, Feb 20, 2018 at 10:40:18AM +0100, Geert Uytterhoeven wrote: > The imx_ports[] array is indexed using a value derived from the > "serialN" alias in DT, which may lead to an out-of-bounds access. > > Fix this by adding a range check. > > Fixes: 9206ab8a0350c3da ("serial: imx:

Re: [PATCH 9/9] serial: xuartps: Fix out-of-bounds access through DT alias

2018-02-20 Thread Michal Simek
On 20.2.2018 10:40, Geert Uytterhoeven wrote: > The cdns_uart_port[] array is indexed using a value derived from the > "serialN" alias in DT, which may lead to an out-of-bounds access. > > Fix this by adding a range check. > > Fixes: 1f118c02a1819856 ("serial: xuartps: Fix out-of-bounds access th

[PATCH 5/9] serial: pxa: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
The serial_pxa_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: c8dcdc77298dde67 ("serial: pxa: Fix out-of-bounds access through DT alias") Signed-off-by: Geert Uytterhoeven --- dr

[PATCH 0/9] serial: Fix out-of-bounds accesses through DT aliases

2018-02-20 Thread Geert Uytterhoeven
Hi all, Serial drivers used on DT platforms use the "serialN" alias in DT to obtain the serial port index for a specific port. Drivers typically use a fixed-size array for keeping track of all available serial ports. However, several drivers do not perform any validation on the index obta

[PATCH 8/9] serial: sirf: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
The sirf_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: 66c7ab1120585d18 ("serial: sirf: Fix out-of-bounds access through DT alias") Signed-off-by: Geert Uytterhoeven --- drivers

[PATCH 7/9] serial: sh-sci: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
The sci_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Note that the array size is defined by a Kconfig symbol (CONFIG_SERIAL_SH_SCI_NR_UARTS), so this can even be triggered using a legiti

[PATCH 6/9] serial: samsung: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
The s3c24xx_serial_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Note that the array size is defined by a Kconfig symbol (CONFIG_SERIAL_SAMSUNG_UARTS), so this can even be triggered using

[PATCH 1/9] serial: arc_uart: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
The arc_uart_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Note that the array size is defined by a Kconfig symbol (CONFIG_SERIAL_ARC_NR_PORTS), so this can even be triggered using a legi

[PATCH 4/9] serial: mxs-auart: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
The auart_port[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: cabf23e7aa00b145 ("serial: mxs-auart: Fix out-of-bounds access through DT alias") Signed-off-by: Geert Uytterhoeven --- dr

[PATCH 3/9] serial: imx: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
The imx_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: 9206ab8a0350c3da ("serial: imx: Fix out-of-bounds access through DT alias") Signed-off-by: Geert Uytterhoeven --- drivers/t

[PATCH 9/9] serial: xuartps: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
The cdns_uart_port[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: 1f118c02a1819856 ("serial: xuartps: Fix out-of-bounds access through DT alias") Signed-off-by: Geert Uytterhoeven ---

[PATCH 2/9] serial: fsl_lpuart: Fix out-of-bounds access through DT alias

2018-02-20 Thread Geert Uytterhoeven
The lpuart_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: 970416c691dc68b5 ("serial: fsl_lpuart: Fix out-of-bounds access through DT alias") Signed-off-by: Geert Uytterhoeven ---

Re: [PATCH] fix double ;;s in code

2018-02-20 Thread Jani Nikula
On Mon, 19 Feb 2018, Pavel Machek wrote: > On Mon 2018-02-19 16:41:35, Daniel Vetter wrote: >> Yeah, pls split this into one patch per area, with a suitable patch >> subject prefix. Look at git log of each file to get a feeling for what's >> the standard in each area. > > Yeah I can spend hour spl