Re: [RFC 1/4] asm-generic/uaccess: don't define inline functions if noinline lib/* in use

2020-01-15 Thread Arnd Bergmann
On Tue, Jan 14, 2020 at 10:33 PM Linus Torvalds wrote: > > On Tue, Jan 14, 2020 at 12:09 PM Vineet Gupta > wrote: > > > > There are 2 generic varaints of strncpy_from_user() / strnlen_user() > > (1). inline version in asm-generic/uaccess.h > > I think we should get rid of this entirely. It's jus

Re: [RFC 1/4] asm-generic/uaccess: don't define inline functions if noinline lib/* in use

2020-01-15 Thread Al Viro
On Wed, Jan 15, 2020 at 10:08:31AM +0100, Arnd Bergmann wrote: > > I would suggest that anybody who uses asm-generic/uaccess.h needs to > > simply use the generic library version. > > Or possibly just everybody altogether: the remaining architectures that > have a custom implementation don't seem

Re: [RFC 1/4] asm-generic/uaccess: don't define inline functions if noinline lib/* in use

2020-01-15 Thread Arnd Bergmann
On Wed, Jan 15, 2020 at 3:12 PM Al Viro wrote: > > On Wed, Jan 15, 2020 at 10:08:31AM +0100, Arnd Bergmann wrote: > > > > I would suggest that anybody who uses asm-generic/uaccess.h needs to > > > simply use the generic library version. > > > > Or possibly just everybody altogether: the remaining

Re: [RFC 2/4] lib/strncpy_from_user: Remove redundant user space pointer range check

2020-01-15 Thread Andrey Konovalov
On Tue, Jan 14, 2020 at 9:08 PM Vineet Gupta wrote: > > This came up when switching ARC to word-at-a-time interface and using > generic/optimized strncpy_from_user > > It seems the existing code checks for user buffer/string range multiple > times and one of tem cn be avoided. > > There's an open-

strace breaks with to be released glibc 2.31

2020-01-15 Thread Vineet Gupta
Hi, I've been testing an in-works glibc port for ARC and with 2.31 there's a glibc change which seems to break strace. Commit d1e411e5c786ce3 "Add PTRACE_GET_SYSCALL_INFO from Linux 5.3 to sys/ptrace.h." This now defines PTRACE_GET_SYSCALL_INFO but defines struct __ptrace_syscall_info (not the

Re: [PATCH net 0/4] net: stmmac: Fix selftests in Synopsys AXS101 board

2020-01-15 Thread David Miller
From: Jose Abreu Date: Tue, 14 Jan 2020 17:09:20 +0100 > Set of fixes for sefltests so that they work in Synopsys AXS101 board. ... Applied patches 1-3, it looks like patch 4 went into another tree. ___ linux-snps-arc mailing list linux-snps-arc@list

clone3 on ARC (was Re: [PATCH v3 2/2] arch: wire-up clone3() syscall)

2020-01-15 Thread Vineet Gupta
On 6/4/19 2:29 PM, Christian Brauner wrote: > On Tue, Jun 04, 2019 at 08:40:01PM +0200, Arnd Bergmann wrote: >> On Tue, Jun 4, 2019 at 6:09 PM Christian Brauner >> wrote: >>> >>> Wire up the clone3() call on all arches that don't require hand-rolled >>> assembly. >>> >>> Some of the arches look l

Re: [RFC 2/4] lib/strncpy_from_user: Remove redundant user space pointer range check

2020-01-15 Thread Vineet Gupta
On 1/15/20 6:42 AM, Andrey Konovalov wrote: >> - max_addr = user_addr_max(); >> - src_addr = (unsigned long)untagged_addr(src); > > If you end up changing this code, you need to keep the untagged_addr() > logic, otherwise this breaks arm64 tagged address ABI [1]. It is moot point now,

Re: [RFC 1/4] asm-generic/uaccess: don't define inline functions if noinline lib/* in use

2020-01-15 Thread Vineet Gupta
On 1/14/20 12:57 PM, Arnd Bergmann wrote: > On Tue, Jan 14, 2020 at 9:08 PM Vineet Gupta > wrote: >> There are 2 generic varaints of strncpy_from_user() / strnlen_user() >> (1). inline version in asm-generic/uaccess.h >> (2). optimized word-at-a-time version in lib/* >> >> This patch disables #

[PATCH] ARC: wireup clone3 syscall

2020-01-15 Thread Vineet Gupta
Signed-off-by: Vineet Gupta --- arch/arc/Kconfig | 1 + arch/arc/include/asm/syscalls.h| 1 + arch/arc/include/uapi/asm/unistd.h | 1 + arch/arc/kernel/entry.S| 12 arch/arc/kernel/process.c | 7 +++ arch/arc/kernel/sys.c

[PATCH v2 1/2] asm-generic/uaccess: don't define inline functions if noinline lib/* in use

2020-01-15 Thread Vineet Gupta
There are 2 generic varaints of strncpy_from_user() / strnlen_user() (1). inline version in asm-generic/uaccess.h (2). optimized word-at-a-time version in lib/* This patch disables #1 if #2 selected. This allows arches to continue reusing asm-generic/uaccess.h for rest of code This came up when

[PATCH v2 0/2] Switching ARC to optimized generic strncpy_from_user

2020-01-15 Thread Vineet Gupta
Hi, This series switches ARC to generic word-at-a-time interface. I understand that going fwd, we may drop the inline versions altogether but this helps ARC code in the interim. v2 <- v1 - Moved __strnlen_user/__strncpy_from_user to under ifdef gaurd [Arnd] - Dropped the broken optimization pa

[PATCH v2 2/2] ARC: uaccess: use optimized generic __strnlen_user/__strncpy_from_user

2020-01-15 Thread Vineet Gupta
The existing ARC variants have 2 issues - Use ZOL which may not be present in forthcoming architecture - Byte loop based vs. generic version which is word loop based Signed-off-by: Vineet Gupta --- arch/arc/Kconfig | 2 + arch/arc/include/asm/uaccess.h | 85 ++---

kisskb: OK linus/axs103_smp_defconfig/arcv2 Thu Jan 16, 15:33

2020-01-15 Thread noreply
OK linus/axs103_smp_defconfig/arcv2 Thu Jan 16, 15:33 http://kisskb.ellerman.id.au/kisskb/buildresult/14097371/ Commit: Merge tag 'platform-drivers-x86-v5.5-3' of git://git.infradead.org/linux-platform-drivers-x86 51d69817519f5f00041a1a039277f0367d76c82c Compiler: arc-linux-gcc.br_re

kisskb: OK linus/axs101_defconfig/arcompact Thu Jan 16, 15:33

2020-01-15 Thread noreply
OK linus/axs101_defconfig/arcompact Thu Jan 16, 15:33 http://kisskb.ellerman.id.au/kisskb/buildresult/14097372/ Commit: Merge tag 'platform-drivers-x86-v5.5-3' of git://git.infradead.org/linux-platform-drivers-x86 51d69817519f5f00041a1a039277f0367d76c82c Compiler: arc-buildroot-linux