Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Anshuman Khandual
inear address with __is_lm_address() >> and >> switch accordingly if it is a kernel text symbol. Nevertheless, its much >> better >> to use __pa_symbol() here rather than __pa(). >> >> Rather than respining the patch once more, will just send

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Andrew Morton
o use __pa_symbol() here rather than __pa(). > > Rather than respining the patch once more, will just send a fix replacing this > helper __pa() with __pa_symbol() for Andrew to pick up as this patch is > already > part of linux-next (next-20200226). But can definitely respin if th

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Anshuman Khandual
ng the patch once more, will just send a fix replacing this helper __pa() with __pa_symbol() for Andrew to pick up as this patch is already part of linux-next (next-20200226). But can definitely respin if that will be preferred. Thanks Qian for catching this. > > Christophe &g

Re: ELF_INITFINI for ARC (was Re: [PATCH] Introduce and ELF_INITFINI for all architectures)

2020-02-26 Thread Vineet Gupta
On 2/26/20 11:27 AM, Florian Weimer wrote: > I haven't followed the ARC contribution process closely, sorry. Do you > plan to contribute the port with a GLIBC_2.32 ABI baseline, or do you > want to support older binaries for an earlier non-upstream port, > backdating the baseline? No we don't

Re: ELF_INITFINI for ARC (was Re: [PATCH] Introduce and ELF_INITFINI for all architectures)

2020-02-26 Thread Florian Weimer
* Vineet Gupta: > It seems that commit also removed init_array from > sysdeps/{riscv,csky}/Implies - so newer arches. I suppose I need to do > that for ARC as well - but could you please explain (or point to > documentation) which explains how this the Implies stuff works. You are very lucky.

ELF_INITFINI for ARC (was Re: [PATCH] Introduce and ELF_INITFINI for all architectures)

2020-02-26 Thread Vineet Gupta
Hi Florian, On 2/20/20 10:48 AM, Florian Weimer wrote: > * Andreas Schwab: > >> environ is empty. > > That's because libc.so.6 still has DT_INIT, from which _environ and > other variables are set up. I assumed binutils would convert that into > DT_INITARRAY because the architecture is not

Re: switching ARC to 64-bit time_t (Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64)

2020-02-26 Thread Lukasz Majewski
Hi Joseph, > On Wed, 26 Feb 2020, Lukasz Majewski wrote: > > > > > hidden_def (__mq_timedsend) > > > > weak_alias (__mq_timedsend, mq_timedsend) [**] > > > > hidden_weak (mq_timedsend) > > > > > > If you have lib_hidden_weak note you also need a > > > corresponding lib_hidden_proto, for the

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Qian Cai
On Wed, 2020-02-26 at 15:45 +0100, Christophe Leroy wrote: > > Le 26/02/2020 à 15:09, Qian Cai a écrit : > > On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: > > > This adds tests which will validate architecture page table helpers and > > > other accessors in their compliance with

Re: switching ARC to 64-bit time_t (Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64)

2020-02-26 Thread Joseph Myers
On Wed, 26 Feb 2020, Lukasz Majewski wrote: > > > hidden_def (__mq_timedsend) > > > weak_alias (__mq_timedsend, mq_timedsend) [**] > > > hidden_weak (mq_timedsend) > > > > If you have lib_hidden_weak note you also need a corresponding > > lib_hidden_proto, for the name of the weak alias. But

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Christophe Leroy
Le 26/02/2020 à 15:09, Qian Cai a écrit : On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: This adds tests which will validate architecture page table helpers and other accessors in their compliance with expected generic MM semantics. This will help various architectures in

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Christophe Leroy
Le 26/02/2020 à 15:12, Qian Cai a écrit : On Wed, 2020-02-26 at 09:09 -0500, Qian Cai wrote: On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: How useful is this that straightly crash the powerpc? And then generate warnings on arm64, [  146.634626][T1] debug_vm_pgtable:

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Qian Cai
[  146.643995][T1] [ cut here ] [  146.649350][T1] virt_to_phys used for non-linear address: (ptrval) (start_kernel+0x0/0x580) [  146.658840][T1] WARNING: CPU: 165 PID: 1 at arch/arm64/mm/physaddr.c:15 __virt_to_phys+0x98/0xe0 [  146.667976]

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Qian Cai
S=256 DEBUG_PAGEALLOC NUMA PowerNV [   23.263731][T1] Modules linked in: [   23.263752][T1] CPU: 4 PID: 1 Comm: swapper/0 Not tainted 5.6.0-rc3-next- 20200226 #1 [   23.263776][T1] NIP:  c007308c LR: c103dbd8 CTR: [   23.263810][T1] REGS: c0

Re: switching ARC to 64-bit time_t (Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64)

2020-02-26 Thread Lukasz Majewski
Hi Joseph, > On Tue, 25 Feb 2020, Lukasz Majewski wrote: > > > Lets consider for example __mq_timedsend_time64. > > > > With lib_hidden_def/proto kept (NOT removed as in [1]): > > GDB: > > __GI___mq_timedsend_time64 [*] > > > > (No build errors, linking with test setup works as expected).