ARC rebootstrap prereq (was Re: switching ARC to 64-bit time_t )

2020-03-25 Thread Vineet Gupta
Hi Helmut, On 2/20/20 8:27 AM, Helmut Grohne wrote: > > Since I saw arc in the subject, I also threw arc at rebootstrap. Turns > out that glibc 2.30 does not yet cover arc and using unpackaged versions > of glibc is non-trivial for rebootstrap, so I cannot do much about that. > Once arc support i

Re: [PATCH v4 01/15] ARC: add definitions to elf/elf.h

2020-03-25 Thread Joseph Myers
This patch is OK (it can be committed without waiting for the rest of the port to be ready). -- Joseph S. Myers jos...@codesourcery.com ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linu

Re: [PATCH v4 01/15] ARC: add definitions to elf/elf.h

2020-03-25 Thread Vineet Gupta
On 3/25/20 6:37 PM, Joseph Myers wrote: > This patch is OK (it can be committed without waiting for the rest of the > port to be ready). Thx. Pushed ! -Vineet ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.or

Re: [PATCH v4 02/15] ARC: ABI Implementation

2020-03-25 Thread Joseph Myers
On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > diff --git a/sysdeps/arc/bits/endianness.h b/sysdeps/arc/bits/endianness.h > new file mode 100644 > index ..8f17ca84b485 > --- /dev/null > +++ b/sysdeps/arc/bits/endianness.h > @@ -0,0 +1,15 @@ > +#ifndef _BITS_ENDIANNESS_H > +#

Re: [PATCH v4 03/15] ARC: startup and dynamic linking code

2020-03-25 Thread Joseph Myers
On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > +case R_ARC_TLS_DTPOFF: > + if (sym != NULL) > +/* Offset set by the linker in the GOT entry would be overwritten > + by dynamic loader instead of added to the symbol location. > + Ot

Re: [PATCH v4 04/15] ARC: Thread Local Storage support

2020-03-25 Thread Joseph Myers
On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > +-- Derive offsets relative to the thread register. > +#define thread_offsetof(mem) (long)(offsetof(struct pthread, mem) - > sizeof(struct pthread)) Missing spaces before '(' in calls to offsetof and sizeof. > +TLS_TCB_SIZE

Re: [PATCH v4 06/15] ARC: math soft float support

2020-03-25 Thread Joseph Myers
On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > +/* Soft-float doesnot support exceptions. */ Missing space, should be "does not". -- Joseph S. Myers jos...@codesourcery.com ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.or

Re: [PATCH v4 07/15] ARC: hardware floating point support

2020-03-25 Thread Joseph Myers
On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > diff --git a/sysdeps/arc/bits/fenv.h b/sysdeps/arc/bits/fenv.h This is another example of one patch fixing up another. You're using the same ABI for both hard and soft float, so the first patch adding a bits/fenv.h header should be usin

Re: [PATCH V2 1/3] mm/debug: Add tests validating arch page table helpers for core features

2020-03-25 Thread Anshuman Khandual
On 03/24/2020 06:59 PM, Zi Yan wrote: > On 24 Mar 2020, at 1:22, Anshuman Khandual wrote: > >> This adds new tests validating arch page table helpers for these following >> core memory features. These tests create and test specific mapping types at >> various page table levels. >> >> 1. SPECIAL m

Re: [PATCH V2 0/3] mm/debug: Add more arch page table helper tests

2020-03-25 Thread Anshuman Khandual
On 03/24/2020 10:52 AM, Anshuman Khandual wrote: > This series adds more arch page table helper tests. The new tests here are > either related to core memory functions and advanced arch pgtable helpers. > This also creates a documentation file enlisting all expected semantics as > suggested by M

Re: [PATCH v4 02/15] ARC: ABI Implementation

2020-03-25 Thread Vineet Gupta
On 3/25/20 6:52 PM, Joseph Myers wrote: > On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: >> +/* ARC has selectable endianness. */ >> +#ifdef __BIG_ENDIAN__ >> +# define __BYTE_ORDER __BIG_ENDIAN >> +#else >> +# define __BYTE_ORDER __LITTLE_ENDIAN >> +#endif > > Elsewhere you say the port

Re: [PATCH v4 03/15] ARC: startup and dynamic linking code

2020-03-25 Thread Vineet Gupta
On 3/25/20 6:55 PM, Joseph Myers wrote: > Do you mean DTPOFF? Otherwise I'm not sure what DTSOFF is. Fixed. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH v4 04/15] ARC: Thread Local Storage support

2020-03-25 Thread Vineet Gupta
On 3/25/20 6:57 PM, Joseph Myers wrote: > On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > >> +-- Derive offsets relative to the thread register. >> +#define thread_offsetof(mem)(long)(offsetof(struct pthread, mem) - >> sizeof(struct pthread)) > > Missing spaces before '(' in ca

Re: [PATCH v4 06/15] ARC: math soft float support

2020-03-25 Thread Vineet Gupta
On 3/25/20 6:59 PM, Joseph Myers wrote: >> +/* Soft-float doesnot support exceptions. */ > Missing space, should be "does not". Fixed. Thx, -Vineet ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/

Re: [PATCH v4 07/15] ARC: hardware floating point support

2020-03-25 Thread Vineet Gupta
On 3/25/20 7:06 PM, Joseph Myers wrote: > On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > >> diff --git a/sysdeps/arc/bits/fenv.h b/sysdeps/arc/bits/fenv.h > > This is another example of one patch fixing up another. You're using the > same ABI for both hard and soft float, so the firs

Re: ARC rebootstrap prereq (was Re: switching ARC to 64-bit time_t )

2020-03-25 Thread Helmut Grohne
Hi Vineet, On Wed, Mar 25, 2020 at 05:25:58PM -0700, Vineet Gupta wrote: > ARC glibc is still in works, but assuming that will happen in near future what > other upstream prerequisites are needed. The obvious ones would be Linux > kernel, > gcc, binutils: all 3 of which are supported for ARC. Fro