Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally

2023-08-10 Thread Guo Ren
Thx, Arnd, I will clean them up for the csky part. On Thu, Aug 10, 2023 at 10:24 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > I have cleaned up the -Wmissing-prototypes warnings for most of the major > architectures > as well as all drivers that get enabled for CONFIG_COMPILE_TEST, so

Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally

2023-08-10 Thread Arnd Bergmann
On Thu, Aug 10, 2023, at 17:59, Helge Deller wrote: > On 8/10/23 17:21, Arnd Bergmann wrote: >> On Thu, Aug 10, 2023, at 16:59, Christophe Leroy wrote: >> >> I did send other fixes for microblaze and parisc specific drivers, >> and I could also send patches for the two defconfig warnings if >> the

Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally

2023-08-10 Thread Helge Deller
On 8/10/23 17:21, Arnd Bergmann wrote: On Thu, Aug 10, 2023, at 16:59, Christophe Leroy wrote: Le 10/08/2023 à 16:19, Arnd Bergmann a écrit : From: Arnd Bergmann I have cleaned up the -Wmissing-prototypes warnings for most of the major architectures as well as all drivers that get enabled

Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally

2023-08-10 Thread Arnd Bergmann
On Thu, Aug 10, 2023, at 16:59, Christophe Leroy wrote: > Le 10/08/2023 à 16:19, Arnd Bergmann a écrit : >> From: Arnd Bergmann >> >> I have cleaned up the -Wmissing-prototypes warnings for most of the major >> architectures >> as well as all drivers that get enabled for CONFIG_COMPILE_TEST, so

Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally

2023-08-10 Thread Christophe Leroy
Le 10/08/2023 à 16:19, Arnd Bergmann a écrit : > From: Arnd Bergmann > > I have cleaned up the -Wmissing-prototypes warnings for most of the major > architectures > as well as all drivers that get enabled for CONFIG_COMPILE_TEST, so now these > should be > close to fixed on x86, arm, arm64,

[PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally

2023-08-10 Thread Arnd Bergmann
From: Arnd Bergmann I have cleaned up the -Wmissing-prototypes warnings for most of the major architectures as well as all drivers that get enabled for CONFIG_COMPILE_TEST, so now these should be close to fixed on x86, arm, arm64, powerpc, s390, and riscv. The other architectures tend to have

[PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes

2023-08-10 Thread Arnd Bergmann
From: Arnd Bergmann Most architectures that support kprobes declare this function in their own asm/kprobes.h header and provide an override, but some are missing the prototype, which causes a warning for the __weak stub implementation: kernel/kprobes.c:1865:12: error: no previous prototype for

[PATCH 00/17] -Wmissing-prototype warning fixes

2023-08-10 Thread Arnd Bergmann
From: Arnd Bergmann Most of the patches I sent so far for the -Wmissing-prototype warnings have made it into linux-next now. There are a few that I'm resending now as nobody has picked them up, and then a number of fixes that I found while test-building across all architectures rather than just

[PATCH v3 2/2] csky: Make pfn accessors static inlines

2023-08-10 Thread Linus Walleij
Making virt_to_pfn() a static inline taking a strongly typed (const void *) makes the contract of a passing a pointer of that type to the function explicit and exposes any misuse of the macro virt_to_pfn() acting polymorphic and accepting many types such as (void *), (unitptr_t) or (unsigned long)

[PATCH v3 0/2] csky: Convert memory accessors to static inlines

2023-08-10 Thread Linus Walleij
This converts the virt_to_pfn and pfn_to_virt macros into static inlines so we get proper type checking on the pointers passed in. Signed-off-by: Linus Walleij --- Changes in v3: - Do not return const void * from pfn_to_virt(), return void * so we don't case a mess. - Link to v2:

[PATCH v3 1/2] csky: Cast argument to virt_to_pfn() to (void *)

2023-08-10 Thread Linus Walleij
The virt_to_pfn() function takes a (void *) as argument, fix this up to avoid exploiting the unintended polymorphism of virt_to_pfn. Acked-by: Guo Ren Signed-off-by: Linus Walleij --- arch/arc/include/asm/page.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git