ne_args *__cl_args, size_t __size,
> int (*__func) (void *__arg), void *__arg);
LGTM, thanks.
Reviewed-by: Adhemerval Zanella
> ---
> Checked on arc-linux-gnu. Previously observed tst-misaling-clone-internal
> test fail was because I used outdated master branch.
> Full testsui
On 02/03/23 13:10, Pavel Kozlov via Libc-alpha wrote:
> From: Pavel Kozlov
>
> For better debug experience use separate code block with extra
> cfi_* directives to run child (same as in __clone3).
LGTM, thanks.
Reviewed-by: Adhemerval Zanella
> ---
> sysdeps/unix/sysv
On 21/02/23 15:59, Adhemerval Zanella Netto wrote:
>
>
> On 21/02/23 10:55, Pavel Kozlov via Libc-alpha wrote:
>> Hi all,
>>
>> I'm excited to introduce myself and become a part of the community.
>>
>> I'm a software engineer in Synopsys an
On 21/02/23 10:55, Pavel Kozlov via Libc-alpha wrote:
> Hi all,
>
> I'm excited to introduce myself and become a part of the community.
>
> I'm a software engineer in Synopsys and member of a team working to enhance
> support for ARC CPUs in the GNU Linux ecosystem.
>
> I would appreciate a
;1c4b4 <__ieee754_sqrtf>
>
> The same is also true for __builtin_fma and __builtin_fmaf.
LGTM, thanks. You might need to check with Carlos O'Donnel to see it you
could install this for 2.36.
Reviewed-by: Adhemerval Zanella
>
> ---
> Changes in v2:
>
On 21/12/22 13:28, Pavel.Kozlov--- via Libc-alpha wrote:
> From: Pavel Kozlov
>
> Add extra check for compiler definitions to ensure that compiler provides
> sqrt and fma hw fpu instructions else use software implementation.
>
> As divide/sqrt and FMA hw support from CPU side is optional,
> t
isalign-clone-internal and
> misc/tst-misalign-clone tests. Stack alignmet fixes these tests
> fails.
LGTM, although I can't really test it since the Synopsys qemu tree does not
have qemu-user support [1].
Reviewed-by: Adhemerval Zanella
[1] https://github.com/foss-for-synopsys-dwc-
On 21/11/22 10:06, Shahab Vahedi via Libc-alpha wrote:
> While porting ARCv2 to elfutils [1], it was brought up that the
> necessary changes to the project's libelf/elf.h must come from
> glibc, because they sync it from glibc [2]. Therefore, this patch
> is to update ARC entries in elf/elf.h.
On 08/09/2020 23:48, Vineet Gupta via Libc-alpha wrote:
> From: Vineet Gupta
>
> This seems to be dead code, so remove it.
It could be useful for a possible statfs/statfs64 consolidation, but indeed
it is dead code now.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella
> --
On 09/07/2020 13:24, Vineet Gupta wrote:
> On 7/9/20 9:03 AM, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 08/07/2020 16:32, Vineet Gupta wrote:
>>> On 7/8/20 9:31 AM, Adhemerval Zanella via Libc-alpha wrote:
>>>>
>>>>
On 08/07/2020 16:32, Vineet Gupta wrote:
> On 7/8/20 9:31 AM, Adhemerval Zanella via Libc-alpha wrote:
>>
>> On 07/07/2020 17:55, Vineet Gupta via Libc-alpha wrote:
>>> ---
>>>Changes since v7.1:
>>> - Added a few more 32-bit time_t syscalls
On 06/07/2020 22:25, Vineet Gupta wrote:
> On 7/6/20 6:20 AM, Adhemerval Zanella via Libc-alpha wrote:
>>>>> diff --git a/sysdeps/unix/sysv/linux/arc/clone.S
>>>>> b/sysdeps/unix/sysv/linux/arc/clone.S
>>>
>>>>> diff --git a/sysdeps/uni
On 04/07/2020 00:54, Vineet Gupta wrote:
> On 7/2/20 7:47 PM, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 30/06/2020 21:08, Vineet Gupta via Libc-alpha wrote:
>>> ---
>>>Changes since v7:
>>> - used long int (iso int) in sy
On 15/06/2020 17:14, Vineet Gupta via Libc-alpha wrote:
> ---
> NEWS| 11 +++
> README | 1 +
> manual/install.texi | 4
LGTM, thanks.
Reviewed-by: Adhemerval Zanella
> 3 files changed, 16 insertions(+)
>
> diff --git
On 15/06/2020 17:14, Vineet Gupta via Libc-alpha wrote:
> ---
> scripts/build-many-glibcs.py | 10 ++
> 1 file changed, 10 insertions(+)
LGTM, thanks.
Reviewed-by: Adhemerval Zanella
>
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
>
27 +++
> sysdeps/unix/sysv/linux/arc/shlib-versions | 7 +
LGTM, thanks.
Reviewed-by: Adhemerval Zanella
> 15 files changed, 369 insertions(+)
> create mode 100644 sysdeps/arc/Implies
> create mode 100644 sysdeps/arc/Makefile
> create mode 100644 sysdeps/arc/Versions
>
On 01/07/2020 16:36, Vineet Gupta wrote:
> On 7/1/20 9:50 AM, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 30/06/2020 21:06, Vineet Gupta via Libc-alpha wrote:
>>> This code deals with the ARC ABI.
>>> ---
>>>Changes since v7:
&g
On 30/06/2020 21:11, Vineet Gupta wrote:
> On 6/23/20 9:56 AM, Vineet Gupta via Libc-alpha wrote:
>> On 6/15/20 1:14 PM, Vineet Gupta wrote:
>>> Hi,
>>>
>>> This patchset implements glibc port to ARC HS48x processor from Synopsys.
>>
>> ping !
>
> ping ^2 !
>
> I've posted the incremental seri
On 15/06/2020 16:09, Vineet Gupta via Libc-alpha wrote:
> On 6/4/20 12:08 PM, Vineet Gupta via Libc-alpha wrote:
>> On 6/2/20 1:31 PM, Vineet Gupta via Libc-alpha wrote:
>>> On 6/2/20 11:16 AM, Joseph Myers wrote:
On Mon, 1 Jun 2020, Vineet Gupta via Libc-alpha wrote:
> Also as sug
On 01/06/2020 19:18, Vineet Gupta wrote:
> This is purely for review purposes to attest the interface defined
> in prior patch
LGTM with some style nits, however I think it should be pushed along with
the ARC patchset.
Reviewed-by: Adhemerval Zanella
> ---
> sysdeps/arc/dl-ru
came up during ARC port review, hence the need for argument pltgot
> in reloc_index() which is not needed by existing ports.
>
> This patch potentially only affects hppa/x86 ports,
> build tested for both those configs and a few more.
>
> Suggested-by: Adhemerval Zanella
LGTM, t
On 05/06/2020 01:44, Vineet Gupta wrote:
> On 5/29/20 4:50 PM, Vineet Gupta via Libc-alpha wrote:
Although this code follow other architectures, I think it woudl be better
to move forward a macro that emulates function calls and use proper
static inline function instead for _FPU_*
On 04/06/2020 12:25, Vineet Gupta wrote:
> On 6/3/20 12:58 PM, Adhemerval Zanella via Libc-alpha wrote:
>>
>>>
>>> diff --git a/config.h.in b/config.h.in
>>> index dea43df438f6..08962dfed075 100644
>>> --- a/config.h.in
>>> +++ b/config.h
On 03/06/2020 17:17, Vineet Gupta wrote:
> On 6/3/20 1:04 PM, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 03/06/2020 16:46, Vineet Gupta wrote:
>>> On 5/29/20 9:49 AM, Adhemerval Zanella via Libc-alpha wrote:
>>>>> + ; - child sta
On 03/06/2020 16:46, Vineet Gupta wrote:
> On 5/29/20 9:49 AM, Adhemerval Zanella via Libc-alpha wrote:
>>> + ; - child starts here -
>>> +
>>> + ; Setup TP register (only recent kernels v4.19+ do that)
>>> + and.f 0, r12, CLONE_SETTLS
On 22/04/2020 22:41, Vineet Gupta via Libc-alpha wrote:
> Signed-off-by: Vineet Gupta
Some comments below.
> ---
> config.h.in| 3 +
> sysdeps/arc/Implies| 3 +
> sysdeps/arc/Makefile | 21 +++
> sysdeps/arc/V
On 03/06/2020 14:06, Vineet Gupta via Libc-alpha wrote:
> On 6/3/20 1:46 AM, Andreas Schwab wrote:
>> s/iee754/ieee754/
>
> Fixed. Thx
>
I think this patchset is ok, there is no need to send a v4. Do you
need someone to push it upstream for you?
_
On 02/06/2020 15:13, Joseph Myers wrote:
> On Tue, 2 Jun 2020, Vineet Gupta via Libc-alpha wrote:
>
>> Thi s approach seems to trip math/check-installed-headers.out
>>
>>
>> -std=c89
>> In file included from ../include/fpu_control.h:2,
>> from /tmp/cih_test_Nknxdp.c:8:
>> ../sysdeps/arc/fp
le check if the objects generated by the removed
implementations did not changed).
Reviewed-by: Adhemerval Zanella
> ---
> sysdeps/aarch64/fpu/e_sqrt.c| 27 --
> sysdeps/aarch64/fpu/e_sqrtf.c | 27 --
> sysdeps/aarch64/fpu/math-use-builtins.h |
; sysdeps/ieee754/ldbl-128/s_fmal.c | 5 +
> 5 files changed, 24 insertions(+)
LGTM with s390 fix pointed by Stefan.
Reviewed-by: Adhemerval Zanella
>
> diff --git a/sysdeps/generic/math-use-builtins.h
> b/sysdeps/generic/math-use-builtins.h
> index fc724c824a17..cf
On 01/06/2020 21:35, Vineet Gupta wrote:
> Reviewed-by: Adhemerval Zanella
LGTM with the small nit below and the s390 fix pointed by Stefan.
Reviewed-by: Adhemerval Zanella
> ---
> sysdeps/generic/math-use-builtins.h | 3 +++
> sysdeps/ieee754/dbl-64/e_sqrt.c | 6 +
On 27/05/2020 22:36, Vineet Gupta wrote:
> On 5/27/20 12:17 PM, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 22/04/2020 22:41, Vineet Gupta via Libc-alpha wrote:
>>> This includes all 4 TLS addressing models
>>>
>>> Signed-off-by: Vine
On 01/06/2020 15:12, Vineet Gupta wrote:
> On 6/1/20 7:42 AM, Adhemerval Zanella via Libc-alpha wrote:
>> You will need to move this definitions inside the !USE_SQRTF_BUILTIN
>> to avoid defined by not used warnings. Current practice is to just
>> open code the const
#endif
#define USE_FLOORL_BUILTIN 0
#define USE_FLOORF128_BUILTIN 0
Reviewed-by: Adhemerval Zanella
> ---
> sysdeps/powerpc/fpu/math-use-builtins.h | 70 +
> sysdeps/powerpc/fpu/s_fma.c | 27 --
> sysdeps/powerpc/fpu/s_fmaf.c
On 29/05/2020 23:00, Vineet Gupta wrote:
> Signed-off-by: Vineet Gupta
LGTM, some comments below.
> ---
> sysdeps/aarch64/fpu/e_sqrt.c| 27 --
> sysdeps/aarch64/fpu/e_sqrtf.c | 27 --
> sysdeps/aarch64/fpu/math-use-builtins.h | 70 +++
On 01/06/2020 11:13, Adhemerval Zanella wrote:
>
>
> On 29/05/2020 23:00, Vineet Gupta wrote:
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella
>
>> ---
>> sysdeps/generic/math-use-builtins.h | 3 +++
>> sysdeps/ieee754/dbl-64/e_sqrt.c
On 29/05/2020 23:00, Vineet Gupta wrote:
Ok with the fixes below.
Reviewed-by: Adhemerval Zanella
> ---
> sysdeps/generic/math-use-builtins.h | 4
> sysdeps/ieee754/dbl-64/s_fma.c | 6 ++
> sysdeps/ieee754/dbl-64/s_fmaf.c | 6 +
On 29/05/2020 23:00, Vineet Gupta wrote:
LGTM, thanks.
Reviewed-by: Adhemerval Zanella
> ---
> sysdeps/generic/math-use-builtins.h | 3 +++
> sysdeps/ieee754/dbl-64/e_sqrt.c | 6 ++
> sysdeps/ieee754/flt-32/e_sqrtf.c| 6 ++
> 3 files changed, 15 insertio
On 29/05/2020 14:39, Vineet Gupta wrote:
> On 5/29/20 5:58 AM, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 28/05/2020 16:43, Vineet Gupta wrote:
>>> The existing macros are fragile and expect local variables with a
>>> certain name. Fix this by
On 22/04/2020 22:41, Vineet Gupta via Libc-alpha wrote:
> Signed-off-by: Vineet Gupta
As prior patches we do not use DCO, but rather copyright assignment.
Some comments below.
> ---
> sysdeps/unix/sysv/linux/arc/arch-syscall.h| 303 ++
> sysdeps/unix/sysv/linux/arc/bits/
On 22/04/2020 22:41, Vineet Gupta via Libc-alpha wrote:
> Signed-off-by: Vineet Gupta
As prior patch we do not use DCO, but rather copyright assignment.
Some comments below.
> ---
> sysdeps/arc/fpu/e_sqrt.c| 27
> sysdeps/arc/fpu/e_sqrtf.c | 27
> sysdeps/a
On 27/05/2020 19:15, Vineet Gupta wrote:
> On 5/27/20 11:26 AM, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 22/04/2020 22:41, Vineet Gupta via Libc-alpha wrote:
>>> This code deals with the ARC ABI.
>>>
>>> Signed-off-by: Vineet Gupt
came up during ARC port review.
>
> This patch potentially only affects hppa/x86 ports,
> build tested for both those configs and a few more.
>
> Suggested-by: Adhemerval Zanella
LGTM, thanks.
Reviewed-by: Adhemerval Zanella
> ---
> elf/dl-runtime.c
On 05/05/2020 19:59, Vineet Gupta wrote:
> On 5/5/20 12:05 PM, Adhemerval Zanella via Libc-alpha wrote:
>>> diff --git a/sysdeps/s390/nptl/bits/semaphore.h
>>> b/sysdeps/unix/sysv/linux/bits/semaphore.h
>>> similarity index 100%
>>> rename from sysdeps/s
On 20/02/2020 18:04, Vineet Gupta wrote:
>
> Through a maze of defines this ends up calling INTERNAL_SYSCALL_RAW which
> seems be
> unconditionally converting !0 value (success) into -ve and returning it. So
> won't
> it convert a legit brk address return into a -ve and save in __curbrk.
>
On 19/02/2020 18:40, Vineet Gupta wrote:
> On 2/10/20 11:20 AM, Adhemerval Zanella wrote:
>> It changes the nios INTERNAL_SYSCALL_RAW macro to return a negative
>> value instead of 'r2' register value on 'err' macro argument.
>>
>> The macro INTER
On 20/12/2018 18:46, Vineet Gupta wrote:
> On 12/20/18 12:06 PM, Adhemerval Zanella wrote:
>>
>>
>> On 20/12/2018 17:23, Vineet Gupta wrote:
>>> On 12/20/18 3:19 AM, Adhemerval Zanella wrote:
>>>>>> #define SET_SA_RESTORER(kact, act)
On 20/12/2018 17:23, Vineet Gupta wrote:
> On 12/20/18 3:19 AM, Adhemerval Zanella wrote:
>>>> #define SET_SA_RESTORER(kact, act) \
>>>> (kact)->sa_flags = (act)->sa_flags | SA_RESTORER; \
>>>> (kact)->sa_r
On 19/12/2018 20:23, Vineet Gupta wrote:
> On 12/19/18 2:00 PM, Adhemerval Zanella wrote:
>>
>>
>> One possibility is to define an arch-specific __sigset_t.h with a custom
>> _SIGSET_NWORDS value and add an optimization on Linux sigaction.c to check
>> i
On 19/12/2018 15:58, Vineet Gupta wrote:
> On 12/18/18 6:39 PM, Vineet Gupta wrote:
diff --git a/sysdeps/unix/sysv/linux/arc/sigaction.c
b/sysdeps/unix/sysv/linux/arc/sigaction.c
>>> Why do you need this, rather than using the unified version (possibly with
>>> a few macros defined f
50 matches
Mail list logo
