Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Julia Lawall
On Wed, 22 Jun 2022, Bagas Sanjaya wrote: > On 6/22/22 16:38, Julia Lawall wrote: > >>> So code that is fine will have typos forever? Fixing typos in comments > >>> doesn't break git blame for the following code. And typos in comments > >>> give

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Julia Lawall
On Wed, 22 Jun 2022, Shahab Vahedi wrote: > On 6/22/22 11:16, Julia Lawall wrote: > > > > > > On Wed, 22 Jun 2022, Shahab Vahedi wrote: > > > >> On 6/22/22 10:30, Bagas Sanjaya wrote: > >> > >>> I think that this kind of cleanup pa

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Julia Lawall
On Wed, 22 Jun 2022, Shahab Vahedi wrote: > On 6/22/22 10:30, Bagas Sanjaya wrote: > > > I think that this kind of cleanup patches (typofixes) are best done > > as part of **actual** work on the code in question (for example > > refactoring or fixing build errors). > > Amen! So code that is fi

[PATCH] ARC: fix typos in comments

2022-03-18 Thread Julia Lawall
Various spelling mistakes in comments. Detected with the help of Coccinelle. Signed-off-by: Julia Lawall --- arch/arc/kernel/disasm.c|2 +- arch/arc/kernel/signal.c|2 +- arch/arc/kernel/smp.c |2 +- arch/arc/kernel/unaligned.c |2 +- arch/arc/mm/cache.c

Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions

2018-10-12 Thread Julia Lawall
> I wrote something like this as below but it failed to compile, Julia any > suggestions on how to express this? > > @pte_alloc_func_proto depends on patch exists@ > type T1, T2, T3, T4; > identifier fn =~ > "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$"; > @@ > >

[PATCH 9/9] serial/arc: constify uart_ops structures

2016-09-01 Thread Julia Lawall
fier r.i; @@ static +const struct uart_ops i = { ... }; // Signed-off-by: Julia Lawall --- drivers/tty/serial/arc_uart.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c index 3a1de5c..5ac06fc 100644 --- a/dri

[PATCH 0/9] constify uart_ops structures

2016-09-01 Thread Julia Lawall
Constify uart_ops structures. --- drivers/tty/serial/altera_jtaguart.c |2 +- drivers/tty/serial/altera_uart.c |2 +- drivers/tty/serial/arc_uart.c|2 +- drivers/tty/serial/atmel_serial.c|2 +- drivers/tty/serial/bcm63xx_uart.c|2 +- drivers/tty/serial/fsl