Re: [PATCH v2] arch: define weak abort

2017-12-21 Thread Sudip Mukherjee
On Tue, Dec 19, 2017 at 01:55:59PM -0800, Andrew Morton wrote: > On Tue, 19 Dec 2017 13:39:22 -0800 Vineet Gupta > wrote: > > > Hmm, I realize there's a small gotcha with this, when testing with a > > different > > patch from Arnd. This needs an EXPORT_SYMBOL()

Re: [PATCH v2] arch: define weak abort

2017-12-19 Thread Andrew Morton
On Tue, 19 Dec 2017 13:39:22 -0800 Vineet Gupta wrote: > > --- a/kernel/exit.c > > +++ b/kernel/exit.c > > @@ -1759,3 +1759,11 @@ long kernel_wait4(pid_t upid, int __user *stat_addr, > > int options, > > return -EFAULT; > > } > > #endif > > + > > +__weak

Re: [PATCH v2] arch: define weak abort

2017-12-19 Thread Vineet Gupta
On 12/12/2017 02:49 PM, Sudip Mukherjee wrote: gcc toggle -fisolate-erroneous-paths-dereference (default at -O2 onwards) isolates faulty code paths such as null pointer access, divide by zero etc. If gcc port doesnt implement __builtin_trap, an abort() is generated which causes kernel link

Re: [PATCH v2] arch: define weak abort

2017-12-13 Thread Alexey Brodkin
Hi Sudip, On Tue, 2017-12-12 at 22:49 +, Sudip Mukherjee wrote: > gcc toggle -fisolate-erroneous-paths-dereference (default at -O2 > onwards) isolates faulty code paths such as null pointer access, divide > by zero etc. If gcc port doesnt implement __builtin_trap, an abort() is > generated