[linux-sunxi] Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC

Hi Yassin, On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaf...@gmail.com wrote: > From: Yassin Jaffer > > Add Keypad controller node definition to the A20 SoC. > > Signed-off-by: Yassin Jaffer > --- > arch/arm/boot/dts/sun7i-a20.dtsi | 9

[linux-sunxi] Re: [PATCH 3/4] input: Add new sun4i-keypad driver

Hi, On Wed, Sep 16, 2015 at 12:05:56AM +1000, yassinjaf...@gmail.com wrote: > From: Yassin Jaffer > > Allwinnner SUN4i Keypad controller is used to interface a SoC > with a matrix-typekeypad device. > The keypad controller supports multiple row and column lines. > A key

Re: [linux-sunxi] Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC

On Thu, Sep 17, 2015 at 7:29 PM, Maxime Ripard wrote: > Hi Yassin, > > On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaf...@gmail.com wrote: >> From: Yassin Jaffer >> >> Add Keypad controller node definition to the A20 SoC. >> >>

Re: [linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs

On Thu, Sep 17, 2015 at 9:31 PM, Maxime Ripard wrote: > Hi Mark, > > On Wed, Sep 16, 2015 at 08:16:12PM +0100, Mark Brown wrote: >> On Sat, Sep 12, 2015 at 03:26:24PM +0200, Maxime Ripard wrote: >> >> This looks pretty good, there's a few minor things below but

[linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs

Hi Mark, On Wed, Sep 16, 2015 at 08:16:12PM +0100, Mark Brown wrote: > On Sat, Sep 12, 2015 at 03:26:24PM +0200, Maxime Ripard wrote: > > This looks pretty good, there's a few minor things below but I'll apply > anyway - please send followup patches fixing these. Sure, I will. Thanks! > > > +

Re: [linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs

On Thu, Sep 17, 2015 at 11:10:41PM +0800, Chen-Yu Tsai wrote: > On Thu, Sep 17, 2015 at 9:31 PM, Maxime Ripard > >> > + .formats= SNDRV_PCM_FMTBIT_S16_LE | > >> > + SNDRV_PCM_FMTBIT_S32_LE, > >> > + .sig_bits = 24, > >> So presumably

[linux-sunxi] Re: [PATCH 3/4] input: Add new sun4i-keypad driver

Hi Maxime I appreciate your time and efforts . Do you need that rate to be enforced, or is it some leftover from the > allwinner BSP? I've found that clock rate works fine with the default denounce and scan cycle. By the way do you have any dev board which expose the keypad pins? I will try