[linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

2016-08-31 Thread Danny Milosavljevic
Hi Chen-Yu, > > +static const char * const sun4i_codec_difflinein_capture_source[] = { > > + "Non-Differential", > > + "Differential", > > How about "Stereo"? And possibly "Mono Differential"? or just "Mono". > A differential input can be used single-ended by grounding one side. Y

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

2016-08-31 Thread Danny Milosavljevic
> And what about microphone bias? Would this be OK? static int sun4i_codec_handle_mic_bias_event(struct snd_soc_dapm_widget *w, struct snd_kcontrol *k, int event) { struct sun4i_codec *scodec = snd_soc_card_get_drvdata(w->dapm->card); i

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

2016-08-31 Thread Chen-Yu Tsai
On Wed, Aug 31, 2016 at 3:40 PM, Danny Milosavljevic wrote: >> And what about microphone bias? > > Would this be OK? > > static int sun4i_codec_handle_mic_bias_event(struct snd_soc_dapm_widget *w, > struct snd_kcontrol *k, int > event) > { > st

[linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

2016-08-31 Thread Chen-Yu Tsai
On Wed, Aug 31, 2016 at 3:17 PM, Danny Milosavljevic wrote: > Hi Chen-Yu, > >> > +static const char * const sun4i_codec_difflinein_capture_source[] = { >> > + "Non-Differential", >> > + "Differential", >> >> How about "Stereo"? And possibly "Mono Differential"? or just "Mono". > >> A d

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

2016-08-31 Thread Danny Milosavljevic
Hi Chen-Yu, > My apologies. I didn't notice that VMIC was already in the driver. > In that your original patch did everything right. Don't worry about it :) But I have a question: If I replace DAPM_INPUT by DAPM_MIC it wants a callback that is supposed to fiddle with the bias. Do I provide on

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

2016-08-31 Thread Chen-Yu Tsai
On Wed, Aug 31, 2016 at 3:49 PM, Danny Milosavljevic wrote: > Hi Chen-Yu, > >> My apologies. I didn't notice that VMIC was already in the driver. >> In that your original patch did everything right. > > Don't worry about it :) > > But I have a question: > > If I replace DAPM_INPUT by DAPM_MIC it w

[linux-sunxi] Re: [PATCH v2 2/8] mfd: axp20x: Add support for AXP806 PMIC

2016-08-31 Thread Lee Jones
On Sat, 27 Aug 2016, Chen-Yu Tsai wrote: > The X-Powers AXP806 is a new PMIC that is paired with Allwinner's A80 > SoC, along with a master AXP809 PMIC. > > This PMIC has a new register layout, and supports some functions not > seen in other X-Powers PMICs, such as master-slave mode, or having >

[linux-sunxi] Re: [PATCH v2 1/8] mfd: axp20x: Add bindings for AXP806 PMIC

2016-08-31 Thread Lee Jones
On Sat, 27 Aug 2016, Chen-Yu Tsai wrote: > This patch adds the basic and regulator bindings for the X-Powers AXP806 > PMIC. > > Signed-off-by: Chen-Yu Tsai > --- > Changes since v1: none > --- > Documentation/devicetree/bindings/mfd/axp20x.txt | 28 > ++-- > 1 file changed,

[linux-sunxi] Re: [PATCH v3] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board

2016-08-31 Thread Maxime Ripard
On Mon, Aug 29, 2016 at 10:18:32PM +0800, Icenowy Zheng wrote: > UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card > on iNet D978 Rev2 board. > > Enable the UART1 to make it possible to use the modified hciattach by > Realtek to drive the BT part of RTL8723BS. > > On the bo

[linux-sunxi] Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i

2016-08-31 Thread Maxime Ripard
Hi Danny, On Tue, Aug 30, 2016 at 07:44:02AM +0200, Danny Milosavljevic wrote: > This distinguishes sun4i from sun7i. It is necessary because they use > different registers for the audio mixer. Your Signed-off-by is missing > --- > sound/soc/sunxi/sun4i-codec.c | 44 > +

Re: [linux-sunxi] Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i

2016-08-31 Thread Danny Milosavljevic
Hi Maxime, On Wed, 31 Aug 2016 19:46:23 +0200 Maxime Ripard wrote: > > -#define SUN4I_CODEC_AC_SYS_VERI(0x38) > > -#define SUN4I_CODEC_AC_MIC_PHONE_CAL (0x3c) > > + > > +#define SUN7I_CODEC_AC_DAC_CAL (0x38) > > +#define SUN7I_CODEC_AC_MIC_PH

[linux-sunxi] Re: Changed: sunxi-ng clock code - NKMP clock implementation is wrong

2016-08-31 Thread Maxime Ripard
Hi Ondrej, Sorry for the (very) belated reply. On Mon, Aug 01, 2016 at 12:01:39AM +0200, Ondřej Jirman wrote: > In the vendor code M is never anything else but 0, and P is used only > for frequencies below 288MHz, which matches the H3 datasheet, which says: > >>> > >>> In the vendor cod

[linux-sunxi] Is it possible to run GMAC without PHY device on A20?

2016-08-31 Thread kimdou
Hi,All: the A20 connect to FPGA via GMAC port without an PHY device, when insmod sunxi_gmac.ko then ifconfig eth0 192.168.0.1 up,the GMAC tell me some errors: [ 1449.066480] eth0: device MAC address 06:e5:a5:60:a5:a8 [ 1449.220752] sunxi_gmac: probed [ 1449.224307] gmac_open: Cannot attach