[linux-sunxi] Re: [PATCH v7 08/15] ahci-imx: Port to library-ised ahci_platform

2014-03-04 Thread Bartlomiej Zolnierkiewicz
arning: ‘imx_ahci_resume’ defined but not used [-Wunused-function] [ There needs to be CONFIG_PM_SLEEP ifdef around imh_ahci_suspend() and imx_ahci_resume(). ] All the rest looks good. > +static SIMPLE_DEV_PM_OPS(ahci_imx_pm_ops, imx_ahci_suspend, imx_ahci_resume); > + > static struct platform_driv

[linux-sunxi] Re: [PATCH v7 05/15] ahci-platform: "Library-ise" ahci_probe functionality

2014-03-03 Thread Bartlomiej Zolnierkiewicz
rc = ahci_platform_enable_resources(hpriv); > - if (rc) > - goto free_clk; > + devres_remove_group(dev, NULL); > + return hpriv; > > - /* > - * Some platforms might need to prepare for mmio region access, > - * which could be done in the f

[linux-sunxi] Re: [PATCH v7 02/15] ahci-platform: Add support for devices with more then 1 clock

2014-03-03 Thread Bartlomiej Zolnierkiewicz
le failed"); > - return rc; > - } > - } > + rc = ahci_enable_clks(dev, hpriv); ahci_platform_enable_clks() > + if (rc) > + return rc; > > if (pdata && pdata->resume) { >